| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-11-18 | |||
| 13:37:43 | sean-k-mooney | i.e. you cant triger it form nova? | |
| 13:38:24 | nelljerram | thanks, I'll take a look at those. I've found it surprisingly hard to write an effective test for fully seamless live migration. I mean I already have a test that tests continuity of an SSH connection to a guest, across a live migration, and it passes, even though our live plumbing migration is really not properly seamless yet. | |
| 13:39:43 | sean-k-mooney | nelljerram: so we actuly kind of have one | |
| 13:39:58 | sean-k-mooney | nelljerram: there is a neutron test for live migration connectiviy | |
| 13:40:10 | sean-k-mooney | however because our ci provider are quite slow/overloaded | |
| 13:40:24 | sean-k-mooney | we have to set the downtime high in the jobs for stablity | |
| 13:40:38 | gibi | sean-k-mooney: I tried here but it did not triggered (yet) There is also a spec about changing the device attach APIs async. Currently owned by Dan but expected to be taken over by Johannes (outside RH) https://review.opendev.org/c/openstack/nova-specs/+/958900 that I personally care about due to eventlet removal relatedness. If Johannes take it then I would like to get this on the list of | |
| 13:40:44 | gibi | priorities. If Johannes does not take it the I would like to ask if RH can pick it up for G. | |
| 13:40:47 | gibi | ahh sorry | |
| 13:40:50 | gibi | wrong copy paste buffer | |
| 13:40:57 | sean-k-mooney | nelljerram: https://github.com/openstack/tempest/blob/8ccefd4bea48d6b38f7e16c50f97931b3fc2a5e2/tempest/scenario/manager.py#L1062 | |
| 13:41:13 | sean-k-mooney | there are live migration test that use that funciton to verify the conenctivy durign the migration | |
| 13:41:15 | nelljerram | sean-k-mooney: thanks! | |
| 13:41:19 | gibi | sean-k-mooney: so I tried to trigger it from here but no luck yet https://review.opendev.org/c/openstack/nova/+/967487 | |
| 13:41:31 | gibi | I will discuss with fwiesel | |
| 13:41:39 | gibi | when he is arond | |
| 13:42:15 | sean-k-mooney | ack | |
| 13:42:41 | sean-k-mooney | gibi: ya no rush either way i just said i woudl sugget that incase you had not tried it yet | |
| 13:42:56 | gibi | ack | |
| 13:43:12 | sean-k-mooney | if the job is not using zuul or even if it is but is not usign requreed project and devstack it woudl not pull in the patch | |
| 13:44:18 | sean-k-mooney | most job devs dont include libs in required prodject to test with the released verion outside the lib repo so my guess is this wont actully work unless they do some tweaks to test it for us | |
| 13:45:33 | gibi | yeah it is likely wont work | |
| 14:57:19 | opendevreview | Merged openstack/nova master: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/960284 | |
| 15:08:36 | opendevreview | Nell Jerram proposed openstack/nova stable/2025.2: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967567 | |
| 15:09:30 | opendevreview | Nell Jerram proposed openstack/nova stable/2025.1: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967568 | |
| 15:09:59 | opendevreview | Nell Jerram proposed openstack/nova stable/2024.2: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967569 | |
| 15:14:17 | nelljerram | gibi: sean-k-mooney: fyi I've failed the cherry-picks for https://review.opendev.org/c/openstack/nova/+/960284 now; hope I did it right | |
| 15:15:08 | sean-k-mooney | nelljerram: almost | |
| 15:15:23 | sean-k-mooney | so you are cherrypicking the older patches dreictly form master | |
| 15:15:38 | sean-k-mooney | you shoudl cherry pick them form the newer stable branch instead | |
| 15:16:09 | nelljerram | (just spotted that I wrote "failed" when I meant "filed"...) | |
| 15:16:12 | sean-k-mooney | so 2025.1 should be cherry picked form 2025.2 and it shoudl have 1 "cherry picked from commit" lien per branch | |
| 15:16:57 | nelljerram | so it should be master -> 2025.2, then 2025.2 -> 2025.1, then 2025.1 -> 2024.2 and so on? | |
| 15:17:48 | sean-k-mooney | yep | |
| 15:17:55 | gibi | nelljerram: also a small nit, please change the topic of the gerrit reviews to have the same topic as the master patch, that help discovering the reviews | |
| 15:18:13 | sean-k-mooney | that helps too ya | |
| 15:18:35 | sean-k-mooney | the master patch shoudl have had "bug/2033681" as the topic | |
| 15:18:46 | sean-k-mooney | but its too late to change it from https://review.opendev.org/q/topic:%22libvirt-tap-managed-no%22 | |
| 15:19:02 | sean-k-mooney | so "libvirt-tap-managed-no" is fine for all the bafckports | |
| 15:19:52 | nelljerram | right, will change them all to "libvirt-tap-managed-no" | |
| 15:27:26 | opendevreview | Nell Jerram proposed openstack/nova stable/2025.1: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967568 | |
| 15:28:43 | opendevreview | Nell Jerram proposed openstack/nova stable/2024.2: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967569 | |
| 15:30:33 | nelljerram | gibi: sean-k-mooney: hopefully all correct now? | |
| 15:32:01 | sean-k-mooney | the commit message are not quiter right | |
| 15:32:15 | sean-k-mooney | they still only have one cherry picked form line | |
| 15:35:01 | nelljerram | OK, I guess that's because the message wasn't recreated when I redid the picks in order. Let me try to fix that manually... | |
| 15:35:37 | sean-k-mooney | you need to use -x or -X to add the line each time rather hten just a cherry pick without flags | |
| 15:35:45 | sean-k-mooney | normally i use git-review to do this | |
| 15:36:47 | nelljerram | I did it using the web UI at review.opendev.org - is that not recommended? (the vertical dots menu on the top right, then "Cherry pick") | |
| 15:37:18 | sean-k-mooney | the web ui wont actully add the cherry-picked form lines properly unless you do it form a merged commit | |
| 15:37:41 | nelljerram | ok, let me try this again using git-review... | |
| 15:38:04 | sean-k-mooney | you can just edit the commit message in the ui | |
| 15:38:08 | sean-k-mooney | to add the correct lines | |
| 15:38:40 | nelljerram | OK, I'll try that first, presumably just need to discover the commit IDs... | |
| 15:39:04 | sean-k-mooney | so the reason we do it this way is if there is a merge conflict along the way you fix it only in the correct only in the banch that it happend in hten cherry pick the fixed version to older ones | |
| 15:39:32 | sean-k-mooney | the commit is aviabel in the ui beside where you slect the patch set just under where it say Comments | |
| 15:41:33 | opendevreview | Nell Jerram proposed openstack/nova stable/2025.1: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967568 | |
| 15:44:16 | opendevreview | Nell Jerram proposed openstack/nova stable/2024.2: Add managed='no' flag to libvirt XML definition for VIF type TAP https://review.opendev.org/c/openstack/nova/+/967569 | |
| 15:49:07 | nelljerram | Ah I see. The commit ID is also available from the gitea link, but the one you pointed to is better. | |
| 15:53:01 | sean-k-mooney | if you use the cli (with or without git review) you can pass a flag to add it automaticly | |
| 15:53:13 | sean-k-mooney | but ya you can do it form the ui too | |
| 15:53:28 | sean-k-mooney | when i do it form the ui i wait for the previous version to merge ot avoid having to update it | |
| 15:53:48 | sean-k-mooney | i approved the first backport ill look at the ohter once its merged | |
| 15:53:56 | nelljerram | many thanks! | |
| 16:13:03 | opendevreview | Merged openstack/osc-placement master: Replace remaining py39 target https://review.opendev.org/c/openstack/osc-placement/+/963809 | |
| 16:36:47 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Add spec for Graceful shutodwn of nova services https://review.opendev.org/c/openstack/nova-specs/+/967469 | |
| 17:21:40 | opendevreview | Ghanshyam proposed openstack/nova-specs master: Propose Step 1 of Graceful shutodwn spec https://review.opendev.org/c/openstack/nova-specs/+/967585 | |
| 17:23:19 | Uggla | gmaan, question, server_shares policies are PROJECT_MEMBER or PROJECT_READER. Is it normal. Should it be PROJECT_MEMBER_OR_ADMIN or PROJECT_READER_OR_ADMIN respectively ? | |
| 17:24:21 | jrosser | AWS host key signing | |
| 17:24:24 | jrosser | argh | |
| 17:25:04 | sean-k-mooney | Uggla: so project reader allsow anyoen wotih project member to access it | |
| 17:25:28 | gmaan | Uggla: *_OR ADMIN should be there as we do want admin to access those | |
| 17:25:29 | sean-k-mooney | so really the question is shoudl ti be PROJECT_READER or shoudl it be PROJECT_READER_OR_ADMIN | |
| 17:26:04 | gmaan | yeah admin will not able to access PROJECT_READER as project id check is there so it should be PROJECT_READER_OR_ADMIN | |
| 17:26:21 | gmaan | PROJECT_MEMBER can access PROJECT_READER as sean-k-mooney mentioned | |
| 17:26:52 | sean-k-mooney | basicaly there is role inheritnace the member role grants the reader role and the admin role grant member | |
| 17:27:07 | sean-k-mooney | so when we write the policy we specify the minium rule that is required | |
| 17:27:18 | sean-k-mooney | the _OR_ADMIN version | |
| 17:27:23 | gmaan | yeah | |
| 17:27:36 | sean-k-mooney | allows admins to bypass the project membership check | |
| 17:27:50 | sean-k-mooney | i..e its for the --all-tenants type commands | |
| 17:28:39 | gmaan | sean-k-mooney: Uggla to avoid using those without OR_ADMIN, i think we should remove these alias and have a note about it there https://github.com/openstack/nova/blob/master/nova/policies/base.py#L41-L43 | |
| 17:29:41 | gmaan | I kept them but forgot to add notes about that we need to support admin to access those project scoped role base permission | |
| 17:30:29 | Uggla | gmaan, so as I suspected, it needs to be corrected on the server_shares, I will open a patch for it. ok ? | |
| 17:30:46 | gmaan | Uggla: yeah | |
| 17:31:03 | Uggla | gmaan 👍 | |
| 17:31:14 | dansmith | melwitt: did you see bauzas' comment on the user patch about coverage? | |
| 17:31:30 | dansmith | I didn't go validate the concern (yet) but thought maybe you missed it | |
| 17:32:04 | melwitt | dansmith: yes, I added coverage. unless I messed up a rebase or upload. I'll check it | |
| 17:32:45 | dansmith | oh, I missed that there was a PS after that comment.. you didn't mark it done so I thought it was fresh | |
| 17:33:13 | melwitt | ah crap | |
| 17:34:46 | dansmith | I guess I'm also not sure the delta between those PSes is what he was asking about | |
| 17:37:10 | melwitt | dansmith: oh really? I thought he was pointing out that use of the image property for tpm_model was not covered? | |
| 17:38:08 | dansmith | I don't know because I don't really know what he's asking.. he said "check the property" and you didn't add any new checks... and the new path excludes the model property | |
| 17:39:05 | dansmith | like you already had a test that passed the tpm_model property | |
| 17:39:34 | dansmith | ohh, as the image prop and not the flavor I guess | |
| 17:39:50 | melwitt | yeah | |
| 17:40:15 | melwitt | I didn't know what else it could mean but I'm open to maybe I misunderstood something :) | |
| 17:40:44 | dansmith | I'm sure you're right I just didn't make sense of it initially | |
| 17:54:18 | opendevreview | Merged openstack/nova master: api: Add response body schemas for snapshots APIs https://review.opendev.org/c/openstack/nova/+/952349 | |