Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-10-30
15:54:56 tkajinam at that time what we wanted to deprecate ASAP was these AXI things while DKB can be independent
15:55:03 dansmith yes
15:56:21 tkajinam I'll watch the status of "trusted TPM" work in case we can just use it when I start SNP support work but my current guess is that it may take a few more years and we have to start with direct kernel boot
15:56:58 tkajinam (assuming the work needs another kernel/qemu/libvirt changes)
15:59:43 tkajinam ratailor, is that finish time thing is to fix the port detach/attach timing problem we discussed some time ago in heat ?
16:00:08 tkajinam I remember we need that mechanism to ensure that a port is fully released during port detach process
16:01:42 ratailor tkajinam, not fully remember this, but it was initially came as a bug here https://bugs.launchpad.net/nova/+bug/2058928 and then became feature because we need to add microversion to add finish_time field.
16:02:36 tkajinam ok. maybe I should ask that question to sean-k-mooney
16:03:54 ratailor tkajinam, if you are talking about ``Duplicate entry 'MAC/UUID-0' for key 'uniq_virtual_interfaces0address0deleted'`` then its related to that only.
16:06:11 tkajinam ah, ok and yes.that's one
16:11:36 sean-k-mooney tkajinam: o/
16:11:48 tkajinam sean-k-mooney, hey :-)
16:11:49 sean-k-mooney we just wrapped up the watcher session did you have a question
16:12:30 tkajinam sean-k-mooney, I was wondering if adding finish_time to instance action API is to fix the port detach problem during heat stack update we discussed some time ago
16:12:39 tkajinam I could not find the link for the bug/patch for some reason
16:13:10 sean-k-mooney tkajinam: yes it is
16:13:15 tkajinam ok
16:13:19 sean-k-mooney tkajinam: we discusse the workaround
16:13:27 sean-k-mooney which is heat can pool server show
16:13:33 tkajinam yeah
16:13:35 tkajinam I should probably look into updating heat to use that API though the tricky part is that heat is using novaclient at this moment :-P
16:13:41 sean-k-mooney but the correct fix is to actully mark the action as completed
16:13:44 tkajinam yeah
16:13:44 tkajinam anyway that's one heat
16:13:54 tkajinam that's "on" heat
16:18:48 opendevreview Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130
17:13:10 tkajinam I'm dropping off. I might skip the sessions tomorrow.
17:13:44 gibi tkajinam: thanks for the contribution
17:13:51 tkajinam gibi, :-)
17:22:51 auniyal Uggla, any ideas if there will be time today for cyborg discussion from Sean ?
17:23:51 Uggla auniyal, yes probably. But I think the session will exceed 18:00UTC (sorry about that).
17:25:47 auniyal okay
17:40:30 dansmith Uggla: you're off mute
17:41:00 Uggla dansmith, sorry thanks notifying me.
17:41:41 dansmith Uggla: when you don't speak but are off mute, your AGC goes way high and we can hear everything in the background and even dust particles landing on your mic :)
17:42:51 Uggla dansmith, as bauzas said already, it is a diabolic plan for introducing French in the session. ;)
17:43:04 dansmith I will complain to the UN
17:44:08 Uggla dansmith, Usually I take care to mute, but as the day progressing I tend to forget. Yes I'm becoming old. ;)
17:46:09 gibi chrome has enable-webrtc-allow-input-volume-adjustment flag. But I don't have my wife home today to try it with the violin :)
#openstack-nova - 2025-10-31
09:13:33 opendevreview Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130
09:27:33 opendevreview Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130
10:39:16 opendevreview Balazs Gibizer proposed openstack/nova master: Do not fork compute workers in native threading mode https://review.opendev.org/c/openstack/nova/+/965466
10:39:17 opendevreview Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467
10:40:07 gibi sean-k-mooney: dansmith: sambork: ^^ I had first light with nova-compute in threading mode. I was able to boot and delete VMs in a local devstack. Let see how this fails on the gate with more complex operations
10:42:27 sean-k-mooney gibi: cool
10:42:54 sambork gibi, nice! change looks less impressive than I think it would :)
10:43:00 sean-k-mooney gibi: i have not looked yet but did you just make spawn a noop
10:45:33 gibi I made the Tpools running the calls on the caller thread, and basically swiched all our executors to ThreadPools (already in tree) with the env variable. I needed to convince oslo.service not to fork a worker process for compute. And that is it. Compute just started working :)
10:45:54 gibi probably fails in edge cases
10:46:01 gibi but it boots and deletes VMs for me locally
10:46:40 sean-k-mooney yep im reviweing th echange now i pushed qution to https://review.opendev.org/c/openstack/nova/+/965466
10:47:02 gibi I will dig a bit into the libvirt direct greenthread usage as that might only work just by luck
10:47:23 gibi but the tpools are neutered
10:47:32 gibi when running with native threading
10:47:47 sean-k-mooney i dont see wehre you did that by the way
10:47:54 sean-k-mooney oh
10:48:01 sean-k-mooney its in earlier pathces
10:48:08 gibi yepp earlier patches
10:48:15 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/956089/12 and https://review.opendev.org/c/openstack/nova/+/956090/12
10:48:18 sean-k-mooney ya ok
10:48:22 gibi one for the vfs and one for the libvirt tpool
10:48:39 sean-k-mooney VFs?
10:49:01 gibi hm
10:49:03 sean-k-mooney do you mean rbd?
10:49:04 gibi then I missed one
10:49:07 gibi I did the rbd
10:49:17 gibi but there is on in nova/virt/disk/vfs/guestfs.py:from eventlet import tpool
10:49:29 sean-k-mooney oh virtual file systems
10:49:34 sean-k-mooney not Virutal fucntions
10:49:42 sean-k-mooney i was like how does sriov come into this
10:50:12 gibi :)
10:50:23 gibi anyhow there are more work to do
10:50:46 gibi but I'm happy with this for now :)
10:51:18 sean-k-mooney have you considerd putting a dnm with an eventlet poison on calls to monkey patch
10:51:40 sean-k-mooney basiclly to prove that no one calls it in the job via a lib ectra
10:52:04 sean-k-mooney importing eventlet is kind of ok provide its not monkey patch but tha twoudl be a nice addtion even if we dont watn to ship that
10:52:34 gibi yeah I want to do that. I cannot do it right now as we still import it. But we are close to get rid of those imports.
10:52:48 sean-k-mooney well im not saying poison the import
10:53:01 sean-k-mooney im saying poison the eventlet.monkey_patch function
10:53:06 gibi ahh OK
10:53:15 gibi didn't we do that already?
10:53:33 opendevreview Rajesh Tailor proposed openstack/nova master: Update the api-ref for unshelve https://review.opendev.org/c/openstack/nova/+/938054
10:53:56 sean-k-mooney we coudl also https://opendev.org/openstack/nova/src/commit/7712e9193a2fc02454d73a43949a056b977076dd/nova/monkey_patch.py
10:54:09 gibi https://github.com/openstack/nova/blob/30bf8c1025ea24823ebde3eacede4ea34ec6be8c/nova/monkey_patch.py#L115-L131
10:54:12 sean-k-mooney so that you first patch
10:54:30 sean-k-mooney ya so your right
10:54:32 sean-k-mooney we did
10:54:38 sean-k-mooney so ok that good
10:54:56 sean-k-mooney so it possibe a lib is doing eventlet.spawn
10:55:28 sean-k-mooney we know that if you dont monkey patch and you call the restul object that cause the eventlet to run
10:55:42 sean-k-mooney blockign the caller until complete
10:55:45 gibi yeah
10:55:56 sean-k-mooney i wonder if we could also poison eventlet.spawn?
10:56:03 gibi so if the libvirt event handling works it works bec;se of that
10:56:04 sean-k-mooney honestly this is probaly overkill
10:56:36 sean-k-mooney lets see how ci fairs but this is great progress
10:57:36 sean-k-mooney if we do what dan suggested for spliting the venvs into one with eventlet and one without
10:57:48 sean-k-mooney we could slithgly update our code to do condtional imports
10:58:06 sean-k-mooney and when eventlet is not there use the threaded mode even if no env var is set
10:58:38 nicolairuckel Can anyone help me explaining the issue here? https://gitlab.com/libvirt/libvirt/-/issues/828 i was under the assumption that libvirt should take care of any permissions but either that's not the case or I'm not able to explain the problem well enough.

Earlier   Later