Earlier  
Posted Nick Remark
#openstack-nova - 2025-10-14
16:51:27 nicolairuckel If you don't add read permissions, there will be a permissions error on a reboot and it won't be preserved.
16:52:04 sean-k-mooney wait why are you copying the file to the instnce dir an back
16:52:04 nicolairuckel The libvirt people told me that the permissions are like than intentionally. It's just a bit weird to me that the disk file has read permissions.
16:52:23 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/959682/3/nova/virt/libvirt/driver.py#10919
16:52:32 nicolairuckel The file contains the UEFI variables that I want to preserve.
16:52:42 sean-k-mooney i tought we were goign to preseve this by passign the libvirt flag to the doamin cleanup to preserve the file
16:53:36 nicolairuckel You mean I could skip copying the file?
16:53:42 sean-k-mooney yes
16:53:58 nicolairuckel I see. I'm going to try that.
16:53:59 sean-k-mooney so for the vtpm data we can pass a flag to tell libvirt not to delete it when the domein is undefiend
16:54:05 sean-k-mooney i belive we can do the same for the nvram
16:54:19 sean-k-mooney i could be mistaken but i belive there was a flag for the nvram as well
16:54:24 nicolairuckel That would be a better solution for sure.
16:54:26 sean-k-mooney so we would not need ot copy the file
16:54:37 nicolairuckel I'm going to look into that, thank you.
16:55:12 nicolairuckel How can I find a reviewer when that is done? Should I just bring it up again next week?
16:56:47 sean-k-mooney you can also ping on irc
16:56:52 nicolairuckel okay
16:57:01 sean-k-mooney we will proably see it updated but you can reach out if we dont
16:57:03 Uggla nicolairuckel, ping on the channel
16:57:16 nicolairuckel thanks
16:57:23 nicolairuckel that would be all from my side then
16:57:56 gibi nicolairuckel: thanks for working on it
16:58:24 sean-k-mooney VIR_DOMAIN_UNDEFINE_KEEP_NVRAM
16:58:39 sean-k-mooney https://github.com/libvirt/libvirt/blob/b42a12174c787b99cd6fcb29b44e4b13bd64ee58/include/libvirt/libvirt-domain.h#L2373
16:58:52 sean-k-mooney that the flag we need to pass to not delete it when the domain is undeifed
16:58:57 Uggla nicolairuckel, yes thanks for working on it
17:00:14 Uggla time to close
17:00:32 Uggla Thank you for participating in this meeting.
17:00:39 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-10-14-16.01.log.html
17:00:39 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-10-14-16.01.txt
17:00:39 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-10-14-16.01.html
17:00:39 opendevmeet Meeting ended Tue Oct 14 17:00:39 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
17:00:39 Uggla #endmeeting
17:01:29 elodilles thanks o/
17:03:27 gibi hanks
17:03:29 gibi thanks
17:03:30 gibi :)
17:06:58 elodilles tom? o:)
17:10:33 gibi nemtom (sorry this only funny in hungarian)
17:18:07 sean-k-mooney by the way im on pto retruning on tusday
17:18:28 sean-k-mooney just an fyi that i wont be here for the rest of the week
17:19:38 gibi sean-k-mooney: have a nice one
18:45:51 opendevreview Merged openstack/nova master: Switch nova-conductor to use global executor https://review.opendev.org/c/openstack/nova/+/962478
20:09:24 opendevreview Henry Richter proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657
22:01:54 opendevreview Fernando Ferraz proposed openstack/nova master: [DNM] Get processutils logs from unprivileged_convert_image https://review.opendev.org/c/openstack/nova/+/964095
23:22:09 opendevreview melanie witt proposed openstack/nova master: Add handling for vTPM secret permission error https://review.opendev.org/c/openstack/nova/+/963648
#openstack-nova - 2025-10-15
02:06:31 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502
02:06:32 opendevreview melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628
02:06:32 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795
02:06:33 opendevreview melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051
02:06:33 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483
02:06:34 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
02:06:34 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021
02:06:35 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
02:06:36 opendevreview melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052
02:06:36 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
02:06:38 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
02:06:38 opendevreview melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889
07:57:21 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
08:48:45 opendevreview Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408
13:20:19 dansmith gibi: I think I can proxy sean's +2 on that since you just changed some english and added an assert to the test.. agree?
13:23:45 gibi dansmith: I agree. If you are confortable with the patch then I think Sean will not disagree approving it based on Sean's past review rounds
13:28:36 gibi dansmith: thank you for your continued effort on that patch I appreciate it. And sorry again that I forced you to re-review it.
14:33:33 dansmith gibi: eventlet sync?
14:36:41 opendevreview Merged openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
17:59:24 gmaan melwitt: +2 on the config option logging fix. I checked in logs (added links in gerrit comment) and it is working fine now https://review.opendev.org/c/openstack/nova/+/963619
17:59:49 gmaan I added the log flow in comment so that it will be quick for 2nd reviewer to check the result
17:59:58 melwitt gmaan: hey thanks :D /me was not expecting reviews so quick
19:55:01 Zhan[m] `_rollback_live_migration` function cannot properly rollback the changes to port bindings. Does it make sense for me to write some code in the rollback function to basically recreate and reactivate the port bindings on the source side if needed, so that we can have the previous change back (start port binding earlier)? thanks!
19:55:01 Zhan[m] hey team, just wanna ask for feedbacks on some ideas on live migrations (using libvirt and QEMU): I saw in this [commit](https://review.opendev.org/c/openstack/nova/+/434870) that we'll be activating port bindings when the VM is paused on the source side, but this change was reverted in this [commit](https://github.com/openstack/nova/commit/aa87b9c288d316b85079e681e0df24354ec1912c) because if the migration fails, the
21:43:17 gmaan bauzas: gibi: I added some comment in ImagePropertiesWeigher fix, nothing blocker so feel free to +w if those does not need updates or reply and I will +w tomorrow https://review.opendev.org/c/openstack/nova/+/963358
#openstack-nova - 2025-10-16
07:52:00 jlejeune hello bauzas, sean-k-mooney[m], gibi and others :) I would like to backport my changes related to these topics: https://review.opendev.org/q/topic:%22bug-2044235%22 and https://review.opendev.org/q/topic:%22bug/2085135%22, what do you think about them ? thanks
08:17:30 gibi jlejeune: I did some reviews in both series now, and had couple of +2 but both series has some minor issues in later backports so I left -1es later
08:37:35 jlejeune gibi: checking, thanks
08:38:59 opendevreview Masahito Muroi proposed openstack/nova-specs master: Add spec for virtio-blk multiqueue extra_spec https://review.opendev.org/c/openstack/nova-specs/+/951636
08:42:42 masahito sean-k-mooney[m]: Uggla: gibi: Thanks for the review in the last development cycle for the multiqueue. I resumed the upstream patch update b/c the Gazpacho development cycle was open :)
08:58:14 opendevreview Merged openstack/nova stable/2025.2: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961948
09:10:17 opendevreview Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358
09:10:45 bauzas gibi: gmaan had a few good comments on https://review.opendev.org/c/openstack/nova/+/963358 I just rebased it
09:16:26 opendevreview Merged openstack/nova stable/2025.2: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963842
09:16:38 opendevreview Merged openstack/nova stable/2025.2: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963843
09:37:25 opendevreview Masahito Muroi proposed openstack/nova-specs master: Add spec for virtio-blk multiqueue extra_spec https://review.opendev.org/c/openstack/nova-specs/+/951636
11:00:40 opendevreview Merged openstack/nova stable/2025.2: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/963844
12:24:41 gibi bauzas: ack I will check it
14:19:44 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.2: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964219
14:19:45 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.2: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964220
14:24:38 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.1: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964221
14:24:39 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.1: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964222
14:25:56 opendevreview Balazs Gibizer proposed openstack/placement stable/2024.2: Reproduce GET a_c slowness bug/2126751 https://review.opendev.org/c/openstack/placement/+/964223
14:25:57 opendevreview Balazs Gibizer proposed openstack/placement stable/2024.2: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/964224
14:26:15 gibi dansmith: I've pushed the stable backports of the placment fix
14:26:32 gibi when you have time please take look. They are all clean cherry-picks
14:27:04 gibi https://review.opendev.org/q/topic:%22bug/2126438%22 and https://review.opendev.org/q/topic:%22bug/2126751%22+project:openstack/placement
14:27:29 dansmith okay I'm really slammed today and I have a bunch of glance things I just got poked for in the meeting just now
14:27:46 gibi sure, no worries we are not in a rush with these backports
14:27:48 dansmith might be good if some other people could just do the low-impact work of validating the backports
14:28:26 gibi I pinged you as you have the context and Sean is on PTO. But yeah this is easy to review for any cores
14:28:41 dansmith ack
14:38:10 jlejeune gibi:about your remark on my cherry-pick, the change is not the same on other stable branches because you 've introduced that new line in test_service.py in that change https://review.opendev.org/c/openstack/nova/+/947245 and it's not been backported on other stable branches

Earlier   Later