Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-10-14
11:48:31 sean-k-mooney the placemetn logs form the placemetn fixture shoudl be capsture in the est setup and filtered out of that assertion
11:49:31 sean-k-mooney in a real envonment that log woudl not be aviabel to the client
11:50:08 sean-k-mooney tkajinam: so the proper fix woudl be to install a log filter int eh osc-palcement functional tests i think to null route the placement logs
11:56:31 tkajinam sean-k-mooney, yeah I agree the issue and the lo level should be separate...
11:57:03 tkajinam sean-k-mooney, I looked into the logging setting but it looks tricky to me. the core problem is that the test does not use actual nova api but uses placement api fixture and filtering all placement logs mean we lost all api logs https://opendev.org/openstack/osc-placement/src/branch/master/osc_placement/tests/functional/base.py#L77
11:57:20 tkajinam the test does not use actual *placement* api, I mean
11:57:56 tkajinam maybe we could raise it to ERROR ?
12:00:33 sean-k-mooney tkajinam: correct we shoudl nto have access to any of the api logs in osc-placement
12:01:12 sean-k-mooney osc-placmenet is the openstack client plugin and in real code it will only have access to the api respocne not hte logs
12:01:15 tkajinam it may be correct for assertions but I'm a bit afraid of loosing debuggability in test failures
12:01:27 sean-k-mooney so if any test is relying on the logs then that test is invlaid
12:02:30 sean-k-mooney we can keep the logs for the fixture but we shoudl not be loging the placment logs to stdout or stderr in generall but we shoudl atttach teh logs to the test output
12:05:04 sean-k-mooney we can proably do somethign like this https://github.com/openstack/nova/blob/master/nova/config.py#L56-L89
12:05:39 sean-k-mooney add a log filt to the root loger that will intercept and redirect the logging else where but ill admit i have not tired
12:05:59 tkajinam ok
12:06:25 tkajinam let me give it some tries but I might just end up with bumping the log level filter to error
12:07:34 sean-k-mooney perhaps like this https://github.com/openstack/nova/blob/8b81b5f91ffe1f9c38a483d151b82316d443dbf6/nova/tests/fixtures/nova.py#L190-L199
12:08:09 sean-k-mooney we may be able ot patch where placmenet or the placment fixutrer setup up logging iwth our own funciton
12:08:47 sean-k-mooney tkajinam: i assume this is repoducable if we just clone master and run the tests?
12:09:03 tkajinam yup
12:09:16 tkajinam replace openstack-placement>=1.0.0 in tox.ini by git+https://opendev.org/openstack/placement#egg=openstack-placement
12:09:25 tkajinam so that it uses non-released version
12:09:39 tkajinam (that's what you need after clone, before tox -e functional
12:09:52 sean-k-mooney ack. ill see if i can play around with it locally too
12:09:55 sean-k-mooney tanks for reporting this
12:10:39 sean-k-mooney im on pto the rest of the week and i dont have too much time today so i cant promis ill make much progress but i have a littel time between meeting today
12:11:59 gibi tkajinam: that log will disappeare once we land a fix https://review.opendev.org/c/openstack/placement/+/962776 . I (wrongly) assumed that we will land the two patches close together so did not worried about the extra logs in the reproduce commit
12:13:15 sean-k-mooney gibi: well it found a bug as a result but that also a good pont it shoudl be resovle when the actual fix lands
12:14:53 gibi it was a log I added to prove that root cause of the bug
12:15:00 gibi it is not necessary in production
12:15:18 gibi I can spin up a patch that removes it independently from https://review.opendev.org/c/openstack/placement/+/962776
12:15:34 gibi so we can restore the sanity of the osc-placement's gate
12:17:13 gibi I did not load context on why osc-placement test depends on placmenet api logs. But that can be (and probably should be) fixed separately from unblocking the gate
12:19:21 tkajinam gibi, ah, thanks !
12:22:55 opendevreview Balazs Gibizer proposed openstack/placement master: Remove troubleshooting logs https://review.opendev.org/c/openstack/placement/+/963952
12:23:05 gibi sean-k-mooney: , tkajinam ^^
12:23:13 opendevreview Takashi Kajinami proposed openstack/osc-placement master: Filter out placement api logs in functional tests https://review.opendev.org/c/openstack/osc-placement/+/963953
12:24:14 tkajinam ^^^ sean-k-mooney gibi: this is the initial try to filter out these logs in osc-placement functional tests
12:24:18 tkajinam gibi, thanks !
12:25:50 gibi tkajinam: I'm OK with that. If CI is green then I think we can land your test setup fix
12:26:05 gibi that will probably land faster than my placement log removal patch
12:26:06 sean-k-mooney tkajinam: i think that is fine we could proably be more granular but im not oppose to that
12:27:07 tkajinam yeah we could probable filter more specific module but I tend to try with that wider filtering and see if that kills out life
12:27:16 tkajinam * our life
12:27:35 tkajinam my concern with narrow filtering is that we may face similar problems frequently in the future
12:28:48 tkajinam so far it worked in my local reproducer but let's see how CI passes...
12:28:55 sean-k-mooney so what i was going to propsoe is lsightly diffent. i was going to try and capture the placment api logs into a seperate stringio buffer and make them aviabel in tests but only log them if you run the test in debug mode
12:30:41 sean-k-mooney so similar to how https://github.com/openstack/placement/blob/master/placement/tests/functional/fixtures/capture.py works internally
12:31:46 sean-k-mooney or rather similar ot how https://github.com/openstack/oslotest/blob/9c1cb8e6df468a459783b49d59c60eee3cf83d4d/oslotest/log.py#L35 works internaly
12:33:11 sean-k-mooney currently the way our test are setup teh python loing module is set up to log to stdout and stderr
12:33:13 sean-k-mooney then https://github.com/openstack/oslotest/blob/9c1cb8e6df468a459783b49d59c60eee3cf83d4d/oslotest/output.py#L64-L71
12:33:29 sean-k-mooney intercept that if we enabel that fixture
12:35:09 sean-k-mooney so what i want to try and do is see if i can redirect the placement loggers to a stringstream or stringio buffer instead and add them to the base test class as self.placment_api_log
12:35:54 sean-k-mooney tkajinam: gibi just to be clear im fine with proceexcing with tkajinam's patch if it passes ci
12:36:20 gibi cool. I think tkajinam's fix can land fast to unblock the gate
12:37:00 gibi there is at least on green functional run already in 963953
12:37:11 gibi I mean in https://zuul.opendev.org/t/openstack/status?change=963953
12:41:02 tkajinam sean-k-mooney, I didn't try that way first, because in these functional tests of osc-placement we have a single root logger which receives both placement log and osc-placmenet's log
12:41:38 tkajinam we can technically add different handlers and select these according to log module name but that's what current fixtures in oslotest and placement are designed for
12:42:14 tkajinam (I'm not saying we can't/shouldn't do it but I'm saying we need additional consideration for this specific use case
12:42:26 sean-k-mooney ya. lets not rush to make that work but if we can split it cleanly later it coudl be nice
12:42:55 sean-k-mooney i am +2w on your current patch so if ci is green it will merge
12:43:52 gibi sean-k-mooney: thanks
12:49:25 gibi it passed check and on the gate now. So I'm abandoning https://review.opendev.org/c/openstack/placement/+/963952
12:52:56 opendevreview Merged openstack/osc-placement master: Filter out placement api logs in functional tests https://review.opendev.org/c/openstack/osc-placement/+/963953
12:53:32 opendevreview Takashi Kajinami proposed openstack/osc-placement master: Replace remaining py39 target https://review.opendev.org/c/openstack/osc-placement/+/963809
12:54:06 tkajinam \o/
13:01:14 gibi that was a quick one. Thanks folks
13:06:22 sean-k-mooney gibi: i got ai to implement the other approch as well im just cleaning it up and makeing sure work properly
13:17:19 sean-k-mooney bauzas: no we are good we merged the quick fix to resolve the gate issue
13:19:56 ratailor sean-k-mooney, gibi bauzas could you please review https://review.opendev.org/c/openstack/nova/+/937534 https://review.opendev.org/c/openstack/nova/+/938054 and https://review.opendev.org/c/openstack/nova/+/934294
13:25:16 bauzas sean-k-mooney: cool sorry I wasn't looking at the channel
13:30:01 opendevreview sean mooney proposed openstack/osc-placement master: Improve functional test debuggability with log capture https://review.opendev.org/c/openstack/osc-placement/+/963962
13:30:37 sean-k-mooney gibi: tkajinam i need to join a call but ^ shoudl work
13:30:50 sean-k-mooney ...
13:30:57 sean-k-mooney after i fix the whitespace issues
13:40:00 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
13:40:32 gibi sean-k-mooney: dansmith: ^^ fixed up based on Dan's comments
13:44:28 dansmith bauzas: if you're looking for reviews, we're still hoping you can +W the bottom two patches in the vtpm series
13:44:36 dansmith and of course, contribute to the reviews up the stack
13:44:43 bauzas shit, my brain forgor :)
13:44:48 bauzas forgot*
13:45:07 dansmith bauzas: https://review.opendev.org/c/openstack/nova/+/961734/4
14:17:34 opendevreview sean mooney proposed openstack/osc-placement master: Improve functional test debuggability with log capture https://review.opendev.org/c/openstack/osc-placement/+/963962
15:28:57 Uggla Nova meeting in ~30mn
15:30:51 opendevreview Merged openstack/nova master: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/961734
16:01:59 opendevmeet The meeting name has been set to 'nova'
16:01:59 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:59 opendevmeet Meeting started Tue Oct 14 16:01:59 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:59 Uggla #startmeeting nova
16:02:36 gibi o/
16:02:38 bauzas o/
16:02:43 gmaan o/
16:02:43 nicolairuckel o/
16:02:44 opendevreview Takashi Natsume proposed openstack/nova master: Update contributor guide for 2026.1 Gazpacho https://review.opendev.org/c/openstack/nova/+/961896
16:02:46 fwiesel o/
16:03:24 Uggla hey gmaan welcome back ;)
16:04:17 gibi gmaan: oooh hi!
16:04:26 sean-k-mooney o/
16:04:27 gmaan hi

Earlier   Later