| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-10-13 | |||
| 13:03:46 | elodilles | jlejeune: ACK, thanks, i'll started to review them already o:) note that we might won't have enough time to get them to final stable 2024.1 Caracal release, but we will see. | |
| 13:04:04 | elodilles | s/i'll/i've/ | |
| 13:05:22 | gibi | sean-k-mooney: dansmith: can I get eyes on the placement scaling patch? https://review.opendev.org/c/openstack/placement/+/962776 | |
| 13:12:25 | jlejeune | elodilles: thanks :) | |
| 14:57:54 | iurygregory | hey nova folks, iury from ironic here o/ we have some cross-project topics for the PTG https://paste.opendev.org/show/brq6RKT7WEmMyOkiWNu9/ can you check if Wednesday works? the topics are in order | |
| 15:04:42 | gibi | Ug | |
| 15:04:44 | gibi | Uggla: ^^ | |
| 15:37:19 | Uggla | iurygregory I'm gonna check | |
| 15:49:18 | iurygregory | Uggla, tks! let me know if you would have a preferable timeslot, I can shift things | |
| 16:18:30 | sean-k-mooney | @gibi i dont really have any addtional feedback so im +2 on it. im happy to proceed with it for now and hten revisit once it has baked a little | |
| 16:23:09 | gibi | sean-k-mooney: OK. Thanks | |
| 17:21:05 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358 | |
| 18:01:40 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test glance bug fix with bootable ISO https://review.opendev.org/c/openstack/nova/+/963878 | |
| #openstack-nova - 2025-10-14 | |||
| 07:25:42 | LarsErikP | " | |
| 08:11:30 | sean-k-mooney | LarsErikP: " | |
| 08:11:39 | sean-k-mooney | :) | |
| 08:11:53 | LarsErikP | sean-k-mooney: fat-finger-tuesday? :P | |
| 08:12:05 | sean-k-mooney | cant just leave un closed quots by them selves they coudl get lonely | |
| 08:12:10 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358 | |
| 08:12:12 | LarsErikP | fair point :P | |
| 08:12:36 | bauzas | sean-k-mooney: thanks for the help on autopep8, I'll look at the alt keys indeed before committing | |
| 08:12:57 | sean-k-mooney | bauzas: i reallised it worse for you | |
| 08:13:09 | sean-k-mooney | so you have a artzy keyboard right | |
| 08:13:14 | sean-k-mooney | so your # us ib 3 | |
| 08:13:20 | sean-k-mooney | *is on | |
| 08:13:21 | bauzas | maybe because I'm using a french kb, yes | |
| 08:13:37 | sean-k-mooney | ya so you press altgr 3 to type hash | |
| 08:13:37 | bauzas | yeah, Alt-Gr + 3 | |
| 08:13:43 | bauzas | correct | |
| 08:13:56 | bauzas | but I had no issues before AFAICR | |
| 08:14:04 | sean-k-mooney | ha so for me and its just the key above shift and for the use i think its shift 3 | |
| 08:14:08 | bauzas | lemme write some code and cat the file | |
| 08:14:35 | bauzas | maybe that's a VSCode/Codium issue | |
| 08:14:53 | sean-k-mooney | no its a local kmap issue | |
| 08:14:59 | bauzas | I was having the same issue with Codium and not only Cursor | |
| 08:15:08 | sean-k-mooney | once i relicated it i coudl do it in emacs as well | |
| 08:15:18 | sean-k-mooney | probably other editor too | |
| 08:15:38 | sean-k-mooney | oh well they may have other key binds that intercept it | |
| 08:15:54 | sean-k-mooney | i can only do it with altgr because left alt is bound ot other things in vscode | |
| 08:17:09 | sean-k-mooney | oh no for me alt space is grabbed by kde | |
| 08:17:34 | sean-k-mooney | its the applicaton laucher | |
| 08:17:58 | bauzas | just created a new file | |
| 08:18:24 | bauzas | https://paste.opendev.org/show/btgI58rkgJvf4i6XkWcO/ | |
| 08:18:33 | bauzas | I wasn't seeing any keys when catting | |
| 08:18:41 | bauzas | but lemme check the chars | |
| 08:19:00 | sean-k-mooney | do cat -vet nova/poc_wip.py | |
| 08:19:07 | sean-k-mooney | and you wil see the unicode | |
| 08:21:17 | bauzas | interesting https://paste.opendev.org/show/bd91pr4uhj1SrmkHRjry/ | |
| 08:22:01 | sean-k-mooney | ya so M-BM- | |
| 08:22:10 | sean-k-mooney | is what a non breaking space looks like | |
| 08:22:30 | bauzas | lemme try with vim to write another file | |
| 08:23:05 | sean-k-mooney | there are plugins by the way for vscode to remove "irrgualar spaces" | |
| 08:23:24 | sean-k-mooney | this is apprently a common enough thing that people took the time to write one | |
| 08:23:42 | sean-k-mooney | i didnt want to recomend any specific one sicne i have never tested them or veted them | |
| 08:25:05 | sean-k-mooney | "Fix Irregular Whitespace" is the most downloaded one | |
| 08:25:28 | bauzas | can also reproduce it with vim | |
| 08:25:57 | opendevreview | Taketani Ryo proposed openstack/nova-specs master: Adjust the SEV/SEV-ES code for multiple cc support https://review.opendev.org/c/openstack/nova-specs/+/962578 | |
| 08:26:00 | bauzas | so that's not an editor issue, definitely a keyboard mapping problem | |
| 08:27:35 | bauzas | oh fuck I found why | |
| 08:27:48 | bauzas | that's PEBKAC | |
| 08:28:01 | bauzas | I'm typing too fast so I wasn't releasing the altgr key when hitting space | |
| 08:28:32 | bauzas | so I was typing 'hashtag' (altgr-3) then 'alternative-mapping' (alt-gr space) | |
| 08:29:04 | bauzas | doh, I should set altgr-space to write a space | |
| 08:33:20 | opendevreview | Bogdan Dobrelya proposed openstack/nova master: Determine the device type from configuration first https://review.opendev.org/c/openstack/nova/+/963702 | |
| 08:37:16 | sean-k-mooney | bauzas: ya that is what i was assuming and because you have # on altgr 3 unlike the rest of us where it etiehr does not hava modifyier or its shift 3 | |
| 08:37:31 | sean-k-mooney | you are just more likely ot pres altgr space then the rest of us | |
| 08:40:13 | bauzas | yeah, I tested : shift-space produces a space, while altgr-space produces a non-visible combination of "M-BM- + space" | |
| 09:02:05 | bauzas | checked Gnome and my mapping is French (alt.) : confirmed that it hits nobreakspace | |
| 09:02:18 | bauzas | that probably changed in a fedora upgrade | |
| 09:09:31 | bauzas | changed my mapping to French, now it should be fixed | |
| 09:09:43 | bauzas | thanks all | |
| 09:42:54 | opendevreview | Bogdan Dobrelya proposed openstack/nova master: Determine the device type from configuration first https://review.opendev.org/c/openstack/nova/+/963702 | |
| 11:23:09 | tkajinam | hmm it seems functional tests in osc-placement is failing due to a warning log added to placement recently https://bugs.launchpad.net/placement/+bug/2127848 | |
| 11:24:01 | tkajinam | gibi, I wonder if that log should be really a warning or can it be debug ? https://opendev.org/openstack/placement/blame/commit/af09d65c3e24f214c43aebcb9cd069703ee87050/placement/objects/allocation_candidate.py#L827 | |
| 11:35:39 | tkajinam | (by the way we should use warning instead of warn... | |
| 11:35:41 | opendevreview | Takashi Kajinami proposed openstack/placement master: Replace LOG.warn https://review.opendev.org/c/openstack/placement/+/963948 | |
| 11:45:55 | sean-k-mooney | tkajinam: it depend on if its actionable or not | |
| 11:46:38 | sean-k-mooney | it proably shoudl be info level | |
| 11:47:08 | sean-k-mooney | with that said osc-placemetn shoudl not be asserting anyting related to placmenet logging | |
| 11:47:41 | sean-k-mooney | so this feels more like a osc placement bug in the test setup | |
| 11:48:31 | sean-k-mooney | the placemetn logs form the placemetn fixture shoudl be capsture in the est setup and filtered out of that assertion | |
| 11:49:31 | sean-k-mooney | in a real envonment that log woudl not be aviabel to the client | |
| 11:50:08 | sean-k-mooney | tkajinam: so the proper fix woudl be to install a log filter int eh osc-palcement functional tests i think to null route the placement logs | |
| 11:56:31 | tkajinam | sean-k-mooney, yeah I agree the issue and the lo level should be separate... | |
| 11:57:03 | tkajinam | sean-k-mooney, I looked into the logging setting but it looks tricky to me. the core problem is that the test does not use actual nova api but uses placement api fixture and filtering all placement logs mean we lost all api logs https://opendev.org/openstack/osc-placement/src/branch/master/osc_placement/tests/functional/base.py#L77 | |
| 11:57:20 | tkajinam | the test does not use actual *placement* api, I mean | |
| 11:57:56 | tkajinam | maybe we could raise it to ERROR ? | |
| 12:00:33 | sean-k-mooney | tkajinam: correct we shoudl nto have access to any of the api logs in osc-placement | |
| 12:01:12 | sean-k-mooney | osc-placmenet is the openstack client plugin and in real code it will only have access to the api respocne not hte logs | |
| 12:01:15 | tkajinam | it may be correct for assertions but I'm a bit afraid of loosing debuggability in test failures | |
| 12:01:27 | sean-k-mooney | so if any test is relying on the logs then that test is invlaid | |
| 12:02:30 | sean-k-mooney | we can keep the logs for the fixture but we shoudl not be loging the placment logs to stdout or stderr in generall but we shoudl atttach teh logs to the test output | |
| 12:05:04 | sean-k-mooney | we can proably do somethign like this https://github.com/openstack/nova/blob/master/nova/config.py#L56-L89 | |
| 12:05:39 | sean-k-mooney | add a log filt to the root loger that will intercept and redirect the logging else where but ill admit i have not tired | |
| 12:05:59 | tkajinam | ok | |
| 12:06:25 | tkajinam | let me give it some tries but I might just end up with bumping the log level filter to error | |
| 12:07:34 | sean-k-mooney | perhaps like this https://github.com/openstack/nova/blob/8b81b5f91ffe1f9c38a483d151b82316d443dbf6/nova/tests/fixtures/nova.py#L190-L199 | |
| 12:08:09 | sean-k-mooney | we may be able ot patch where placmenet or the placment fixutrer setup up logging iwth our own funciton | |
| 12:08:47 | sean-k-mooney | tkajinam: i assume this is repoducable if we just clone master and run the tests? | |
| 12:09:03 | tkajinam | yup | |