Earlier  
Posted Nick Remark
#openstack-nova - 2025-10-08
06:13:49 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
06:20:22 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
06:20:22 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021
06:20:23 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
06:20:23 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
06:20:24 opendevreview melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889
06:20:24 opendevreview melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052
06:20:25 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
06:46:24 opendevreview Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682
06:47:41 opendevreview Rajesh Tailor proposed openstack/nova stable/2024.1: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/963348
07:14:11 jlejeune hello all, can someone may have time to check my change https://review.opendev.org/c/openstack/nova/+/963156 please ?
07:51:29 bauzas jlejeune: looking
07:55:37 jlejeune bauzas: thanks, it's the first step to help me to reproduce the bug#2085135
07:56:10 bauzas jlejeune: ack, I don't have a context, so this is related to a bug ?
07:57:01 jlejeune yes, that one: https://bugs.launchpad.net/nova/+bug/2085135
08:00:04 jlejeune like explained in my commit message, I noticed that in tests, we don't update the mapped field of compute nodes after creating their mapping object, and I think we should, like it's done here: https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209
08:13:19 jlejeune bauzas: I've replied to your comments
08:16:37 bauzas cool will look
08:19:12 bauzas jlejeune: ah right, thanks, you were right about the fact we need to call twice the ServiceFixture but could you please add the bug report in the commit msg ?
08:33:08 opendevreview Julien Le Jeune proposed openstack/nova master: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963156
08:34:23 jlejeune bauzas: done
08:34:40 bauzas jlejeune: thanks, will do another round
08:37:20 bauzas jlejeune: I'm just looking now at what lookups for context nested cell cache
08:42:32 jlejeune thanks bauzas !
09:15:38 jlejeune bauzas: do I need to ask for more reviews from another core devs ?
09:17:20 bauzas hopefully no :)
09:17:37 bauzas I have more time for this cycle upstream \o/
09:35:13 jlejeune bauzas: ok, cool :)
10:28:10 opendevreview Sylvain Bauza proposed openstack/nova master: Add a regression test for ImagePropsWeigher https://review.opendev.org/c/openstack/nova/+/963357
10:28:11 opendevreview Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358
10:57:02 opendevreview Pavlo Shchelokovskyy proposed openstack/nova master: Return Conflict from attach_interface when no PCI slots https://review.opendev.org/c/openstack/nova/+/963363
10:57:43 sean-k-mooney jlejeune: on i remeber this bug report, so ok you making the test setup work more like reality with the cell db update and adjusting the two test that fail as a sidefect.
11:21:03 jlejeune sean-k-mooney: exactly, thanks for your votes
11:21:29 jlejeune I'm going to push my new regression test when that first change will be merged
11:35:31 opendevreview Merged openstack/nova master: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963156
11:45:41 opendevreview Julien Le Jeune proposed openstack/nova master: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963368
11:48:27 jlejeune bauzas: sean-k-mooney: here it is ^
11:53:45 sean-k-mooney can you rebase the fix change on top of the repoducer. regression test shoudl idealy be in the regression folder in a file named test_bug_#######.py
11:59:47 opendevreview Julien Le Jeune proposed openstack/nova master: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/933022
12:00:40 jlejeune done for the rebase
12:02:52 sean-k-mooney that does not seem to be rebased on https://review.opendev.org/c/openstack/nova/+/963368
12:03:13 sean-k-mooney so i was expectign to see that with the rebase it would fial in ci
12:03:40 sean-k-mooney until you later update it to modify the regression test to nolonger assert that the excption is raised
12:07:37 jlejeune for me it made more sense to put it in test_host_mapping module but I can move it in a dedicated module if you insist
12:09:29 gibi bauzas: can you look back to https://review.opendev.org/c/openstack/nova/+/947260 I promise it is very simple
12:10:25 bauzas gibi: thanks for the reminder
12:10:26 bauzas did it
12:12:48 gibi thanks
12:19:08 opendevreview Julien Le Jeune proposed openstack/nova master: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963368
12:20:27 opendevreview Julien Le Jeune proposed openstack/nova master: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963368
12:25:07 opendevreview Julien Le Jeune proposed openstack/nova master: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/933022
12:29:14 opendevreview Julien Le Jeune proposed openstack/nova master: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/933022
12:29:18 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
12:29:18 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
12:29:19 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
12:52:25 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
12:52:25 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
12:52:26 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
12:55:11 gibi dansmith: I fixed the comments and replied to you questions
12:56:52 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
13:03:58 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.2: Remove excessive logging from GET a_c https://review.opendev.org/c/openstack/placement/+/963382
13:04:38 opendevreview Balazs Gibizer proposed openstack/placement stable/2025.1: Remove excessive logging from GET a_c https://review.opendev.org/c/openstack/placement/+/963383
13:05:07 opendevreview Balazs Gibizer proposed openstack/placement stable/2024.2: Remove excessive logging from GET a_c https://review.opendev.org/c/openstack/placement/+/963384
13:26:48 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
13:26:49 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
13:26:49 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
13:41:54 dansmith gibi: replied
13:52:10 bauzas dansmith: not sure you saw it, but I eventually found the solution so please review that series : https://review.opendev.org/q/topic:%22bug/2125935%22
13:53:06 bauzas btw. I lol'd when I saw BTTF2 and BTTF1 (the best movies <3)
13:53:21 bauzas s/BTTF2/BTTF3
13:56:08 dansmith there is more BTTF trivia sprinkled (by me) through our tests, FYI... but yep, will look in a bit
13:59:54 bauzas thanks
14:10:06 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
14:10:07 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
14:10:07 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
14:10:38 gibi dansmith: thanks. I think everything is fixed now ^^
14:25:24 dansmith gibi: just one more nit.. just ooooooone more
14:25:29 dansmith (not really)
14:26:34 gibi :)
14:26:38 gibi thanks
14:28:06 dansmith gibi: so the inlining patch.. is that really a big benefit?
14:29:43 opendevreview Merged openstack/nova master: Remove nova.service.process_launcher https://review.opendev.org/c/openstack/nova/+/947260
14:30:16 gibi yep it can half runtime or bigger configs like for for a compute with 21 devs and a flavor with 21 devs requested
14:30:22 gibi s/or/for/
14:30:36 dansmith but why? just overhead for the function call?
14:30:51 dansmith (few minutes late to the eventlet call, fyi)
14:31:16 gibi it is not just inlining the call it is avoiding recalculation of things by re-using intermediate data and relying on the fact that the logic behind the call is cumulative
14:33:30 dansmith okay, would we get most of the benefit by just making a better function instead of having to inline? I haven't looked at it in detail yet, so..
15:16:58 sean-k-mooney gibi: dansmith i belive this https://review.opendev.org/c/openstack/placement/+/679385 was related to that work but its not the optimistation i was refering too
15:18:42 gibi sean-k-mooney: https://blog.leafe.com/graph-database-follow-up/ this describes one of the experiment
15:20:11 sean-k-mooney oh it was tetsuro that was workign on this
15:20:41 sean-k-mooney ya i remeber taliksing about graphql as well i belvie this was all arount th time of the second vancouver summit
15:23:57 gibi I remember the room where Ed showed his trials but I cannot associate a city to the room :)
15:28:44 sean-k-mooney it may have been the second denver one also
15:28:53 sean-k-mooney it was one of the last in person ones
15:32:06 sean-k-mooney but ya the preor post had some imperssin ve early showing https://blog.leafe.com/placement-graph-examples/ honestly whyile i do think adopting a graph based db on teh backend might ultimpalty make sense. moving an existing cloud and supproting the full api of placemetn with its special cases liek memerof ectra woudl be non trivail to do
15:33:23 sean-k-mooney neo4j is perhapse even more popular today the it was back then with the riase of llms and rag
15:33:33 sean-k-mooney but java is less so
16:15:01 opendevreview Merged openstack/os-resource-classes master: Drop basepython https://review.opendev.org/c/openstack/os-resource-classes/+/962806
17:11:12 opendevreview Merged openstack/placement master: Remove remaining basepython https://review.opendev.org/c/openstack/placement/+/962804

Earlier   Later