| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-10-07 | |||
| 16:56:04 | bauzas | because we were having a dict of dict | |
| 16:56:23 | dansmith | bauzas: oh the dict thing, right, but I also want to know why it passed our QE... | |
| 16:56:33 | dansmith | bauzas: anyway, put up a full patch and I'll look | |
| 16:57:01 | bauzas | but given the instances you createed in https://github.com/openstack/nova/commit/420050cf33dd58bc6b608540fc8f32b2f65ef274 don't have any metadata recorded in DB, then it always returns an empty dict | |
| 16:57:28 | bauzas | dansmith: ack, will upload a patch and try to write some comment + some pastebin | |
| 16:57:43 | bauzas | I need to leave for tai-chi but hopefully be back around 7pm UTC | |
| 16:59:13 | bauzas | long story short, I need to find a way to persist some metadata for the instances you create in test_fill_metadata() so that when calling db.instances_fill_metadata() we get those values for adding them into the object metadata itself | |
| 16:59:42 | bauzas | my brain is fried and I have to run errand | |
| 17:00:55 | dansmith | okay | |
| 17:01:46 | dansmith | melwitt: I think you're going to say it's expected behavior and it looks like the resize patch has a lot of conversion logic.. | |
| 17:02:28 | dansmith | I'm not sure if I think it's problematic behavior, but it's very much not what I expected | |
| 17:02:58 | melwitt | dansmith: yes I am typing that. I think the main issue is that in the 'user' patch the resize is not looking at image_hw_ in sysmeta but it should be (ignoring all of these patches ...) so I'm currently confused about that | |
| 17:03:07 | dansmith | because I don't know how to reconcile when the flavor and image disagree (especially in this case where I haven't set anything on my image) | |
| 17:04:02 | dansmith | melwitt: if it's not looking at image_hw_tpm_security then I don't know why it let me schedule to a user host when the flavor requests a host host | |
| 17:04:26 | melwitt | dansmith: yeah. that's what I was chatting with sean about last week is, is this going to be a problem that we have overloaded the image_hw_tpm_secret_security sysmeta key when it did not necessarily come from any image | |
| 17:05:38 | melwitt | dansmith: it's because there is no trait filtering logic yet at that point in the series. it knows nothing about 'host' at this point so it's treating it as if it doesn't exist. it is still 'user' despite the fact that it lets you set the flavor as 'host' | |
| 17:06:23 | dansmith | melwitt: eh? isn't this the trait filtering? https://review.opendev.org/c/openstack/nova/+/942502/19/nova/scheduler/request_filter.py | |
| 17:06:26 | melwitt | dansmith: so I guess maybe what I need to do is at least make it know about the "will-be-valid" values early on to reject them until support is introduced | |
| 17:06:37 | dansmith | oh, | |
| 17:06:47 | dansmith | you mean because it lets any security it doesn't know about through | |
| 17:06:52 | melwitt | yes | |
| 17:07:06 | dansmith | ack, so that should probably have an else: False or something | |
| 17:07:22 | dansmith | (if false means fail, I don't remember) | |
| 17:07:51 | melwitt | it's confusing because resize is allowed today for TPM, so 'user' is just current behavior so it's always going to work until support for the others like 'host' and 'deployment' are added | |
| 17:08:25 | dansmith | well, | |
| 17:08:28 | melwitt | I agree there is a problem here, just thinking of what the best way to deal with it | |
| 17:08:54 | dansmith | I would think it should be security=flavor.get('security', 'user') and not "security is something I don't recognize, so MEH WFM | |
| 17:09:26 | dansmith | because the extra spec lets you set =host right now, which is fine, but we should not just ignore that I think | |
| 17:09:41 | melwitt | it is, but if you specify 'host', it will set that. it just doesn't know what that is yet | |
| 17:10:28 | dansmith | well, right.. I just mean dropping out the bottom for unsupported-as-of-yet values | |
| 17:10:31 | melwitt | yeah I agree, that's what I was trying to say a minute ago is that I think I need to add awareness of what the valid values are so far and reject anything that is not | |
| 17:10:45 | dansmith | and even when they're all there, I think not allowing a security that it doesn't know about (regardless of how that got in there) is a better plan | |
| 17:10:53 | melwitt | yeah, agree | |
| 17:10:54 | dansmith | yeah | |
| 17:11:30 | melwitt | I'll update the patch to do that | |
| 17:12:03 | dansmith | cool, just commented on the missing else | |
| 17:12:10 | melwitt | thanks | |
| 19:02:40 | opendevreview | sean mooney proposed openstack/nova-specs master: Add ResourceProviderWeigher scheduler spec https://review.opendev.org/c/openstack/nova-specs/+/951222 | |
| 19:19:56 | opendevreview | sean mooney proposed openstack/nova-specs master: Add ResourceProviderWeigher scheduler spec https://review.opendev.org/c/openstack/nova-specs/+/951222 | |
| 20:36:18 | opendevreview | Merged openstack/nova master: [nova-tox-py312-threading]Ignore failing tests https://review.opendev.org/c/openstack/nova/+/961781 | |
| 21:36:03 | opendevreview | John Garbutt proposed openstack/nova master: Fix ironic rebuild with API >=2.93 https://review.opendev.org/c/openstack/nova/+/963298 | |
| #openstack-nova - 2025-10-08 | |||
| 02:09:26 | opendevreview | Sam Morrison proposed openstack/nova master: Filter out deleted instances when looking for build timouts https://review.opendev.org/c/openstack/nova/+/880125 | |
| 06:13:40 | opendevreview | melanie witt proposed openstack/nova master: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 06:13:40 | opendevreview | melanie witt proposed openstack/nova master: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 06:13:41 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | |
| 06:13:41 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502 | |
| 06:13:42 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | |
| 06:13:42 | opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | |
| 06:13:43 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 06:13:43 | opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051 | |
| 06:13:44 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 06:13:45 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 06:13:45 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |
| 06:13:47 | opendevreview | melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889 | |
| 06:13:47 | opendevreview | melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | |
| 06:13:49 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 06:20:22 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 06:20:22 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 06:20:23 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 06:20:23 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |
| 06:20:24 | opendevreview | melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889 | |
| 06:20:24 | opendevreview | melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | |
| 06:20:25 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 06:46:24 | opendevreview | Nicolai Ruckel proposed openstack/nova master: Preserve UEFI NVRAM variable store https://review.opendev.org/c/openstack/nova/+/959682 | |
| 06:47:41 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2024.1: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/963348 | |
| 07:14:11 | jlejeune | hello all, can someone may have time to check my change https://review.opendev.org/c/openstack/nova/+/963156 please ? | |
| 07:51:29 | bauzas | jlejeune: looking | |
| 07:55:37 | jlejeune | bauzas: thanks, it's the first step to help me to reproduce the bug#2085135 | |
| 07:56:10 | bauzas | jlejeune: ack, I don't have a context, so this is related to a bug ? | |
| 07:57:01 | jlejeune | yes, that one: https://bugs.launchpad.net/nova/+bug/2085135 | |
| 08:00:04 | jlejeune | like explained in my commit message, I noticed that in tests, we don't update the mapped field of compute nodes after creating their mapping object, and I think we should, like it's done here: https://opendev.org/openstack/nova/src/commit/cc742602bcdeff185ff120452e4f301398f6aa7b/nova/objects/host_mapping.py#L209 | |
| 08:13:19 | jlejeune | bauzas: I've replied to your comments | |
| 08:16:37 | bauzas | cool will look | |
| 08:19:12 | bauzas | jlejeune: ah right, thanks, you were right about the fact we need to call twice the ServiceFixture but could you please add the bug report in the commit msg ? | |
| 08:33:08 | opendevreview | Julien Le Jeune proposed openstack/nova master: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963156 | |
| 08:34:23 | jlejeune | bauzas: done | |
| 08:34:40 | bauzas | jlejeune: thanks, will do another round | |
| 08:37:20 | bauzas | jlejeune: I'm just looking now at what lookups for context nested cell cache | |
| 08:42:32 | jlejeune | thanks bauzas ! | |
| 09:15:38 | jlejeune | bauzas: do I need to ask for more reviews from another core devs ? | |
| 09:17:20 | bauzas | hopefully no :) | |
| 09:17:37 | bauzas | I have more time for this cycle upstream \o/ | |
| 09:35:13 | jlejeune | bauzas: ok, cool :) | |
| 10:28:10 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a regression test for ImagePropsWeigher https://review.opendev.org/c/openstack/nova/+/963357 | |
| 10:28:11 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix fill_metadata usage for the ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/963358 | |
| 10:57:02 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Return Conflict from attach_interface when no PCI slots https://review.opendev.org/c/openstack/nova/+/963363 | |
| 10:57:43 | sean-k-mooney | jlejeune: on i remeber this bug report, so ok you making the test setup work more like reality with the cell db update and adjusting the two test that fail as a sidefect. | |
| 11:21:03 | jlejeune | sean-k-mooney: exactly, thanks for your votes | |
| 11:21:29 | jlejeune | I'm going to push my new regression test when that first change will be merged | |
| 11:35:31 | opendevreview | Merged openstack/nova master: Update start_service() function in test https://review.opendev.org/c/openstack/nova/+/963156 | |
| 11:45:41 | opendevreview | Julien Le Jeune proposed openstack/nova master: Adds regression test for bug LP#2085135 https://review.opendev.org/c/openstack/nova/+/963368 | |
| 11:48:27 | jlejeune | bauzas: sean-k-mooney: here it is ^ | |
| 11:53:45 | sean-k-mooney | can you rebase the fix change on top of the repoducer. regression test shoudl idealy be in the regression folder in a file named test_bug_#######.py | |
| 11:59:47 | opendevreview | Julien Le Jeune proposed openstack/nova master: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/933022 | |
| 12:00:40 | jlejeune | done for the rebase | |
| 12:02:52 | sean-k-mooney | that does not seem to be rebased on https://review.opendev.org/c/openstack/nova/+/963368 | |
| 12:03:13 | sean-k-mooney | so i was expectign to see that with the rebase it would fial in ci | |
| 12:03:40 | sean-k-mooney | until you later update it to modify the regression test to nolonger assert that the excption is raised | |
| 12:07:37 | jlejeune | for me it made more sense to put it in test_host_mapping module but I can move it in a dedicated module if you insist | |
| 12:09:29 | gibi | bauzas: can you look back to https://review.opendev.org/c/openstack/nova/+/947260 I promise it is very simple | |