Earlier  
Posted Nick Remark
#openstack-nova - 2025-10-06
15:37:18 gibi yepp
15:37:57 gibi and we would also notice that 1,2,1 is an invalid prefix, so if there would be more groups, we would not test any of 1,2,1,x partial products
15:38:18 gibi as x can be any value the product would be invalid
15:38:20 dansmith yeah, sorry seems obvious now :P
15:39:24 dansmith okay so the solution is starting to come into view now.. the odometer is supposed to roll past a bunch of product "solutions" at the first index that isn't viable
15:39:33 gibi yepp
15:39:55 gibi (odometer or I learned during the weekend that it is called a mixed radix number in english that the odometer represents)
15:40:06 dansmith this is why I wanted to see a unit test to understand what the desired behavior was instead of trying to synthesize it in my head :)
15:41:02 gibi totally valid request to have unit tests
15:41:55 dansmith oh I know, I just mean.. I thought it would be easier to review the code with unit tests to show the behavior
15:42:18 dansmith that's not always the case, but here.. this is some complex stuff to reason about (until you get the idea in your head)
16:11:14 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
#openstack-nova - 2025-10-07
06:59:15 jlejeune1 gibi: hello, what do you think about: https://review.opendev.org/c/openstack/nova/+/963156 ? first requirement to fix bug 2085135
08:19:16 sthoffmann[m] Hi, I wrote a RFE for how to wait for ovn-controller at live-migration https://bugs.launchpad.net/neutron/+bug/2069718. I included some feedback to the POC changes I created for that. Can you approve from nova side, that the RFE/blueprint is ok?
08:50:38 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
08:50:38 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
08:50:39 opendevreview Balazs Gibizer proposed openstack/placement master: Inline exceeds_capacity https://review.opendev.org/c/openstack/placement/+/963053
09:58:03 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
09:58:04 opendevreview Balazs Gibizer proposed openstack/placement master: Inline exceeds_capacity https://review.opendev.org/c/openstack/placement/+/963053
09:58:04 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
10:08:33 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
10:08:33 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
10:08:34 opendevreview Balazs Gibizer proposed openstack/placement master: Inline exceeds_capacity https://review.opendev.org/c/openstack/placement/+/963053
10:23:14 opendevreview Balazs Gibizer proposed openstack/placement master: Inline exceeds_capacity https://review.opendev.org/c/openstack/placement/+/963053
10:23:14 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
11:51:07 priteau Hi Nova team! I have a trivial doc fix that has been open for a while: https://review.opendev.org/c/openstack/nova/+/955566
12:00:27 gibi priteau: thanks. fast approved it
12:03:58 priteau thanks!
12:11:00 opendevreview Merged openstack/nova master: doc: Fix typo in nova-manage command https://review.opendev.org/c/openstack/nova/+/955566
12:14:00 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
12:14:00 opendevreview Balazs Gibizer proposed openstack/placement master: Prune a_c search space by invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
12:14:01 opendevreview Balazs Gibizer proposed openstack/placement master: Inline exceeds_capacity https://review.opendev.org/c/openstack/placement/+/963053
12:34:04 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
12:34:57 opendevreview Balazs Gibizer proposed openstack/placement master: Inline _consolidate_allocation_requests https://review.opendev.org/c/openstack/placement/+/963052
12:36:38 gibi dansmith: sean-k-mooney: ^^ the prune https://review.opendev.org/c/openstack/placement/+/962776 and the inlining of consolidation https://review.opendev.org/c/openstack/placement/+/963052 patches are ready for review from my perspective. I'm abandoning the 3rd patch https://review.opendev.org/c/openstack/placement/+/963053 as it does not significantly help
12:39:38 gibi I will add a 3rd patch on top with a reno
12:58:40 opendevreview Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408
13:01:01 opendevreview Balazs Gibizer proposed openstack/placement master: Release notes for bug/2126751 https://review.opendev.org/c/openstack/placement/+/963275
13:02:01 sean-k-mooney gibi: ack i see you chosse not to factor out the logic into a helper. that is fine we can mark that restolved. i think the fact that you are not just purly inline and are integrating it into the algorthim while graduclaly buildign the candiates is called out enough in the commit
13:02:23 sean-k-mooney ill try and make some time later to treview them
13:02:55 sean-k-mooney gibi: nit: wyou have whitespace issues in teh relese note patch
13:03:54 opendevreview Balazs Gibizer proposed openstack/nova master: DNM: test with placement fix https://review.opendev.org/c/openstack/nova/+/963035
13:03:55 opendevreview Balazs Gibizer proposed openstack/nova master: DNM:Test with optimize_for_wide_provider_trees https://review.opendev.org/c/openstack/nova/+/963036
13:11:36 gibi sean-k-mooney: ack I will fix them
13:16:14 opendevreview Balazs Gibizer proposed openstack/nova master: [doc]PCI in Placement tuning https://review.opendev.org/c/openstack/nova/+/963281
13:52:34 dansmith gibi: what was the fix for not generating the extra duplicate matches?
13:54:15 opendevreview Balazs Gibizer proposed openstack/nova-specs master: Placement child resource provider usage in allocation-candidates https://review.opendev.org/c/openstack/nova-specs/+/938070
13:55:27 dansmith oh was it the deepcopy in the test itself maybe?
13:55:31 opendevreview Balazs Gibizer proposed openstack/nova-specs master: Placement child resource provider usage in allocation-candidates https://review.opendev.org/c/openstack/nova-specs/+/938070
13:56:08 gibi dansmith: I needed to copy the call args in the test as they are lists that are mutated between calls and the mock only stores the reference to the list
13:56:45 dansmith ack, so the code was doing the right thing, the test was just wrong.. I was hoping there was more optimization coming from the fix for that :)
13:56:53 gibi :)
13:56:53 gibi me too
13:58:01 gibi sean-k-mooney: dansmith: as you see the links above I pushed a nova doc change to link to the placement optimizations in the PCI in Placement doc. And I updated our backlog spec about the general allocation candidated explosioin problem with the new learning about the invalid candidates
13:58:22 dansmith ++
14:01:36 dansmith gibi: some comments and a couple questions on the latest rev
14:01:57 gibi OK. I will check
14:01:59 gibi thanks
14:02:28 dansmith gibi: apologies for going grammar police on it, but this is hard stuff to understand and having the english all correct definitely helps me when I'm trying to understand
14:16:16 gibi no worries. I do need help explaning this clearly for the reader
14:20:53 dansmith I think I'm pretty happy with the implementation now though.. feeling more comfortable for sure
15:08:02 Uggla Nova meeting in ~50mn
15:10:22 melwitt dansmith: I'm not sure if enable_service barbican would work. I have been using "enable_plugin barbican https://opendev.org/openstack/barbican"
15:11:18 dansmith melwitt: ack
15:11:20 dansmith thanks
15:14:15 melwitt dansmith: something to know about configuring barbican (which will be after everything is stacked afaik) is that the canned config will require you to add the "creator" role for any user that will need to create secrets. so for this it will be the user you will use to create VMs and also the nova service user. alternatively,
15:14:40 dansmith orly
15:14:57 melwitt if you configure enforce_new_defaults = true and enforce_scope = true you will not need the "creator" role. that's what I do bc I don't like doing role assignments if I can avoid it
15:15:18 dansmith in barbican's config I assume?
15:15:22 melwitt yes
15:18:26 melwitt in case it's helpful, this is the zuul job config I use for the proposed tempest tests I have proposed https://review.opendev.org/c/openstack/nova/+/957477/19/.zuul.yaml it could help to just see what sort of settings there are. you will not need to do all of that obviously like things about tempest
15:22:06 dansmith yeah cool, thanks,
15:37:52 opendevreview John Garbutt proposed openstack/nova master: Fix Ironic Rebuild with API >=2.93 https://review.opendev.org/c/openstack/nova/+/963298
15:45:25 Uggla Nova meeting in ~15mn
15:55:19 opendevreview John Garbutt proposed openstack/nova master: Fix ironic rebuild with API >=2.93 https://review.opendev.org/c/openstack/nova/+/963298
15:57:13 opendevreview John Garbutt proposed openstack/nova master: Fix ironic rebuild with API >=2.93 https://review.opendev.org/c/openstack/nova/+/963298
16:00:58 opendevmeet The meeting name has been set to 'nova'
16:00:58 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:58 opendevmeet Meeting started Tue Oct 7 16:00:58 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:58 Uggla #startmeeting nova
16:01:05 Uggla Hello everyone
16:01:54 fwiesel o/
16:02:21 kgube o/
16:02:25 Uggla awaiting others to join.
16:02:37 elodilles o/
16:02:48 bauzas o/
16:02:52 dansmith o/
16:04:00 Uggla Let's start
16:04:07 Uggla #topic Bugs (stuck/critical)
16:04:13 Uggla #info No Critical bug
16:04:26 Uggla #topic Gate status
16:04:34 Uggla #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:04:40 Uggla #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:04:47 Uggla #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status
16:04:55 Uggla #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:05:02 Uggla #info Please try to provide a meaningful comment when you recheck
16:05:08 opendevreview Konrad Gube proposed openstack/nova-specs master: Re-propose using extend volume completion action for 2026.1 https://review.opendev.org/c/openstack/nova-specs/+/949504
16:05:33 Uggla I haven't seen anything special regarding gate.
16:05:59 Uggla Does someone want to report something.
16:06:40 Uggla I guess gibi is still monitoring nova-tox-py312-threading

Earlier   Later