Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-10-01
10:35:11 bauzas we have one
10:35:12 sean-k-mooney but you can do asserts
10:35:16 sean-k-mooney ack
10:35:27 bauzas even with assertIn, the log doesn't have debug logs
10:35:49 sean-k-mooney it should let me check the capture fixture
10:36:04 sean-k-mooney im pretty sure we hage regression tests that assert debug logs
10:36:27 bauzas I wasn't able to see some of them
10:37:56 sean-k-mooney https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/functional/regressions/test_bug_1853009.py#L109-L111
10:38:15 sean-k-mooney that may not be a debug log but i expect output to have all logs including debug
10:39:01 bauzas I'm now able to get debug logs by doing in the SetUp :
10:39:02 bauzas root.handlers[0].setLevel(logging.DEBUG)
10:39:02 bauzas if root.handlers:
10:39:02 bauzas root = logging.getLogger()
10:39:17 bauzas but that's not right good
10:39:44 sean-k-mooney ya so that why i said i want to check the fixture
10:40:02 sean-k-mooney i was expectign our default log level in the funtional test to be debug
10:40:11 sean-k-mooney you coudl jsut ensure that by suign flags
10:40:24 sean-k-mooney in the test to set the confgi option to make it debug and see if that is enough
10:40:31 sean-k-mooney that woudl be the better way to do that
10:41:31 sean-k-mooney so this is our defult logging fixture https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/fixtures/nova.py#L126-L205
10:42:56 bauzas yeah, I'll try to use a conf flag instead
10:43:23 bauzas and yeah I found the fixture, that's why I'm mimic'ing it
10:43:44 bauzas wait_for_log now works with DEBUG, but I'll look at the conf flag
10:43:56 sean-k-mooney ya os it mention using OS_DEBUG=True to print out the debug logs but i tought it was just for that contoling the printing not if we capture them
10:44:09 sean-k-mooney i.e. i expected them to still be aviablein the tests to use
10:44:23 sean-k-mooney but just not logged to the test output
10:44:26 sean-k-mooney the ohter way to do this
10:44:36 sean-k-mooney is you can mock the LOG module level variable
10:44:49 sean-k-mooney and then just assert that its called with the message you expect
10:44:55 sean-k-mooney we do do that in places too
10:45:06 bauzas fwiw, self.flags(debug=True, group='DEFAULT') doesn't work
10:45:17 sean-k-mooney right it wont not with how this is written
10:45:29 sean-k-mooney that why im suggeting just mockign LOG in the relevent module
10:45:49 bauzas sean-k-mooney: yup, should be better to assert the LOG call for the weigher
10:46:04 bauzas thanks, will do it instead
10:46:07 sean-k-mooney https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/unit/virt/libvirt/volume/test_mount.py#L583
10:46:25 bauzas yup, there are examples, I just forgot them
10:46:28 sean-k-mooney so we typicly do that in a buch of place for unit test but it shoudl work the same for functional
10:46:50 bauzas mocking LOG is the right pattern for debug logs then, I forgot it
10:47:03 bauzas thanks
10:47:13 sean-k-mooney no worries
10:47:54 sean-k-mooney i also often just end up trying one way then the ohter depending on which works
10:48:07 sean-k-mooney i prefer ot not mock if i can avoid it but its just simpler in this case
12:23:17 opendevreview Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408
13:27:18 opendevreview Thomas Goirand proposed openstack/nova-specs master: Restrict booting from volume with disk https://review.opendev.org/c/openstack/nova-specs/+/960513
13:57:55 opendevreview Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408
14:28:41 opendevreview Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657
20:04:44 opendevreview Merged openstack/nova master: Centralize cooperative yield https://review.opendev.org/c/openstack/nova/+/950991
20:24:33 opendevreview Merged openstack/nova master: [hacking] N374 do not use time.sleep(0) to yield https://review.opendev.org/c/openstack/nova/+/950992
20:51:01 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795
20:51:01 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502
20:51:02 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483
20:51:02 opendevreview melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628
20:51:03 opendevreview melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021
20:51:03 opendevreview melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051
20:51:04 opendevreview melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771
20:51:05 opendevreview melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975
20:51:05 opendevreview melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629
20:51:07 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
20:51:07 opendevreview melanie witt proposed openstack/nova master: Opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052
23:51:20 opendevreview melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477
#openstack-nova - 2025-10-02
07:15:21 jlejeune1 hello, now that 2025.2 is out, I would like to have new reviews for my backports please: https://review.opendev.org/q/topic:%22bug-2044235%22 :)
09:43:24 opendevreview Balazs Gibizer proposed openstack/placement master: Reproduce GET a_c slowness https://review.opendev.org/c/openstack/placement/+/962596
09:43:25 opendevreview Balazs Gibizer proposed openstack/placement master: Prune search space with invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776
09:43:25 opendevreview Balazs Gibizer proposed openstack/placement master: Remove excessive logging from GET a_c https://review.opendev.org/c/openstack/placement/+/962775
09:45:05 gibi dansmith: sean-k-mooney: ^^ this helps if we keep max_allocation_candidates <= 1000 . I will test it in devstack next. I know that it is uggly and I have intention to clean it up as much as possible
09:45:33 gibi I just need proof first that it helps my customer as well
09:46:17 sean-k-mooney[m] cool ill take a look
09:46:54 sean-k-mooney[m] ugly and works reliably is better then broken at least in the short to medium term
09:49:03 sean-k-mooney[m] without buying in to any of the graphql hype i do wonder if there are larger refactors we may want to look at eventually. i know there was an experimetn to see if more could be done in sql in the past bt i dont know if that ever landed
09:52:51 sean-k-mooney[m] gibi: one comment can you keep the assisted-By in the commit message only. i really dont think that belongs in commetnt or doc strings
09:56:44 sean-k-mooney[m] gibi also that is not that ugly you just created your own product generatior, when you said ugly i was expectign somthing much more hack ish although im not a huge fan of the while true. i need to step away breifly but ill read it propler when i get back
10:02:37 stephenfin gibi: sean-k-mooney[m]: Can you review this test-only change? https://review.opendev.org/c/openstack/nova/+/951744
10:03:31 stephenfin I'm trying to remove keystoneclient from keystonemiddleware, and lajoskatona is trying to remove python-neutronclient, so this will (hopefully) break at some point
10:54:28 sean-k-mooney ack that makes sense to me
11:05:17 gibi sean-k-mooney[m]: I agree. I will move the assisted by tag to the commit message
11:06:06 gibi stephenfin: +2+A
11:06:16 stephenfin ty
11:31:43 sean-k-mooney gibi: sambork: https://review.opendev.org/c/openstack/nova/+/962478/2 see comment in line i think we are leakying that executor between test runs
11:32:12 sean-k-mooney im happy to proceed with teh first 2 nova-conductor native threading patchs for what its worth but the third i think has a bug
11:49:22 gibi sean-k-mooney: lets procede with the first two for now while Kamil checks the refactor. dansmith could you review https://review.opendev.org/c/openstack/nova/+/962478 ?
12:07:51 opendevreview Merged openstack/nova master: tests: Replace keystoneclient with keystoneauth1 https://review.opendev.org/c/openstack/nova/+/951744
12:16:15 zigo stephenfin: Thanks for taking over https://review.opendev.org/c/openstack/python-openstackclient/+/962487 !
12:16:19 zigo Much appreciated.
12:16:42 stephenfin nw, actually need to approve that
13:40:28 opendevreview Merged openstack/nova master: Switch nova-conductor to use ThreadPoolExecutor https://review.opendev.org/c/openstack/nova/+/957088
14:03:24 opendevreview Takashi Kajinami proposed openstack/placement master: Remove remaining basepython https://review.opendev.org/c/openstack/placement/+/962804
14:04:26 opendevreview Takashi Kajinami proposed openstack/os-traits master: Drop basepython https://review.opendev.org/c/openstack/os-traits/+/962805
14:04:49 opendevreview Takashi Kajinami proposed openstack/os-resource-classes master: Drop basepython https://review.opendev.org/c/openstack/os-resource-classes/+/962806
14:05:29 opendevreview Takashi Kajinami proposed openstack/os-resource-classes master: Drop basepython https://review.opendev.org/c/openstack/os-resource-classes/+/962806
14:05:45 opendevreview Takashi Kajinami proposed openstack/os-traits master: Drop basepython https://review.opendev.org/c/openstack/os-traits/+/962805
14:10:45 tkajinam anyone care to merge these trivial changes ? https://review.opendev.org/c/openstack/os-resource-classes/+/947488 https://review.opendev.org/c/openstack/os-resource-classes/+/932878
14:17:08 sean-k-mooney done
14:17:22 sean-k-mooney well for the last 2
14:17:27 gibi done
14:17:34 gibi ahh
14:17:38 tkajinam thanks both !
14:17:44 gibi :)
14:18:14 sean-k-mooney the basepython thing we can do
14:18:22 sean-k-mooney but it also will nto break anything if we never do it

Earlier   Later