| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-10-01 | |||
| 10:08:30 | gibi | but to generate enough valid candidate we go throuhg a lot of invalid one | |
| 10:08:38 | sean-k-mooney | ya | |
| 10:08:53 | sean-k-mooney | so really we need a second config option for how many we woudl evaculate | |
| 10:09:43 | gibi | that is hard, as in the current config 300k invalid is generated before the first valid is found from the 40k valid and 16M total candidates | |
| 10:09:46 | sean-k-mooney | i.e limit=100 , check=10000 | |
| 10:10:06 | sean-k-mooney | ya | |
| 10:10:40 | sean-k-mooney | really we need a better approch overall to this problem rather then trying to retofit the existign algorthim | |
| 10:10:54 | sean-k-mooney | but obviouly that is a much larger change | |
| 10:10:57 | gibi | I have high level ideas how to prune the search when we found an invalid candidate | |
| 10:11:21 | sean-k-mooney | i was just going to ask | |
| 10:11:27 | gibi | I just need time to put it together and see if it is enough help or not | |
| 10:11:28 | sean-k-mooney | what is the direction you are thinking of going wiht this | |
| 10:11:33 | sean-k-mooney | ack | |
| 10:11:47 | gibi | E.g. if G1-R1, G2-R1, G3-R2 is invalid due to R1 is overallocated by G1 and G2 then we don't have to check G1-R1, G2-R1, G3-R3 | |
| 10:12:39 | gibi | so a single invalid candidate can remove a bunch of other possible candidate that would fail the same check the same reason | |
| 10:12:50 | sean-k-mooney | you did something similar to the numa node code in nova too if i recall | |
| 10:12:55 | gibi | I did caching there | |
| 10:13:12 | gibi | here I would rather skip generating the candidate | |
| 10:13:20 | gibi | but the idea is similar | |
| 10:13:24 | sean-k-mooney | ya | |
| 10:13:29 | gibi | don't go through the same sub check repatedly | |
| 10:13:51 | sean-k-mooney | ok well since you have a direction i wont suggest any other but if you want to brainstorm or chat about it let me know | |
| 10:16:25 | gibi | I want to go down to this path a bit, then we can re-discuss | |
| 10:16:57 | gibi | also I think there will be a ptg topic about it as well :) | |
| 10:17:07 | gibi | thanks for checking the patch | |
| 10:17:24 | gibi | I will keep the nova team informed about the progress | |
| 10:20:13 | Vii | for informational purposes, working copy/paste novnc https://github.com/Vishwamithra37/galam_nonvc_copypaste/blob/CopyPasteWorking_NoVnc_OpenStack/README.md | |
| 10:25:23 | sean-k-mooney | Vii: it need a addtiona spice clipborad device added to the xml i belive | |
| 10:25:57 | sean-k-mooney | we looked at it breifly before but did you mange to get it workign without nova code changes? | |
| 10:27:01 | sean-k-mooney | upstream novnc supprot copypaset i bleive but not the way we create the vms | |
| 10:27:54 | sean-k-mooney | https://github.com/novnc/noVNC?tab=readme-ov-file#features | |
| 10:28:33 | sean-k-mooney | https://libvirt.org/formatdomain.html#channel | |
| 10:28:49 | sean-k-mooney | we need to add a qemu-vdagent channel | |
| 10:29:02 | sean-k-mooney | o supprot the clipboard functionalty | |
| 10:30:25 | sean-k-mooney | Vii: i looked into this a bit about a year ago but never worked on a poc | |
| 10:30:58 | sean-k-mooney | but form talking ot our virt team internally this functionalyt shoudl work with vnc and novnc if we wire it up properly | |
| 10:31:04 | sean-k-mooney | without the need for spice | |
| 10:31:42 | sean-k-mooney | it seams like you did it a diffent way by modifying the novnc html client applcation instead | |
| 10:34:23 | bauzas | do people here know how the fuck I could check DEBUG logs with something like _wait_for_log() in either a functional test or a regression one ? | |
| 10:34:32 | sean-k-mooney | this has been requested in teh past so we proably shoudl implement copy paste supprot at some point although VDI usecase for openstack in the past have mainly invovled isntalling a vdi service like window RDP server in the gust in the past | |
| 10:34:56 | bauzas | unless of course if you use OS_DEBUG | |
| 10:35:04 | sean-k-mooney | bauzas: i dont know if we have a wait funciton | |
| 10:35:11 | bauzas | we have one | |
| 10:35:12 | sean-k-mooney | but you can do asserts | |
| 10:35:16 | sean-k-mooney | ack | |
| 10:35:27 | bauzas | even with assertIn, the log doesn't have debug logs | |
| 10:35:49 | sean-k-mooney | it should let me check the capture fixture | |
| 10:36:04 | sean-k-mooney | im pretty sure we hage regression tests that assert debug logs | |
| 10:36:27 | bauzas | I wasn't able to see some of them | |
| 10:37:56 | sean-k-mooney | https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/functional/regressions/test_bug_1853009.py#L109-L111 | |
| 10:38:15 | sean-k-mooney | that may not be a debug log but i expect output to have all logs including debug | |
| 10:39:01 | bauzas | I'm now able to get debug logs by doing in the SetUp : | |
| 10:39:02 | bauzas | root.handlers[0].setLevel(logging.DEBUG) | |
| 10:39:02 | bauzas | if root.handlers: | |
| 10:39:02 | bauzas | root = logging.getLogger() | |
| 10:39:17 | bauzas | but that's not right good | |
| 10:39:44 | sean-k-mooney | ya so that why i said i want to check the fixture | |
| 10:40:02 | sean-k-mooney | i was expectign our default log level in the funtional test to be debug | |
| 10:40:11 | sean-k-mooney | you coudl jsut ensure that by suign flags | |
| 10:40:24 | sean-k-mooney | in the test to set the confgi option to make it debug and see if that is enough | |
| 10:40:31 | sean-k-mooney | that woudl be the better way to do that | |
| 10:41:31 | sean-k-mooney | so this is our defult logging fixture https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/fixtures/nova.py#L126-L205 | |
| 10:42:56 | bauzas | yeah, I'll try to use a conf flag instead | |
| 10:43:23 | bauzas | and yeah I found the fixture, that's why I'm mimic'ing it | |
| 10:43:44 | bauzas | wait_for_log now works with DEBUG, but I'll look at the conf flag | |
| 10:43:56 | sean-k-mooney | ya os it mention using OS_DEBUG=True to print out the debug logs but i tought it was just for that contoling the printing not if we capture them | |
| 10:44:09 | sean-k-mooney | i.e. i expected them to still be aviablein the tests to use | |
| 10:44:23 | sean-k-mooney | but just not logged to the test output | |
| 10:44:26 | sean-k-mooney | the ohter way to do this | |
| 10:44:36 | sean-k-mooney | is you can mock the LOG module level variable | |
| 10:44:49 | sean-k-mooney | and then just assert that its called with the message you expect | |
| 10:44:55 | sean-k-mooney | we do do that in places too | |
| 10:45:06 | bauzas | fwiw, self.flags(debug=True, group='DEFAULT') doesn't work | |
| 10:45:17 | sean-k-mooney | right it wont not with how this is written | |
| 10:45:29 | sean-k-mooney | that why im suggeting just mockign LOG in the relevent module | |
| 10:45:49 | bauzas | sean-k-mooney: yup, should be better to assert the LOG call for the weigher | |
| 10:46:04 | bauzas | thanks, will do it instead | |
| 10:46:07 | sean-k-mooney | https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/unit/virt/libvirt/volume/test_mount.py#L583 | |
| 10:46:25 | bauzas | yup, there are examples, I just forgot them | |
| 10:46:28 | sean-k-mooney | so we typicly do that in a buch of place for unit test but it shoudl work the same for functional | |
| 10:46:50 | bauzas | mocking LOG is the right pattern for debug logs then, I forgot it | |
| 10:47:03 | bauzas | thanks | |
| 10:47:13 | sean-k-mooney | no worries | |
| 10:47:54 | sean-k-mooney | i also often just end up trying one way then the ohter depending on which works | |
| 10:48:07 | sean-k-mooney | i prefer ot not mock if i can avoid it but its just simpler in this case | |
| 12:23:17 | opendevreview | Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408 | |
| 13:27:18 | opendevreview | Thomas Goirand proposed openstack/nova-specs master: Restrict booting from volume with disk https://review.opendev.org/c/openstack/nova-specs/+/960513 | |
| 13:57:55 | opendevreview | Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408 | |
| 14:28:41 | opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | |
| 20:04:44 | opendevreview | Merged openstack/nova master: Centralize cooperative yield https://review.opendev.org/c/openstack/nova/+/950991 | |
| 20:24:33 | opendevreview | Merged openstack/nova master: [hacking] N374 do not use time.sleep(0) to yield https://review.opendev.org/c/openstack/nova/+/950992 | |
| 20:51:01 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | |
| 20:51:01 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502 | |
| 20:51:02 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | |
| 20:51:02 | opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | |
| 20:51:03 | opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 20:51:03 | opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051 | |
| 20:51:04 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 20:51:05 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 20:51:05 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |