| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-09-18 | |||
| 06:50:52 | opendevreview | yangjianfeng proposed openstack/nova master: Support reusing existing port binding during instance live-migration https://review.opendev.org/c/openstack/nova/+/961593 | |
| 07:42:10 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2025.1: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961601 | |
| 07:43:48 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2024.2: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961602 | |
| 07:47:10 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2024.1: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961603 | |
| 08:49:39 | opendevreview | Merged openstack/nova stable/2024.1: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/960411 | |
| 10:12:52 | opendevreview | Sylvain Bauza proposed openstack/nova master: Regression test for ImagePropsWeigher due to missing context https://review.opendev.org/c/openstack/nova/+/961615 | |
| 11:57:34 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Mention socket in pci numa affinity extra spec help https://review.opendev.org/c/openstack/nova/+/961634 | |
| 13:23:21 | opendevreview | Josephine Seifert proposed openstack/nova stable/2024.2: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/961655 | |
| 14:03:55 | bauzas | dansmith: ping, if you are free of meetings :) | |
| 14:04:01 | dansmith | bauzas: just a sec | |
| 14:04:04 | bauzas | cool | |
| 14:05:58 | dansmith | bauzas: so, fill_faults() and fill_metadata() are operations on the list object, just like .save() on an instance or anything else | |
| 14:06:09 | dansmith | they expect to use the context that the object maintains | |
| 14:06:31 | bauzas | I see, those are not getters | |
| 14:06:33 | dansmith | since you're sort of yanking InstanceList into existence (and not getting one as the result of a DB query), you don't have a context set on the object itself | |
| 14:06:49 | dansmith | it's not wrong, it's just not the intended workflow | |
| 14:07:07 | dansmith | so just create the list like insts = InstanceList(context, ...) and then it will have it internally | |
| 14:07:27 | bauzas | sure, but then I wonder which context to pass | |
| 14:07:34 | dansmith | but you need to use an admin context, not the one for the current boot request, since that one won't be able to read all the instances you're going to survey | |
| 14:07:44 | bauzas | context for others, we speak about https://bugs.launchpad.net/nova/+bug/2125052 | |
| 14:08:12 | bauzas | yup, I figured it, so I probably need to instantiate a fully new admin context | |
| 14:08:38 | bauzas | we have the user request context stored in the requestspec, but as you said, that can't work | |
| 14:09:11 | bauzas | okay, I think I have everything I need | |
| 14:09:18 | bauzas | I'll write the bugfix | |
| 14:09:45 | dansmith | yup | |
| 14:10:07 | dansmith | I also definitely think it makes sense to have this enabled in nova-next, if not more of the weighers | |
| 14:10:17 | bauzas | dansmith: fancy question, is it better to hydrate a list of instances by passing the context in InstanceList creator or do exactly liek https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L339 ? | |
| 14:10:21 | dansmith | even if they're simple, if we're not running them we're not testing them | |
| 14:10:51 | dansmith | pass it on create, IIRC.. that other usage is likely very old (or misguided) | |
| 14:11:47 | bauzas | dansmith: I don't disagree but if so, we need to find the right weigher configs in order to have predictable and easy-to-understand scheduling | |
| 14:12:48 | dansmith | I surely hope that the weighers won't change the behavior in a way that makes the tests not work, especially on single-node jobs :) | |
| 14:31:55 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add admin context when filling metadata on ImagePropsWeigher https://review.opendev.org/c/openstack/nova/+/961673 | |
| 14:31:55 | opendevreview | Sylvain Bauza proposed openstack/nova master: Regression test for ImagePropsWeigher due to missing context https://review.opendev.org/c/openstack/nova/+/961615 | |
| 14:47:11 | bauzas | gibi: dansmith: given you still have context about the bug (oh oh oh, pun intended), reviews would be appreciated before we all forget https://review.opendev.org/c/openstack/nova/+/961673 | |
| 14:47:36 | dansmith | already did? | |
| 14:53:51 | bauzas | well, that's a one-liner addition, right? | |
| 14:54:14 | bauzas | the regression suite was written this morning | |
| 14:54:32 | dansmith | what? | |
| 14:56:37 | bauzas | the functional test I meant | |
| 14:57:04 | dansmith | I'm not sure what you're saying | |
| 14:57:24 | dansmith | I already +2d the regression and left a comment on the other one | |
| 15:03:27 | bauzas | let me rephrase: my morning, I investigated the cause of the bug and I tried to reproduce it using a functional test, which I uploaded | |
| 15:03:58 | bauzas | that's why it only took me 10 mins to upload the fix itself | |
| 15:04:19 | bauzas | (I was just replying to to 'already did ?') | |
| 15:04:27 | dansmith | weren't you asking for review? | |
| 15:04:43 | dansmith | that's what I was responding to: "already did...review" | |
| 15:09:06 | bauzas | oh sorry about the misunderstanding then :) | |
| 15:18:30 | gibi | I'm +2 on the first patch and the second looks good too I will +2 once Dan's comment is fixed | |
| 15:22:27 | bauzas | cool, lemme provide a new patchset then | |
| 15:25:22 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add admin context when filling metadata on ImagePropsWeigher https://review.opendev.org/c/openstack/nova/+/961673 | |
| 16:09:26 | opendevreview | Merged openstack/nova master: Regression test for ImagePropsWeigher due to missing context https://review.opendev.org/c/openstack/nova/+/961615 | |
| 19:03:43 | opendevreview | melanie witt proposed openstack/nova master: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/961734 | |
| 19:07:07 | opendevreview | melanie witt proposed openstack/nova master: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/961734 | |
| 20:01:34 | opendevreview | Merged openstack/nova stable/2024.1: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/960050 | |
| #openstack-nova - 2025-09-19 | |||
| 06:57:58 | gibi | bauzas: Hi! if you have a bit of time this backport will look familiar to you https://review.opendev.org/q/topic:%22bug/2115905%22 :)h | |
| 07:00:25 | bauzas | lolilol | |
| 07:01:33 | jlejeune | gibi: hello, same request for mine https://review.opendev.org/c/openstack/nova/+/961601 :) | |
| 07:07:25 | gibi | jlejeune: on it | |
| 07:08:07 | jlejeune | thanks :) | |
| 07:11:26 | gibi | jlejeune: maybe its me but I only see the regression test being backported there. do you have the actual fix backported on top of that as well? | |
| 07:12:55 | jlejeune | yes but I haven't yet create the changes, doing | |
| 07:14:44 | gibi | OK. I'm +2 on the regression test backports. Feel free to ping me when the fix backports are up. | |
| 07:14:57 | jlejeune | perfect | |
| 07:36:11 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2025.1: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/961601 | |
| 07:36:12 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2025.1: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/961774 | |
| 07:40:47 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2024.2: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/961775 | |
| 07:41:55 | opendevreview | Julien LE JEUNE proposed openstack/nova stable/2024.1: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/961778 | |
| 07:42:57 | jlejeune | gibi: here there are ^ | |
| 07:47:33 | opendevreview | Merged openstack/nova stable/2025.1: Reproduce bug/2115905 https://review.opendev.org/c/openstack/nova/+/960241 | |
| 08:02:55 | gibi | jlejeune: thanks | |
| 08:06:16 | gibi | jlejeune: one small suggestion, you can put all these to the same gerrit topic that was used for the original bugfix so it is easy to see the list of backports in a single query | |
| 08:30:53 | jlejeune | gibi: indeed, can I add a topic after having created the change ? | |
| 08:33:30 | gibi | jlejeune: yes on the web UI you can add it by hand | |
| 08:40:04 | jlejeune | nice, done :) | |
| 08:46:44 | gibi | jlejeune: thanks | |
| 08:47:11 | gibi | elodilles: there is a simple clean backport series from jlejeune in https://review.opendev.org/q/topic:%22bug-2044235%22 if you have time :) | |
| 08:48:05 | elodilles | gibi: ACK, will add it to my TODO :] | |
| 08:48:12 | gibi | elodilles: thanks! | |
| 08:50:34 | gibi | Uggla: (and others) I kept monitoring the nova-tox-py312-threading job to see if we have unexplained failures. I found three cases where this job failed but the eventlet based unit test job does not. I filed a bug and I will patch the ignore list to not run these two test cases until I have time to go back to burning down that ignore list https://bugs.launchpad.net/nova/+bug/2125185 | |
| 08:51:23 | gibi | If anybody sees a nova-tox-py312-threading run that fails while the normal unit test job passes then please let me know | |
| 08:53:39 | Uggla | gibi, ok I think we could share this in our next meeting and follow up on it if you wish. | |
| 08:57:24 | gibi | sure I will try to remember of it in the next meeting j) | |
| 08:57:25 | gibi | :) | |
| 09:00:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: [nova-tox-py312-threading]Ignore failing tests https://review.opendev.org/c/openstack/nova/+/961781 | |
| 09:00:33 | gibi | Uggla: ^^ this is the immediate fix | |
| 09:00:51 | Uggla | 👍 | |
| 09:00:52 | gibi | bauzas: sean-k-mooney: ^^ if you are around this fix a small gate instability | |
| 09:31:47 | bauzas | gibi: looking (sorry was on meeting) | |
| 09:32:27 | bauzas | gibi: thanks for continuing looking at our CI <3 | |
| 09:33:08 | gibi | yeah I feel like I introduced a voting job so I responsible keeping that job in good health :) | |
| 11:22:37 | sean-k-mooney | gibi: done | |
| 11:23:26 | sean-k-mooney | gibi: sorry was not around in my morning today | |
| 12:03:13 | gibi | sean-k-mooney: thanks, and no worries :) | |
| 12:15:47 | gibi | heads up I saw multiple multinode job failing due to the fact that the subnode nova-compute cannot connet to rabbit. | |
| 12:16:34 | gibi | maybe it is intermitten infra issue but if you also see it happening on your patches then it might worth to report to infra | |
| 12:17:31 | frickler | gibi: infra is watching you already ;) do you have an example I could look at? | |
| 12:19:42 | sean-k-mooney | gibi: the last tim ethat happend it was a build where the nodes came form 2 diffent providers | |
| 12:20:01 | sean-k-mooney | so it woudl be good to check if all nodes came form the same provider in that failed job run | |
| 12:20:54 | gibi | frickler: https://zuul.opendev.org/t/openstack/build/488552424c654e2e8a4d8c5cb82f02a0/logs | |
| 12:21:12 | gibi | frickler: and thanks for keeping an eye on it (on me?!) | |