| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-09-14 | |||
| 10:43:25 | ivveh | because there is nothing hindering from KVM/QEMU side to execute "virsh attach-device <instance> some.xml --live --config" which contains xml config for a filesystem with a socket coming from virtiofsd | |
| 10:43:48 | ivveh | (while the instance is running).. you can also detach-device as well | |
| 10:44:45 | ivveh | and since this was implemented not so long ago and this has worked for quite some time in qemu, im just wondering.. is it pointing perhaps to a very old version of QEMU/KVM? | |
| #openstack-nova - 2025-09-15 | |||
| 07:37:35 | opendevreview | Julien LE JEUNE proposed openstack/nova master: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/960349 | |
| 08:21:59 | opendevreview | Julien LE JEUNE proposed openstack/nova master: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/960349 | |
| 09:01:27 | opendevreview | Julien LE JEUNE proposed openstack/nova master: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/901655 | |
| 09:47:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | |
| 10:40:16 | sean-k-mooney | ivveh so the current state is as follows, when we were adding the feature to nova orginally the qemu feature to supprot attach was not complete so it was put out of scope of the nova feature wit the intent to support atach in the future. the nova support for this took longer then intended and since then libvirt and qemu have released supprot for it but nova has not been | |
| 10:40:18 | sean-k-mooney | updated to supprot it | |
| 10:41:26 | sean-k-mooney | ivveh so the tl;dr is it used ot be a qemu limiation and not its a nova one as we have not updated to use the new qemu fatures. for partcial reasons however the limitation si still in effefct for openstack but its something we would like to eventually adress. | |
| 10:49:35 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix string format specifier https://review.opendev.org/c/openstack/nova/+/961211 | |
| 11:31:24 | ratailor | sean-k-mooney, gibi bauzas could you please review clean backports, one more +2 is required. https://review.opendev.org/q/project:openstack/nova+branch:stable/2024.2+owner:ratailor@redhat.com | |
| 11:48:07 | sean-k-mooney | gibi's on pto until wednesday i belvie but i can take a look at the latter two now. it looks like elod and gibi have already approved the first 2 | |
| 11:48:24 | sean-k-mooney | oh elod already didi it | |
| 11:49:57 | sean-k-mooney | since elod has appvoed the 2024.2 version ill quickly pre review the 2024.1 backports | |
| 11:51:06 | jlejeune | hello sean-k-mooney, did you have time to check my regression test: https://review.opendev.org/c/openstack/nova/+/960349 ? | |
| 11:52:53 | sean-k-mooney | i saw that you change to a plain Excption you could also have used a TestEXcption but my main concern with that is you likely can just catch every excption in the main code. | |
| 11:53:55 | sean-k-mooney | this might be fine https://review.opendev.org/c/openstack/nova/+/901655/8/nova/compute/manager.py#9095 because its in pre live migraiton | |
| 11:54:29 | sean-k-mooney | but the futher we get into the migraiton tbe more clean up that is required and the more careful and specific we need to be with what we catch | |
| 11:55:33 | sean-k-mooney | you are at least converting the generic error to a specific on in that expcption handeler which is good | |
| 11:56:25 | jlejeune | yes it's because it happens in pre live migration check that I allowed myself to do it | |
| 11:57:28 | sean-k-mooney | can you rebase your fix patch on the latest revsion of the repoducer so we can see them working togehter | |
| 11:58:41 | jlejeune | sure, doing | |
| 12:00:25 | sean-k-mooney | your reusign the exsitng exception.MigrationPreCheckError that we have for the late tenatn anti affinity check which imples this exception case shoudl already be handeld and it shoudl rollback any work done so i think that is a good chioce and it is also another precheck failure so its semanticly valid | |
| 12:00:50 | opendevreview | Julien LE JEUNE proposed openstack/nova master: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/901655 | |
| 12:02:33 | sean-k-mooney | jlejeune: by the way, whle we prefer functional repoduces if wee cant simulate the exact condtions in the fucntional suite we also do use unit test repodcues form time to time. | |
| 12:03:39 | jlejeune | hm ok good to know | |
| 12:04:21 | sean-k-mooney | so if other want to see more explicte testign with a timeout excption, we could add one that directly calls check_can_live_migrate_destination and mke it mock check_can_live_migrate_source to raise the timeout excption you orgianlly hit | |
| 12:04:46 | sean-k-mooney | then you can show yoru fix convet it to a MigrationPreCheckError | |
| 12:05:12 | sean-k-mooney | the functional test you already have will continue to assert the overall instnace state stays active | |
| 12:05:20 | jlejeune | it was what I have done at first on the unit test :) | |
| 12:05:23 | sean-k-mooney | and the unit test will assert that timeouts are properly handeled | |
| 12:05:36 | sean-k-mooney | yep | |
| 12:05:54 | jlejeune | I can replace the test.Exception by the olso message timeout if you prefer | |
| 12:06:00 | jlejeune | in the unit tets | |
| 12:06:41 | sean-k-mooney | im not sure that is requird. | |
| 12:06:55 | sean-k-mooney | im more saying f other think we should have a more explcit repoducer | |
| 12:07:18 | sean-k-mooney | i woudl proably do that via pulling in part fo the unit test you wote | |
| 12:07:51 | sean-k-mooney | but instead assert that the excption is not handled properly locally. | |
| 12:08:19 | ratailor | sean-k-mooney, do we need to backport this once it merges on master. https://review.opendev.org/c/openstack/nova/+/961211 | |
| 12:08:27 | sean-k-mooney | i.e. that it is not properly converted to the MigrationPreCheckError error by check_can_live_migrate_destination | |
| 12:09:06 | sean-k-mooney | it depend on what the side effect is. | |
| 12:09:14 | sean-k-mooney | we proably should backprot it because its trivial | |
| 12:09:25 | sean-k-mooney | but i dont see a bug for it | |
| 12:09:51 | sean-k-mooney | im guessign the error is not incldued in the message correct | |
| 12:10:06 | sean-k-mooney | so it prints litrally $(error)s | |
| 12:10:13 | sean-k-mooney | instead of interpolating the strign | |
| 12:10:46 | sean-k-mooney | that is not critical to backport as long as it does not break anything but it will improve debugablity so its good to backport it | |
| 12:11:03 | ratailor | sean-k-mooney, should I file a bug for it then ? | |
| 12:12:03 | sean-k-mooney | sure, feel free to triage it and asign it to your self | |
| 12:12:46 | ratailor | sean-k-mooney, ack. Thanks! | |
| 12:15:53 | jlejeune | not sure to understand what do you mean sean-k-mooney :) | |
| 12:17:04 | sean-k-mooney | jlejeune: i mean your current unit test is fine in the fix patch, you might consider copying it to the repodcuer patch and have it assert it retruns the timeout or test expction instead fo converting it to the pre migration expction | |
| 12:17:34 | sean-k-mooney | jlejeune: that woudl show that orginally the code did not have any sepcial handelign for timeouts and after your change it does | |
| 12:17:59 | sean-k-mooney | where as the functional test shows that before that ment the instnace went to error and after the instance stays active | |
| 12:18:19 | sean-k-mooney | jlejeune: that makes it very clear what you fixed and how | |
| 12:19:41 | sean-k-mooney | what: error -> active how: Timeout/generic excption -> MigrationPreCheckError | |
| 12:20:19 | sean-k-mooney | jlejeune: you dont have to do that but it would be nice to have that level fo clarity in the repoducer and fix. | |
| 12:20:50 | jlejeune | hm ok I get it | |
| 12:42:40 | jlejeune | so we can move on with that for now ? and I will know it for the next time :) | |
| 12:43:25 | sean-k-mooney | yes i think so, and if other would like more testing in the repoducer you knwo what to add | |
| 12:46:13 | jlejeune | ok ! | |
| 12:48:55 | opendevreview | Julien LE JEUNE proposed openstack/nova master: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/901655 | |
| 12:50:12 | jlejeune | what do you think about that (https://review.opendev.org/c/openstack/nova/+/960349) gibi ? | |
| 13:06:51 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add compute-volume-az-mapping spec https://review.opendev.org/c/openstack/nova-specs/+/961233 | |
| 13:07:55 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add compute-volume-az-mapping spec https://review.opendev.org/c/openstack/nova-specs/+/961233 | |
| 13:08:20 | sean-k-mooney | stephenfin: is ^ a purly nova spec or also invovles cidner | |
| 13:28:53 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix string format specifier https://review.opendev.org/c/openstack/nova/+/961211 | |
| 13:44:06 | opendevreview | Merged openstack/nova stable/2024.2: Fix case sensitive comparison https://review.opendev.org/c/openstack/nova/+/959534 | |
| 14:37:26 | opendevreview | Julien LE JEUNE proposed openstack/nova master: Adds regression test for bug LP#2044235 https://review.opendev.org/c/openstack/nova/+/960349 | |
| 14:41:54 | opendevreview | Julien LE JEUNE proposed openstack/nova master: nova-conductor puts instance in error state https://review.opendev.org/c/openstack/nova/+/901655 | |
| 14:42:52 | jlejeune | sean-k-mooney: here are my last changes following your note ^ | |
| 14:46:11 | sean-k-mooney | thanks i have a meeting at the top of the hour but ill see if i can review it before then | |
| 14:47:42 | jlejeune | ok, no pb | |
| 14:48:29 | dansmith | Uggla: rc1 is cut so we're good to merge on master for 2026.1 yeah? | |
| 14:56:52 | Uggla | dansmith, yes RC1 patch was merged so we are good to go. | |
| 14:57:14 | dansmith | Uggla: cool | |
| 14:57:23 | dansmith | bauzas: can you circle back on this? https://review.opendev.org/c/openstack/nova/+/954990 | |
| 14:57:52 | bauzas | ack | |
| 15:03:50 | stephenfin | sean-k-mooney: I think just Nova | |
| 15:04:10 | stephenfin | If we did it the way I planned, it would live in nova because that's where the metadata service lives | |
| 15:13:02 | opendevreview | Merged openstack/nova stable/2024.2: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/959429 | |
| 15:14:09 | opendevreview | Merged openstack/nova stable/2024.2: Fix disable memballoon device https://review.opendev.org/c/openstack/nova/+/952960 | |
| 15:16:54 | sean-k-mooney | stephenfin: i havene tread it but ok this is about metadta not about modelign it in palcement | |
| 15:17:19 | stephenfin | yes, purely a host-level config option exposed to the user via metadata | |
| 15:18:06 | stephenfin | I want it so cinder CSI doesn't need to conflate compute AZ with block storage AZs (we've no mechanism currently to say "give me the storage AZ for this instance) | |
| 17:15:05 | opendevreview | Merged openstack/nova master: Remove eventlet timer from multi_cell_list https://review.opendev.org/c/openstack/nova/+/954990 | |
| 17:15:18 | opendevreview | Merged openstack/nova stable/2024.1: Fix disable memballoon device https://review.opendev.org/c/openstack/nova/+/952961 | |
| 20:14:21 | opendevreview | Merged openstack/nova stable/2024.2: Fix case-sensitivity for metadata keys https://review.opendev.org/c/openstack/nova/+/959435 | |
| #openstack-nova - 2025-09-16 | |||
| 04:51:05 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix string format specifier https://review.opendev.org/c/openstack/nova/+/961211 | |
| 04:52:41 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2025.2: Fix string format specifier https://review.opendev.org/c/openstack/nova/+/961336 | |
| 04:53:43 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2025.1: Fix string format specifier https://review.opendev.org/c/openstack/nova/+/961337 | |
| 08:01:25 | jkulik | sean-k-mooney: I'd appreciate another look at https://review.opendev.org/c/openstack/nova/+/959696 | |
| 08:46:10 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2024.1: Fix case-sensitivity for metadata keys https://review.opendev.org/c/openstack/nova/+/961352 | |
| 10:09:19 | opendevreview | Taketani Ryo proposed openstack/nova master: doc: Need to configure the compute_driver in RHEL distributions https://review.opendev.org/c/openstack/nova/+/961360 | |
| 12:52:14 | opendevreview | Merged openstack/os-vif stable/2024.1: Do not add taps in trunk bridges to the dead vlan https://review.opendev.org/c/openstack/os-vif/+/957490 | |
| 13:01:11 | opendevreview | Merged openstack/os-vif stable/2024.1: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/957491 | |
| 13:01:12 | opendevreview | Merged openstack/os-vif stable/2025.2: Remove remaining job with Ubuntu Jammy (22.04) https://review.opendev.org/c/openstack/os-vif/+/959855 | |
| 15:04:10 | Uggla | Nova meeting in ~1h. | |
| 15:42:41 | bauzas | Uggla: I need to taxi back my daughter from the high school, I'll join a bit later | |