| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-09-07 | |||
| 18:33:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:33:42 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:34:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:36:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:37:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:38:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:39:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:39:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:41:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:41:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 19:16:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate image for stateless firmware https://review.opendev.org/c/openstack/nova/+/959988 | |
| 19:16:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| #openstack-nova - 2025-09-08 | |||
| 10:38:45 | sean-k-mooney | atmark: we have never supproted detacting volume via cinder like that and it actully cause security problem if you do that | |
| 10:39:06 | sean-k-mooney | atmark: the only way to detach a volume form an instnace is via nova's api | |
| 10:41:51 | sean-k-mooney | depending on the relase of openstack we have two volume healing operations, in newer relase a hard reboot will regenerate teh bdms using cidner as the source of truth for what shoudl be attached, we also have a nova-manage command that predates it and uses the bdm as the souce of truth and will recreate the attachments | |
| 13:26:54 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/960050 | |
| 13:27:14 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | |
| 13:38:31 | opendevreview | Merged openstack/python-novaclient master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959749 | |
| 13:40:16 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2025.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/958874 | |
| 13:41:11 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.2: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959913 | |
| 14:45:04 | dansmith | I'm sick of autopep8 reformatting my code instead of suggesting it when I run `tox -epep8` | |
| 14:45:16 | dansmith | surely there's some way I can locally prefer not to do that right? | |
| 14:45:23 | dansmith | bauzas: Uggla ? | |
| 14:45:44 | dansmith | not sure when the team agreed to do this, but man it's annoying | |
| 14:47:12 | bauzas | dansmith: pre-commit is already doing that :( | |
| 14:47:40 | dansmith | I know | |
| 14:47:44 | dansmith | I want to turn it off | |
| 14:47:57 | bauzas | apart finding another agreement, I don't see what we can do | |
| 14:48:11 | bauzas | the agreement being that autopep8 is and should always be optional | |
| 14:48:23 | bauzas | including in the tox target | |
| 14:48:31 | dansmith | bauzas: +1000 | |
| 14:48:52 | bauzas | also, skipping pre-commit is unfair, as I need pre-commit for adding the gerrit change ID automatically, I can't just skip autopep8 | |
| 14:49:15 | bauzas | (AFAIK, no way to only skip a subset of the multiple pre-commit hooks) | |
| 14:49:51 | Uggla | hum it is the case for quite some time right ? | |
| 14:50:34 | dansmith | Uggla: it has been yes and I've hated it this whole time, but this morning it's really killing me and I want it to stop | |
| 14:50:56 | dansmith | I also argued against it when it was even proposed before it was autopep8'ing | |
| 14:51:14 | dansmith | IIRC it used to just show the suggestions but not force them on me | |
| 14:59:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 14:59:18 | Uggla | it depends some changes are left to the author, but some basic reformatting are applied, if I'm not wrong. | |
| 14:59:44 | dansmith | yes and I never ever want it to do that.. | |
| 15:00:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 15:00:18 | dansmith | if I have uncommitted changes and I run pep8, it will make a bunch of extra changes that I did not want that are all "opinions" of the tool and now I have more change queued | |
| 15:01:44 | dansmith | right now it keeps forcing this on me: 3 | |
| 15:01:49 | dansmith | https://paste.opendev.org/show/bjPrI7fQi2rx3TH1ndDB/ | |
| 15:02:03 | dansmith | which takes the code from readable to stupid for no effing reason | |
| 16:10:55 | ratailor__ | bauzas, melwitt can I get reviews on backports https://review.opendev.org/c/openstack/nova/+/958834 and https://review.opendev.org/q/project:openstack/nova+branch:stable/2024.2+owner:ratailor@redhat.com | |
| 16:12:15 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | |
| 16:20:06 | sean-k-mooney | bauzas: the change-id hook is entirly seperate | |
| 16:21:19 | sean-k-mooney | you can 1 not install pre-commit, 2 if you have it install do --no-verify to dsiabll all hooks other then the change id hook ro 3 use SKIP=list,of,hook.ids as some options | |
| 16:21:30 | bauzas | sean-k-mooney: sorry, I meant that --no-verify skips all the hooks | |
| 16:21:56 | sean-k-mooney | all the hooks form the pre-commit tool but i dont think it skips the change id hook | |
| 16:22:50 | sean-k-mooney | dansmith: that may be a side effect of a change i did a while a go to make autopep8 fix more things | |
| 16:22:56 | sean-k-mooney | we coudl look at trunign that off | |
| 16:23:07 | dansmith | please please please turn it off | |
| 16:23:15 | bauzas | sean-k-mooney: the git help says that it also skims commit hooks, so the gerrit one | |
| 16:23:24 | sean-k-mooney | ack | |
| 16:23:36 | bauzas | commit-msg sorry | |
| 16:23:37 | sean-k-mooney | let me find the comit and pose a revert and see if that help | |
| 16:24:41 | sean-k-mooney | i basically took some of the config form oslo/sdk and ported it a few monts ago | |
| 16:25:05 | dansmith | fast8 also was broken, I assume by one of these changes a while ago which is also really frustrating | |
| 16:25:33 | dansmith | I haven't tried fixing it yet, but it's really annoying because it's like "please try pre-commit instead!" with the implication of "so I can break your code for you" | |
| 16:25:41 | sean-k-mooney | well that was ment to bedeelted a while ago but i dont think that is related | |
| 16:26:20 | dansmith | I dunno why it was "meant to be deleted" .. I assume that's just your opinion, but it's a huge time saver | |
| 16:27:15 | sean-k-mooney | so this https://github.com/openstack/nova/commit/ebd75760e1907bb4b1bc089ecf6f4405bf52e208 might be the issue | |
| 16:27:44 | sean-k-mooney | dansmith: not just that it has not been maintaiend for a while an i otught it broke with some of the ohter seuptools change ectra | |
| 16:27:57 | sean-k-mooney | i dont reacall honestly because i have not used it in a few years | |
| 16:28:22 | dansmith | I will propose the revert for that if you don't | |
| 16:29:02 | sean-k-mooney | aggressive = 3 is the actual change in behavior but when we did change it it dint really change mouch code | |
| 16:29:09 | sean-k-mooney | but sure if tis cause issue swe can drop that | |
| 16:31:25 | sean-k-mooney | ok i need to do that form the cli... | |
| 16:33:23 | tkajinam | or you can just copy-paste the string | |
| 16:33:30 | tkajinam | it does not require actual signing | |
| 16:33:35 | dansmith | Uggla: I'd really like to get wider team agreement on more things like this: https://review.opendev.org/c/openstack/nova/+/949292 before they merge | |
| 16:33:48 | sean-k-mooney | tried that but i cant use my normal email if i do that | |
| 16:34:00 | tkajinam | ah, yeah | |
| 16:34:15 | sean-k-mooney | i could swap to my redhat one but it complain about the commit not matchign the sgined off by line since my redhat email is my gerrit default | |
| 16:34:33 | sean-k-mooney | it woudl be better if it allwoed any of them or allowed my to select like if im editing things in the ui | |
| 16:34:51 | tkajinam | I remember I faced similar problems when I tried to rebase your change. | |
| 16:34:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 16:35:11 | tkajinam | so yeah I agree with you | |
| 16:35:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 16:36:01 | opendevreview | Dan Smith proposed openstack/nova master: Fix fast8 tox target https://review.opendev.org/c/openstack/nova/+/960149 | |
| 16:36:10 | dansmith | bauzas: ^ can haz please to fix fast8 | |
| 16:36:14 | dansmith | it's trivial | |
| 16:36:27 | opendevreview | sean mooney proposed openstack/nova master: Revert "Allow autopep8 to fix more things" https://review.opendev.org/c/openstack/nova/+/960150 | |
| 16:37:01 | dansmith | bauzas: and also that ^ | |
| 16:37:39 | sean-k-mooney | dansmith: can you test that locally by remving the agressive=3 line | |
| 16:37:50 | sean-k-mooney | that actully the only thing it is really changing | |
| 16:38:07 | sean-k-mooney | i think the default is 0 or 1 | |
| 16:40:54 | dansmith | I don't ever want in-place=True, assuming that's the permission to modify anything | |
| 16:41:19 | sean-k-mooney | yes that what that enables | |
| 16:41:55 | sean-k-mooney | when invoked form per-commit it will do that by defualt adn recurse | |
| 16:41:55 | dansmith | removing aggressive=3 still modifies my file | |
| 16:42:04 | dansmith | yeah -2 on that | |
| 16:42:19 | sean-k-mooney | well we have been doing that and agreed to do that for years | |
| 16:42:24 | sean-k-mooney | that was not part of this change | |
| 16:42:36 | sean-k-mooney | i jsut encoded the defaults we already had implictly | |
| 16:42:48 | dansmith | we have not "agreed to do that for years" | |
| 16:42:58 | sean-k-mooney | well it not new | |
| 16:43:10 | sean-k-mooney | it was not part of that change | |