| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-09-03 | |||
| 12:31:58 | sean-k-mooney | i tired claks suggestion and while i could get it to work having to specyify all the deps one by one is more fagile IMO then doign it the other way so i think im goign to try the -t approch isntead next time. | |
| 12:32:40 | sean-k-mooney | gibi: basiclly i would have to list all the same packages you did in yoru downgrade patch for qemu-img and thats a pain | |
| 12:33:52 | sean-k-mooney | addin a branch to install_libvirt for debian 12 i think its just simpler the refactoing the install to use files | |
| 12:51:27 | Uggla | gibi thanks for the above info. | |
| 12:53:06 | Uggla | the msg from qemu-img is quite strange. | |
| 13:11:58 | opendevreview | Tobias Urdin proposed openstack/nova master: Retry more volume API functions on server error https://review.opendev.org/c/openstack/nova/+/942981 | |
| 14:02:22 | ratailor | sean-k-mooney, gibi could you please review https://review.opendev.org/c/openstack/nova/+/946733 and https://review.opendev.org/c/openstack/nova/+/954460 | |
| 14:03:43 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos https://review.opendev.org/c/openstack/nova/+/959322 | |
| 14:06:28 | ratailor | Uggla, could you please review this clean backport to stable/2024.1 https://review.opendev.org/c/openstack/nova/+/952961 | |
| 14:06:55 | Uggla | ratailor, sure I'm going to do it. | |
| 14:07:05 | ratailor | Uggla, Thanks! | |
| 14:12:50 | gibi | ratailor: https://review.opendev.org/c/openstack/nova/+/954460 is pretty featury so that probably need to wait G | |
| 14:14:16 | gibi | I'm +2 on https://review.opendev.org/c/openstack/nova/+/946733 | |
| 14:14:22 | ratailor | gibi, ack. Thanks! could you please glance through it and check if anything is missing. when you have time. | |
| 14:22:25 | sean-k-mooney | ya i feel the same about 954460 | |
| 14:22:39 | sean-k-mooney | we can revisit it after rc1 is cut in 8 days | |
| 14:22:47 | sean-k-mooney | so ping us again in like 2 weeks | |
| 14:23:46 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/946733 is ok before RC1 but ill review it properly when i get back to my desk, grabing coffee | |
| 14:27:57 | ratailor | sean-k-mooney, sure. Thanks! I will do. | |
| 14:28:05 | ratailor | sean-k-mooney, should I resolve conflict here https://review.opendev.org/c/openstack/nova/+/957958 with your permission, looks like you backported directly from UI. | |
| 14:47:15 | sean-k-mooney | i did and i just have not had time to update it | |
| 14:47:25 | bauzas | gibi: sorry forgot the eventlet meeting, do we have it ? | |
| 14:47:51 | sean-k-mooney | i fyou want to rebase it properly feel free i was going to wait until i cleared my current backlog of patche befoer redoing it | |
| 14:48:12 | sean-k-mooney | that why i set - workflow on the patch orginally | |
| 14:48:32 | sean-k-mooney | i wanted to wait until after FF/RC was out of the way to finish the backport | |
| 15:00:36 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2025.1: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/957958 | |
| 15:28:33 | zigo | It's obviously failing when building the sphinx doc. Anyways, does anyone have a clue what I could do? (except a painful tempest.cmd folder rename) | |
| 15:28:33 | zigo | https://paste.opendev.org/show/bb1c8yKdZi4J7aKd4KsY/ | |
| 15:28:33 | zigo | I'm having an issue with tempest's packaging: it's having tempest/cmd which conflicts with sytem's cmd.Cmd. Here's the build log: | |
| 15:38:54 | clarkb | is something doing from tempest import cmd? Otherwise they shouldn't conflict right? | |
| 15:40:46 | clarkb | hrm maybe it is part of the sphinx imports situation. Looks like your traceback has a whole import_module() routine that could be "polluting" things | |
| 16:05:42 | sean-k-mooney | so you can have issue like that on ocation if thing do relitive imporat based on your workign dir btu this wi oen of the reason we never use relitive imports in openstack | |
| 16:06:55 | sean-k-mooney | zigo: by the way this is proably more suitbale for #openstack-qa | |
| 16:07:05 | sean-k-mooney | sinc ethis does not seam to be related to nova in nay way | |
| 16:07:15 | sean-k-mooney | zigo: oh | |
| 16:07:21 | gibi | bauzas: yeah we had one, I forgot to ping here. Bottom line we discussed a bit of scale testing, a bit of fixing sync rpc calls like volume attach and a bit of switching defaults in early G from eventlet to threading in the API | |
| 16:07:28 | sean-k-mooney | zigo: why are you doing PYTHONPATH=. | |
| 16:07:41 | sean-k-mooney | your adding the current workign dir into the python path | |
| 16:07:50 | bauzas | gibi: thanks for the summary | |
| 16:07:54 | sean-k-mooney | that could cause import issues like that | |
| 16:08:31 | sean-k-mooney | gibi: ah sorry i ment to join i got nerd sniped by somethign else | |
| 16:09:47 | sean-k-mooney | gibi: by the way i almost never use our fake driver, but if we wanted to test a mroe compelte fake driver eventually we coudl likely enabel the libvirt fixture in it vai a config option or siilar. it still would not actully talk to libvirt but it would be much more complete | |
| 16:10:04 | sean-k-mooney | basiclly run it the way we do in the libvirt fucntional tests | |
| 16:10:35 | sean-k-mooney | i dont think you can do that via config today but it could be intersting to try | |
| 16:11:09 | sean-k-mooney | kolla has or at least had the ablity to deploy multiple copies of the nova and neutorn fake drivers per physical host in the past | |
| 16:11:39 | sean-k-mooney | allowing you to take 3 host and run 10s to 100s of fake hosts | |
| 16:12:22 | sean-k-mooney | i think devstack might eb able to do that too but its been 8 years or so since i actully tried to use any of that | |
| 16:14:16 | gibi | yeah it is a good idea to try to upgrade our fake driver to use the libvirt fixture. I have an item for G to have fake driver based scale testing that can be extended with this | |
| 16:16:25 | sean-k-mooney | https://docs.openstack.org/devstack/latest/guides/nova.html#fake-virt-driver | |
| 16:17:27 | sean-k-mooney | so we do still have the basic supprot but i dotn knwo if this ever worked with ovn adn i suspect there coudl be other issues. | |
| 16:17:41 | sean-k-mooney | just bit rot honstly more then anything fundemental | |
| 16:18:21 | sean-k-mooney | but the ml2 ovsagent can run in a fake mode, the other hack is to just test without networking | |
| 16:20:02 | opendevreview | ribaudr proposed openstack/nova master: Add Flamingo prelude section https://review.opendev.org/c/openstack/nova/+/959188 | |
| 16:22:17 | gmaan | Uggla: you need quick fix here which is caused by rebase, btw updates lgtm now - https://review.opendev.org/c/openstack/nova/+/952894/comment/75fbb034_6c75825e/ | |
| 16:24:44 | Uggla | gmaan, thx I did not noticed it failed. I gonna fix it right now. | |
| 16:48:48 | opendevreview | ribaudr proposed openstack/nova master: Reproducer for bug 2114951 https://review.opendev.org/c/openstack/nova/+/952894 | |
| 16:48:49 | opendevreview | ribaudr proposed openstack/nova master: Fix bug 2114951 https://review.opendev.org/c/openstack/nova/+/952895 | |
| 16:59:23 | opendevreview | Merged openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 17:29:26 | opendevreview | Merged openstack/nova master: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/946733 | |
| 18:38:07 | gmaan | Uggla: thanks +2 on both | |
| 19:55:04 | zigo | sean-k-mooney: It's normal to do PYTHONPATH=., because the package isn't installed in /usr/lib/python3/dist-packages when calling sphinx, that's a way to add the module in the path. | |
| 19:55:14 | zigo | I do that very often in my packages, with no issue. | |
| 19:55:43 | zigo | As for my error here, the weird thing is that it happens it crashes in Unstable, but not in Trixie, so something must have changed. | |
| 19:55:54 | zigo | I'll try to do a pip freeze and compare. | |
| 19:58:28 | clarkb | zigo: why not add the path to the location rather than .? | |
| 19:59:12 | clarkb | then cmd would only be resolvable as tempest.cmd or the stdlib stuff | |
| 20:31:47 | zigo | clarkb: It produces the same result, that's not the issue. | |
| 20:33:14 | clarkb | zigo: I think that means you're a directory level too deep? | |
| 20:33:45 | clarkb | youre in tempest/ so cmd is there and . allows you to import cmd that way. Another approach would be to put it at the end of your path if python resolves the path in order | |
| 20:33:53 | zigo | I'm not. | |
| 20:33:58 | zigo | I'm on top of that folder. | |
| 20:39:07 | clarkb | its possible that the sphinx build changes its cwd maybe? (but I would expect the rooted version instead of '.' to fix that) | |
| 20:40:50 | zigo | Ok, the diff is because of sphinx version. | |
| 20:41:19 | zigo | 8.1.3 in Trixie, vs 8.2.3 in Unstable. | |
| 20:41:58 | zigo | I checked building in Trixie, adding sphinx as --extra-package in the sbuild command line. | |
| 20:42:17 | zigo | And then it fails ... | |
| 20:42:38 | zigo | clarkb: Is there a way I can do such demonstration with a patch in gerrit? | |
| 20:46:03 | zigo | sys.path.insert(0, os.path.abspath('../../tempest')) | |
| 20:46:03 | zigo | In conf.py, there's: | |
| 20:46:26 | zigo | That's a likely guilty thingy ... :P | |
| 20:46:49 | clarkb | it could be just run the tempest doc job with the version of sphinx that you want | |
| 20:47:06 | clarkb | I think you might need to edit requirements upper-constraints and do a depends on for that | |
| 20:47:45 | clarkb | its possible that should be os.path.abspath(os.path.join(__file__, '../../')) | |
| 20:47:55 | clarkb | then you have to refer to things as tempest.cmd not just cmd | |
| 20:49:15 | zigo | BINGO !!! | |
| 20:49:17 | zigo | I was right. | |
| 20:51:25 | zigo | I see no reason why the conf.py does this ... When I remove it, building the doc continues to work. | |
| 20:51:59 | clarkb | the git log might give a hint. But if it works without it then removing it seems like a good option | |
| 20:52:23 | zigo | Yeah, let me git blame. | |
| 20:52:59 | clarkb | If extensions (or modules to document with autodoc) are in another directory, add these directories to sys.path here. If the directory is relative to the documentation root, use os.path.abspath to make it absolute, like shown here. | |
| 20:53:28 | clarkb | thats from the comment in conf.py. So its related to autodoc. It is possible that it is required to make autodoc work and then that breaks sphinx trying to use cmd | |
| 20:55:07 | clarkb | zigo: if you look at the automodule directives they all start with tempest | |
| 20:55:35 | clarkb | so my hunch here is that the path manipulation is unnecessary (because its off by a level anyway) and that the doc build must be relying on tox installing the package before building | |
| 20:55:48 | clarkb | from https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#ensuring-the-code-can-be-imported the code just need to be importable | |
| 20:56:39 | clarkb | if you need to keep it then I think you just need __file__ + '../../' then tempest is in that directory and the automodule directives should find it is importable from there. But also we can stop polluting the nova channel as this is a qa problem | |
| 20:57:34 | zigo | Let's see how it goes: https://review.opendev.org/c/openstack/tempest/+/959390 :) | |
| 20:58:43 | zigo | clarkb: Yeah, wrong chan, appologies. | |
| 21:08:59 | zigo | Comes from here: https://review.opendev.org/c/openstack/tempest/+/735619 | |
| #openstack-nova - 2025-09-04 | |||
| 06:53:46 | opendevreview | Rajesh Tailor proposed openstack/nova stable/2025.1: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/958834 | |
| 08:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2115905 https://review.opendev.org/c/openstack/nova/+/954336 | |