| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-08-21 | |||
| 13:13:00 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957732 | |
| 13:49:02 | zigo | elodilles: https://review.opendev.org/c/openstack/nova/+/958200 https://review.opendev.org/c/openstack/nova/+/958202 | |
| 13:49:14 | zigo | Will you also review backports for Watcher? | |
| 14:22:10 | elodilles | zigo: thanks! sure, i can do review watcher backports as well | |
| 14:22:44 | zigo | Ok, working on it then. | |
| 14:29:54 | zigo | elodilles: I did this one for Antelope: https://review.opendev.org/c/openstack/watcher/+/958207 though there's no unmaintained/zed branch, how can I do it then? | |
| 14:46:16 | opendevreview | Merged openstack/placement master: sqlalchemy: Use built-in declarative https://review.opendev.org/c/openstack/placement/+/953759 | |
| 14:54:59 | elodilles | zigo: thanks for the nova backports, i've found some nits in it, otherwise looks good! see my comments! | |
| 14:55:58 | elodilles | zigo: as watcher is only open for backports till antelope, we cannot test it and post it on zed (and older branches), so antilope is fine there | |
| 14:59:51 | elodilles | zigo: i'll review the watcher patch as well, thanks for that, too! | |
| 15:00:52 | zigo | Fixed according to your suggestions. | |
| 15:15:19 | elodilles | zigo: thanks! though i think you forgot to git push it o:) | |
| 15:17:27 | elodilles | zigo: on the other hand i see that tempest jobs are failing as we use pinned tempest (branchless repository) there, so we probably have to exclude some tests in .zuul.yaml to make the tempest based jobs functional on unmaintained/2023.1 | |
| 15:25:08 | priteau | sean-k-mooney: Hello. Could you please review these backports like you did for 2025.1? Thanks! https://review.opendev.org/c/openstack/nova/+/945098 and https://review.opendev.org/c/openstack/nova/+/945099 | |
| 15:25:21 | priteau | Same request for elodilles :) | |
| 15:27:38 | sean-k-mooney | elodilles: there are exactly 3 that will fail | |
| 15:28:40 | sean-k-mooney | elodilles: so you would need to update the regex or backprot and release a new tempest verion to support the unmainted versions | |
| 15:28:53 | sean-k-mooney | elodilles: i think modifying the regex is proably mroe correct | |
| 15:31:38 | elodilles | priteau: ACK, will review in a minute | |
| 15:32:50 | elodilles | sean-k-mooney: backport on tempest is not possible, so yes, the regex is the way-forward i think (see my comment: https://review.opendev.org/c/openstack/nova/+/958200/2#message-f75c8b173bbd03f257e96a5291b4db82f9b3d4c8 ) | |
| 15:34:16 | sean-k-mooney | the proble is that cinder and other project likely also have those tests runnning | |
| 15:34:27 | sean-k-mooney | so the regex change will impact far more then nova | |
| 15:46:36 | elodilles | sean-k-mooney: oh i see :S then probably we have to set the exclude regex in job definition directly, so that will fix more jobs in multiple repositories, though i guess we won't fix everything in one single place :/ | |
| 16:01:29 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Separate volume, snapshot and volume attachments https://review.opendev.org/c/openstack/nova/+/952347 | |
| 16:01:29 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Address issues with images APIs https://review.opendev.org/c/openstack/nova/+/956102 | |
| 16:01:30 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Only apply "soft" additionalProperties validation to requests https://review.opendev.org/c/openstack/nova/+/952936 | |
| 16:01:30 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Use valid UUIDs for cinder resources https://review.opendev.org/c/openstack/nova/+/952935 | |
| 16:01:31 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for snapshots APIs https://review.opendev.org/c/openstack/nova/+/952349 | |
| 16:01:31 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for volumes APIs https://review.opendev.org/c/openstack/nova/+/952348 | |
| 16:01:32 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for floating IP APIs https://review.opendev.org/c/openstack/nova/+/952972 | |
| 16:01:32 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for volume attachments APIs https://review.opendev.org/c/openstack/nova/+/952350 | |
| 16:01:33 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for security group APIs https://review.opendev.org/c/openstack/nova/+/952973 | |
| 16:01:34 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server usage audit log APIs https://review.opendev.org/c/openstack/nova/+/953209 | |
| 16:01:34 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for services APIs https://review.opendev.org/c/openstack/nova/+/953196 | |
| 16:01:36 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for simple tenant usage APIs https://review.opendev.org/c/openstack/nova/+/956096 | |
| 16:01:36 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for tenant network APIs https://review.opendev.org/c/openstack/nova/+/956088 | |
| 16:01:38 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for quota class sets API https://review.opendev.org/c/openstack/nova/+/956140 | |
| 16:01:38 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for limits API https://review.opendev.org/c/openstack/nova/+/956139 | |
| 16:01:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for migrations API https://review.opendev.org/c/openstack/nova/+/956142 | |
| 16:01:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for quota sets API https://review.opendev.org/c/openstack/nova/+/956141 | |
| 16:01:42 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server tags API https://review.opendev.org/c/openstack/nova/+/956144 | |
| 16:01:42 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server migrations API https://review.opendev.org/c/openstack/nova/+/956143 | |
| 16:01:44 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify servers views (1/3) https://review.opendev.org/c/openstack/nova/+/956231 | |
| 16:01:44 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server metadata APIs https://review.opendev.org/c/openstack/nova/+/956145 | |
| 16:01:46 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify servers views (3/3) https://review.opendev.org/c/openstack/nova/+/956233 | |
| 16:01:46 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify servers views (2/3) https://review.opendev.org/c/openstack/nova/+/956232 | |
| 16:01:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (2/6) https://review.opendev.org/c/openstack/nova/+/956236 | |
| 16:01:48 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (1/6) https://review.opendev.org/c/openstack/nova/+/956234 | |
| 16:01:50 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (4/6) https://review.opendev.org/c/openstack/nova/+/956238 | |
| 16:01:50 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (3/6) https://review.opendev.org/c/openstack/nova/+/956237 | |
| 16:01:52 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (6/6) https://review.opendev.org/c/openstack/nova/+/956240 | |
| 16:01:52 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239 | |
| 16:01:54 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Invert validation check https://review.opendev.org/c/openstack/nova/+/956241 | |
| 16:01:54 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server shares APIs https://review.opendev.org/c/openstack/nova/+/956266 | |
| 16:02:28 | stephenfin | sean-k-mooney: gmaan: I'd appreciate reviews on https://review.opendev.org/c/openstack/nova/+/952347 when you can get to it. That's been the cause of a few rebases now, due to the number of lines it touches (it's just code shuffling but git doesn't know that) | |
| 16:03:21 | stephenfin | and from sean-k-mooney on the one below it (gmaan is already +2 there) | |
| 16:18:31 | gmaan | stephenfin: +2 | |
| 16:18:38 | stephenfin | ty | |
| 16:21:22 | opendevreview | Stephen Finucane proposed openstack/nova stable/2025.1: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957739 | |
| 16:21:54 | opendevreview | Stephen Finucane proposed openstack/nova stable/2024.2: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957744 | |
| 16:22:25 | opendevreview | Stephen Finucane proposed openstack/nova stable/2024.1: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957745 | |
| 16:24:15 | opendevreview | Max proposed openstack/nova master: performance: reduce calls to libvirt / add caching https://review.opendev.org/c/openstack/nova/+/922855 | |
| 17:24:09 | opendevreview | Masahito Muroi proposed openstack/nova master: Add image_response_extra_properties config https://review.opendev.org/c/openstack/nova/+/958230 | |
| 17:30:00 | masahito | hi, nova team. We have already used the image properties fields to see our own custom image properties which not listed in the image meta object. if nova keeps showing the properties, it's super helpful. please review the patch if it's not a wrong direction. | |
| 18:26:38 | melwitt | sean-k-mooney: do you know if host domain capabilities like TPM are ever expected to be available in CI? I tried to create some regular tempest TPM tests and it failed bc there was tpm=no in host domain caps | |
| 18:27:24 | sean-k-mooney | you mean upstream | |
| 18:27:26 | sean-k-mooney | it shoudl work | |
| 18:27:36 | sean-k-mooney | vtpm does not depend on havign a tpm on the host | |
| 18:27:47 | sean-k-mooney | youjust need ot have the swtpm package isntalled | |
| 18:28:19 | sean-k-mooney | and ubuntu 24.04 is new enoguht to meet all our requiremetns | |
| 18:28:26 | sean-k-mooney | melwitt: do you have an exampel failure | |
| 18:28:46 | melwitt | uhm yeah, sec | |
| 18:29:42 | melwitt | sean-k-mooney: this, just trying to run only the nova-live-migration job https://review.opendev.org/c/openstack/nova/+/957477 | |
| 18:29:46 | melwitt | ok I must need some additional setup or such | |
| 18:33:28 | sean-k-mooney | is https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.swtpm_enabled set to true | |
| 18:34:32 | sean-k-mooney | ok it is https://fdc1d05a9a337a8993b4-089607d394060d72ce519e30966a0033.ssl.cf2.rackcdn.com/openstack/4eb4b144eadc47b2848afc0e4ac315c8/controller/logs/etc/nova/nova-cpu_conf.txt | |
| 18:34:34 | melwitt | yes but I don't have the swtpm_user and swtpm_group set, not sure if that matters | |
| 18:34:45 | sean-k-mooney | it shouldnt by default | |
| 18:34:45 | melwitt | I noticed in whitebox it sets those | |
| 18:34:56 | sean-k-mooney | hum is it passign there? | |
| 18:35:06 | sean-k-mooney | the default should work | |
| 18:36:05 | sean-k-mooney | i dont see the swtpm package installed | |
| 18:36:09 | sean-k-mooney | https://fdc1d05a9a337a8993b4-089607d394060d72ce519e30966a0033.ssl.cf2.rackcdn.com/openstack/4eb4b144eadc47b2848afc0e4ac315c8/controller/logs/dpkg-l.txt | |
| 18:36:26 | sean-k-mooney | i wonder if its a suggested or recomemned package | |
| 18:36:37 | melwitt | yeah when you said that earlier I was thinking I need to add something to install it probablah | |
| 18:36:55 | sean-k-mooney | 25-08-16 18:29:02.173 | alsa-ucm-conf alsa-topology-conf libxml2-utils swtpm swtpm-tools mdevctl | |
| 18:37:01 | sean-k-mooney | so it in recommended | |
| 18:37:45 | melwitt | I shall try it. thanks | |
| 18:37:59 | sean-k-mooney | https://paste.opendev.org/show/bcoAzqGjo8UbLR3JWy1i/ | |
| 18:38:35 | melwitt | right next to our friend mdevctl | |
| 18:39:22 | sean-k-mooney | https://github.com/openstack/devstack/blob/master/lib/nova_plugins/functions-libvirt#L72 | |
| 18:39:26 | sean-k-mooney | you can add it there | |
| 18:39:53 | sean-k-mooney | proably with mdevctl while yoru at it for good messure | |
| 18:40:44 | melwitt | cool thanks :) | |
| 18:41:42 | sean-k-mooney | i woudl sepcficly add `swtpm swtpm-tools mdevctl` | |
| 18:42:05 | sean-k-mooney | i think the names are the same for centos too but i woudl just do it for ubuntu for now | |
| 18:42:31 | sean-k-mooney | if you submit a patch feel free to add me and ill take a look on monday | |
| 18:43:04 | sean-k-mooney | https://repology.org/project/swtpm/versions | |
| 18:43:12 | sean-k-mooney | swtpm is the same for waht its worth | |
| 18:43:23 | sean-k-mooney | im just not sure about the tools package | |