| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-08-14 | |||
| 11:40:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 11:40:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 11:45:28 | jssfr | hmm, what would be a good way to check for the libvirt version from within guest.py:Guest? As far as I can tell, the _host object from driver.py:LibvirtDriver is not reachable from there... | |
| 11:45:41 | jssfr | I need to know whether it's new enough to support the VIR_DOMAIN_UNDEFINE_KEEP_TPM flag. | |
| 11:45:49 | jssfr | (in Guest.delete_configuration) | |
| 11:58:52 | jssfr | adding something like `may_preserve_vtpm` to the Guest constructor causes quite a bit of havoc in unittests which create an ad-hoc Guest instance... | |
| 12:01:37 | jssfr | aha | |
| 12:01:51 | jssfr | self._domain.connect(), and I think I can manage from there. | |
| 12:21:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | |
| 12:21:51 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 12:21:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]RPC using threading or eventlet selectively https://review.opendev.org/c/openstack/nova/+/953815 | |
| 12:21:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | |
| 12:21:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 12:21:53 | opendevreview | Balazs Gibizer proposed openstack/nova master: [CI]Make nova-tox-py312-threading voting https://review.opendev.org/c/openstack/nova/+/955791 | |
| 12:21:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 12:21:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 12:21:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 12:21:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 12:21:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: [vncproxy]Handle ssl.wrap_socket removal in py312 https://review.opendev.org/c/openstack/nova/+/955915 | |
| 12:21:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ask for pre-prod testing for native threading https://review.opendev.org/c/openstack/nova/+/957424 | |
| 15:03:49 | dansmith | gibi: not sure if you've already been pinged, but there were a few places in the vTPM series that we were looking for your opinon | |
| 15:03:56 | dansmith | such as: https://review.opendev.org/c/openstack/nova/+/941483/21/nova/compute/api.py | |
| 15:33:50 | melwitt | thanks dansmith, I had forgot to ping him | |
| 16:03:51 | gibi | ohh, I will check | |
| 16:49:35 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Reproduce bug/2116852 https://review.opendev.org/c/openstack/nova/+/957419 | |
| 17:12:02 | sean-k-mooney | jssfr: we do libvirt version check in driver.py mostly | |
| 17:12:34 | sean-k-mooney | so you can do the check in driver.py and call guest.py as appropat rather then doign the check in guest.py | |
| 17:16:21 | sean-k-mooney | jssfr: takign flags as an argumet to delete_configuration may also be a bterr option | |
| 19:23:29 | melwitt | 140 items in the zuul check queue 🤯 that might be a record | |
| 19:39:19 | sean-k-mooney | you say that but im pretty sure tripleo alow triger more then tha tbefore it got put in its own queue | |
| 19:39:34 | sean-k-mooney | but ya htat alot more then typical | |
| 19:40:04 | sean-k-mooney | i feel like they update the ui agian. not that im complaining | |
| 21:28:13 | opendevreview | Merged openstack/os-vif stable/2024.2: Do not add taps in trunk bridges to the dead vlan https://review.opendev.org/c/openstack/os-vif/+/952815 | |
| 23:13:47 | gmaan | yeah, I have seen 3 digit only few times. | |
| #openstack-nova - 2025-08-15 | |||
| 00:25:37 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 02:44:05 | opendevreview | Merged openstack/os-vif stable/2024.2: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/952778 | |
| 04:48:16 | opendevreview | Merged openstack/nova master: Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 06:11:55 | opendevreview | Merged openstack/nova stable/2024.1: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/955305 | |
| 07:22:38 | gibi | melwitt: dansmith: replied in the vtpm series https://review.opendev.org/c/openstack/nova/+/941483/21#message-f8bc46bbe27eeb78f1ec79040932d9e3fa2db062 | |
| 08:01:26 | opendevreview | Merged openstack/nova master: Drop unused method https://review.opendev.org/c/openstack/nova/+/927680 | |
| 08:09:20 | opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | |
| 08:25:42 | Guest23994 | sean-k-mooney can we agree on the rfe for waiting for ovn-controller at live migration? https://bugs.launchpad.net/neutron/+bug/2069718 | |
| 08:26:32 | Guest23994 | The submitted patches are only as POC, of cause some adjustments are needed. But I wanted first to discuss if the approach is fine for you. | |
| 08:43:59 | sthoffmann[m] | Sorry, messed up my nick. | |
| 08:45:23 | opendevreview | Markus Hentsch proposed openstack/nova master: Adapt to Cinder and Glance changes for image encryption https://review.opendev.org/c/openstack/nova/+/926326 | |
| 09:16:20 | opendevreview | Lajos Katona proposed openstack/os-vif stable/2024.1: Do not add taps in trunk bridges to the dead vlan https://review.opendev.org/c/openstack/os-vif/+/957490 | |
| 09:16:21 | opendevreview | Lajos Katona proposed openstack/os-vif stable/2024.1: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/957491 | |
| 09:45:11 | jssfr | sean-k-mooney, melwitt, I updated the vTPM patch. I find the version check implementation a bit clunky, but it's the variant which I found causes least impact in unittesting. A quick feedback on whether that's the right direction or you'd prefer something else would be appreciated: https://review.opendev.org/c/openstack/nova/+/955657/3/nova/virt/libvirt/driver.py#590 | |
| 09:45:23 | jssfr | and https://review.opendev.org/c/openstack/nova/+/955657/3/nova/virt/libvirt/driver.py#1689 | |
| 10:37:07 | sean-k-mooney | jssfr: ya its because we do the version checks for the most part in driver.py rather then in guest.py | |
| 10:37:25 | jssfr | I did that now, too :) | |
| 10:37:39 | jssfr | (see the linked lines, I hope linking to the lines worked) | |
| 10:37:50 | sean-k-mooney | jssfr: but your following the pattern so that fine. as i said i woudl be tempted to take flags instead of keep_vtpm as teh partameter | |
| 10:38:05 | jssfr | ohh | |
| 10:38:14 | jssfr | like the actual flags passed to the undefine command? | |
| 10:38:19 | sean-k-mooney | ya | |
| 10:38:22 | jssfr | hmmm | |
| 10:38:24 | jssfr | I think I like my way better ;) | |
| 10:38:40 | sean-k-mooney | we dont need too but it will be more flexable going forward | |
| 10:38:40 | jssfr | (in particular because there's also some error handling around undefineFlags not being available in that method) | |
| 10:38:57 | jssfr | ack | |
| 10:39:21 | sean-k-mooney | right this way we can keep the guest.py code pretty dumb i.e. just passing through the calls to libvirt | |
| 10:39:38 | sean-k-mooney | and keep the busisness logic for checkign if the flags are supprot external where its used | |
| 10:40:30 | jssfr | do I need to somehow link the launchpad bug in the commit message or something? | |
| 10:41:00 | sean-k-mooney | am that is perfered `Closes-Bug: #<bug number> | |
| 10:41:02 | sean-k-mooney | ` | |
| 10:41:29 | opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | |
| 10:41:31 | jssfr | done | |
| 10:41:32 | sean-k-mooney | if you do it in that formate with teh # gerrit will make it a hyperlink ot the right place | |
| 10:41:44 | jssfr | neat! | |
| 10:43:54 | sean-k-mooney | i have targeted the bug to all the stable branches. if its backported that far you could bring it to unmainteained however you will likely problems with the aviable libvirt version as you go older | |
| 10:44:13 | sean-k-mooney | well it wont break because your doing the check it just wont be functional either | |
| 10:45:33 | sean-k-mooney | i have assigned the bug to you for master and then we can update the others based on who does the backport later | |
| 10:45:53 | jssfr | thanks! | |
| 10:46:20 | jssfr | as I mentioned, we'll likely backport to 2024.1 on our own, so you could assign that to me, too. | |
| 10:52:36 | sean-k-mooney | if you want to do that upstream you just need to cherry pick the same patch to each branch in turn so i have assigne all of them to you for now but you can clear that if you dont end up workign on it | |
| 10:52:47 | sean-k-mooney | we dont really use the assinee filed for much | |
| 10:53:11 | sean-k-mooney | its at most "this person might be working on it" | |
| 10:53:24 | sean-k-mooney | so feel free to udpate it as needed | |
| 11:21:05 | opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | |
| 11:53:38 | opendevreview | Merged openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 13:00:28 | opendevreview | Markus Hentsch proposed openstack/nova master: Adapt to Cinder and Glance changes for image encryption https://review.opendev.org/c/openstack/nova/+/926326 | |
| 13:39:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Force librbd1 19.2.0 to fix ceph job https://review.opendev.org/c/openstack/nova/+/954956 | |
| 13:43:11 | gibi | does anybod have history about why we have address space limitation set for qemu-img info calls in https://github.com/openstack/nova/blob/e39bac965a2d947d32325446ef8427dd5f6c85c7/nova/privsep/qemu.py#L34-L36 ? And why we choose the 1G limit? It seems that with ceph 19.2.1 with luks v1 encrypted volume when that volume is resized the qemu-img info fails as due to the memory 1G limit. If I bump it with | |
| 13:43:17 | gibi | 5MB then the qemu-img info succeeds. Is it a valid solution to bump the limit? Should we not hardoce a limit but make it configurable? | |
| 13:43:28 | gibi | ref https://bugs.launchpad.net/nova/+bug/2116852 and https://bugzilla.redhat.com/show_bug.cgi?id=2388271 | |
| 13:48:14 | dansmith | gibi: I'm sure it's a safety limit and I wouldn't think bumping it for everything would make sense | |
| 13:48:25 | dansmith | you literally bump it to 1.005G and it works? | |
| 13:48:36 | gibi | yepp | |
| 13:49:09 | gibi | I tried to see how close we were the limit in 19.2.0 but I cannot roll back to that version any more locally | |
| 13:49:42 | dansmith | so tools like this have to work pretty hard to not load the entire image into memory so I think it's probably a good idea for us to have that limit | |
| 13:50:15 | gibi | yeah, I affraid that this is a wack a mole just bumping the limit blindly | |
| 13:50:17 | dansmith | and TBH, I'm surprised that it needs to be 1G to run qemu-img info, which probably means a bug that this is catching | |
| 13:50:53 | gibi | the Ceph folks so far was responsive in the bz. So hopefully they can come up with a way to troubleshoot it further | |
| 13:50:58 | dansmith | unless there's a very large extent size on a volume or something, causing us to buffer that large | |
| 13:51:23 | dansmith | I would think making it configurable would be a good idea | |
| 13:51:26 | jssfr | and/or a non-raw format | |
| 13:52:16 | dansmith | jssfr: it's hard but not impossible to support the non-raw formats in constant memory, but that's an easy place for bugs to creep in of course | |
| 13:52:24 | jssfr | yep. | |
| 13:52:31 | dansmith | I was thinking more the LUKS chunk size, since this is encrypted | |