| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-06-12 | |||
| 17:31:43 | JayF | I remember nothing :) | |
| 17:31:47 | JayF | but we can check! | |
| 17:31:50 | TheJulia | I think we get handed an iso9660 file right now | |
| 17:32:02 | sean-k-mooney | oh ok | |
| 17:32:23 | sean-k-mooney | i mean we can always change that if you come up with a design | |
| 17:32:42 | TheJulia | the factory which builds it in the overall virt utils, if memory serves just hands us the file pre-formed | |
| 17:32:53 | sean-k-mooney | i might be conflating this with the auto leasee feature | |
| 17:32:58 | TheJulia | yeah | |
| 17:33:28 | sean-k-mooney | so the reaosn i was quistioning it is we currently store it in memcache | |
| 17:33:35 | sean-k-mooney | if you turn that one | |
| 17:33:47 | sean-k-mooney | so we ahve it in a dict like serisable datascuture | |
| 17:34:10 | TheJulia | Isent there a mechanism on the nova side to do file injection? | |
| 17:34:28 | sean-k-mooney | yes its deprecated and ahs been for about a decaade or so | |
| 17:34:31 | TheJulia | oh, good | |
| 17:34:41 | sean-k-mooney | its called personality files | |
| 17:35:11 | sean-k-mooney | you can also pass a user-data cript for cloud init that is what was ment to repalce arbity file injection | |
| 17:35:21 | TheJulia | okay, as I mentioned, it has been ages | |
| 17:35:28 | TheJulia | in the user-data payload right? | |
| 17:35:59 | sean-k-mooney | ya, either by passing somethign like a valut cred and downloading the afctul data on first boot or inline | |
| 17:36:03 | sean-k-mooney | it depens on the usecase | |
| 17:36:27 | TheJulia | yup, unfortunately I've done stuff like that long ago | |
| 17:37:41 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1108-L1141 | |
| 17:38:58 | TheJulia | Yeah, we don't allow file passing today, but if that is the personality files stuff, maybe since its been deprecated so long it might make sense to drop and refactor? | |
| 17:38:59 | TheJulia | dunno | |
| 17:38:59 | sean-k-mooney | so righ now we create a tempory file generate the config data gzip it, base64 encode and then decode it and pass that ot ironci | |
| 17:39:41 | TheJulia | we only permit a pass-in of meta-data, user-data, and network-data via configdrive api on our provision endpoint | |
| 17:40:03 | TheJulia | I could have sworn that was structured a little differnetly in nova, but thanks! | |
| 17:40:17 | sean-k-mooney | it is | |
| 17:40:24 | sean-k-mooney | this is the ironic customtioation | |
| 17:41:12 | sean-k-mooney | all the other virt drviers share common code. the ironic driver uses the common code but then modifyes it before sending to to the ironci api | |
| 17:41:44 | sean-k-mooney | TheJulia: the ironic driver enriches the network metadta for exmaple https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1045-L1106 | |
| 17:42:36 | sean-k-mooney | the rest use https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L112 | |
| 17:44:22 | sean-k-mooney | so we have an objet in memoy thaat can redner subpaths into json for the metadta api https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L317 | |
| 17:45:00 | sean-k-mooney | or produce the content for the config drive https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L590 | |
| 17:45:06 | TheJulia | Yeah, for portgroups. we can likely just rip that out and address it locally in ironic at some point | |
| 17:46:00 | sean-k-mooney | so it would not take much to jsut add a method to this obejc tthat wil return the data in a singel json dict | |
| 17:46:07 | sean-k-mooney | filepath -> file content | |
| 17:46:16 | TheJulia | yeah, that would be fairly straight forward | |
| 17:46:38 | sean-k-mooney | that acctully what that generator returns already | |
| 17:47:06 | sean-k-mooney | its just a mateter of passing it to ironic in a way that would work better for ye | |
| 17:47:58 | TheJulia | something for some point down the road | |
| 17:50:23 | sean-k-mooney | yep, we can always imrpove things like that if we know about the pain point and someone has time to od the work | |
| 17:51:24 | sean-k-mooney | TheJulia: speaning of improment https://review.opendev.org/c/openstack/nova-specs/+/471815 | |
| 17:51:55 | sean-k-mooney | i need to get back to that but tha tis aimed at making the data we pass more useful for the vlan trunking case | |
| 17:52:28 | sean-k-mooney | although that not nessisarly ironic speicific it shoudl be useful for any dirver the support neutron trunk ports | |
| 17:52:37 | TheJulia | Hmmmm | |
| 17:52:49 | TheJulia | I'll add that to my list to look at when I don't have a migraine | |
| 17:52:55 | TheJulia | Unfortunately, I woke up with one today :( | |
| 17:53:43 | sean-k-mooney | that sucks, i often get eystrain headaches or if i forget to take my blodd pressure medication but i fortunate to never had to deal with migraines | |
| 17:55:23 | sean-k-mooney | that actully is propsoing inlcudign the mtu info for the vlan sub intereface by the way | |
| 17:56:46 | TheJulia | oh good, becuase that would be a logical requirement. | |
| #openstack-nova - 2025-06-13 | |||
| 07:11:21 | opendevreview | Johannes Beisiegel proposed openstack/nova master: Adds packing_host_pci_numa_cells_allocation_strategy option https://review.opendev.org/c/openstack/nova/+/952451 | |
| 08:55:37 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2024.1: Cache [pci]alias parsing https://review.opendev.org/c/openstack/nova/+/952489 | |
| 10:20:32 | opendevreview | Lajos Katona proposed openstack/os-vif stable/2025.1: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/952567 | |
| 10:53:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | |
| 10:53:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | |
| 10:53:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | |
| 10:53:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 10:53:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | |
| 10:53:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | |
| 10:53:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | |
| 10:53:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | |
| 10:54:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | |
| 10:54:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Document threading mode and tuneables https://review.opendev.org/c/openstack/nova/+/949364 | |
| 10:54:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | |
| 10:54:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 10:54:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow services to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | |
| 10:54:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 10:54:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 13:06:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Document threading mode and tuneables https://review.opendev.org/c/openstack/nova/+/949364 | |
| 13:06:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | |
| 13:06:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 13:06:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow services to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | |
| 13:06:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 13:06:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 13:59:35 | sean-k-mooney | gmaan: just an fyi i have seen no movement on https://review.opendev.org/c/openstack/cyborg/+/949772 so it might be time to bring it up on the tc call. i did not see any responce to my email either. | |
| 14:00:44 | sean-k-mooney | gmaan: if we dont see any movement on this by m2 i will put up a patch to nova to move the job to the perodic-weekly pipelien and experimental instead of check | |
| 14:06:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | |
| 14:06:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | |
| 14:06:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | |
| 14:06:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | |
| 14:06:05 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | |
| 14:06:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | |
| 14:06:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | |
| 14:06:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow services to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | |
| 14:06:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Document threading mode and tuneables https://review.opendev.org/c/openstack/nova/+/949364 | |
| 14:06:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 14:06:09 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 14:06:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 14:18:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Document threading mode and tuneables https://review.opendev.org/c/openstack/nova/+/949364 | |
| 14:18:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 14:18:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow services to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | |
| 14:18:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 14:18:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 14:19:18 | gibi | Uggla: I thanks for the reviews on the eventlet series. I think I fixed / answered all your questions and comments now. | |
| 14:19:45 | gibi | I'm still working on some of the executor statistcs improvements we discussed on the sync | |
| 14:21:47 | Uggla | gibi, thanks. I hope it was useful. I'll try to do a new check next week. Regarding the stats ok. Tbh I thought that the outcome was let's start with the current stuffs. We will improve along the way. | |
| 14:22:20 | Uggla | But you may already spot some improvements. | |
| 14:26:01 | gibi | Uggla: yes they were usefull | |
| 14:26:53 | gibi | Uggla: yepp the remaining stats improvements (task waiting time, executor thread sleep time / utiliziation) will be top of the series not inside it. So they are not blocking landing what we have | |