| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-05-14 | |||
| 11:12:24 | Luzi | thank you gibi | |
| 11:13:47 | gibi | tkajinam ^^ | |
| 11:33:43 | stephenfin | sean-k-mooney: gmaan: Could we set aside a day in the next 2-3 weeks to buzz through those openapi patches, while things are _relatively_ quiet? | |
| 11:35:17 | sean-k-mooney | ill try perhaps the 27th ill try to do it before m2 | |
| 11:35:30 | sean-k-mooney | if i find time before then ill do oen or two reviews | |
| 11:36:17 | stephenfin | ack | |
| 12:35:02 | sean-k-mooney | by the way this https://review.opendev.org/q/topic:%22update-precommit%22 is my series to update our use of precommit. it start with just updatign the version to get 3.13 supprot in autopep8 then i have soem refinment to oru exsitng hook and added some new ones. the final patch add bandit to do some security scanning and i reviewd and adress all the medium and high issues | |
| 12:35:04 | sean-k-mooney | found | |
| 12:36:29 | sean-k-mooney | i have tired ot keep each patch fairly small and self contained but some changes are partly down to taste so feedback is welcome | |
| 12:40:20 | gibi | sean-k-mooney: I'm +2 all over it. Thanks | |
| 12:43:36 | opendevreview | Lajos Katona proposed openstack/os-vif master: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/949736 | |
| 13:05:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | |
| 13:05:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | |
| 13:05:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | |
| 13:05:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 13:05:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | |
| 13:05:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | |
| 13:05:21 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | |
| 13:05:21 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | |
| 13:05:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Print ThreadPool statistics https://review.opendev.org/c/openstack/nova/+/948340 | |
| 13:05:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | |
| 13:05:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP: allow service to start with threading https://review.opendev.org/c/openstack/nova/+/948311 | |
| 13:05:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Document threading mode and tuneables https://review.opendev.org/c/openstack/nova/+/949364 | |
| 13:05:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Run nova-next with n-sch in threading mode https://review.opendev.org/c/openstack/nova/+/948450 | |
| 13:38:44 | opendevreview | Lajos Katona proposed openstack/os-vif master: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/949736 | |
| 13:57:47 | opendevreview | Konrad Gube proposed openstack/nova master: Use Cinder's os-extend_volume_completion volume action. https://review.opendev.org/c/openstack/nova/+/873560 | |
| 14:05:33 | opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet.event.Event with threading.Event https://review.opendev.org/c/openstack/nova/+/949754 | |
| 14:26:33 | Uggla | FYI: After yesterday’s bug scrubbing and the work I’ve done on newly reported issues, we’re holding steady at 150 new bugs. This is a good sign, as the number hasn’t increased despite several new reports being filed. | |
| 14:26:41 | Uggla | https://etherpad.opendev.org/p/nova-bug-selection-for-triaging#L4 | |
| 14:26:41 | Uggla | I’ve updated the Nova bug triage etherpad with the next set of bugs to review: | |
| 15:30:41 | gmaan | stephenfin: ack, will try during next week (or friday if get time) | |
| 16:04:51 | sean-k-mooney | gmaan: gibi so https://review.opendev.org/c/openstack/cyborg/+/949772 seams to fix cyborg and since they do not have a grenade job we only need that on master | |
| 16:05:05 | sean-k-mooney | are there any active cyborg cores? | |
| 16:05:54 | fungi | `/msg chanserv access #openstack-nova list` includes your new channel-specific ops now | |
| 16:06:15 | fungi | https://docs.opendev.org/opendev/system-config/latest/irc.html#basic-channel-operator-commands | |
| 16:06:25 | fungi | useful commands documented there ^ | |
| 16:07:04 | fungi | feel free to reach out if you have questions! | |
| 16:07:40 | sean-k-mooney | fungi: was that for Uggla or someone specific | |
| 16:08:34 | fungi | it was for everyone in this channel to be aware that you have channel operators you can reach out to besides our global chanops | |
| 16:09:03 | sean-k-mooney | ack | |
| 16:09:22 | fungi | the new ops were added when https://review.opendev.org/949707 deployed | |
| 16:11:24 | Uggla | thx fungi it was super fast ! | |
| 16:12:59 | fungi | you're welcome. i try not to let trivial changes sit around for long | |
| 16:16:33 | sean-k-mooney | fungi: since your hear do you know what the current status of cyborg is from a governance point of view. interm of the activity of its core team and project status. i belive they had a ptl self nominate but i could be wrong | |
| 16:18:01 | sean-k-mooney | it does not list 2025.2 as apporitned so i belive that means alex was electe this cycle | |
| 16:18:03 | sean-k-mooney | https://github.com/openstack/governance/blob/master/reference/projects.yaml#L177 | |
| 16:18:38 | sean-k-mooney | ok i have added them to the get fix patches if we dont hear from them in a wek or two i guess i can reach out via email | |
| 16:18:58 | gmaan | sean-k-mooney: ++, added Brin also as he also sometime checks but its mostly Wenping who is merging thing there | |
| 16:19:05 | sean-k-mooney | s/get fix/gate fix/ | |
| 16:19:58 | fungi | yeah, i've not heard of cyborg being on the tc's radar for inactivity, though they've not been the most high-bandwidth of projects (ever, as far as i can remember), and some cycles they don't merge anything except job config updates and the like | |
| 16:20:00 | sean-k-mooney | gmaan: thanks. the job is non voting on our side so its not breaking anythin but given tis a simple enouch fix it would be nice to land | |
| 16:20:21 | gmaan | usually I get cyborg change merges on time but yes soemtime I do ping them in email | |
| 16:20:58 | sean-k-mooney | fungi: ya i was asking because some of hte bot patches are still open for things like stable/2025.1 branch creation | |
| 16:21:00 | gmaan | it is not in activity radar from TC but clearly it is like many other projects where there are very few active core | |
| 16:22:11 | gmaan | I will keep eyes on it and bring in TC based on another couple of week monitoring | |
| 16:22:25 | sean-k-mooney | i fixed the api and dropped the jammy jobs. i was hesitent to start fixing more | |
| 16:26:39 | gmaan | true, I also 'usually fix their tempest plugin and keep it up to dated but yes there were lot to fix/update. | |
| 16:38:44 | sean-k-mooney | ok so given i finally pusht that the thing i was ment to do last firiday is now done. time to start on this weeks work... | |
| 16:39:23 | sean-k-mooney | ok that kind of un true but this is the first item i have opened a terminal or code editiro this week | |
| 16:59:40 | opendevreview | Merged openstack/nova master: Disable NOVA_COMPILE_MDEV_SAMPLES to unblock CI https://review.opendev.org/c/openstack/nova/+/949622 | |
| 17:26:23 | opendevreview | Sylvain Bauza proposed openstack/nova master: [doc] Adding vGPUs max_instances caveat fix for virtual-gpu https://review.opendev.org/c/openstack/nova/+/949579 | |
| 17:27:37 | bauzas | sean-k-mooney: gibi: just amended the doc to tell that device_addresses is optional | |
| 17:28:02 | sean-k-mooney | bauzas: cool ill tak a look again quickly | |
| 17:29:47 | sean-k-mooney | bauzas: it looks ok to me. we could word smith it alittle but i dont see a reason to hold it honestly | |
| 17:30:52 | sean-k-mooney | i would much rather add the missing content then stall out on phasing so +2 | |
| #openstack-nova - 2025-05-15 | |||
| 07:40:49 | opendevreview | Merged openstack/nova master: [doc] Adding vGPUs max_instances caveat fix for virtual-gpu https://review.opendev.org/c/openstack/nova/+/949579 | |
| 09:34:40 | opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet.event.Event with threading.Event https://review.opendev.org/c/openstack/nova/+/949754 | |
| 10:01:18 | sean-k-mooney | gibi: would you mind looking at https://review.opendev.org/c/openstack/nova/+/946581/2 also it the update to the repoducer below melwitt migration fix. im going to take a look at the migration fix now | |
| 10:11:43 | opendevreview | Serhii Ivanov proposed openstack/nova-specs master: Proposes 'Add Graceful Nova Compute Shutdown' https://review.opendev.org/c/openstack/nova-specs/+/937185 | |
| 10:14:40 | opendevreview | Serhii Ivanov proposed openstack/nova-specs master: Proposes 'Add Graceful Nova Compute Shutdown' https://review.opendev.org/c/openstack/nova-specs/+/937185 | |
| 10:16:17 | opendevreview | Ivan Anfimov proposed openstack/placement master: wip https://review.opendev.org/c/openstack/placement/+/949864 | |
| 10:17:16 | opendevreview | Ivan Anfimov proposed openstack/placement master: Remove installation guide for openSUSE/SLES https://review.opendev.org/c/openstack/placement/+/949864 | |
| 10:38:03 | opendevreview | Ivan Anfimov proposed openstack/nova master: wip https://review.opendev.org/c/openstack/nova/+/945781 | |
| 11:58:46 | opendevreview | Lajos Katona proposed openstack/os-vif master: VS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/949736 | |
| 12:46:10 | opendevreview | Merged openstack/nova master: Amend functional reproducer for bug 1899835 https://review.opendev.org/c/openstack/nova/+/946581 | |
| 13:50:36 | MengyangZhang[m]1 | Hi folks,... (full message at <https://matrix.org/oftc/media/v1/media/download/AQCeKS0ygNQmR5GAVx8_xminTOY9XUuccxdyP6UnUQrmb3Vz1w1JBUlNsmlKKGyklGrLpna6pA6u3Ut2PN1dGyJCeXHE8e3wAG1hdHJpeC5vcmcvdnJhVFZrZ1hHbERzQWJWVFluSVJ0bE5s>) | |
| 16:43:22 | gibi | stephenfin: sean-k-mooney: melwitt: I think we indeed have a useless lock in https://review.opendev.org/c/openstack/nova/+/949161/comment/e72e2ca3_b8b7f24f/ | |
| 16:44:34 | sean-k-mooney | gibi: so this was there i belvie because of mod_wsig | |
| 16:45:01 | sean-k-mooney | but i guess your right that becasue we reinitalise the lock | |
| 16:45:31 | sean-k-mooney | even if its reloaded it wont guard the we we expect | |
| 16:45:39 | gibi | yeah | |
| 16:45:58 | melwitt | hm | |
| 16:45:58 | sean-k-mooney | we need either only create the lock if it is not None or delete it | |
| 16:46:49 | gibi | I think there is no way to threadsafely check if the variable is None and set it atomically | |
| 16:47:00 | sean-k-mooney | if we really want we coudl proably apply the run once decorator to init_applciation | |
| 16:47:01 | gibi | at least not in this context | |
| 16:47:54 | sean-k-mooney | what we are trying to do is not have 2 thread reintiallse the applction object | |
| 16:48:25 | gibi | we would need to guard the is None check with a lock :) | |
| 16:48:45 | sean-k-mooney | on the other hand nova does nto currently supprot using multiple thread in mod_wsgi any way for other reasons | |
| 16:49:09 | sean-k-mooney | gibi: you normlly fix this with atomics | |
| 16:49:20 | gibi | yeah CAS | |
| 16:49:25 | gibi | which we don't have :) | |
| 16:49:34 | sean-k-mooney | well actully | |
| 16:49:38 | sean-k-mooney | how we fix it in nova | |
| 16:49:45 | sean-k-mooney | is we use the synconise decorator | |
| 16:49:53 | sean-k-mooney | to create a filesystem level lock | |
| 16:51:12 | melwitt | with the guard you would just check None once outside the lock and again inside the lock before proceeding to init, no? | |
| 16:51:52 | sean-k-mooney | you mean double check locking that only works if you declari the loc with static lifetime | |
| 16:52:17 | melwitt | right | |
| 16:52:21 | gibi | the lock needs to exists before any of the two threads enters, otherwise both can create a lock as both can see that the lock variable is none | |