| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-04-30 | |||
| 20:51:31 | EugenMayer440180 | sean-k-mooney thanks! | |
| 20:53:46 | sean-k-mooney | melwitt: oh i see the issue "bindep_profiles=" | |
| 20:54:11 | sean-k-mooney | i was wrgon we dont install the test profile in the devstack job we invoke it with no profile | |
| 20:54:31 | sean-k-mooney | so the fix is just to remvoe test form https://review.opendev.org/c/openstack/nova/+/922140/20/bindep.txt | |
| 20:54:39 | melwitt | sean-k-mooney: I dunno, I looked around for awhile in devstack and codesearch and it looked like it's pretty much just for tox envs like func and unit test jobs | |
| 20:54:59 | sean-k-mooney | right | |
| 20:55:12 | sean-k-mooney | i guess maybe we dont invoke it at all | |
| 20:55:13 | melwitt | sean-k-mooney: oh really? I looked for an invocation in the job output and didn't find it | |
| 20:55:20 | sean-k-mooney | well im not sure | |
| 20:56:40 | sean-k-mooney | melwitt: we do this https://paste.opendev.org/show/bdsCVZoGiydogkQcKlh8/ | |
| 20:56:53 | sean-k-mooney | so im seing 2 things local bindep=0 | |
| 20:57:00 | sean-k-mooney | and local bindep_profiles= | |
| 20:57:34 | melwitt | yeah IIUC that is looking for a "-bindep" option in the install package args and if it's not found it won't invoke | |
| 20:57:35 | sean-k-mooney | so it looks like we install it without enabling bindep or any profile | |
| 20:58:02 | sean-k-mooney | ok so the fix i guess is what your propsoing | |
| 20:58:08 | sean-k-mooney | jsut have the nova devstack plugin install it | |
| 20:58:28 | melwitt | I might be wrong, just wanted to try it out and see what happens | |
| 20:58:30 | sean-k-mooney | oh your doing it with a preplaybook | |
| 20:58:51 | sean-k-mooney | it would be nice to just do it in the devstack plug since its compiling the mtty module too | |
| 20:59:10 | sean-k-mooney | it might as well ensure mdevctl is install that way we can use it locally too | |
| 20:59:11 | melwitt | from what I could tell there is not a clean way to invoke bindep if it's not a tox job and then I thought well I could just run bindep and then I thought if bindep isn't already running then I don't need to install 50 packages just to get one package | |
| 20:59:33 | sean-k-mooney | right we dont need to use bindep | |
| 20:59:54 | sean-k-mooney | we can just do package_install mdevctl here https://github.com/openstack/nova/blob/master/devstack/plugin.sh#L9 | |
| 20:59:59 | melwitt | yeah, that's a good point it would be good to have it for devstack dev | |
| 21:00:42 | sean-k-mooney | oh its install_package not package install | |
| 21:01:22 | sean-k-mooney | but ya "install_package mdevctl" woudl fix it or you could do that in devstack propper | |
| 21:02:03 | sean-k-mooney | here https://github.com/openstack/devstack/blob/master/lib/nova_plugins/hypervisor-libvirt#L90-L125 | |
| 21:02:23 | melwitt | yeah I was looking at that too earlier | |
| 21:02:35 | sean-k-mooney | or here https://github.com/openstack/devstack/blob/master/lib/nova_plugins/functions-libvirt#L58-L106 | |
| 21:02:50 | sean-k-mooney | i honestly dont really have a prefernce | |
| 21:03:05 | sean-k-mooney | other then via devstack in some from | |
| 21:03:18 | sean-k-mooney | the playbook works fine for ci too | |
| 21:03:21 | melwitt | that's what I found first but didn't want to mess with it just to see nova-next run | |
| 21:03:26 | melwitt | me neither. I am not that expert about devstack and all that | |
| 21:04:05 | sean-k-mooney | the reson i sugggested here https://github.com/openstack/nova/blob/master/devstack/plugin.sh#L9 was it will only do it if we compile the mtty supprot | |
| 21:04:14 | sean-k-mooney | so it would only be done in nova-next | |
| 21:04:37 | melwitt | I think that makes sense | |
| 21:04:49 | sean-k-mooney | but ya if it works i guess any of the options are fine | |
| 21:05:16 | sean-k-mooney | on ubuntu its a recommended package but we dont install those by default | |
| 21:05:34 | melwitt | yeah I noticed it in the "recommended packages" in the job output | |
| 21:06:41 | sean-k-mooney | the recommened packages are not insane we could enable those. the suggesetd ones are more porblematic | |
| 21:07:04 | melwitt | welp, my thing didn't work. zuul job already angry 😝 | |
| 21:07:22 | sean-k-mooney | :) it was worth a try | |
| 21:07:47 | sean-k-mooney | oh i see | |
| 21:07:58 | melwitt | "/opt/stack/devstack/local.sh: line 18: install_package: command not found" yay | |
| 21:08:27 | sean-k-mooney | ya that ran at the end but im not sure if its sourced | |
| 21:08:32 | melwitt | I thought devstack functions would be available in there. I dunno | |
| 21:08:41 | sean-k-mooney | if its just run in a subshell it wont have access to devtack functions | |
| 21:09:20 | melwitt | that must be why then I guess | |
| 21:09:43 | sean-k-mooney | its odd because i tought it was actully sourced but i may have imagined that | |
| 21:10:11 | sean-k-mooney | ok ya its not sourced https://github.com/openstack/devstack/blob/master/stack.sh#L1489 | |
| 21:10:40 | melwitt | a-ha | |
| 21:11:43 | sean-k-mooney | if you wanted to be really hacky not that i would encurage that :) local.conf is sourced.... | |
| 21:12:29 | sean-k-mooney | but ya i guess plugin and then maybe squash with sylvian or waith thill they get back | |
| 21:12:38 | melwitt | me do hacks? I would never! | |
| 21:12:43 | melwitt | 😂 | |
| 21:13:32 | melwitt | yeah sylvain can add whatever way he prefers. I didn't want to mess up his patch | |
| 21:14:12 | sean-k-mooney | are you on PTO tomorow? im not sure who is around and who is off | |
| 21:14:27 | melwitt | no I'm not | |
| 21:14:48 | sean-k-mooney | ah ok so may 1st isnt a day off in the US | |
| 21:15:20 | melwitt | oh yeah it's a holiday in france looks like | |
| 21:16:33 | sean-k-mooney | in ireland too kind of we move almost all our public holidays to the ned monday https://publicholidays.ie/ | |
| 21:17:09 | melwitt | oh I see. that's better I think | |
| 21:18:07 | sean-k-mooney | what confusitng is while we normally jsut call it the may bankholidy its somethime called labor day but that differnt in the us | |
| 21:18:12 | sean-k-mooney | so i avoid that name | |
| 21:19:59 | melwitt | may day but not mayday | |
| 21:20:55 | sean-k-mooney | ya so may1st is tradtionaly the 1st day of summer in ireland | |
| 21:23:39 | sean-k-mooney | well ikid of its a whole thing https://en.wikipedia.org/wiki/Irish_calendar the month of summer in teh irish language do not align to those in most english speaking contries | |
| 21:24:34 | opendevreview | melanie witt proposed openstack/nova master: DNM try to install mdevctl https://review.opendev.org/c/openstack/nova/+/948581 | |
| 21:26:09 | melwitt | cool I didn't know that | |
| 21:27:50 | sean-k-mooney | its partly a genererational thing. while its still tought espically in irish speakign schools both calandars are actully used dependign on the context. | |
| 21:28:12 | sean-k-mooney | melwitt: when i was young i was alwasy confused why americans have spring break in summer | |
| 21:29:14 | sean-k-mooney | hum maybe ye dont | |
| 21:29:40 | sean-k-mooney | https://www.voyista.com/blog/when-are-spring-break-dates-colleges-universities ? | |
| 21:29:53 | JayF | Spring Break is usually in April, but it can depend on when Easter lands | |
| 21:29:54 | sean-k-mooney | i tought it was in may for some reason | |
| 21:30:00 | sean-k-mooney | ah ok | |
| 21:30:04 | JayF | early may or late march is likely possible | |
| 21:30:31 | JayF | plus it's not standard; in most places in the US school calendars are set at the district (city/county) level | |
| 21:30:42 | JayF | although in practice they generally fall in close proximity | |
| 21:30:43 | melwitt | I was going to say similar, that they usually put it near easter | |
| 21:30:50 | sean-k-mooney | that must make thing harder to plan for | |
| 21:31:29 | sean-k-mooney | ya its the same here we just call it midterm and it easter adjcent | |
| 21:31:48 | JayF | I mean, really same thing for Summer break | |
| 21:32:09 | JayF | my wife has worked schools that start early August, she has worked schools that start early September (with summer start moving along with the start date) | |
| 21:32:24 | sean-k-mooney | not that the first sunday after the first full moon after the equanox relaly help nail it down | |
| 21:33:20 | melwitt | lol | |
| 21:33:26 | sean-k-mooney | we litrally get the modern Gregorian calendar form cristiantity and then dont even use it for easter... | |
| 21:33:53 | sean-k-mooney | it moves because it tied to the 13 month lunar calandar and you have to translate | |
| 21:34:56 | sean-k-mooney | an this is why you thank the maintianer so time zone lib for there hard work and hope you never have to maintian them | |
| 21:35:42 | sean-k-mooney | that and 15min timezones that have non 1 hour DST adjustments | |
| 21:38:52 | sean-k-mooney | https://youtu.be/-5wpm-gesOY?si=ufuellJXKZcZBjQ7 | |
| 22:05:37 | melwitt | ok so installing it in plugin.sh made it install to the controller only, need to also install on the subnode | |
| 22:06:02 | sean-k-mooney | well that implies the plugin is not runing on the compute | |
| 22:06:15 | sean-k-mooney | we need to compile the module in both places | |
| 22:06:20 | melwitt | yeah | |
| 22:06:26 | sean-k-mooney | so the plugin is probly just not enabled on the subnode | |
| 22:07:44 | sean-k-mooney | ya looking at the job the devstack_plugins section is not defiend on the subnode | |
| 22:08:28 | sean-k-mooney | which is a prexisting bug i guess | |
| 22:08:54 | sean-k-mooney | maybe also the libvirt section libvirt | |