| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-04-30 | |||
| 19:16:30 | sean-k-mooney | most people just use snaphost directly instead of backup | |
| 19:16:40 | sean-k-mooney | because backup has never workd form server booted form cinder volume | |
| 19:16:50 | sean-k-mooney | where as the snapshot command do | |
| 19:17:49 | sean-k-mooney | im not saying this should not be fix im saying its a rearly used api/command | |
| 19:18:13 | EugenMayer440180 | yeah, this would explain that. Can you safely say that both 2025.x releases will not remove nova backup? or is this nothing that can be said | |
| 19:19:30 | sean-k-mooney | more or less yes. i expect it to still be a thing in 2026.1 | |
| 19:20:01 | sean-k-mooney | it might not exist in 2027.1 or 2027.2 if we mange to get everyone over to the sdk | |
| 19:21:04 | EugenMayer440180 | well i will not get to 2026 anyway, so this is not what i would worry then. I plan to migrate away from openstack in Dec 2025 and want to be sure the backup strategy works as long as that. | |
| 19:21:28 | sean-k-mooney | EugenMayer440180: https://paste.opendev.org/show/bZLdha8p7l5juf4jF8Dw/ | |
| 19:21:39 | EugenMayer440180 | Again sean-k-mooney, as all the other times, you helped me so much. I would hand you just another medal for that :) | |
| 19:21:44 | sean-k-mooney | so with a clean vm on master the backup commadn works | |
| 19:21:48 | sean-k-mooney | at least once | |
| 19:22:00 | sean-k-mooney | lets see what happens if i do it again | |
| 19:22:14 | sean-k-mooney | sean@devstack-ui:~$ openstack --os-cloud devstack-admin server backup create --name test --type daily --rotate 5 6a314bdf-66ba-42d5-908a-c13e6f67b214 | |
| 19:22:16 | sean-k-mooney | Could not load 'message_list': module 'zaqarclient.queues.v2.cli' has no attribute 'OldListMessages' | |
| 19:22:18 | sean-k-mooney | Could not load 'message_post': module 'zaqarclient.queues.v2.cli' has no attribute 'OldPostMessages' | |
| 19:22:20 | sean-k-mooney | More than one Image exists with the name 'test'. | |
| 19:22:32 | sean-k-mooney | so ya my guess is we only test creating 1 backup | |
| 19:22:46 | sean-k-mooney | and since that works we didnt notice | |
| 19:23:01 | EugenMayer440180 | for a backup supporting rotation? thats elaborated :) | |
| 19:23:57 | sean-k-mooney | https://paste.opendev.org/show/827657/ | |
| 19:24:07 | sean-k-mooney | so this is a clinet bug | |
| 19:24:15 | sean-k-mooney | nova responce fine and it fails exactly where i said it would | |
| 19:25:13 | sean-k-mooney | sean@devstack-ui:~$ openstack --os-cloud devstack-admin image list | |
| 19:25:15 | sean-k-mooney | Could not load 'message_list': module 'zaqarclient.queues.v2.cli' has no attribute 'OldListMessages' | |
| 19:25:17 | sean-k-mooney | Could not load 'message_post': module 'zaqarclient.queues.v2.cli' has no attribute 'OldPostMessages' | |
| 19:25:19 | sean-k-mooney | +--------------------------------------+--------------------------+--------+ | |
| 19:25:21 | sean-k-mooney | | ID | Name | Status | | |
| 19:25:23 | sean-k-mooney | +--------------------------------------+--------------------------+--------+ | |
| 19:25:25 | sean-k-mooney | | 6a1617c4-7b38-47ce-a197-c24932f1f358 | cirros-0.6.3-x86_64-disk | active | | |
| 19:25:27 | sean-k-mooney | | e7feb98c-9eca-463b-a8d1-54d90b265c76 | test | active | | |
| 19:25:29 | sean-k-mooney | | 7631698f-aac7-4ba0-93fd-c4ac7ccdc46f | test | active | | |
| 19:25:32 | sean-k-mooney | | 19aaf0a5-2978-4a8f-ac69-a812e4805750 | test | active | | |
| 19:25:33 | sean-k-mooney | +--------------------------------------+--------------------------+--------+ | |
| 19:25:40 | sean-k-mooney | its not happy with that as it expecgin thte name to be unique | |
| 19:27:59 | sean-k-mooney | so we can see in the debug output on line 62 https://paste.opendev.org/show/827657/ | |
| 19:28:20 | sean-k-mooney | RESP BODY: {"image_id": "e7feb98c-9eca-463b-a8d1-54d90b265c76"} | |
| 19:28:55 | sean-k-mooney | so the fix should be to save that to var and use it when geting the iamge https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server_backup.py#L94-L102 | |
| 19:31:26 | EugenMayer440180 | good catch | |
| 19:38:45 | sean-k-mooney | EugenMayer440180: so unfortunetly to fix this we need to fix the sdk first | |
| 19:38:47 | sean-k-mooney | https://github.com/openstack/openstacksdk/blob/df1b9e4f8ca877a7caddcbb9afc66de225a8dd21/openstack/compute/v2/server.py#L635-L655 | |
| 19:39:10 | sean-k-mooney | it should return the id like create_image does https://github.com/openstack/openstacksdk/blob/df1b9e4f8ca877a7caddcbb9afc66de225a8dd21/openstack/compute/v2/server.py#L508-L551 | |
| 19:53:38 | opendevreview | melanie witt proposed openstack/nova master: DNM try to install mdevctl https://review.opendev.org/c/openstack/nova/+/948581 | |
| 20:04:26 | opendevreview | melanie witt proposed openstack/nova master: DNM try to install mdevctl https://review.opendev.org/c/openstack/nova/+/948581 | |
| 20:07:16 | sean-k-mooney | EugenMayer440180: i have not witten any test but i have a version working locally | |
| 20:23:35 | sean-k-mooney | EugenMayer440180: https://review.opendev.org/c/openstack/python-openstackclient/+/948586 and https://review.opendev.org/c/openstack/openstacksdk/+/948584 are the fixes | |
| 20:24:18 | sean-k-mooney | EugenMayer440180: but it would be nice if there was a bug report. it will take a while to fully fix it becasue we will need a new sdk relase and test and then the client patch can merge after | |
| 20:25:13 | sean-k-mooney | EugenMayer440180: im not sure if/when ill have time to do that but your welcome to try out the fix | |
| 20:39:51 | opendevreview | melanie witt proposed openstack/nova master: DNM try to install mdevctl https://review.opendev.org/c/openstack/nova/+/948581 | |
| 20:50:28 | sean-k-mooney | melwitt: weried im not sure why bindep didnt work | |
| 20:51:31 | EugenMayer440180 | sean-k-mooney thanks! | |
| 20:53:46 | sean-k-mooney | melwitt: oh i see the issue "bindep_profiles=" | |
| 20:54:11 | sean-k-mooney | i was wrgon we dont install the test profile in the devstack job we invoke it with no profile | |
| 20:54:31 | sean-k-mooney | so the fix is just to remvoe test form https://review.opendev.org/c/openstack/nova/+/922140/20/bindep.txt | |
| 20:54:39 | melwitt | sean-k-mooney: I dunno, I looked around for awhile in devstack and codesearch and it looked like it's pretty much just for tox envs like func and unit test jobs | |
| 20:54:59 | sean-k-mooney | right | |
| 20:55:12 | sean-k-mooney | i guess maybe we dont invoke it at all | |
| 20:55:13 | melwitt | sean-k-mooney: oh really? I looked for an invocation in the job output and didn't find it | |
| 20:55:20 | sean-k-mooney | well im not sure | |
| 20:56:40 | sean-k-mooney | melwitt: we do this https://paste.opendev.org/show/bdsCVZoGiydogkQcKlh8/ | |
| 20:56:53 | sean-k-mooney | so im seing 2 things local bindep=0 | |
| 20:57:00 | sean-k-mooney | and local bindep_profiles= | |
| 20:57:34 | melwitt | yeah IIUC that is looking for a "-bindep" option in the install package args and if it's not found it won't invoke | |
| 20:57:35 | sean-k-mooney | so it looks like we install it without enabling bindep or any profile | |
| 20:58:02 | sean-k-mooney | ok so the fix i guess is what your propsoing | |
| 20:58:08 | sean-k-mooney | jsut have the nova devstack plugin install it | |
| 20:58:28 | melwitt | I might be wrong, just wanted to try it out and see what happens | |
| 20:58:30 | sean-k-mooney | oh your doing it with a preplaybook | |
| 20:58:51 | sean-k-mooney | it would be nice to just do it in the devstack plug since its compiling the mtty module too | |
| 20:59:10 | sean-k-mooney | it might as well ensure mdevctl is install that way we can use it locally too | |
| 20:59:11 | melwitt | from what I could tell there is not a clean way to invoke bindep if it's not a tox job and then I thought well I could just run bindep and then I thought if bindep isn't already running then I don't need to install 50 packages just to get one package | |
| 20:59:33 | sean-k-mooney | right we dont need to use bindep | |
| 20:59:54 | sean-k-mooney | we can just do package_install mdevctl here https://github.com/openstack/nova/blob/master/devstack/plugin.sh#L9 | |
| 20:59:59 | melwitt | yeah, that's a good point it would be good to have it for devstack dev | |
| 21:00:42 | sean-k-mooney | oh its install_package not package install | |
| 21:01:22 | sean-k-mooney | but ya "install_package mdevctl" woudl fix it or you could do that in devstack propper | |
| 21:02:03 | sean-k-mooney | here https://github.com/openstack/devstack/blob/master/lib/nova_plugins/hypervisor-libvirt#L90-L125 | |
| 21:02:23 | melwitt | yeah I was looking at that too earlier | |
| 21:02:35 | sean-k-mooney | or here https://github.com/openstack/devstack/blob/master/lib/nova_plugins/functions-libvirt#L58-L106 | |
| 21:02:50 | sean-k-mooney | i honestly dont really have a prefernce | |
| 21:03:05 | sean-k-mooney | other then via devstack in some from | |
| 21:03:18 | sean-k-mooney | the playbook works fine for ci too | |
| 21:03:21 | melwitt | that's what I found first but didn't want to mess with it just to see nova-next run | |
| 21:03:26 | melwitt | me neither. I am not that expert about devstack and all that | |
| 21:04:05 | sean-k-mooney | the reson i sugggested here https://github.com/openstack/nova/blob/master/devstack/plugin.sh#L9 was it will only do it if we compile the mtty supprot | |
| 21:04:14 | sean-k-mooney | so it would only be done in nova-next | |
| 21:04:37 | melwitt | I think that makes sense | |
| 21:04:49 | sean-k-mooney | but ya if it works i guess any of the options are fine | |
| 21:05:16 | sean-k-mooney | on ubuntu its a recommended package but we dont install those by default | |
| 21:05:34 | melwitt | yeah I noticed it in the "recommended packages" in the job output | |
| 21:06:41 | sean-k-mooney | the recommened packages are not insane we could enable those. the suggesetd ones are more porblematic | |
| 21:07:04 | melwitt | welp, my thing didn't work. zuul job already angry 😝 | |
| 21:07:22 | sean-k-mooney | :) it was worth a try | |
| 21:07:47 | sean-k-mooney | oh i see | |
| 21:07:58 | melwitt | "/opt/stack/devstack/local.sh: line 18: install_package: command not found" yay | |
| 21:08:27 | sean-k-mooney | ya that ran at the end but im not sure if its sourced | |
| 21:08:32 | melwitt | I thought devstack functions would be available in there. I dunno | |
| 21:08:41 | sean-k-mooney | if its just run in a subshell it wont have access to devtack functions | |
| 21:09:20 | melwitt | that must be why then I guess | |
| 21:09:43 | sean-k-mooney | its odd because i tought it was actully sourced but i may have imagined that | |