| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-03-25 | |||
| 15:43:27 | dansmith | okay, isn't that capture_logs flag telling oslo to capture the logs in memory so they can be reported with the test failure? | |
| 15:43:29 | sean-k-mooney | so instead of hardcoding this to true defualt that to 0 or 1 i dont know what makes the most sense and allow you to override it | |
| 15:43:43 | dansmith | I'm not sure why we'd ever want that to be false unless the reporting is wrong | |
| 15:45:27 | sean-k-mooney | i need to read the related code to answer properly but this is the relevnet code https://github.com/openstack/oslotest/blob/1fe445863e124f8a10c1496fb8244c745e546b21/oslotest/log.py#L35-L91 | |
| 15:46:13 | sean-k-mooney | this is why i have not pushed a patch yet im trying to load context and then figurout what the correct behavior should be before commiting and pushing | |
| 15:47:36 | Uggla | nova meeting in aound 15mn. | |
| 15:48:03 | sean-k-mooney | dansmith: by hardcodign it to ture we were alsways addign the fake loonger | |
| 15:48:25 | sean-k-mooney | which make shte logs aviable in the tests | |
| 15:48:37 | dansmith | right, but that's the intent so it gets reported to the test runner so the runner can report the test fail with logs right? | |
| 15:48:39 | sean-k-mooney | btu im not sure if that will attach them to the tests to print on output | |
| 15:48:47 | dansmith | yeah, idk | |
| 15:49:03 | dansmith | so many layers and years of crust, I'm not even sure how it's supposed to work | |
| 15:49:20 | sean-k-mooney | since we know what to flip we can easly expose that bool as an env var in any case | |
| 15:51:43 | sean-k-mooney | dansmith: so its wrapping a logging fixture form fixtures and nuke_handeler is set to true | |
| 15:51:45 | sean-k-mooney | https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/logger.py#L39-L40 | |
| 15:52:03 | sean-k-mooney | which prevent it going to stdout | |
| 15:53:15 | sean-k-mooney | dansmith: i have not trast all the code it possibel we ar attachign the logs as an addtional attachment to the test | |
| 15:53:27 | dansmith | right, but I thought things like testr were doing their own capturing of the logs, as long as they don't get swallowed so they can be reported per-test (in the "logging" section) | |
| 15:53:28 | sean-k-mooney | there is an stester flag to print addtional attachments | |
| 15:53:37 | dansmith | right, unittest does that with addSection() or whatever | |
| 15:53:54 | sean-k-mooney | ya let me see if passing that flag helps | |
| 15:54:52 | sean-k-mooney | oh that just for succesful test "--all-attachments" | |
| 15:55:00 | dansmith | yeah | |
| 15:56:03 | opendevreview | Merged openstack/nova master: Fix case sensitive comparison https://review.opendev.org/c/openstack/nova/+/933107 | |
| 15:57:28 | opendevreview | Merged openstack/nova master: Fix case-sensitivity for metadata keys https://review.opendev.org/c/openstack/nova/+/873901 | |
| 15:57:36 | opendevreview | Merged openstack/nova master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/nova/+/944890 | |
| 16:00:20 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:20 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:20 | opendevmeet | Meeting started Tue Mar 25 16:00:20 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:20 | Uggla | #startmeeting nova | |
| 16:00:42 | Uggla | Hello everyone | |
| 16:01:41 | masahito | o/ | |
| 16:02:02 | elodilles | o/ | |
| 16:02:24 | gibi | o/ | |
| 16:02:35 | Uggla | awaiting a moment for people to join. | |
| 16:02:43 | dansmith | o/ | |
| 16:03:24 | bauzas | \o (in another meeting) | |
| 16:03:45 | Uggla | #topic Bugs (stuck/critical) | |
| 16:03:54 | Uggla | #info No Critical bug | |
| 16:04:02 | Uggla | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:04:34 | Uggla | anything about bugs ? | |
| 16:05:30 | Uggla | #topic Gate status | |
| 16:06:06 | Uggla | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:06:14 | Uggla | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | |
| 16:06:25 | Uggla | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status | |
| 16:06:32 | Uggla | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:06:39 | Uggla | #info Please try to provide meaningful comment when you recheck | |
| 16:06:58 | Uggla | anything about the gate ? | |
| 16:07:46 | Uggla | seems not. | |
| 16:07:57 | Uggla | #topic Release Planning | |
| 16:08:07 | Uggla | #link https://releases.openstack.org/epoxy/schedule.html | |
| 16:08:15 | Uggla | #info Nova deadlines are set in the above schedule | |
| 16:08:21 | Uggla | #link https://etherpad.opendev.org/p/nova-epoxy-rc-potential | |
| 16:08:27 | Uggla | #link https://releases.openstack.org/flamingo/schedule.html | |
| 16:08:52 | Uggla | #info Remaining post RC1: update min servion version for a SLURP or non-SLURP release : https://review.opendev.org/c/openstack/nova/+/944018/ | |
| 16:09:11 | Uggla | #info Nova Flamingo deadlines will be discussed at the PTG. | |
| 16:09:46 | Uggla | We are almost good for Epoxy release. | |
| 16:09:48 | elodilles | note that this week is the week of Final RC for 2025.1 Epoxy :) | |
| 16:10:36 | Uggla | #topic Review priorities | |
| 16:10:44 | Uggla | #info Flamingo priorities will be discussed at the PTG. | |
| 16:10:59 | Uggla | #topic PTG planning | |
| 16:11:06 | Uggla | #info Next PTG will be held on Apr 7-11 | |
| 16:11:11 | Uggla | #link https://etherpad.opendev.org/p/nova-2025.2-ptg | |
| 16:11:45 | Uggla | Please add the topics you want to discuss in the pad. | |
| 16:12:24 | Uggla | #topic Stable Branches | |
| 16:12:30 | Uggla | #info stable gates seem to be healthy | |
| 16:12:41 | Uggla | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:13:03 | Uggla | elodilles, if you want to add something please go ahead. | |
| 16:13:14 | elodilles | yepp, one thing maybe: | |
| 16:13:17 | elodilles | #info stable/2025.1 branch was cut for nova as well last week | |
| 16:13:24 | elodilles | that's all from me | |
| 16:13:36 | elodilles | back to you Uggla | |
| 16:13:53 | Uggla | thanks elodilles | |
| 16:13:58 | elodilles | np | |
| 16:15:22 | Uggla | I skip the vmwareapi 3rd-party CI efforts Highlights as fwiesel is ooo this week. | |
| 16:15:54 | Uggla | #topic Open discussion | |
| 16:16:16 | Uggla | anything to discuss ? | |
| 16:16:47 | keerthivasan86[m] | Just quick question why https://bugs.launchpad.net/nova/+bug/1766387 ( why tx_queue_size is not getting implemented in vhost , any specific reason ) | |
| 16:16:52 | gibi | just to double check | |
| 16:17:14 | gibi | we do not track anything for RC2 | |
| 16:17:17 | sean-k-mooney | keerthivasan86[m]: if i recall corectly its only supproted in vhost-user but not kernel vhost | |
| 16:17:19 | gibi | is it corr4ect? | |
| 16:18:02 | sean-k-mooney | gibi: not that im aware of | |
| 16:19:04 | keerthivasan86[m] | sean-k-mooney: As part of vhost-net able to see rx_queue_size is implemented at vm level as well. It works for vhost-net as well | |
| 16:19:10 | Uggla | gibi, not yet. Do you think about FUP for vfio pci migration ? | |
| 16:19:43 | sean-k-mooney | keerthivasan86[m]: when it was implented there was a specific reaosn why we didnt enabled it | |
| 16:20:12 | gibi | Uggla: it is going to land on master probably today. I'm not advocating for pusing for an RC2 tomorrow just for that single thing. (it is not an Epoxy regression) | |
| 16:20:25 | sean-k-mooney | keerthivasan86[m]: that may haved chnted but the current code was becasue of how qemu/libivrt worked at the time we implemtned https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/libvirt-virtio-set-queue-sizes.html | |
| 16:21:30 | keerthivasan86[m] | sean-k-mooney: if you are ok , can i work on to implement tx_queue_size for vhost-net ? | |
| 16:22:11 | sean-k-mooney | sure but we need to know when it started to be supported, and we need to take accound of upgrades | |
| 16:22:13 | dansmith | the only PCI FUP that should be backported is doc stuff right? | |
| 16:22:19 | dansmith | Uggla: gibi ^ | |
| 16:22:31 | dansmith | the test and cleanliness things should not be backported, IMHO, but definitely not hold up rc2 | |
| 16:22:44 | Uggla | gibi, this is what I have in mind as well. Waiting for GA as this is the only thing. | |
| 16:22:48 | sean-k-mooney | keerthivasan86[m]: so im not sure fi it needs a spec or if a specless blueprint woudl be enough. | |
| 16:23:06 | sean-k-mooney | dansmith: the doc is the one that really should be | |
| 16:23:15 | sean-k-mooney | dansmith: some of the others are nice to have but not required | |
| 16:23:39 | dansmith | backporting test cleanliness doesn't make sense to me unless it's needed for an actual fix | |
| 16:23:57 | gibi | dansmith: for RC2 prespective only https://review.opendev.org/c/openstack/nova/+/944105/5 in interesting | |
| 16:24:04 | sean-k-mooney | right the doc i could see for an RC2 but at this point i woudl just wait and do that after the release | |