| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-03-21 | |||
| 09:52:52 | zigo | Especially considering the oslo.middleware healthcheck was implemented in all other projects. | |
| 11:02:22 | sean-k-mooney | zigo: we dont plan to ever use oslo.middleware for healthchefcs as we have stated in the past given its a security risk | |
| 11:02:34 | sean-k-mooney | and doe snot actully do anything useful for nova | |
| 11:04:59 | sean-k-mooney | specificlly the detailed mode is unsafe https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/__init__.py#L159-L160 | |
| 11:05:48 | sean-k-mooney | zigo: for any of the apis you can and should hit the microverion endpoint instead | |
| 11:06:00 | sean-k-mooney | which si the root of the api | |
| 11:58:28 | zigo | sean-k-mooney: That's a very silly answer. How do you explain that all other projects do have the /healthcheck and that it works for me? | |
| 12:00:35 | opendevreview | Ishan Shanware proposed openstack/nova master: [FEAT]: using quota_details to optimize validate networks https://review.opendev.org/c/openstack/nova/+/945204 | |
| 12:05:31 | opendevreview | Ishan Shanware proposed openstack/nova master: [FEAT]: using quota_details to optimize validate networks https://review.opendev.org/c/openstack/nova/+/945204 | |
| 12:07:48 | ishanwar[m] | sean-k-mooney dansmith I have raised a PR based on our discussion in the previous meeting | |
| 12:08:11 | ishanwar[m] | let me know your thoughts | |
| 12:27:43 | sean-k-mooney | zigo: if it works for you your free to ignore out advice and change ti in your downstream packageing, i dont think any project should ever enable it by default | |
| 13:02:29 | zigo | sean-k-mooney: *ALL* projects enabled it by default... | |
| 13:02:34 | zigo | Only Nova refuses to do so. | |
| 13:44:02 | dansmith | sean-k-mooney: I updated this for some verbiage after your last +2, would you mind re-applying? should be easy: https://review.opendev.org/c/openstack/nova-specs/+/943486 | |
| 13:49:26 | opendevreview | Dan Smith proposed openstack/nova master: Support glance's new location API https://review.opendev.org/c/openstack/nova/+/891036 | |
| 14:02:23 | sean-k-mooney | sorrry was doing somethign else but sure i can look now | |
| 14:03:52 | sean-k-mooney | i did skim v7 the comment gibi had on how you were usign burned we actully my intall reacitno too but then i deciced that since you did not defien the teim i would jsut follow your uasage instead of my internal definition but i generally agreed with that change | |
| 14:04:49 | sean-k-mooney | dansmith: by the way related to the latch term, i starged using bruned because i think of the single use devices like eFueses | |
| 14:05:27 | dansmith | burned is mine! | |
| 14:05:32 | dansmith | but yeah, new rev defines that clearly-er | |
| 14:08:24 | sean-k-mooney | +2w, v8 looks good to me. as an aside are you plannig to move on to the placement swap issue next or complte the integration with the glance api for multiple locations or your change for making glance the enforcer? if the next priortiy is tbd thats fine im just wonderign what you planned ot do next | |
| 14:09:26 | sean-k-mooney | dansmith: im kind of aware thaty you expressed interest in a a few differnet semi high priority issues and it felt like you had a lot on your plate | |
| 14:09:27 | dansmith | sean-k-mooney: so I missed that the locations stuff ever finally landed, and that's partially because I expected the glance people to iterate on my nova patch until it was passing | |
| 14:09:30 | dansmith | but apparently they just merged without it working | |
| 14:09:44 | dansmith | so I just refreshed that and will look at the test results | |
| 14:09:48 | gibi | it is Friday, I'm burned already, needs an external tool applied on me during the weekend to unburn me before I can be used again next week | |
| 14:10:01 | dansmith | gibi: ++ :) | |
| 14:10:04 | sean-k-mooney | lol | |
| 14:10:13 | dansmith | gibi: I'll allow you to use my trademarked term under license :) | |
| 14:10:32 | sean-k-mooney | gibi: can i recommend good food and a audio or phsyical book | |
| 14:10:32 | gibi | understood, send me the necessary invoice | |
| 14:10:40 | dansmith | sean-k-mooney: tbh, I'm pretty steamed about the gpt stuff. I've had that up with cinder, nova, glance changes since last year and I have run out of energy to push people to do simple reviews on it | |
| 14:10:47 | gibi | sean-k-mooney: physical book for sure along with the book :) | |
| 14:10:59 | gibi | sorry along with the food | |
| 14:11:06 | dansmith | sean-k-mooney: so at the moment we're in a reasonable state with image inspection, so I'm not really motivated to push on it at the moment | |
| 14:11:18 | gibi | and sunshine, we are getting proper sunshine here now finally | |
| 14:12:20 | dansmith | sean-k-mooney: the nova side OTU stuff is, I think, ready for some critical review so I'm planning to put up a strawman fix for the placement swap issue in the next week or so so we can argue about all kinds of WWJD lore | |
| 14:12:27 | sean-k-mooney | dansmith: i mean we can chat about it in the ptg or internally but ya it might be better to focus on the things we have control over like placement and see if other can get invovled in teh efforts we dont | |
| 14:12:40 | dansmith | yup | |
| 14:12:49 | opendevreview | Merged openstack/nova-specs master: Add one-time-use-devices spec https://review.opendev.org/c/openstack/nova-specs/+/943486 | |
| 14:13:12 | dansmith | I'm exhausted from pushing people to review, so my hissy fit is to just let it sit.. nobody else will notice, but I'll feel better | |
| 14:13:33 | sean-k-mooney | gibi: same we have had blue skys every morning for the last 2 weeks, cold but clear although they go gray every afternoon | |
| 14:14:39 | gibi | for OTU I'm still planning to a session of local testing with the WIP patch | |
| 14:14:39 | sean-k-mooney | dansmith: speaking of thanks for the constructive review of the mod_wsgi thing. ill try and get the final version ready before i finsh today but no rush to review | |
| 14:14:47 | gibi | *for | |
| 14:15:16 | dansmith | sean-k-mooney: no problem I'm happy with how that has gone for sure and nice to get some quick iterative review | |
| 14:15:21 | sean-k-mooney | if needed i can proably do the same with virual or real hardware | |
| 14:15:27 | dansmith | gibi: cool, thanks | |
| 14:16:47 | sean-k-mooney | dansmith: by the way tehre is one other thing we could consider for the one time ues devices | |
| 14:16:59 | sean-k-mooney | i dont think we should do this | |
| 14:17:16 | sean-k-mooney | bu tlivbirt has an optional deamon that can do device leasing | |
| 14:17:48 | sean-k-mooney | https://libvirt.org/formatdomain.html#device-leases | |
| 14:18:15 | sean-k-mooney | i dont think that helps use because we still need all the placement stuff for schduling | |
| 14:18:23 | dansmith | hmm, but that would encourage people to go direct to libvirt, right? and also, we'd have to sync our state with that in order to .. yeah, scheduling :) | |
| 14:19:03 | sean-k-mooney | right i was going to say the only usecase i see for that is we could take a least and potially never drop it | |
| 14:19:22 | sean-k-mooney | but if we dont refence a lease in our xml i think it ignore it | |
| 14:19:40 | sean-k-mooney | puluse we do not deploy teh relevent deamon in our product downstream | |
| 14:19:49 | sean-k-mooney | so i just wanted to make you aware this exists | |
| 14:19:56 | sean-k-mooney | but i think the soluiton we have is better | |
| 14:20:06 | dansmith | yeah interesting thanks for the pointer | |
| 14:52:30 | sean-k-mooney | dansmith: i kind of know the answer but should i file a new bug for the mod_wsgi thing i have related bug to https://bugs.launchpad.net/nova/+bug/1882094 because it was an incomplete bug fix | |
| 14:52:56 | dansmith | oh that's the previous one huh | |
| 14:53:26 | sean-k-mooney | im trying to see if bogdan filed anything new upstream | |
| 14:54:48 | dansmith | so, it seems like we should have a new bug, yeah, especially if we're going to backport this | |
| 14:54:57 | sean-k-mooney | i was shortening the release note and was going to link the bug an dwas like this is proably not useful to them | |
| 14:55:00 | dansmith | and it seems like it's probably something worth backporting to me (or at least being an option) | |
| 14:55:08 | dansmith | yes, dump that in a bug I'd say | |
| 14:55:20 | sean-k-mooney | ok ill go do that now | |
| 15:05:42 | sean-k-mooney | dansmith: while i have you. do you know if this requires a data migration. https://review.opendev.org/c/openstack/watcher/+/945199/1/watcher/db/sqlalchemy/models.py#250 im debatingin if we need to add a new column, use that going forward and drop the current one after a few release or if this is only a change in the model but not the db schema | |
| 15:06:14 | sean-k-mooney | i need to lookup exactly hwat the numeric datatype in sqlachemy is doing | |
| 15:06:25 | sean-k-mooney | i fyou dont know off the top of yoru head dont worry about it | |
| 15:07:18 | dansmith | hmm, yeah, I'm not sure what scale=3 means there.. is that an order of magnitude that auto-chooses an integer size or something? | |
| 15:07:20 | sean-k-mooney | sorry wrong line i mean 241 | |
| 15:07:32 | sean-k-mooney | its for how many decimal places to keep | |
| 15:07:44 | sean-k-mooney | depending on your db configuriton it can be 0 | |
| 15:08:14 | sean-k-mooney | this would keep 3 decimal places i bleive | |
| 15:09:10 | dansmith | oh okay so it probably doesn't change the size of the float but just how its rendered? | |
| 15:10:12 | sean-k-mooney | we are getting back "0.0 for standard_deviation_before_audit" when we calulated "reduces standard deviation to 0.08665386000750841." | |
| 15:10:40 | sean-k-mooney | so i think its truncating/normalisigin the float when its stored | |
| 15:10:58 | sean-k-mooney | i think 3 would give us a granularity of 0.01 | |
| 15:11:10 | sean-k-mooney | and hopfully round to that | |
| 15:11:16 | dansmith | ack, so that kinda seems like it's in the "view" layer and doesn't change the schema, but I'm definitely talking out of the wrong orifice.. I have no real idea | |
| 15:11:34 | sean-k-mooney | ya no worries | |
| 15:12:07 | sean-k-mooney | i also havent really dug into this much ill look at the doc before going back to the review properly | |
| 15:12:30 | sean-k-mooney | i cant see sqlacammy mapping this ot a custom numic type or a string | |
| 15:12:47 | sean-k-mooney | so i think it must be using a standard float of some lenght underneath | |
| 15:13:13 | sean-k-mooney | i just dont want to do an acidental db data migration as a result | |
| 15:13:27 | dansmith | yeah | |
| 15:13:36 | sean-k-mooney | we should be able to verify that by looking at the schema before and after if we populate some data | |
| 15:14:13 | dansmith | yeah that's probably true | |
| 15:15:06 | dansmith | sean-k-mooney: scale – the numeric scale for use in DDL CREATE TABLE. | |
| 15:15:10 | dansmith | that tells me it changes the schema | |
| 15:15:24 | sean-k-mooney | fun... thanks for looking | |
| 15:15:27 | dansmith | https://docs.sqlalchemy.org/en/20/core/type_basics.html#sqlalchemy.types.Numeric | |
| 15:17:08 | sean-k-mooney | " Numeric returns Python decimal.Decimal objects by default" so scale might influcance how we read back the existing data | |
| 15:17:28 | dansmith | https://dev.mysql.com/doc/refman/8.4/en/precision-math-decimal-characteristics.html | |
| 15:17:29 | sean-k-mooney | im not sure if it will actuly change the data storage in the db | |
| 15:17:42 | dansmith | that shows the number of bytes it uses based on the digits | |
| 15:18:28 | sean-k-mooney | "If D is omitted, the default is 0. If M is omitted, the default is 10." | |