Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-03-19
17:02:42 sean-k-mooney https://review.opendev.org/q/topic:%22per-process-healthchecks%22+status:open
17:10:29 opendevreview sean mooney proposed openstack/nova master: [WIP] raise_forever on wsgi app init https://review.opendev.org/c/openstack/nova/+/945028
17:10:51 sean-k-mooney i just rebased that to master
17:12:05 sean-k-mooney and here is the test patch https://github.com/openstack-k8s-operators/nova-operator/pull/943
17:12:29 sean-k-mooney im going to leave it there for today but i will look at the result tomrrow
17:19:15 opendevreview Mina Shahsavan pour proposed openstack/nova master: Volume Affinity Filter https://review.opendev.org/c/openstack/nova/+/945031
17:26:16 opendevreview Balazs Gibizer proposed openstack/nova master: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/944277
17:53:27 dansmith bauzas: Uggla good to approve stuff for master=flamingo yes?
18:28:43 dansmith aight, stable/2025.1 is present so I'm just gonna do it
19:10:30 sean-k-mooney dansmith: do you have any idea what "reservation id" is for a nova instance
19:12:47 sean-k-mooney hum
19:12:51 sean-k-mooney "The reservation id for the server. This is an id that can be useful in tracking groups of servers created with multiple create, that will all have the same reservation_id. By default, it appears in the response for administrative users only."
19:13:25 sean-k-mooney ok apprently that show up even if you dont use multi create
19:14:18 sean-k-mooney i dont think i have seen that in horizon before but i guess i dont use the admin project most of the time
19:18:14 dansmith sean-k-mooney: that may be a holdover from being able to support the ec2 api
19:18:32 sean-k-mooney it was added in 2.3 but maybe
19:18:41 sean-k-mooney i was wondering if it was somehow blazar related
19:18:47 sean-k-mooney just off the name
19:19:19 dansmith orly okay
19:25:06 opendevreview Merged openstack/nova master: Fix missing backtick in configuration option help https://review.opendev.org/c/openstack/nova/+/931253
19:26:11 opendevreview Merged openstack/nova master: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/941673
22:04:08 opendevreview Merged openstack/nova master: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/944277
#openstack-nova - 2025-03-20
07:48:10 opendevreview Adam Kijak proposed openstack/nova stable/2024.1: Fix race condition when attaching a volume and deleting the instance https://review.opendev.org/c/openstack/nova/+/945067
09:17:05 bauzas dansmith: sean-k-mooney: yeah the reservation id is some older field related to ec2 API, nothing related to blazar
09:17:37 bauzas it was existing *before* climate :) (ie. blazar older name)
10:09:59 bauzas gmann: dansmith: when you're up, as a reminder, there is some work to be done on grenade as we can't merge https://review.opendev.org/c/openstack/nova/+/944018 yet for our non-SLURP support enveloppe
10:27:34 sean-k-mooney bauzas: ack, i use horizon im just rarely logged in as admin so i was like what is this feild i never see
10:29:26 bauzas more than a decade ago when we incepted climate, we were wondering the interest of that field and whether it could be useful
10:29:38 bauzas eventually, we said meh
10:30:26 bauzas but afaik, you get the same reservation id for multicreate, that's one way for you to match the relationship (particularly given the request_id isn't public)
10:31:02 bauzas that has to be confirmed, I'm a bit unsure of that
10:37:26 sean-k-mooney ya apprently its just a way to corralate instance create by multi create (and happens to be set on all instnaces probly because of common code path) im not really sure why that useful
10:37:48 sean-k-mooney it would be more useful if we recored the orginal request id but ti probably predates that?
10:38:23 sean-k-mooney at least with the resquest id we could easilly corralate the request to logs if they still existed and it would work across all services
10:39:07 sean-k-mooney bauzas: the resuqest id is set in the header of the request by the user so it is public
10:39:18 sean-k-mooney bauzas: we generate one if its not present using middelware
10:39:54 sean-k-mooney but you as a normal user are free to set it, you just dont have access to the logs to make use of it. the only api that takes it as an input it the instance action log
10:44:08 sean-k-mooney dansmith: by the way my ci run with the invokeation fo kill took the sys.exit path... so either the mod_wsgi docs are wrong about the constant i need to check or it does not work for some other reason
10:44:53 sean-k-mooney dansmith: on the pluse side the raise_forever version worked as expected and cause the k8s pods to fail the ready check and that got reported back up into the CRs
10:45:32 sean-k-mooney so im going to rework https://review.opendev.org/c/openstack/nova/+/945028 with a workaorund config flag to opt into that behavior if you have external monitoring that will detect the error
10:47:54 sean-k-mooney bauzas: by the way i think we have our own variant of teh grenade multi node job
10:48:18 sean-k-mooney bauzas: so if we wanted we could overried the base branch temporally until it get changed for everything else
10:48:48 sean-k-mooney we jsut need to export the wirte varible in the job def
10:49:11 sean-k-mooney or wait like 2 weeks until it gets fixed in greneade either is fine
12:17:37 opendevreview Mina Shahsavan pour proposed openstack/nova master: Volume Affinity Filter https://review.opendev.org/c/openstack/nova/+/945031
12:57:49 opendevreview Balazs Gibizer proposed openstack/nova stable/2025.1: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/945095
12:57:50 opendevreview Balazs Gibizer proposed openstack/nova stable/2025.1: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945096
12:59:13 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.2: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/945098
12:59:14 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.2: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945099
12:59:55 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.1: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/945100
12:59:56 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.1: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945101
13:01:26 opendevreview Balazs Gibizer proposed openstack/nova stable/2023.2: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/945102
13:01:27 opendevreview Balazs Gibizer proposed openstack/nova stable/2023.2: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945103
13:32:22 sean-k-mooney feck it anyway, of cores i cant use a workaround config flag to decied how to handel invalid config errors
13:32:47 sean-k-mooney s/cores/course/
13:33:45 sean-k-mooney i wrote some nice help text and everything, oh well i guess i can use some of that for the release note
13:38:14 dansmith sean-k-mooney: cool
14:03:03 opendevreview sean mooney proposed openstack/nova master: raise_forever on wsgi app init https://review.opendev.org/c/openstack/nova/+/945028
14:10:13 sean-k-mooney dansmith: ^ i think is in a pretty good state ill kick off one more recheck via the operator repo to to get fresh result with mod_wsgi but it should be good to review
14:10:20 dansmith I've got it open
17:21:30 gmann bauzas: yes, today I got go ahead from release team about all repo are branched now and I will start the QA tooling (including grenade) setup for old/new releases
17:33:11 bauzas gmann: cool excellent
17:57:21 zigo sean-k-mooney: Hey there! Do you happen to know how far we've been from having the virtiofs driver in Manila? Is it in Epoxy, or should we wait another release ?!?
17:59:01 opendevreview sean mooney proposed openstack/nova master: wrap wsgi_app.init_application with latch_error_on_raise https://review.opendev.org/c/openstack/nova/+/945028
17:59:03 sean-k-mooney zigo: its in
17:59:12 zigo Oh !!! :)
17:59:17 sean-k-mooney zigo: the osc patches for it missed however
17:59:41 zigo sean-k-mooney: Is there anything I should do to support it at the packaging level ?
17:59:51 zigo Or "it just works" (tm) ?
17:59:58 sean-k-mooney so the osc command to attach/detach the share were not merged on time as they are waiting for the sdk patch for the new nova api to land
18:00:46 sean-k-mooney zigo: i dont think it changes any deps or requries packaging work beyond making sure you have the right version of openstacksdk ectra
18:00:50 zigo sean-k-mooney: At this point, I probably will try to get Epoxy in Debian 13, so if there's a (small) series of patches to add, it's probably worth it !
18:01:24 zigo Maybe I should ask in the -discuss list about this topic?
18:01:32 sean-k-mooney they are proposed we proablly will see if we can do a release early in 2025.2 to get the client out there
18:02:14 zigo I'd love it if they were backported to Epoxy officially.
18:02:56 sean-k-mooney https://review.opendev.org/c/openstack/python-openstackclient/+/881540 and https://review.opendev.org/c/openstack/openstacksdk/+/880056 are the pending patches
18:03:32 sean-k-mooney they need a little more work to get over the line hopefully Uggla will have time to work on them again soon
18:04:58 sean-k-mooney zigo: but sure start a mail thread if you want we know completing hte client side fo the various api we added this cycle is a priority
18:05:34 sean-k-mooney we have a couple of gaps for spice-direct, manilla-shared, image properties in server show and server groups in server show
18:05:55 sean-k-mooney all i think have pathces up but we need to work with the clinet fould to get them in shape and landed
19:06:28 mikal zigo: yeah, it would be good to know if Debian 13 had any discussions around dropping SPICE support too. Debian is currently the recommended host OS for hypervisors with spice-direct.
#openstack-nova - 2025-03-21
00:57:50 opendevreview benlei proposed openstack/nova master: optimize process of get connector for swap volume https://review.opendev.org/c/openstack/nova/+/945177
00:57:50 opendevreview benlei proposed openstack/nova master: Abort live migration task when stop nova compute service https://review.opendev.org/c/openstack/nova/+/938223
06:22:11 ishanwar[m] Hi Folks... (full message at <https://matrix.org/oftc/media/v1/media/download/AfIljfPE94kqyEbidICMKCnOaBBquL9y8M186dozy6czq9FKuNXkU37cf0hQWWGf7ByL_Gxne4_JEcywIr82jMNCeV_3bP0QAG1hdHJpeC5vcmcvc2NSRlZCQUlsclpPc2lZWUZuZE9Ramdt>)
06:22:30 ishanwar[m] Can anyone explain how I can find the correct constant
06:22:35 ishanwar[m] * correct constant ?
08:38:57 opendevreview benlei proposed openstack/nova master: FIX: optimize process of get connector for swap volume https://review.opendev.org/c/openstack/nova/+/945177
09:38:04 zigo It's been now 5 years that I opened a merge request for the Nova project to add a /healthcheck from oslo.middleware in the default api-paste.ini. Is this enough time so that the team delcares a "game over" from the team that wanted to improve the oslo.middleware healthcheck before merging ?
09:48:33 frickler zigo: it might help if you include a link to your review (we don't talk about merge requests with gerrit). and yes, without interacting with the community regularly, getting things done is sometimes difficult
09:48:43 zigo https://review.opendev.org/c/openstack/nova/+/724684
09:49:24 gibi zigo: I think the nova team wants to do https://specs.openstack.org/openstack/nova-specs/specs/2025.1/approved/per-process-healthchecks.html
09:50:07 zigo That's a good thing, though I still need to patch Nova to be able to hook an haproxy to its API, that's kind of annoying.
09:52:52 zigo Especially considering the oslo.middleware healthcheck was implemented in all other projects.
11:02:22 sean-k-mooney zigo: we dont plan to ever use oslo.middleware for healthchefcs as we have stated in the past given its a security risk
11:02:34 sean-k-mooney and doe snot actully do anything useful for nova
11:04:59 sean-k-mooney specificlly the detailed mode is unsafe https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/__init__.py#L159-L160
11:05:48 sean-k-mooney zigo: for any of the apis you can and should hit the microverion endpoint instead
11:06:00 sean-k-mooney which si the root of the api
11:58:28 zigo sean-k-mooney: That's a very silly answer. How do you explain that all other projects do have the /healthcheck and that it works for me?
12:00:35 opendevreview Ishan Shanware proposed openstack/nova master: [FEAT]: using quota_details to optimize validate networks https://review.opendev.org/c/openstack/nova/+/945204

Earlier   Later