| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-03-14 | |||
| 14:15:37 | sean-k-mooney | consume is what we run on the compute | |
| 14:15:58 | gibi | yepp | |
| 14:16:01 | sean-k-mooney | its actully operating not just on the ppoos but the pci_device records and selecting the device | |
| 14:16:52 | dansmith | gibi: another thing that seems messy is that we take a thing, which is a dict'ing of an object, and pop out things that we ignore, and then see if "everything else is the same" right? | |
| 14:17:32 | dansmith | seems like we should opt-in to the things that distinguish them so that new things that get added in later don't cause fracturing of the pools if you don't also update the exclusion list | |
| 14:17:36 | dansmith | (or just do this differently) | |
| 14:18:26 | sean-k-mooney | that would be more maintianable wehn this was first writtin jay was pretty again adding new tag in the future | |
| 14:18:33 | sean-k-mooney | since then we have added several | |
| 14:18:47 | sean-k-mooney | btu never really revisited that orgianl approch | |
| 14:19:48 | gibi | dansmith: I think the concept is that a pool is a set of devs with a set of common field values. So it is the defintion of the interesting fields is the question here | |
| 14:20:10 | sean-k-mooney | gibi: yep | |
| 14:20:26 | gibi | and yes I share you feeling that ignoring flags is less maintainable than listing interesting flags | |
| 14:20:54 | dansmith | right | |
| 14:21:02 | gibi | I'm not motivated to change this logic in a bugfix though. I can queue up a refactor after it. | |
| 14:21:04 | sean-k-mooney | and this is what i mean when i say tis placement like a pool is effectivly an rp with and inventory fo common "fungable" dvices | |
| 14:22:06 | gibi | I would even wrap these dev and pool dicts in proper objects in memory (not ovos) for more readability (and mypy) | |
| 14:23:20 | gibi | I'm bit affraid of what can of worms this opens up | |
| 14:24:12 | gibi | and I have the ovo version bump preemptive unit test and refactor series to get back to as well | |
| 14:24:24 | gibi | I need more time for actually writing code | |
| 14:24:27 | dansmith | gibi: no I'm not suggesting you fix it in this bugfix or even later, I'm just lamenting the design | |
| 14:24:35 | gibi | dansmith: OK | |
| 14:25:10 | dansmith | _especially_ if it means more mypy in this code :) | |
| 14:26:03 | gibi | sh*t I have this from the PCI in Placement work remaining as well https://review.opendev.org/q/topic:%22bp/pci-device-spec-cleanup%22 (danger, it contain mypy changes as well) | |
| 14:26:39 | dansmith | going on three years old there... | |
| 14:26:52 | gibi | yeah it is sad | |
| 14:27:21 | sean-k-mooney | ya... | |
| 14:27:46 | sean-k-mooney | this https://review.opendev.org/c/openstack/nova/+/844491 i think was one fo the more valuable changes | |
| 14:28:28 | sean-k-mooney | although the seise of a whole impoved alot of things | |
| 14:30:48 | gibi | maybe in Flamingo :) | |
| 14:31:02 | gibi | less golang more python :) | |
| 14:33:39 | sean-k-mooney | :) | |
| 14:33:46 | gibi | I don't know what is the relationship of flamingos a pythons, who would eat who | |
| 14:34:24 | dansmith | pythons would eat flamingos no doubt | |
| 14:35:31 | gibi | cool then. (we have neither this side of the globe) | |
| 14:36:01 | gibi | and gopher (the golang mascot) would definitely loose againts python | |
| 16:03:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/941673 | |
| 16:03:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/944277 | |
| 16:09:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/944277 | |
| 17:12:54 | sean-k-mooney | werid i just got a destop notificaiton form a comment gibi made a few hours ago | |
| 17:13:28 | sean-k-mooney | dansmith: not that im disagreeign but dont we test migration with postgres in the tox jobs | |
| 17:13:41 | sean-k-mooney | i would not try and use it in production | |
| 17:14:01 | sean-k-mooney | but we do install it with bindep in the tox env | |
| 17:14:25 | sean-k-mooney | and the opertunistic database stuff should kick in but maybe that broke at some point | |
| 17:14:51 | sean-k-mooney | we defintlly dont have stong testin gthere as we only really apply the migration ot an empty db | |
| 17:18:37 | sean-k-mooney | ya nova.tests.unit.db.main.test_migrations.TestMigrationsWalkPostgreSQL.test_walk_versions is still running in tox | |
| 17:20:28 | dansmith | (back in a sec) | |
| 17:21:05 | sean-k-mooney | dansmith: its not urgent dont worry. teh prostgress test are still runing but obviously those migration tests dont test that much | |
| 17:21:35 | sean-k-mooney | pointing to https://governance.openstack.org/tc/resolutions/20170613-postgresql-status.html is still the best responce | |
| 17:23:10 | sean-k-mooney | i was just concerned that those opertuneistic tests broke at some point and we missed it but the pg and mysqlone are running in addtion to sqlite | |
| 17:26:37 | dansmith | sean-k-mooney: we do, but not full of real world data | |
| 17:27:05 | dansmith | so maybe I was less than accurate about 'we don't test it' but testing with an empty DB is not really testing IMHO | |
| 17:27:14 | dansmith | it makes sure all the schema SQL is right, but not much else | |
| 17:27:40 | sean-k-mooney | ya so i know we incorrectly set the coration type on at least one of the tables when movign to alembic | |
| 17:27:56 | sean-k-mooney | so that might cuase some issues only when there is data | |
| 17:28:07 | sean-k-mooney | or on some locales but not our default | |
| 17:28:40 | sean-k-mooney | i think neutron had a postgress job up until about a year ago | |
| 17:30:53 | dansmith | IMHO people that want to run postgres are more than welcome to test and fix the things | |
| 17:31:27 | sean-k-mooney | ya i dont think its unreasonable | |
| 17:32:05 | sean-k-mooney | i just know that it broke for them at some poitn and no one stepped up to fix it so they droped testing | |
| 17:32:47 | sean-k-mooney | oh wow | |
| 17:32:58 | sean-k-mooney | they actully dropped postgress code https://github.com/openstack/neutron/commit/16e4f0af89cc67b7a8901bfd357fd49b86de73c8 | |
| 17:33:28 | sean-k-mooney | i pointed out to stephen that we techinially still supprot it | |
| 17:33:45 | sean-k-mooney | we just dont test it | |
| 18:09:01 | sean-k-mooney | dansmith: im reluctantly +2 but +2 none the same on the one time use device spec | |
| 18:09:44 | dansmith | I will take a reluctant +2 over the alternative thanks :) | |
| 18:09:49 | sean-k-mooney | i lost that tab like 4 times today.... | |
| 18:11:03 | sean-k-mooney | dansmith: by the way you mentioned a crash when you used the qxl device to test this, you might have better luck with somethign like the random number generator or a virtio-blk device | |
| 18:11:32 | sean-k-mooney | or igb vfs if your qemu supports it | |
| 18:12:22 | sean-k-mooney | i have had better look with nic/block devices when palying with double passthough then graphics cards | |
| 18:12:33 | sean-k-mooney | not sure why but just my personal experince | |
| 18:14:17 | dansmith | yeah, no igb on this box's qemu but yeah I need to use a different device | |
| 18:14:34 | dansmith | honestly it reboots in seconds and I always need to restart nova services after each fail, so it hasn't been so bad :P | |
| 18:15:36 | sean-k-mooney | if you try e1000 instead i think that will work | |
| 18:15:57 | sean-k-mooney | it diefenly works with a doubel passthough of a phsyical e1000 nic but i think the virutal ones work too | |
| 19:13:04 | opendevreview | Dan Smith proposed openstack/nova master: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/944277 | |
| #openstack-nova - 2025-03-16 | |||
| 02:23:46 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2025.2 Flamingo https://review.opendev.org/c/openstack/nova/+/944603 | |
| 13:36:37 | opendevreview | Takashi Kajinami proposed openstack/nova master: Fix description of [pci] alias https://review.opendev.org/c/openstack/nova/+/944611 | |
| 14:32:39 | IshanShanware[m] | sean-k-mooney:... (full message at <https://matrix.org/oftc/media/v1/media/download/AV6erZTaSkUc-1ptdYd_qKTJvrKZM-gcFd4g_bJVy6rXGULoskvXyHay2wXi9H0HKT8DjkWIuL9S_YoRXhpohZBCeV53gI0wAG1hdHJpeC5vcmcveVpPZUhSanJ3eFhCck52TXBrSVJFZklq>) | |
| 19:16:55 | Callum027 | sean-k-mooney: Looking at the agenda for the next meeting, kinda looks like it's still focusing on the current release and not planning for 2025.2. Should I add the image meta changes to the agenda for next week, or is this week fine? | |
| #openstack-nova - 2025-03-17 | |||
| 07:08:29 | r-taketn | hi. I have two entries for next PTG(About CCA, RDT/MPAM). Besides purchasing a ticket and submitting spec, what else should I prepare for the PTG? | |
| 08:03:56 | frickler | Uggla: could you have a quick look at https://review.opendev.org/c/openstack/releases/+/943801 pls? | |
| 09:19:58 | IshanShanware[m] | * sean-k-mooney:... (full message at <https://matrix.org/oftc/media/v1/media/download/Af0thDY-PzrHZLStDMYwU6GFaZIiMSA41JuprrmuPgJq6AY3dEeP8-2cHH70wc9rwy3S6QmtPw_bSYPSO95YLsdCeV64AjOgAG1hdHJpeC5vcmcvVUNuTVBJVllKcFlkQmR5bnhsc0V2Qllv>) | |
| 09:36:12 | frickler | Uggla: bauzas: also what's the status with rc1 for nova+placement? we're past the deadline now | |
| 09:36:43 | bauzas | frickler: as said in the nova rc1 patch, we're missing some patches before tagging | |
| 09:37:09 | bauzas | everything is tracked here https://etherpad.opendev.org/p/nova-epoxy-rc-potential | |
| 09:37:40 | bauzas | placement rc1 can be tagged tho, just double-checking the last dependencies | |
| 09:43:50 | frickler | bauzas: unless I miss something, the only remaining nova change is https://review.opendev.org/c/openstack/nova/+/943952 which is a pretty trivial but necessary change that keeps failing due to unrelated CI instability. let me know once you're ready to get this force-merged to unblock things :-) | |
| 09:44:29 | bauzas_ | frickler: not exactly, we're also missing a prelude patch that needs to be written as copy of the cycle highlights | |
| 09:45:02 | bauzas_ | that's a TODO on me this morning since we start to have a review quorum from the nova cores about the highlights | |
| 10:19:47 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add Epoxy prelude section https://review.opendev.org/c/openstack/nova/+/944713 | |
| 11:29:10 | IshanShanware[m] | <IshanShanware[m]> "sean-k-mooney:..." <- bauzas: any thoughts here ? | |
| 12:14:46 | opendevreview | ribaudr proposed openstack/nova master: FUP Remove unnecessary PCI check https://review.opendev.org/c/openstack/nova/+/944105 | |
| 12:14:46 | opendevreview | ribaudr proposed openstack/nova master: FUP improve comment accuracy and variable naming for tag removal https://review.opendev.org/c/openstack/nova/+/943124 | |
| 12:14:47 | opendevreview | ribaudr proposed openstack/nova master: FUP Add a warning to make non-explicit live migration request debugging easier https://review.opendev.org/c/openstack/nova/+/944133 | |
| 12:14:47 | opendevreview | ribaudr proposed openstack/nova master: FUP improve and add integration tests for PCI SR-IOV servers https://review.opendev.org/c/openstack/nova/+/944106 | |
| 12:14:48 | opendevreview | ribaudr proposed openstack/nova master: FUP Update pci-passthrough and virtual-gpu documentation https://review.opendev.org/c/openstack/nova/+/944153 | |
| 13:45:54 | bauzas | cores, can we please give this a go ? https://review.opendev.org/c/openstack/nova/+/944713 | |
| 13:47:16 | dansmith | bauzas: I did three minutes ago | |
| 13:47:26 | bauzas | cool | |
| 13:49:28 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add Epoxy prelude section https://review.opendev.org/c/openstack/nova/+/944713 | |