Earlier  
Posted Nick Remark
#openstack-nova - 2025-03-10
15:33:02 sean-k-mooney im happy to disucss that at some point just also dont have the brain power to context switch to this in detail right now
15:33:03 gibi lets add more metadata :)
15:33:16 dansmith memory has no address or serial number, but a pci device does, a disk might
15:33:32 sean-k-mooney memory kind of does
15:33:43 dansmith gibi: it would only be good if we can drop something else in favor, of course :)
15:33:54 sean-k-mooney its at least got a numa node
15:34:08 sean-k-mooney it might not be a unique idetifier across all host
15:34:18 sean-k-mooney but there are ways to talk about fungible pools of it
15:34:23 dansmith sean-k-mooney: if the numa node is a nested provider, then the allocation within has no (further) addressing
15:34:27 dansmith right
15:34:58 dansmith anyway, we're way off in the weeds, didn't mean to start digging a hole
15:35:36 sean-k-mooney https://collection.nam.ac.uk/images/960/204000-204999/204324.jpg
15:36:06 dansmith heh yeah
15:36:11 sean-k-mooney thats not actuly the meme i was loogkign for but it will do
15:36:33 gibi :)
15:50:49 bauzas folks I just saw your discussion, will review again dansmith's spec tomorrow
16:52:15 opendevreview Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658
16:54:37 masahito sean-k-mooney: gibi: please review this api bug fix again https://review.opendev.org/c/openstack/nova/+/939658 thank you.
18:25:05 gmann sean-k-mooney: do you remember the some missing package for pcre.h in bindep.txt for doc job running on noble. this one https://review.opendev.org/c/openstack/nova/+/935577
18:25:20 sean-k-mooney yes
18:25:30 sean-k-mooney didnt htat go away?
18:25:43 sean-k-mooney or is that still a thing
18:25:45 gmann sean-k-mooney: no, I tired some but still error
18:26:07 sean-k-mooney what job was failing
18:26:12 gmann libpcre3-dev should include it but that is already in bindep file
18:26:21 sean-k-mooney docs and apiref it seams
18:26:37 sean-k-mooney i thinki have noble somewhere
18:26:39 gmann openstack-tox-docs this one https://zuul.opendev.org/t/openstack/build/a1a1fbda6cf24246a3ed9912c5e952b3
18:26:42 gmann yeah
18:27:27 gmann I am not able to produce it locally I think I installed some extra package there
18:28:11 sean-k-mooney if you install devstack on the know it fixes the porblem if i recall
18:29:03 sean-k-mooney im runnign the docs target localy now
18:29:09 sean-k-mooney ill check where that header came form after
18:31:14 sean-k-mooney gmann: oh you kno what it might be that if you have to build the wheel form source it fails but if you can get it form the wheel cache ti works
18:31:56 sean-k-mooney the ci job is trying to build the wheel for python-pcre
18:34:01 gmann yeah
18:36:55 sean-k-mooney ubuntu@sean-devstack-watcher-1:~/repos/nova-docs$ find /usr -name "pcre.h"
18:36:57 sean-k-mooney /usr/include/pcre.h
18:36:59 sean-k-mooney ubuntu@sean-devstack-watcher-1:~/repos/nova-docs$ apt-file search /usr/include/pcre.h
18:37:01 sean-k-mooney libpcre3-dev: /usr/include/pcre.h
18:37:24 sean-k-mooney gmann: so no noble https://review.opendev.org/c/openstack/nova/+/935577/3/bindep.txt is not correct
18:37:43 sean-k-mooney line 53 should be all that is required
18:37:50 sean-k-mooney libpcre3-dev [platform:dpkg test]
18:39:24 gmann yeah, libpcre3-dev should be enough but it is not finding it when building wheel for python-pcre
18:39:58 sean-k-mooney i can try doing it in a clean vm and see what happens
18:40:11 gmann or you can see PS2 test run and it fails there too https://review.opendev.org/c/openstack/nova/+/935577/2
18:40:29 gmann but log expire there
18:40:34 gmann expired
18:40:53 gmann oh, its there https://zuul.opendev.org/t/openstack/build/5ddcd6d9f0a94008a722346992cf499b
18:42:24 sean-k-mooney ya so this sound like somethign to do with the build chain
18:42:41 sean-k-mooney and by that i mean how the toll chain is set up in the vm
18:43:16 sean-k-mooney like its missing one of the devel packages like make or something is missing
18:47:02 sean-k-mooney i dont think this is it but one thing i do notice is i have a slightly old verion of virutal env locally then it used in the failed buil
18:47:13 sean-k-mooney virtualenv = 20.26.3 locally
18:58:13 sean-k-mooney gmann: so not a clean vm but https://paste.opendev.org/show/bv240D3BK3XVEKBywbMN/
18:58:33 sean-k-mooney if i disable using all binaireas and force a build it definly works
19:04:05 sean-k-mooney gmann: ok i create a clean ubuntu vm on our internal cloud. im gong to confirm pcre.h is not pre installed in the image and then only install the bindep package with the test profile
19:04:22 sean-k-mooney and ill see if mater doc target fail or not
19:06:57 sean-k-mooney ... cloning nova is painful aat 500KiB/s
19:12:29 sean-k-mooney gmann: so this is what im going to install
19:12:32 sean-k-mooney .venv) ubuntu@sean-upstream-docs:~/nova$ bindep -b test | nc termbin.com 9999
19:12:34 sean-k-mooney https://termbin.com/hrrp
19:12:51 sean-k-mooney that is for master
19:12:58 sean-k-mooney i guess i should also include the docs target
19:23:26 sean-k-mooney gmann: so locally that works for me on a clean vm
19:23:50 sean-k-mooney gmann: what i did was as followes
19:23:53 sean-k-mooney sudo apt install python3.12-venv
19:24:03 sean-k-mooney python3 -m venv .venv
19:24:12 sean-k-mooney actully ill past it
19:25:03 sean-k-mooney https://paste.opendev.org/show/bq494eyZBhcRJTR1ATEm/
19:27:15 sean-k-mooney this seams to be somethign either specific to the ci vms or to the playbooks we are using to do this in ci
19:29:35 gmann yeah, it seems so. something wit editable install with pyproject.toml ? but not sure
19:29:57 opendevreview Ghanshyam proposed openstack/nova master: Testing doc job on Ubuntu Noble https://review.opendev.org/c/openstack/nova/+/935577
20:12:36 opendevreview Merged openstack/nova master: Update libvirt fixtures to support hostdevs https://review.opendev.org/c/openstack/nova/+/943207
20:20:21 opendevreview Merged openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147
#openstack-nova - 2025-03-11
01:12:17 opendevreview suiong ng proposed openstack/nova stable/2024.2: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/943994
06:19:40 opendevreview Amit Uniyal proposed openstack/nova master: DNM: enable NFS backend job https://review.opendev.org/c/openstack/nova/+/944008
06:25:49 opendevreview Amit Uniyal proposed openstack/nova master: DNM: enable NFS backend job https://review.opendev.org/c/openstack/nova/+/944008
08:02:20 opendevreview Amit Uniyal proposed openstack/nova master: DNM: enable NFS backend job https://review.opendev.org/c/openstack/nova/+/944008
08:15:42 opendevreview Amit Uniyal proposed openstack/nova master: DNM: enable NFS backend job https://review.opendev.org/c/openstack/nova/+/944008
08:28:34 opendevreview Amit Uniyal proposed openstack/nova master: DNM: enable NFS backend job https://review.opendev.org/c/openstack/nova/+/944008
08:32:08 ralonsoh hello folks, where exactly in Nova compute the VF is created and the VLAN ID defined?
08:32:14 ralonsoh can you point me to the code?
08:32:28 ralonsoh I'm talking about SR-IOV ports
08:40:54 ralonsoh bauzas, sean-k-mooney ^
08:41:36 sean-k-mooney[m] the vlan id is compute by neturon
08:41:50 sean-k-mooney[m] we just apply the value ye provide to the vf
08:41:52 ralonsoh sean-k-mooney[m], the VLAN ID is set by Neutron?
08:42:01 sean-k-mooney[m] no its set by nova
08:42:06 ralonsoh no no, I know the VLAN info is provided by Nova
08:42:14 ralonsoh but where this VLAN ID is set in the VF?
08:42:17 sean-k-mooney[m] but we use the value form the neutron network accosated with the neutron port
08:42:38 ralonsoh by Neutron* (not Nova)
08:42:51 sean-k-mooney[m] its set by nova in the libvirt xml
08:43:01 ralonsoh ok, this is what I was looking for
08:43:07 sean-k-mooney[m] ill find the code one sec
08:43:08 ralonsoh thanks!
08:46:22 sean-k-mooney so our LibvirtConfigGuestInterface has a vlan property https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L1912 which is rendered into the xml for type direct and hostdeve vnic_type=direct is hostdev in this case and vnic_type=macvtap is direct...
08:46:24 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L2015-L2019
08:46:57 ralonsoh right, so the VLAN is set in the interface definition

Earlier   Later