| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-03-07 | |||
| 14:36:14 | opendevreview | OpenStack Release Bot proposed openstack/os-vif stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943754 | |
| 14:36:16 | opendevreview | OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943756 | |
| 14:36:22 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943757 | |
| 14:36:23 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943758 | |
| 14:36:24 | opendevreview | OpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/osc-placement/+/943759 | |
| 14:36:32 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943762 | |
| 14:36:34 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943763 | |
| 14:36:35 | opendevreview | OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943764 | |
| 15:11:10 | opendevreview | Merged openstack/os-vif stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943753 | |
| 15:12:03 | opendevreview | Merged openstack/os-vif stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943754 | |
| 15:12:04 | opendevreview | Merged openstack/os-vif master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/os-vif/+/943756 | |
| 15:42:16 | dansmith | gibi: if I look at the allocations that we have in the resource tracker before we do the local claim stuff, I don't see any for the pci device | |
| 15:42:24 | dansmith | ...but I should right? | |
| 15:44:09 | dansmith | yeah, they're in the actual allocations in placement, they're just not like added to the allocations we pass down to the compute node.. | |
| 15:54:15 | gibi | dansmith: allocation is made in placement, the InstancePCIRequest carries the information about what RPs are fulfilling what request by placement. | |
| 15:54:38 | dansmith | yeah I guess I would just expect those to be in our list of allocations | |
| 15:55:03 | gibi | when you say "allocation" what you mean exactly? | |
| 15:57:38 | gibi | the pci claim only happens on the compute side. so the pci tracker has no information about the allocation until the pci claim happens on the comptue side | |
| 16:03:56 | dansmith | gibi: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L142 | |
| 16:04:10 | dansmith | that allocations variable is a dict of {rp_uuid: {allocation_dict}} | |
| 16:04:34 | dansmith | in this case, it has the local compute node's rp_uuid and allocations for memory, etc, but not the pci allocations | |
| 16:05:19 | dansmith | to me, it should be "all the allocations that have been made for this instance".. or at least, that's what I expect | |
| 16:08:31 | gibi | yeah that should have it | |
| 16:08:44 | gibi | do you have pci_in_placement enable? | |
| 16:09:45 | gibi | https://github.com/openstack/nova/blob/276685b3db6e8f2ad59c33bc254461c255700ff8/nova/compute/manager.py#L2615C1-L2617C40 | |
| 16:09:57 | gibi | we load allocation from placement before the instance_claim call | |
| 16:10:40 | gibi | so if you see the allocation in placement then the same data should be in the allocation dict in the claim call | |
| 16:10:42 | dansmith | yes, the allocations get made in placement, and the pci device has the rp_uuid in the extra_info, it's just never getting merged | |
| 16:11:52 | gibi | I suggest to trace how we read the allocations from placement before the instance_claim call | |
| 16:12:03 | dansmith | the device that we get back from the pci claim also doesn't get the new key in extra_info that I'm putting in device_spec | |
| 16:12:49 | dansmith | gibi: okay I thought those were passed down via rpc and not re-loaded in compute, but I could be wrong | |
| 16:13:39 | dansmith | but yeah I see that get_allocations_for_consumer() call.. it's almost like that's filtering for just our RP or something | |
| 16:14:18 | gibi | dansmith: for the devspec => dev data move you need to extend this https://github.com/openstack/nova/blob/276685b3db6e8f2ad59c33bc254461c255700ff8/nova/pci/devspec.py#L418 | |
| 16:15:14 | dansmith | ah, okay I added the key in the update, like this: https://review.opendev.org/c/openstack/nova/+/942144/4/nova/objects/pci_device.py | |
| 16:15:35 | dansmith | and I see it in the "final resource view" when n-cpu starts, but not when I get it back from the pci claim | |
| 16:15:45 | dansmith | I'll add it there too | |
| 16:16:26 | gibi | I need to drop. It was a long week. I will try to check back later today but more likely only on monday | |
| 16:16:45 | dansmith | no prob, thanks | |
| 16:19:05 | dansmith | yep, that did it | |
| 16:23:45 | gibi | ohh if you see the allocation in placement but not during claim then it must be the allocation healing that creates the allocation in placement and not the scheduler. pci_in_placement flag needs to be true in the config not just report_in_placement | |
| 16:32:59 | dansmith | hmm | |
| 17:15:56 | opendevreview | Merged openstack/python-novaclient master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/python-novaclient/+/943764 | |
| 17:22:51 | dansmith | gibi: aha, yep, that does it, thanks | |
| 17:36:37 | opendevreview | Merged openstack/nova stable/2024.2: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/942085 | |
| 18:09:57 | opendevreview | Merged openstack/nova stable/2024.2: Update InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/942086 | |
| 18:11:46 | opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | |
| 18:13:20 | opendevreview | Merged openstack/nova stable/2024.2: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/942087 | |
| 18:16:05 | opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | |
| 18:17:23 | sean-k-mooney | gibi: ^ this is a less dramtic rewite tha tavoid round triping the data via the object when we are composing the responce | |
| 18:17:45 | sean-k-mooney | gibi: so it will keep the keys and values matching what we have in the system_metadta_table | |
| 18:18:38 | sean-k-mooney | of couse if we normalised the values before we saved them there is noting we can do at this point | |
| 18:22:03 | opendevreview | sean mooney proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | |
| 18:22:17 | sean-k-mooney | fixed pep8 issue | |
| 18:22:40 | sean-k-mooney | am im going to finish now ish and i assume you already have so no rush with ^ | |
| 18:30:38 | opendevreview | Dan Smith proposed openstack/nova master: WIP: Reserve OTU devices https://review.opendev.org/c/openstack/nova/+/943816 | |
| 18:30:45 | dansmith | shockingly, that seems to work ^ | |
| 18:31:29 | sean-k-mooney | that looks shorter then im expecting | |
| 18:31:59 | dansmith | well, I wasn't thinking it would be huge given it's technically a simple thing to do, | |
| 18:32:02 | sean-k-mooney | oh | |
| 18:32:03 | dansmith | but yeah | |
| 18:32:27 | sean-k-mooney | your doing it in update_provider_tree | |
| 18:32:42 | dansmith | yeah so I'm adding some review comments about why | |
| 18:33:00 | sean-k-mooney | ok | |
| 18:33:14 | sean-k-mooney | we just make sure that that is not only working because of the perodic | |
| 18:33:53 | sean-k-mooney | or we would have a gap where if we spawned and delete right after each other it might not run | |
| 18:34:15 | dansmith | it's not, but obviously tests | |
| 20:17:50 | opendevreview | Merged openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145 | |
| #openstack-nova - 2025-03-08 | |||
| 01:23:11 | opendevreview | melanie witt proposed openstack/nova master: unified limits: discover service ID and region ID https://review.opendev.org/c/openstack/nova/+/943507 | |
| #openstack-nova - 2025-03-10 | |||
| 05:05:05 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 11:15:38 | sean-k-mooney | melwitt: would you mind readding your +2 adn approving https://review.opendev.org/c/openstack/nova/+/939411/10 the only differnce since you last reviewd was the addtion of a release note | |
| 11:16:29 | sean-k-mooney | bauzas: this ^ was a regression breaking rebuild last cycle so we will have to backport it anyway but still nice ot have before rc1 | |
| 12:13:37 | opendevreview | Merged openstack/nova master: libvirt: fix maxphysaddr passthrough dom parsing https://review.opendev.org/c/openstack/nova/+/942371 | |
| 12:16:52 | opendevreview | Yaguang Tang proposed openstack/nova stable/2024.2: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/943924 | |
| 13:19:10 | bauzas | sean-k-mooney: ack, stephenfin already sent it to the gate fwiw | |
| 13:19:32 | bauzas | sean-k-mooney: I started a new etherpad for rc tracking https://etherpad.opendev.org/p/nova-epoxy-rc-potential | |
| 13:20:11 | bauzas | sean-k-mooney: you can as usual add some changes if you think those are important before RC1 in the right section 'bugfixes requiring attention before RC1' | |
| 13:32:52 | sean-k-mooney | bauzas: ack, this is/was a latent issue form the ironic leeasee serise so not super urgent. i.e. if it missed rc 1 it woul dnot be a new regression intoduced in epoxy, just nice to have sooner rtahter then later | |
| 13:33:00 | sean-k-mooney | stephenfin: thanks for reviewing :) | |
| 13:33:39 | sean-k-mooney | bauzas: as it stand im not really aware of anyting super urgent for RC1 outside of the mechanical patches we do every release | |
| 13:46:39 | opendevreview | Merged openstack/nova master: api: project/tenant and user IDs are not UUIDs https://review.opendev.org/c/openstack/nova/+/940369 | |
| 13:46:45 | opendevreview | Merged openstack/nova master: api: Address TODO in microversion v2.99 https://review.opendev.org/c/openstack/nova/+/943253 | |
| 13:54:28 | opendevreview | Yaguang Tang proposed openstack/nova stable/2024.2: Handle iso+gpt detections https://review.opendev.org/c/openstack/nova/+/943940 | |
| 14:09:23 | opendevreview | Merged openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | |
| 14:10:00 | gibi | dansmith: o/ regarding https://review.opendev.org/c/openstack/nova/+/943816/1/nova/compute/pci_placement_translator.py | |
| 14:11:02 | gibi | that palce exists in the pci in placement code to implement missing allocation healing and not intended to remain there for ever. It is more like a transitional code to support upgrade and gradual enablement of the featureh | |
| 14:11:28 | dansmith | orly, okay | |
| 14:11:35 | gibi | in general pci allocation should only happen during scheduling in the scheduler / conductor. | |
| 14:12:01 | gibi | this allocation healing is like the old healing periodic when we introduced placement | |
| 14:12:09 | gibi | 5+ years ago | |
| 14:12:27 | dansmith | right, well, this is not really allocation and I think the consensus (me, sean, sylvain) is that the reservation should be in the compute node | |
| 14:12:28 | gibi | I think you ended up looking at this code as friday in your env the allocation happened in this code | |
| 14:12:42 | gibi | yeah I know that your code is not allocation | |
| 14:12:51 | dansmith | but yeah I traced the placement update stuff looking for a good place to do it and this looked perfect :) | |
| 14:12:54 | gibi | but the code path seem to only exists for allocation | |
| 14:12:56 | gibi | so far | |
| 14:13:06 | dansmith | I had originally written my own inventory update in the RT | |
| 14:13:45 | dansmith | so I can go back to that approach, which it sounds like would be better so this healing can be ripped out later yeah? | |
| 14:13:57 | gibi | I might be mistake. I have to dig a bit deeper where we do the actual inventory reporting of PCI in placement | |
| 14:14:45 | gibi | https://github.com/openstack/nova/blob/5f3133efc04dde15d64679e1e7564d2e575549db/nova/compute/resource_tracker.py#L1325-L1342 | |
| 14:14:53 | dansmith | okay, tbh, this looked like it was intended to be permanent.. it seems related to making sure placement inventory gets healed if our resources ever changed | |