| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-19 | |||
| 14:43:12 | bauzas | so indeed the lazyloading is something like a good performance concern | |
| 14:43:48 | bauzas | when we discussed with sean-k-mooney, we said eventually "yeah, but just for the moment we wouldn't working on it" | |
| 14:44:04 | bauzas | that said, now, if you want, I can provide another dependent change for this | |
| 14:44:43 | dansmith | bauzas: we will lazy-load every instance on every host we're considering...sequentially | |
| 14:44:58 | dansmith | for ten hosts with 100 instances each, that's 1000 trips to the database for each schedule operation | |
| 14:45:08 | bauzas | indeed you see this in https://4d2664479333d0a7d727-a4adcb41e06ec456a00383225f090da6.ssl.cf5.rackcdn.com/940642/9/check/nova-multi-cell/bbf5fea/controller/logs/screen-n-sch.txt | |
| 14:45:21 | bauzas | Feb 17 19:20:02.725500 np0039881226 nova-scheduler[84264]: DEBUG nova.objects.instance [None req-6e249595-d7b0-4cbc-95d0-e2798d45bc99 tempest-ImagesOneServerNegativeTestJSON-728670221 tempest-ImagesOneServerNegativeTestJSON-728670221-project-member] Lazy-loading 'system_metadata' on Instance uuid e6f93654-3b12-429d-8f17-15ad1e605964 {{(pid=84264) obj_load_attr | |
| 14:45:23 | bauzas | /opt/stack/nova/nova/objects/instance.py:1141}} | |
| 14:45:28 | dansmith | yeah | |
| 14:45:52 | bauzas | so I don't disagree with you, if you think it's a priority issue, I can try to fix it then | |
| 14:46:07 | bauzas | or you if you want | |
| 14:46:24 | bauzas | that would be a bottom change for the series | |
| 14:46:39 | dansmith | I really don't think it's reasonable to do this in a filter, and definitely not one that is always enabled by default and/or would have this behavior when it's not even weighted | |
| 14:47:20 | dansmith | can we gmeet about this for a minute? I want to make sure we're also considering the track-changes path properly | |
| 14:47:22 | bauzas | yeah cool with me | |
| 14:47:29 | bauzas | dansmith: yeah, sure | |
| 14:47:48 | dansmith | bauzas: when you're ready: meet.google.com/aug-ibty-wrz | |
| 14:48:36 | dansmith | sean-k-mooney: if you're interested ^ | |
| 14:49:00 | sean-k-mooney | am sure | |
| 14:49:08 | sean-k-mooney | be right there | |
| 14:50:18 | sean-k-mooney | give me a sec i need to sign in to sso... | |
| 15:17:15 | sean-k-mooney | bauzas: so looks like melwitt gave me feedback on the release not so ill proably respine for that https://review.opendev.org/c/openstack/nova/+/940835/7 if you have any other comments then i can adress them at the same time | |
| 15:19:54 | sean-k-mooney | im goign to squash the two commit and reuplload in a few minutes | |
| 15:22:25 | sean-k-mooney | if people are around later i want to merge https://review.opendev.org/c/openstack/os-vif/+/941585 and https://review.opendev.org/c/openstack/os-vif/+/941568 today if we can too so we can do a release of os-vif before the non clinet lib freeze tomorrow | |
| 15:23:00 | sean-k-mooney | ill work on the nova deprecation patch later today as well but that is less urgent | |
| 15:24:44 | sean-k-mooney | as a psa firday is a company day at redhat so many of us wont be around | |
| 15:29:02 | bauzas | sean-k-mooney: gibi: you probably lost context about https://review.opendev.org/c/openstack/nova/+/845757/8 but I now rebased it and I think it would help many users, particularly for evacuation ccases | |
| 15:29:24 | bauzas | sean-k-mooney: I can dig into the os-vif patches | |
| 15:29:51 | sean-k-mooney | i cna review that later. i still have some of the context | |
| 15:30:48 | bauzas | sean-k-mooney: I wonder why I did split the change in two patches, one for the doc change and the other one for the code change | |
| 15:31:10 | bauzas | maybe I should squash that, particularly you had concerns about the doc | |
| 15:47:00 | opendevreview | Dan Smith proposed openstack/nova master: Add fill_metadata() to InstanceList https://review.opendev.org/c/openstack/nova/+/942214 | |
| 15:49:45 | dansmith | sean-k-mooney: bauzas: ^ | |
| 15:50:11 | bauzas | thanks | |
| 16:00:28 | opendevreview | Merged openstack/nova master: Respect supplied arguments in novncproxy_base_url https://review.opendev.org/c/openstack/nova/+/928839 | |
| 17:05:07 | opendevreview | ribaudr proposed openstack/nova master: Add live_migratable flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/942144 | |
| 17:05:07 | opendevreview | ribaudr proposed openstack/nova master: Augment the LiveMigrateData object https://review.opendev.org/c/openstack/nova/+/942143 | |
| 17:05:08 | opendevreview | ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146 | |
| 17:05:08 | opendevreview | ribaudr proposed openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145 | |
| 17:05:09 | opendevreview | ribaudr proposed openstack/nova master: WIP: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147 | |
| 17:06:57 | ratailor | gibi, I already submitted changes for sdk and client here https://review.opendev.org/q/topic:%22bp/image-props-in-server-show%22 but the tests are failing, because not sure how to add 'image_properties' attr to class Server in openstacksdk with 2.98 version specific. | |
| 17:07:25 | ratailor | gibi, could you please check and provide your feedback, when you have time ? | |
| 17:09:41 | opendevreview | sean mooney proposed openstack/nova master: move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940873 | |
| 17:11:05 | sean-k-mooney | melwitt: bauzas ^ squased into one comment, with release note updated. this is the review that was used for depends on before and i have abandoned the first patch | |
| 17:11:43 | sean-k-mooney | ok so next on my list is dans patch | |
| 17:12:04 | melwitt | sean-k-mooney: cool, thanks. will look | |
| 17:40:43 | sean-k-mooney | dansmith: bauzas im good with https://review.opendev.org/c/openstack/nova/+/942214 | |
| 17:41:14 | sean-k-mooney | just waiting on zuul beofre +w | |
| 17:41:27 | sean-k-mooney | with that said | |
| 17:41:51 | sean-k-mooney | it would be nice to see this used in https://review.opendev.org/c/openstack/nova/+/940642 | |
| 17:41:55 | sean-k-mooney | before we merge | |
| 17:42:09 | sean-k-mooney | so perhaps we shoud wait to merge until the other patches are on top | |
| 17:42:43 | dansmith | yep, fine to wait until it's used | |
| 17:42:50 | bauzas | sure, I'm working on the rebase | |
| 17:42:59 | bauzas | and then I'll need to end for the day | |
| 17:56:26 | gmann | In case anyone interested, TC is short of one candidate for this election. nomination ending in ~6 hrs from now https://governance.openstack.org/election/ | |
| 18:00:09 | dansmith | gmann: a non-redhat person is needed I assume :) | |
| 18:02:17 | gmann | dansmith: I think we still have one member capacity for RH member. slaweq is not re-running and no new RH member nominated yet | |
| 18:07:08 | MengyangZhang[m] | sean-k-mooney: I may need some help with implementing this min version check you mentioned for this patch https://review.opendev.org/c/openstack/nova-specs/+/932653. I have two ideas to do this:... (full message at <https://matrix.org/oftc/media/v1/media/download/AViM5KuzefB-19EfrDbw71k64XnKJJpP_G9sobaeS8NH-AJhP8DfPwD665n9DmazUuyKEk2lk1KiimNHIqjb0xpCeVZ31wDgAG1hdHJpeC5vcmcvcUdQVElMSnlsTUNLTWFJUVFDaFpmdERR>) | |
| 18:09:00 | sean-k-mooney | MengyangZhang[m]: oh so you cant really do that properly. my expection was cidner qos would never change out side of spawn/attach or perhaps volume retype | |
| 18:09:38 | sean-k-mooney | we coudl do it for spawn and attach in https://github.com/openstack/nova/blob/master/nova/compute/api.py | |
| 18:09:56 | sean-k-mooney | but cidner will end up bypassing any proection we put in place... | |
| 18:10:28 | sean-k-mooney | so im not sure what to do about that | |
| 18:10:54 | sshmlbrg | Hi? | |
| 18:11:07 | sean-k-mooney | sshmlbrg: o/ | |
| 18:11:24 | sshmlbrg | I have a question about the 'attach volume to shelved instance' functionality. How does it work if an instance in the 'shelved_offloaded' status has no availability zone, but when attaching, the availability zones of the instance and the volume are checked? The documentation states that this functionality works starting from microversion 2.20. | |
| 18:12:28 | sean-k-mooney | sshmlbrg: i dont think we supprot attach ro deation for shleve_offloaded but i would have to check | |
| 18:13:29 | sshmlbrg | ok, thanks | |
| 18:13:43 | sean-k-mooney | maybe we do i might be confusing that with snapshosts | |
| 18:14:34 | sshmlbrg | https://docs.openstack.org/api-ref/compute/?expanded=attach-a-volume-to-an-instance-detail#attach-a-volume-to-an-instance | |
| 18:14:47 | sean-k-mooney | ok so yes we do suprot it basedon the api refe as you said form 2.20 | |
| 18:15:01 | sean-k-mooney | you were asking about aviablity zone checks | |
| 18:15:13 | sshmlbrg | but it doesn't work | |
| 18:15:31 | sean-k-mooney | so by default htere are no aviablity zone checks for nova and cinder voluems. | |
| 18:15:46 | sean-k-mooney | we have a config option to opt into the non default beahvior of preventign cross az attach | |
| 18:16:18 | sean-k-mooney | its possible this only works when cross az atach is allow or when an instance is pinned to an az | |
| 18:19:53 | sean-k-mooney | ill see if i can quickly test it | |
| 18:20:27 | sshmlbrg | But this function lacks a cross-AZ check, and we proceed to compare the availability zone of the volume and the instance. https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5143 | |
| 18:22:07 | sean-k-mooney | so cross_az attach is a comput enode option | |
| 18:22:19 | sean-k-mooney | a shevle offloaded instance does not have a compute service | |
| 18:22:41 | sean-k-mooney | so you cant actuly reason about if this shoudl or shoudl not work | |
| 18:23:50 | sean-k-mooney | the az check i enabeld by this check https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5065 | |
| 18:23:56 | sean-k-mooney | *this default | |
| 18:24:02 | sean-k-mooney | because we are not passsing that variable | |
| 18:24:35 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | |
| 18:24:36 | opendevreview | Sylvain Bauza proposed openstack/nova master: per-property ImageMetaPropsWeigher https://review.opendev.org/c/openstack/nova/+/941601 | |
| 18:24:47 | bauzas | dansmith: sean-k-mooney: rebased as asked | |
| 18:25:27 | sshmlbrg | Then, should we disable this option so that attach works for shelved_offloaded VMs? | |
| 18:25:51 | dansmith | bauzas: okay did you want me to make the mods to use the new method? | |
| 18:26:03 | sean-k-mooney | there is more context here | |
| 18:26:24 | sean-k-mooney | sshmlbrg: https://github.com/openstack/nova/commit/07a24dcef7ce6767b4b5bab0c8d3166cbe5b39c0 | |
| 18:27:20 | sshmlbrg | i need a few minutes to get it :) | |
| 18:28:39 | sean-k-mooney | sshmlbrg: it looks like the curent check was added to fix https://bugs.launchpad.net/nova/+bug/1694844 | |
| 18:28:57 | sean-k-mooney | but it may have broken seveled atatch in the process | |
| 18:29:59 | sean-k-mooney | skimming the patch it maybe looks like the intent was to fall back to the default schduler zone | |
| 18:30:31 | sean-k-mooney | i think in this sepcific case it woudl be valide to pass false | |
| 18:31:00 | sean-k-mooney | if an donly if instnace.az was None in either the request spec or the instance table in teh cell db | |
| 18:31:35 | sean-k-mooney | basically if the isntance is shelve_offloaded. and it not pinend to any az | |
| 18:32:04 | sean-k-mooney | then we can possibly disable the afinity check | |
| 18:32:33 | sean-k-mooney | but that may lead to issue unshevling | |