| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-11 | |||
| 17:20:54 | dansmith | right, so my point is that's exactly like what dict.items() returns, so you might just name the property (or use a method) "items" for parity/consistency | |
| 17:21:22 | bauzas | ahah OK | |
| 17:21:53 | dansmith | just an idea, not critical | |
| 17:22:11 | bauzas | also, I think I'll use obj_to_primitive() for that, as I got https://6ae015e4c924496dfda3-74c26bb67ca36871e200d07f3210a3f0.ssl.cf1.rackcdn.com/940642/5/check/nova-multi-cell/c2a2f68/controller/logs/screen-n-sch.txt due to the fact I'd also want to modify a list | |
| 17:22:40 | dansmith | ack | |
| 18:10:28 | opendevreview | Merged openstack/nova stable/2024.2: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/940836 | |
| 18:18:37 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | |
| 19:14:20 | mikal | sean-k-mooney: did you end up having any joy on your tempest SPICE thing? I tweaked the tempest test last night to address review comments, but I am not sure where exactly we're up to now. | |
| 19:15:23 | mikal | Also melwitt if you're around, I'd appreciate a quick re-review on https://review.opendev.org/c/openstack/os-traits/+/940418. I think its good to go and it has a +2 from sean-k-mooney already. | |
| 19:29:09 | gmann | mikal: I am going to check tempest/devstack changes soon after TC discussion | |
| 19:31:24 | mikal | gmann: thanks | |
| 19:31:46 | mikal | gmann: I assume you don't want to actually merge that tempest change until the microversion merges in nova though? | |
| 19:36:16 | gmann | mikal: not strong opinion, as tests are capped with microversion those going to be skipped/not failed. I am ok to merge tempest test before nova change also or after whatever make things easy. | |
| 19:36:37 | mikal | gmann: ok cool | |
| 19:36:38 | gmann | I know you have made tempest change depends-on on nova change so that test results can be seen while review which is good dependency/ | |
| 19:47:32 | mikal | What's the best way in the zuul output to verify the test actually run? I'm not entirely which file I should be searching for that. | |
| 19:51:31 | MengyangZhang[m] | <MengyangZhang[m]> "understood, just curious in..." <- I may need some help with implementing the min version check. I have two ideas: | |
| 19:54:14 | gmann | mikal: commented here, we need to change the tempest test regex in this job https://review.opendev.org/c/openstack/nova/+/940873/5/.zuul.yaml#173 | |
| 19:54:53 | gmann | log/job-output.txt is where you can see the test running and how much time it takes https://zuul.opendev.org/t/openstack/build/afeee7c92cce46348341232a188427b3/log/job-output.txt | |
| 19:55:19 | gmann | or testr_results.html for quick ref https://e287b5846f894c7179f4-83ee41d1d15b6e7c94a25488c54501c9.ssl.cf1.rackcdn.com/924844/34/check/nova-ovs-hybrid-plug/afeee7c/testr_results.html | |
| 20:00:05 | MengyangZhang[m] | ||
| 20:01:25 | mikal | gmann: so yeah, either I am looking in the wrong place or the spice test isn't running in the job yet then... https://e287b5846f894c7179f4-83ee41d1d15b6e7c94a25488c54501c9.ssl.cf1.rackcdn.com/924844/34/check/nova-ovs-hybrid-plug/afeee7c/testr_results.html | |
| 20:01:50 | mikal | That's the nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/afeee7c92cce46348341232a188427b3 job for https://review.opendev.org/c/openstack/nova/+/924844 | |
| 20:02:32 | mikal | I feel like 30 tests is a really low number too, like there's some test filtering happening that I haven't found yet or something. | |
| 20:03:21 | mikal | Oh sorry, that's your regex comment above! | |
| 20:03:58 | gmann | yeah, we need to change the regex | |
| 20:04:04 | mikal | sean-k-mooney: do we feel like we should rename the nova-ovs-hybrid-plug job if it now does more than that/ | |
| 20:11:26 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 20:11:27 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 20:11:27 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 20:27:37 | sean-k-mooney | mikal: we can, that kind of my semi personal job. i created specifically to test non default deployment configuraiton focusing on ml2/ovs coverage wehn we change teh default in devstack to ovn | |
| 20:27:52 | sean-k-mooney | mikal: so we can add spice or otherwise rename it if you like | |
| 20:28:28 | sean-k-mooney | mikal: i choose that job becuase its the one i expected other to object to the least in terms of altering its scope | |
| 20:29:07 | sean-k-mooney | mikal: i.e. other might be uncofrotabel movign the ceph job to debian but i didnt htink anyone would obejct to that one havign spcie in stead of vnc or debain ectra | |
| 20:29:54 | sean-k-mooney | it also test live migration and cold migration ensurign that at least at the qemu level enablign spice does nto break that | |
| 20:52:16 | mikal | Cool. I have to run for a bus now, but it sounds like I could propose a more generic name for that job when I get a chance. | |
| 20:58:33 | sean-k-mooney | gmann: mikal oh it was the regex that skipped it | |
| 20:59:01 | sean-k-mooney | ya we can change that but its currently diabling some test to keep the job time short | |
| 20:59:14 | sean-k-mooney | and because we didn need to test them for the previous job scope | |
| 21:00:06 | sean-k-mooney | thats why cidner and swift are disabled i did not want to deal with the cinder volume test flakynes | |
| 21:01:38 | sean-k-mooney | the job is currenlty mainly to test move operations with ml2/ovs as i said but feel free to expand the test set to anyting you consider useful but ideally dont add addtioanl services unless its really needed | |
| 21:10:07 | MengyangZhang[m] | <MengyangZhang[m]> "I may need some help with..." <- oh i think we can use the get_minimum_version function in service.py to find the min version of all hosts. | |
| 21:48:27 | MengyangZhang[m] | <MengyangZhang[m]> "oh i think we can use the..." <- Do we know what would be the version number of 2025.2 release? | |
| #openstack-nova - 2025-02-12 | |||
| 01:07:18 | opendevreview | Doug Goldstein proposed openstack/nova stable/2024.1: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/940846 | |
| 02:51:09 | gmann | mikal: as you might have seen spice test running now but failing that is because of schema versions missing in tempest change, I forgot to check it before. I commented in tempest change https://review.opendev.org/c/openstack/tempest/+/940943/2/tempest/lib/services/compute/servers_client.py | |
| 02:56:15 | gmann | sean-k-mooney: ^^ i think you are debugging the failure | |
| 03:00:55 | sean-k-mooney | ya so tempest reponce schema rejected the respone | |
| 03:01:04 | sean-k-mooney | the schema looked ok | |
| 03:01:16 | sean-k-mooney | so i was wonderign is the patch missing something to apply it | |
| 03:01:39 | gmann | yeah, it is missing this part https://review.opendev.org/c/openstack/tempest/+/940943/comment/4b1cc154_361f1c5e/ | |
| 03:02:27 | sean-k-mooney | oh cool ya so it was not registered in the schema_versions_info list | |
| 03:03:54 | sean-k-mooney | i should proably go to bed since its like 3 am but this all looks liek it is pretty close | |
| 03:05:38 | sean-k-mooney | by the way if anyone fells like +2w ing https://review.opendev.org/c/openstack/nova/+/939476 or https://review.opendev.org/c/openstack/nova/+/938523 it would be nice to wake up with those merged :) | |
| 05:29:45 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 07:11:09 | mikal | gmann / sean-k-mooney: I fix that tempest schema thing and am retesting now. | |
| 08:52:21 | opendevreview | Vasyl Saienko proposed openstack/nova master: Add trunk subports to network metadata https://review.opendev.org/c/openstack/nova/+/941227 | |
| 09:33:39 | opendevreview | Ghanshyam proposed openstack/nova master: Add project manager role in Nova API policy rule https://review.opendev.org/c/openstack/nova/+/941347 | |
| 12:56:25 | opendevreview | Balazs Gibizer proposed openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 13:52:33 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 13:52:33 | opendevreview | ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 14:00:56 | opendevreview | ribaudr proposed openstack/nova-specs master: Amend the specification about the data in LiveMigrate object https://review.opendev.org/c/openstack/nova-specs/+/941417 | |
| 14:38:05 | bauzas | dansmith: doh, somehow items() is already used for o.vo objects https://4c92e32258abec426e9c-a1b3a735e9c0af824100c02f6885a5ce.ssl.cf1.rackcdn.com/940642/6/check/openstack-tox-py39/266ccf7/testr_results.html | |
| 14:38:22 | dansmith | bauzas: for the dict-based one yes, that's my point | |
| 14:38:25 | bauzas | so I need to provide another method name | |
| 14:38:34 | dansmith | if this a dict-compat object? if so you already have items() :) | |
| 14:38:37 | bauzas | dansmith: see, this is calling my own method | |
| 14:38:54 | bauzas | instead of the original dict() one | |
| 14:38:59 | bauzas | items() one | |
| 14:39:23 | dansmith | why can't you use the base one? | |
| 14:40:09 | bauzas | dansmith: I'll test this | |
| 14:40:32 | bauzas | I haven't seen this method before tbh | |
| 14:40:54 | dansmith | your object inherits from https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L728 ? | |
| 14:41:56 | bauzas | looking | |
| 14:43:25 | bauzas | that's ImageMetaProps | |
| 14:43:40 | bauzas | which inherits from the base NovaObject | |
| 14:44:53 | bauzas | which apparently isn't using this mixin | |
| 14:45:54 | dansmith | okay I'm not sure what you're saying.. you said your items conflicted with the base items right? | |
| 14:46:30 | dansmith | that error looks more like you're overriding obj_to_primitive? | |
| 14:46:32 | bauzas | yeah, see the stacktrace | |
| 14:46:56 | bauzas | nope, I'm not overriding it, I'm using it | |
| 14:46:59 | bauzas | https://review.opendev.org/c/openstack/nova/+/940642/6/nova/objects/base.py | |
| 14:47:14 | dansmith | ohh, I see, you're overriding items on the NovaObject base | |
| 14:47:24 | dansmith | but the dict compat is a mix-in, | |
| 14:47:41 | dansmith | so you're messing up *other* objects I guess | |
| 14:47:42 | bauzas | right | |
| 14:47:46 | bauzas | yeah that | |
| 14:47:56 | bauzas | for the imageprops object, we're good | |
| 14:48:16 | bauzas | but when trying to call the original items() on some other object, then it calls out my own items() | |
| 14:48:23 | bauzas | because it takes precedence | |
| 14:48:26 | dansmith | even still, obj_to_primitive().items() is not what you want right? that won't get you the actual fields of the object | |
| 14:48:49 | bauzas | well, I want to get the key/values of the fields that are set | |
| 14:49:02 | bauzas | and obj_to_primitive gives me all I want | |
| 14:49:05 | dansmith | right, did you look at what obj_to_primitive() returns? | |
| 14:49:17 | bauzas | the base one, not the one we use for passing over the bus | |
| 14:49:20 | dansmith | it's a nested dict, but the keys in that dict will be metadata | |
| 14:49:37 | dansmith | *object metadata, not your imagemeta fields | |
| 14:50:16 | dansmith | looks like this: https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L565 | |
| 14:51:18 | dansmith | anyway, so you can't override items in the base class because of the mixing in.. seems like the easiest thing is to just grab the fields in your weigher instead of add a new field/method to all our objects (especially since it duplicates what the dict-compat objects already have), but whatever you want | |
| 14:53:13 | bauzas | no, look, I'm calling our https://github.com/openstack/nova/blob/master/nova/objects/base.py#L331 | |
| 14:53:43 | bauzas | but yeah, I can use that function in the weigher directly | |