| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-10 | |||
| 19:29:30 | sean-k-mooney | mikal: i see your recheck from 30 mins ago but i dont see anyign in zuul for that | |
| 19:30:20 | sean-k-mooney | i wonder is there a merge confligt with the depends on agaisnt my patch | |
| 19:32:06 | mikal | Yeah, I did that recheck because I couldn't find any evidence that zuul had actually run a check on the latest patchset. | |
| 19:32:55 | mikal | That recheck did cause the vmware test to run at least, but I agree I can't see anything in zuul. | |
| 19:33:04 | sean-k-mooney | let me rebase my patch quickly | |
| 19:33:28 | sean-k-mooney | v4 is not based on teh latest verion of its parent https://review.opendev.org/c/openstack/nova/+/940873/4 | |
| 19:33:43 | mikal | I fixed a typo in one of yours to remove a stray pep8 error in my test results. I wonder if that is the problem?> | |
| 19:33:52 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:34:32 | sean-k-mooney | maybe, when you did that you did not update the follow up patch which is the one your referncing | |
| 19:34:53 | mikal | Yeah, I did it quickly in the web UI and didn't really think it through... | |
| 19:35:32 | sean-k-mooney | ok now its running | |
| 19:35:46 | sean-k-mooney | that was all that was wrong it seams | |
| 19:36:24 | sean-k-mooney | https://zuul.openstack.org/status?change=924844 | |
| 19:36:27 | mikal | Oh nice. Thank you. | |
| 19:36:56 | mikal | gmann left some comments on the tempest patch, so I'll address those today now that I have a test run to observe. | |
| 19:37:18 | sean-k-mooney | ya i clicked into it but didnt look at the code yet | |
| 19:38:13 | sean-k-mooney | i dont think ether of the issues will prevent the test form running but the feedback maskes sense | |
| 19:38:49 | sean-k-mooney | at least with my almost 0 knowladge of tempest convetions if gmann says it shoudl be done a certin way i tend to agree :) | |
| 19:39:16 | mikal | I see your zero knowledge and raise you negative knowledge! | |
| 19:39:24 | mikal | I just cargo culted the previous VNC test. | |
| 19:41:08 | sean-k-mooney | well you actully implemnted part fo the spice handshake it seams | |
| 19:41:25 | sean-k-mooney | so you proably deserve more credit then your giving yourself | |
| 19:42:20 | mikal | Heh. Well yeah, the scaffolding is all cargo culted. The SPICE protocol bit was a cut and paste from the Kerbside code and some tweaks. | |
| 19:42:54 | JayF | good artists borrow; great artists steal :) | |
| 19:43:18 | mikal | Heh | |
| 19:43:34 | mikal | sean-k-mooney: has there been any more discussion of an os-traits release? I think that blocks the other patchset for now. | |
| 19:44:45 | sean-k-mooney | are the traits patches merged | |
| 19:45:17 | gmann | sean-k-mooney: commented in devstack change to enable tempest cofig option also, https://review.opendev.org/c/openstack/devstack/+/940838 | |
| 19:45:55 | sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 19:46:06 | sean-k-mooney | gmann: did you see my nova job changes? | |
| 19:46:26 | gmann | sean-k-mooney this one? https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:46:38 | sean-k-mooney | yep | |
| 19:47:02 | gmann | yeah, but that does not set tempest config | |
| 19:47:07 | sean-k-mooney | so that is what enabled the testing in the nova check pipelien | |
| 19:47:23 | sean-k-mooney | right so ill update devstack with the change you susggeted | |
| 19:47:30 | gmann | either you can set tempest option also in job or better is devstack set it based on nova configuration | |
| 19:47:38 | sean-k-mooney | i was orginling thinkign of configuring that in the job as a followup | |
| 19:47:48 | gmann | i see | |
| 19:47:56 | sean-k-mooney | but im fine with devstack | |
| 19:48:12 | gmann | that will be easy if we want to test it in more jobs or so | |
| 19:49:32 | sean-k-mooney | sure so i dont neesisaly want to kick the current run out of the gate on the other hand the job has not started yet its still queue | |
| 19:49:55 | sean-k-mooney | so will i just do it now or do it after the current execution completes so we have one test run? | |
| 19:50:10 | sean-k-mooney | i guess in its current state it wont run the new test | |
| 19:50:20 | sean-k-mooney | so its proably better to update devstack now | |
| 19:50:24 | gmann | yeah | |
| 19:51:02 | gmann | at least to merge the tempest tests (which is almost ready), we need to see test running somewhere. | |
| 19:52:02 | sean-k-mooney | yep, do you have an example of how we set this in devstack normally | |
| 19:52:11 | sean-k-mooney | is it in lib/tempest or lib/nova | |
| 19:52:28 | mikal | sean-k-mooney: no, the os-traits change hasn't seen any more review recently. | |
| 19:52:48 | sean-k-mooney | ah found it | |
| 19:53:15 | gmann | sean-k-mooney: here https://github.com/openstack/devstack/blob/master/lib/tempest#L417 | |
| 19:53:50 | gmann | sean-k-mooney: you can add both condition 'is_service_enabled n-spice || [ "$NOVA_SPICE_ENABLED" != False ]' there same as how nova is configuring | |
| 19:55:04 | sean-k-mooney | ... whitespace https://review.opendev.org/c/openstack/devstack/+/940838/3/lib/tempest | |
| 19:55:42 | sean-k-mooney | so i need ot update that again anyway, i can do that if you liek but tempest is normmaly only installed on the contoler where the spice/serial proxy runs | |
| 19:56:02 | gmann | sean-k-mooney: I think you should add "$NOVA_SPICE_ENABLED" != False also like done in lib/nova | |
| 19:56:15 | sean-k-mooney | if i add || [ "$NOVA_SPICE_ENABLED" != False ] | |
| 19:56:21 | sean-k-mooney | will it break on the compute | |
| 19:56:31 | sean-k-mooney | on i guess tempet wont be enabeld on the compute | |
| 19:56:40 | sean-k-mooney | and if it was then it would be correct to do this ther too | |
| 19:56:44 | sean-k-mooney | ok ya ill fix that | |
| 19:59:19 | sean-k-mooney | gmann: ok https://review.opendev.org/c/openstack/devstack/+/940838 should work i think | |
| 20:00:09 | gmann | sean-k-mooney: yup. looks good | |
| 20:00:23 | sean-k-mooney | ok ill recheck mikal patch then to get a run with that enabled | |
| 20:00:35 | sean-k-mooney | once i find the tab... | |
| 20:01:19 | sean-k-mooney | cool its running again | |
| 20:02:30 | gmann | thanks | |
| 20:03:18 | sean-k-mooney | 39 itmes in check, my guess is we will have results in about 3 hours, maybe 2 if we get lucky with ci capsity | |
| 20:04:28 | sean-k-mooney | mikal: feel free to recheck or update any or my patches as needed. ill proably finish in the ned 30 mins or so | |
| 20:47:45 | opendevreview | Sylvain Bauza proposed openstack/nova master: Fix verifying all the alloc requests from a multi-create https://review.opendev.org/c/openstack/nova/+/846786 | |
| 21:09:43 | mikal | sean-k-mooney: no worries, thanks yet again. | |
| 21:10:34 | sean-k-mooney | its runnng tempet by the way | |
| 21:10:59 | sean-k-mooney | we are just waiting for it to report back now so my estimate is off it will be doen in less then an hour form now maybe 20 mins | |
| 21:11:10 | sean-k-mooney | i also never finish when i intened too... | |
| 21:18:42 | sean-k-mooney | mikal: ... 2025-02-10 21:14:19.686874 | controller | {3} setUpClass (tempest.api.compute.servers.test_spice.SpiceDirectConsoleTestJSON) ... SKIPPED: SPICE console feature is disabled. | |
| 21:19:03 | sean-k-mooney | so either i messed up this ran with an old verison of the devstack plugin | |
| 21:19:20 | sean-k-mooney | lets let is complete and we can check what is wrong | |
| 21:19:40 | sean-k-mooney | its still runing temepst i just saw that in the job log | |
| #openstack-nova - 2025-02-11 | |||
| 04:25:41 | opendevreview | Takashi Kajinami proposed openstack/nova-specs master: tox: Drop envdir https://review.opendev.org/c/openstack/nova-specs/+/941184 | |
| 06:10:08 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 07:09:08 | mikal | sean-k-mooney: I just pushed an updated tempest patch to address review comments, so I guess we have to retry at some point regardless. | |
| 10:22:05 | opendevreview | Vasyl Saienko proposed openstack/nova master: WIP: Implement trunk subports for ironic driver https://review.opendev.org/c/openstack/nova/+/941227 | |
| 13:31:37 | Uggla | vGPU meeting : https://meet.google.com/tek-noky-eca | |
| 14:08:34 | MengyangZhang[m] | <sean-k-mooney> "so we woudl need to have the..." <- understood, just curious in reality when we will see a cloud have hosts on different version of openstack? | |
| 14:14:21 | sean-k-mooney | MengyangZhang[m]: its quite common for larger clouds to do rolling uprgardes potentially over the course of several mantiance window over a period of months | |
| 14:14:52 | sean-k-mooney | i.e. where the operatrion team need to work with the teants to organise outages | |
| 14:15:15 | sean-k-mooney | not all feature in nova allow live migration for example vgpus or pci passthough | |
| 14:15:40 | sean-k-mooney | so depenidng on the constraitnt the admin has they may not be able to upgrade all host ot the same version at once | |
| 14:17:56 | sean-k-mooney | MengyangZhang[m]: https://github.com/openstack/governance/blob/master/resolutions/20220210-release-cadence-adjustment.rst describe the skip level upgrade requirments that all project must support | |
| 14:51:12 | opendevreview | Takashi Kajinami proposed openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619 | |
| 15:30:11 | gmann | bauzas: can you please check this rbac spec, need 2nd +2. I would not be able to attend the meeting, in case it needs to be discussed as feature freeze exception but I think you know the context of it. I started the code change also in parallel https://review.opendev.org/c/openstack/nova-specs/+/937650 | |
| 16:01:09 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:01:09 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:01:09 | opendevmeet | Meeting started Tue Feb 11 16:01:09 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:01:09 | bauzas | #startmeeting nova | |
| 16:01:32 | fwiesel | o/ | |
| 16:01:47 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:53 | sp-bmilanov | hello! | |
| 16:02:06 | elodilles_pto | o/ | |
| 16:02:46 | Uggla | o/ | |
| 16:03:01 | bauzas | I guess we can softly starty | |