Earlier  
Posted Nick Remark
#openstack-nova - 2025-02-10
15:49:44 opendevreview Fabian Wiesel proposed openstack/nova master: WIP: Re-create volume backed root before destroy https://review.opendev.org/c/openstack/nova/+/941095
16:03:40 bauzas good news are that apparently nova-next runs are not really stopped https://zuul.openstack.org/builds?job_name=nova-next&skip=0
16:04:08 sean-k-mooney stopped?
16:04:14 sean-k-mooney by what?
16:04:33 sean-k-mooney oh you saw a few failures
16:04:36 bauzas sean-k-mooney: see my above comment ^
16:05:00 sean-k-mooney MengyangZhang[m]: migration woudl fail in pre-livemigrate
16:05:42 sean-k-mooney actully no it would not
16:06:22 sean-k-mooney MengyangZhang[m]: migrating form an upgraded compute to an non upgraded one will generate the correct config
16:06:33 sean-k-mooney but then if you hard reboot the qos config would be lost
16:07:01 sean-k-mooney so we woudl need to have the migration fail in that case
16:46:34 opendevreview Merged openstack/nova master: api: Allow min/max_version arguments to response https://review.opendev.org/c/openstack/nova/+/936364
16:46:40 opendevreview Merged openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377
18:50:18 mikal Was there a zuul outage yesterday or something? CI doesn't seem to have run on https://review.opendev.org/c/openstack/nova/+/924844 after about 10 hours.
19:23:02 sean-k-mooney there was yesterday at some point i think
19:23:11 sean-k-mooney not today that im aware of
19:27:44 sean-k-mooney mikal: it looks like the last buidl for that was https://zuul.openstack.org/buildset/5704a9aeddb44126966dad2b267a6263
19:28:03 sean-k-mooney so around "2025-02-09 00:09:08"
19:29:30 sean-k-mooney mikal: i see your recheck from 30 mins ago but i dont see anyign in zuul for that
19:30:20 sean-k-mooney i wonder is there a merge confligt with the depends on agaisnt my patch
19:32:06 mikal Yeah, I did that recheck because I couldn't find any evidence that zuul had actually run a check on the latest patchset.
19:32:55 mikal That recheck did cause the vmware test to run at least, but I agree I can't see anything in zuul.
19:33:04 sean-k-mooney let me rebase my patch quickly
19:33:28 sean-k-mooney v4 is not based on teh latest verion of its parent https://review.opendev.org/c/openstack/nova/+/940873/4
19:33:43 mikal I fixed a typo in one of yours to remove a stray pep8 error in my test results. I wonder if that is the problem?>
19:33:52 opendevreview sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873
19:34:32 sean-k-mooney maybe, when you did that you did not update the follow up patch which is the one your referncing
19:34:53 mikal Yeah, I did it quickly in the web UI and didn't really think it through...
19:35:32 sean-k-mooney ok now its running
19:35:46 sean-k-mooney that was all that was wrong it seams
19:36:24 sean-k-mooney https://zuul.openstack.org/status?change=924844
19:36:27 mikal Oh nice. Thank you.
19:36:56 mikal gmann left some comments on the tempest patch, so I'll address those today now that I have a test run to observe.
19:37:18 sean-k-mooney ya i clicked into it but didnt look at the code yet
19:38:13 sean-k-mooney i dont think ether of the issues will prevent the test form running but the feedback maskes sense
19:38:49 sean-k-mooney at least with my almost 0 knowladge of tempest convetions if gmann says it shoudl be done a certin way i tend to agree :)
19:39:16 mikal I see your zero knowledge and raise you negative knowledge!
19:39:24 mikal I just cargo culted the previous VNC test.
19:41:08 sean-k-mooney well you actully implemnted part fo the spice handshake it seams
19:41:25 sean-k-mooney so you proably deserve more credit then your giving yourself
19:42:20 mikal Heh. Well yeah, the scaffolding is all cargo culted. The SPICE protocol bit was a cut and paste from the Kerbside code and some tweaks.
19:42:54 JayF good artists borrow; great artists steal :)
19:43:18 mikal Heh
19:43:34 mikal sean-k-mooney: has there been any more discussion of an os-traits release? I think that blocks the other patchset for now.
19:44:45 sean-k-mooney are the traits patches merged
19:45:17 gmann sean-k-mooney: commented in devstack change to enable tempest cofig option also, https://review.opendev.org/c/openstack/devstack/+/940838
19:45:55 sean-k-mooney https://review.opendev.org/c/openstack/os-traits/+/940418
19:46:06 sean-k-mooney gmann: did you see my nova job changes?
19:46:26 gmann sean-k-mooney this one? https://review.opendev.org/c/openstack/nova/+/940873
19:46:38 sean-k-mooney yep
19:47:02 gmann yeah, but that does not set tempest config
19:47:07 sean-k-mooney so that is what enabled the testing in the nova check pipelien
19:47:23 sean-k-mooney right so ill update devstack with the change you susggeted
19:47:30 gmann either you can set tempest option also in job or better is devstack set it based on nova configuration
19:47:38 sean-k-mooney i was orginling thinkign of configuring that in the job as a followup
19:47:48 gmann i see
19:47:56 sean-k-mooney but im fine with devstack
19:48:12 gmann that will be easy if we want to test it in more jobs or so
19:49:32 sean-k-mooney sure so i dont neesisaly want to kick the current run out of the gate on the other hand the job has not started yet its still queue
19:49:55 sean-k-mooney so will i just do it now or do it after the current execution completes so we have one test run?
19:50:10 sean-k-mooney i guess in its current state it wont run the new test
19:50:20 sean-k-mooney so its proably better to update devstack now
19:50:24 gmann yeah
19:51:02 gmann at least to merge the tempest tests (which is almost ready), we need to see test running somewhere.
19:52:02 sean-k-mooney yep, do you have an example of how we set this in devstack normally
19:52:11 sean-k-mooney is it in lib/tempest or lib/nova
19:52:28 mikal sean-k-mooney: no, the os-traits change hasn't seen any more review recently.
19:52:48 sean-k-mooney ah found it
19:53:15 gmann sean-k-mooney: here https://github.com/openstack/devstack/blob/master/lib/tempest#L417
19:53:50 gmann sean-k-mooney: you can add both condition 'is_service_enabled n-spice || [ "$NOVA_SPICE_ENABLED" != False ]' there same as how nova is configuring
19:55:04 sean-k-mooney ... whitespace https://review.opendev.org/c/openstack/devstack/+/940838/3/lib/tempest
19:55:42 sean-k-mooney so i need ot update that again anyway, i can do that if you liek but tempest is normmaly only installed on the contoler where the spice/serial proxy runs
19:56:02 gmann sean-k-mooney: I think you should add "$NOVA_SPICE_ENABLED" != False also like done in lib/nova
19:56:15 sean-k-mooney if i add || [ "$NOVA_SPICE_ENABLED" != False ]
19:56:21 sean-k-mooney will it break on the compute
19:56:31 sean-k-mooney on i guess tempet wont be enabeld on the compute
19:56:40 sean-k-mooney and if it was then it would be correct to do this ther too
19:56:44 sean-k-mooney ok ya ill fix that
19:59:19 sean-k-mooney gmann: ok https://review.opendev.org/c/openstack/devstack/+/940838 should work i think
20:00:09 gmann sean-k-mooney: yup. looks good
20:00:23 sean-k-mooney ok ill recheck mikal patch then to get a run with that enabled
20:00:35 sean-k-mooney once i find the tab...
20:01:19 sean-k-mooney cool its running again
20:02:30 gmann thanks
20:03:18 sean-k-mooney 39 itmes in check, my guess is we will have results in about 3 hours, maybe 2 if we get lucky with ci capsity
20:04:28 sean-k-mooney mikal: feel free to recheck or update any or my patches as needed. ill proably finish in the ned 30 mins or so
20:47:45 opendevreview Sylvain Bauza proposed openstack/nova master: Fix verifying all the alloc requests from a multi-create https://review.opendev.org/c/openstack/nova/+/846786
21:09:43 mikal sean-k-mooney: no worries, thanks yet again.
21:10:34 sean-k-mooney its runnng tempet by the way
21:10:59 sean-k-mooney we are just waiting for it to report back now so my estimate is off it will be doen in less then an hour form now maybe 20 mins
21:11:10 sean-k-mooney i also never finish when i intened too...
21:18:42 sean-k-mooney mikal: ... 2025-02-10 21:14:19.686874 | controller | {3} setUpClass (tempest.api.compute.servers.test_spice.SpiceDirectConsoleTestJSON) ... SKIPPED: SPICE console feature is disabled.
21:19:03 sean-k-mooney so either i messed up this ran with an old verison of the devstack plugin
21:19:20 sean-k-mooney lets let is complete and we can check what is wrong
21:19:40 sean-k-mooney its still runing temepst i just saw that in the job log
#openstack-nova - 2025-02-11
04:25:41 opendevreview Takashi Kajinami proposed openstack/nova-specs master: tox: Drop envdir https://review.opendev.org/c/openstack/nova-specs/+/941184
06:10:08 opendevreview Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649
07:09:08 mikal sean-k-mooney: I just pushed an updated tempest patch to address review comments, so I guess we have to retry at some point regardless.
10:22:05 opendevreview Vasyl Saienko proposed openstack/nova master: WIP: Implement trunk subports for ironic driver https://review.opendev.org/c/openstack/nova/+/941227
13:31:37 Uggla vGPU meeting : https://meet.google.com/tek-noky-eca

Earlier   Later