| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-29 | |||
| 18:55:11 | sean-k-mooney | mel mention you can remvoe the scheme here https://review.opendev.org/c/openstack/nova/+/924844/comment/bcfe7166_8d9bb51c/ | |
| 18:56:16 | sean-k-mooney | mikal: i think all the other comments were adress looking over them quickly | |
| 18:56:36 | mikal | Yeah honestly I thought I'd addressed them all but I definitely missed that one. | |
| 18:57:01 | sean-k-mooney | beyond that i dont see anything quickly that i would -1 for | |
| 18:57:22 | sean-k-mooney | i need to finsih reading the release note but i suspect we could proceed ith it as is | |
| 18:57:32 | sean-k-mooney | or adress other issue in a followup | |
| 18:58:07 | mikal | As an aside, I learned the other day that libvirt's equivalent to oVirt VDSM hooks _does_ _not_ allow modifying the domain XML or qemu command line on instance start. There are some times you can change the XML, mostly around live migration, but not for a domain create. | |
| 18:58:14 | sean-k-mooney | oh ya one trivial issue in the release note | |
| 18:58:24 | sean-k-mooney | "spice-direct" shoudl be ``spice-direct`` | |
| 18:58:35 | sean-k-mooney | double backtics to make it bold | |
| 18:58:41 | mikal | I cna fix that now too. | |
| 18:58:41 | sean-k-mooney | btu honstly it fine with quotes | |
| 18:59:07 | sean-k-mooney | same for spice_direct_proxy_base_url | |
| 18:59:08 | mikal | Do you want it bold in the API reelase notes too? | |
| 18:59:34 | sean-k-mooney | you mena the api ref | |
| 18:59:47 | mikal | nova/api/openstack/compute/rest_api_version_history.rst | |
| 19:00:02 | sean-k-mooney | ah the microversion history doc | |
| 19:00:09 | sean-k-mooney | it does not hurt to call it out | |
| 19:00:13 | sean-k-mooney | but up to you | |
| 19:00:24 | sean-k-mooney | i was more commenting on not useing "" for empahsie | |
| 19:00:40 | sean-k-mooney | *emphasis | |
| 19:00:41 | mikal | Ok | |
| 19:02:02 | sean-k-mooney | once that is resovled i think im +2 on the 3 main patches | |
| 19:03:47 | sean-k-mooney | ill try and review the remaing too now while i have context | |
| 19:04:07 | mikal | Thank you. I am in the process of prepping to upload a new version now that address those comments. | |
| 19:08:53 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 20:17:07 | sean-k-mooney | mikal: im just finishing for today. im +2 on the first 3 pathces and -1 for the last two, comments in line | |
| 20:32:08 | mikal | Ok cool, I'll take a look at the comments today. | |
| 23:24:51 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 23:25:48 | mikal | sean-k-mooney: ^--- a first swing at the os-traits change | |
| 23:45:53 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| #openstack-nova - 2025-01-30 | |||
| 00:31:36 | opendevreview | Merged openstack/nova master: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/883411 | |
| 01:06:05 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 06:07:17 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | |
| 08:17:03 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 08:48:35 | ierdem | Hi, how can I live migrate VMs between two different containers? I have environment deployed by using kolla-ansible and some of my compute nodes have rocky containers, some of them have ubuntu. I want to live migrate VMs from Rocky (has higher qemu version and different machine type *_rhel-*) to Ubuntu. Is there any hackish and easy method to do this? (on production) | |
| 08:59:29 | mnasiadka | ierdem: I know people just run rocky version of libvirt container on Ubuntu - but that’s not the solution you are asking for :) | |
| 09:04:31 | ierdem | mnasiadka, yes :) actually we run all containers on Ubuntu too but the problem is difference between nova containers OS releases | |
| 09:15:23 | mikal | sean-k-mooney: I'm still working on the sound traits changes, I haven't even attempted the equivalent changes for the USB controller yet. So I think that os-traits patch is simple and could do with some feedback if possible. When I give up for the day today I'll upload the sound patch so you can decide if I am even on the right track... | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:10:25 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 12:07:57 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add flavor-search-by-name spec https://review.opendev.org/c/openstack/nova-specs/+/940440 | |
| 17:29:11 | ganso | mention of "vfio" in the nova docs for attaching GPU to guests | |
| 17:29:11 | ganso | Hi folks. Given nvidia has dropped support for mdev in their v535+ drivers, what one would have to do to transition from an mdev configuration to a vfio configuration? I've been using mdev and working fine but now with the driver update nothing works anymore. I have installed libvirt 10 but that alone doesn't fix the problem. Does Nova SRIOV support running VGPUs in this mode? What config is necessary to change? I don't see | |
| 18:10:49 | melwitt | ganso: I don't think yet but there is vfio work in progress toward supporting it https://specs.openstack.org/openstack/nova-specs/specs/2025.1/index.html | |
| 18:15:04 | ganso | melwitt: I saw that spec but I thought it was specific to "variant drivers" (I am not familiar with that). If not, then basically the new nvidia drivers rendered the GPUs completely incompatible with OpenStack Nova until that spec is implemented? | |
| 18:19:26 | melwitt | ganso: I'm not familiar with it either (and not an expert in vgpu) but IIUC that work is needed as a prereq toward supporting sriov vgpu. bauzas would know for sure | |
| 18:57:37 | ganso | melwitt: thanks! let's wait for bauzas to respond | |
| 19:14:17 | mikal | sean-k-mooney: you around today? | |
| 19:29:07 | sean-k-mooney | mikal: sorry sort of. ill be aroudn for a bit longer but them im off until tuesday (pto tomorrow because of public holiday on monday) | |
| 19:30:39 | mikal | sean-k-mooney: ahhh fair enough. I sent an os-traits patch, which I _think_ is correct. I'm arguing with the nova sound patch to integrate it, but I've never done one of these before so I think I'll have missed stuff. I'll move on to the USB one after that. | |
| 19:30:51 | mikal | sean-k-mooney: worst case you'll have some patches to laugh at on Tuesday. | |
| 19:31:47 | sean-k-mooney | i can take a look now | |
| 19:31:58 | sean-k-mooney | im not sure if Uggla has cut the new release yet or not | |
| 19:32:02 | sean-k-mooney | we wanted to do one this week | |
| 19:32:22 | sean-k-mooney | we can always do another one next week if needed | |
| 19:32:54 | sean-k-mooney | so https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 19:33:01 | mikal | Yep, that's it. | |
| 19:33:36 | mikal | I assume I need that released before CI for the nova patch will pass? (Its failing for other reasons now, but presumably that will eventually block me). | |
| 19:33:59 | sean-k-mooney | it will pass in tempest but not unit tests with depends on | |
| 19:34:09 | sean-k-mooney | you could put the traits stuff at the end | |
| 19:34:43 | mikal | Oh, I've been doing the sound one in the sound patch, not in a separate one. | |
| 19:34:49 | mikal | I could separate them if I need to I suppose. | |
| 19:34:53 | sean-k-mooney | mikal: so the patch looks correct to me ill eave a copule of comments to that effect | |
| 19:35:00 | mikal | Thanks. | |
| 19:35:06 | sean-k-mooney | it can be in one pathc it normlaly is | |
| 19:35:11 | mikal | Ok | |
| 19:35:31 | sean-k-mooney | just the unit test will complain ectra if you try and import the constnat | |
| 19:35:50 | mikal | Even with a depends-on? | |
| 19:36:12 | sean-k-mooney | thre are ways to make ti work in unit test but its complex, ya we would have to properly hook up tox siblings and some other stuff | |
| 19:36:31 | sean-k-mooney | bacislly the unit test alwasy pull the libs form pypi | |
| 19:36:37 | mikal | Yeah, that doesn't sound like a good use of time. | |
| 19:36:38 | sean-k-mooney | we woudl need to make the job install them form souce | |
| 19:36:54 | sean-k-mooney | devstack has explcit supprot for this | |
| 19:37:20 | mikal | I am a big concerned about the feature freeze deadline, but not concerned enough to do something like that quite yet. | |
| 19:39:31 | sean-k-mooney | well even if we made it pass we still cant merge it for two reaons one we need to have a release or if anyone tries to use it for real it would break | |
| 19:39:46 | sean-k-mooney | second the depend on will prevent it form merging until the other patch is merged | |
| 19:40:00 | sean-k-mooney | so mechanically it would not speed anything up really | |
| 19:40:05 | sean-k-mooney | maybe slighlty | |
| 19:40:20 | sean-k-mooney | but only by the tiem ti takes to cut a release | |
| 19:40:43 | mikal | Yeah cool. I'll keep working on traits for sound and usb then and hope a release happens in the mean time. | |
| 19:41:15 | mikal | If you've got time for a quick scan of my traits attempt in https://review.opendev.org/c/openstack/nova/+/926126/12 that would be cool, but if you don't that's also fine. | |
| 19:42:40 | sean-k-mooney | i have +2'd the triats patch melwitt if your about care to take a look https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 19:43:42 | sean-k-mooney | mikal: ah https://review.opendev.org/c/openstack/releases/+/940363 merged 6 hours ago | |
| 19:44:10 | mikal | How often do they do those releases? On demand? | |
| 19:44:21 | sean-k-mooney | bauzas: ^ we shoudl plan an os-traits 3.4.0 once we merge mikal's patch | |
| 19:44:34 | sean-k-mooney | mikal: yes on demand | |
| 19:44:40 | melwitt | sean-k-mooney: not sure I can do a useful review. what are the sources for the list enums? i.e. where do they come from | |
| 19:45:01 | sean-k-mooney | libvirt models. i was debating if we shoudl add the links | |
| 19:45:18 | sean-k-mooney | i decied nto to bring that up but since you asked | |
| 19:45:20 | mikal | Links to the domain XML docs? | |
| 19:45:33 | sean-k-mooney | https://libvirt.org/formatdomain.html#sound-devices | |
| 19:45:53 | sean-k-mooney | mikal: ya we sometime link to the libvirt docs or other refences | |