| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-29 | |||
| 15:37:12 | kpdev | let me check internally as you are saying its not then in scope of nova to address. | |
| 15:43:07 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 16:26:06 | melwitt | sean-k-mooney: hey I just read your comment on the power management patch. are you saying that you think we should not be offlining CPU for STOPPED instances? | |
| 17:35:36 | opendevreview | Masahito Muroi proposed openstack/nova master: Use defaultdict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | |
| 17:43:47 | opendevreview | Masahito Muroi proposed openstack/nova master: Use defaultdict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | |
| 17:45:42 | masahito | gibi sean-k-mooney: thank you for the review for the patch. I did the further investigation for the current response value pattern. Please check the result and document update, too. https://review.opendev.org/c/openstack/nova/+/939658 | |
| 18:47:00 | mikal | sean-k-mooney: I think you're saying you just want the changes to that file that you commented on removed? Is that right? | |
| 18:47:30 | sean-k-mooney | so im unsure | |
| 18:47:56 | sean-k-mooney | mikal: melwitt made a comment that that api was remvoed in 2.6 | |
| 18:48:01 | mikal | sean-k-mooney: IIRC Mel was confused by an old removed API and in the end I didn't need to do anything. I am trying to reload state on that file at the moment. | |
| 18:48:03 | sean-k-mooney | so we shoudl not need to update it | |
| 18:48:37 | sean-k-mooney | and as a result we likely dont need that addtional validation schema | |
| 18:48:51 | mikal | sean-k-mooney: yeah, Mel wanted a test for the HTTP GET on that API, which was removed. | |
| 18:49:06 | sean-k-mooney | because if you were to use the 2.5 microversion it shoudl not return the new spice console anyway | |
| 18:49:30 | sean-k-mooney | so it was removed in a micorversion but we did not remove the functionaltiy | |
| 18:49:51 | sean-k-mooney | if we did the funciton woudl be returnign a 410 | |
| 18:50:06 | melwitt | this sounds familiar and maybe I forgot to reply (and don't remember at the moment) | |
| 18:50:30 | sean-k-mooney | melwitt: context is i started reviewing mikal spice console serise again yesterday | |
| 18:50:39 | sean-k-mooney | and noticed your comment did not seam to be adressed | |
| 18:51:18 | mikal | So I can revert the changes to that file. Honestly I'm not across the validation stuff much, but if you think that's correct I believe you. | |
| 18:51:25 | melwitt | ok, I'll take a look | |
| 18:52:22 | mikal | sean-k-mooney: I'm just removing the validation for the HTTP GET right, not the POST? | |
| 18:52:24 | sean-k-mooney | mikal: i think you can revert the changes to that file and also remove the other changes melwitt mention in ps 18 | |
| 18:52:47 | sean-k-mooney | i would also need ot load context | |
| 18:52:56 | sean-k-mooney | im looking for the patch now | |
| 18:53:21 | sean-k-mooney | ok so https://review.opendev.org/c/openstack/nova/+/924844/24/nova/api/openstack/compute/remote_consoles.py | |
| 18:53:51 | sean-k-mooney | so the changes to create are correct | |
| 18:54:22 | sean-k-mooney | schema.get_spice_console_v298 is not needed and the changes to get_spice_console can be reverted | |
| 18:54:25 | mikal | Ok, doing that now. | |
| 18:55:11 | sean-k-mooney | mel mention you can remvoe the scheme here https://review.opendev.org/c/openstack/nova/+/924844/comment/bcfe7166_8d9bb51c/ | |
| 18:56:16 | sean-k-mooney | mikal: i think all the other comments were adress looking over them quickly | |
| 18:56:36 | mikal | Yeah honestly I thought I'd addressed them all but I definitely missed that one. | |
| 18:57:01 | sean-k-mooney | beyond that i dont see anything quickly that i would -1 for | |
| 18:57:22 | sean-k-mooney | i need to finsih reading the release note but i suspect we could proceed ith it as is | |
| 18:57:32 | sean-k-mooney | or adress other issue in a followup | |
| 18:58:07 | mikal | As an aside, I learned the other day that libvirt's equivalent to oVirt VDSM hooks _does_ _not_ allow modifying the domain XML or qemu command line on instance start. There are some times you can change the XML, mostly around live migration, but not for a domain create. | |
| 18:58:14 | sean-k-mooney | oh ya one trivial issue in the release note | |
| 18:58:24 | sean-k-mooney | "spice-direct" shoudl be ``spice-direct`` | |
| 18:58:35 | sean-k-mooney | double backtics to make it bold | |
| 18:58:41 | mikal | I cna fix that now too. | |
| 18:58:41 | sean-k-mooney | btu honstly it fine with quotes | |
| 18:59:07 | sean-k-mooney | same for spice_direct_proxy_base_url | |
| 18:59:08 | mikal | Do you want it bold in the API reelase notes too? | |
| 18:59:34 | sean-k-mooney | you mena the api ref | |
| 18:59:47 | mikal | nova/api/openstack/compute/rest_api_version_history.rst | |
| 19:00:02 | sean-k-mooney | ah the microversion history doc | |
| 19:00:09 | sean-k-mooney | it does not hurt to call it out | |
| 19:00:13 | sean-k-mooney | but up to you | |
| 19:00:24 | sean-k-mooney | i was more commenting on not useing "" for empahsie | |
| 19:00:40 | sean-k-mooney | *emphasis | |
| 19:00:41 | mikal | Ok | |
| 19:02:02 | sean-k-mooney | once that is resovled i think im +2 on the 3 main patches | |
| 19:03:47 | sean-k-mooney | ill try and review the remaing too now while i have context | |
| 19:04:07 | mikal | Thank you. I am in the process of prepping to upload a new version now that address those comments. | |
| 19:08:53 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 20:17:07 | sean-k-mooney | mikal: im just finishing for today. im +2 on the first 3 pathces and -1 for the last two, comments in line | |
| 20:32:08 | mikal | Ok cool, I'll take a look at the comments today. | |
| 23:24:51 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 23:25:48 | mikal | sean-k-mooney: ^--- a first swing at the os-traits change | |
| 23:45:53 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| #openstack-nova - 2025-01-30 | |||
| 00:31:36 | opendevreview | Merged openstack/nova master: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/883411 | |
| 01:06:05 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 06:07:17 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | |
| 08:17:03 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 08:48:35 | ierdem | Hi, how can I live migrate VMs between two different containers? I have environment deployed by using kolla-ansible and some of my compute nodes have rocky containers, some of them have ubuntu. I want to live migrate VMs from Rocky (has higher qemu version and different machine type *_rhel-*) to Ubuntu. Is there any hackish and easy method to do this? (on production) | |
| 08:59:29 | mnasiadka | ierdem: I know people just run rocky version of libvirt container on Ubuntu - but that’s not the solution you are asking for :) | |
| 09:04:31 | ierdem | mnasiadka, yes :) actually we run all containers on Ubuntu too but the problem is difference between nova containers OS releases | |
| 09:15:23 | mikal | sean-k-mooney: I'm still working on the sound traits changes, I haven't even attempted the equivalent changes for the USB controller yet. So I think that os-traits patch is simple and could do with some feedback if possible. When I give up for the day today I'll upload the sound patch so you can decide if I am even on the right track... | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:10:25 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 12:07:57 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add flavor-search-by-name spec https://review.opendev.org/c/openstack/nova-specs/+/940440 | |
| 17:29:11 | ganso | mention of "vfio" in the nova docs for attaching GPU to guests | |
| 17:29:11 | ganso | Hi folks. Given nvidia has dropped support for mdev in their v535+ drivers, what one would have to do to transition from an mdev configuration to a vfio configuration? I've been using mdev and working fine but now with the driver update nothing works anymore. I have installed libvirt 10 but that alone doesn't fix the problem. Does Nova SRIOV support running VGPUs in this mode? What config is necessary to change? I don't see | |
| 18:10:49 | melwitt | ganso: I don't think yet but there is vfio work in progress toward supporting it https://specs.openstack.org/openstack/nova-specs/specs/2025.1/index.html | |
| 18:15:04 | ganso | melwitt: I saw that spec but I thought it was specific to "variant drivers" (I am not familiar with that). If not, then basically the new nvidia drivers rendered the GPUs completely incompatible with OpenStack Nova until that spec is implemented? | |
| 18:19:26 | melwitt | ganso: I'm not familiar with it either (and not an expert in vgpu) but IIUC that work is needed as a prereq toward supporting sriov vgpu. bauzas would know for sure | |
| 18:57:37 | ganso | melwitt: thanks! let's wait for bauzas to respond | |
| 19:14:17 | mikal | sean-k-mooney: you around today? | |
| 19:29:07 | sean-k-mooney | mikal: sorry sort of. ill be aroudn for a bit longer but them im off until tuesday (pto tomorrow because of public holiday on monday) | |
| 19:30:39 | mikal | sean-k-mooney: ahhh fair enough. I sent an os-traits patch, which I _think_ is correct. I'm arguing with the nova sound patch to integrate it, but I've never done one of these before so I think I'll have missed stuff. I'll move on to the USB one after that. | |
| 19:30:51 | mikal | sean-k-mooney: worst case you'll have some patches to laugh at on Tuesday. | |
| 19:31:47 | sean-k-mooney | i can take a look now | |
| 19:31:58 | sean-k-mooney | im not sure if Uggla has cut the new release yet or not | |
| 19:32:02 | sean-k-mooney | we wanted to do one this week | |
| 19:32:22 | sean-k-mooney | we can always do another one next week if needed | |
| 19:32:54 | sean-k-mooney | so https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 19:33:01 | mikal | Yep, that's it. | |
| 19:33:36 | mikal | I assume I need that released before CI for the nova patch will pass? (Its failing for other reasons now, but presumably that will eventually block me). | |
| 19:33:59 | sean-k-mooney | it will pass in tempest but not unit tests with depends on | |
| 19:34:09 | sean-k-mooney | you could put the traits stuff at the end | |
| 19:34:43 | mikal | Oh, I've been doing the sound one in the sound patch, not in a separate one. | |
| 19:34:49 | mikal | I could separate them if I need to I suppose. | |
| 19:34:53 | sean-k-mooney | mikal: so the patch looks correct to me ill eave a copule of comments to that effect | |