| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-29 | |||
| 15:09:58 | sean-k-mooney | we really shoudl fix that... | |
| 15:10:30 | sean-k-mooney | this is a simple case where mypy and type checking would have saved use. we just mixed up the paramater order | |
| 15:10:57 | sean-k-mooney | johnthetubaguy: if no one else has ocmmend ill loop back and +w next week | |
| 15:11:33 | sean-k-mooney | mikal: looking at https://review.opendev.org/c/openstack/nova/+/924844 melwitt comment form pathset 18 have not been adressed | |
| 15:12:28 | kpdev | hi all, need review on https://review.opendev.org/c/openstack/nova/+/927474 | |
| 15:12:44 | kpdev | I had also mentioned at https://etherpad.opendev.org/p/nova-bug-triage-20240904 | |
| 15:13:09 | sean-k-mooney | mikal: sorry https://review.opendev.org/c/openstack/nova/+/924844/24 | |
| 15:14:01 | sean-k-mooney | mikal: i shoudl slow down https://review.opendev.org/c/openstack/nova/+/924844/24/nova/api/openstack/compute/remote_consoles.py the api change relate to the get_spice_console api that was remvoed in 2.6 | |
| 15:15:22 | sean-k-mooney | kpdev: that change is not valid | |
| 15:17:07 | kpdev | @sean-k-mooney: what is missing ? Can you please reply on pull request ? | |
| 15:17:23 | sean-k-mooney | the bug report is invliad | |
| 15:17:45 | sean-k-mooney | if we were to implemnt what you propsoe it would be a feature with a non tivial upgrade impact | |
| 15:19:54 | sean-k-mooney | kpdev: nova assumes that all cpus can be use by default, if that is not the case you are requried to use the [compute]cpu_shared_set and [compute]cpu_dedicated_set or the legacy [default]vcpu_pin_set to specify which cpu can be used | |
| 15:20:48 | sean-k-mooney | if your host cgroups are configure in such a way as they cannot be assigned to the vm becuase of the cpu_exclisve bit or otherwise and you do not use the provided config option that is not a nova bug | |
| 15:21:55 | kpdev | so you mean, using provided config option there is no need of this PR | |
| 15:22:42 | sean-k-mooney | correct i dont think this change is required if you correctly confire nova via the cpu_share_set | |
| 15:23:29 | sean-k-mooney | nova should not be parssing the cgoup configuration to determin which cpu can be used | |
| 15:23:42 | sean-k-mooney | the the installer shoudl be configuring that via the aviabel options | |
| 15:25:27 | kpdev | ok | |
| 15:26:48 | kpdev | I have added this on bug and update after checking with engineer | |
| 15:32:02 | sean-k-mooney | i have tiraged the bug as opipion, if you stongly feel that the ux should be imporved i think we would need to have a disgin dicussion on how before proceedign with this as a new feature | |
| 15:32:11 | sean-k-mooney | i dont think this is in the scope of nova to adress however | |
| 15:37:12 | kpdev | let me check internally as you are saying its not then in scope of nova to address. | |
| 15:43:07 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 16:26:06 | melwitt | sean-k-mooney: hey I just read your comment on the power management patch. are you saying that you think we should not be offlining CPU for STOPPED instances? | |
| 17:35:36 | opendevreview | Masahito Muroi proposed openstack/nova master: Use defaultdict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | |
| 17:43:47 | opendevreview | Masahito Muroi proposed openstack/nova master: Use defaultdict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | |
| 17:45:42 | masahito | gibi sean-k-mooney: thank you for the review for the patch. I did the further investigation for the current response value pattern. Please check the result and document update, too. https://review.opendev.org/c/openstack/nova/+/939658 | |
| 18:47:00 | mikal | sean-k-mooney: I think you're saying you just want the changes to that file that you commented on removed? Is that right? | |
| 18:47:30 | sean-k-mooney | so im unsure | |
| 18:47:56 | sean-k-mooney | mikal: melwitt made a comment that that api was remvoed in 2.6 | |
| 18:48:01 | mikal | sean-k-mooney: IIRC Mel was confused by an old removed API and in the end I didn't need to do anything. I am trying to reload state on that file at the moment. | |
| 18:48:03 | sean-k-mooney | so we shoudl not need to update it | |
| 18:48:37 | sean-k-mooney | and as a result we likely dont need that addtional validation schema | |
| 18:48:51 | mikal | sean-k-mooney: yeah, Mel wanted a test for the HTTP GET on that API, which was removed. | |
| 18:49:06 | sean-k-mooney | because if you were to use the 2.5 microversion it shoudl not return the new spice console anyway | |
| 18:49:30 | sean-k-mooney | so it was removed in a micorversion but we did not remove the functionaltiy | |
| 18:49:51 | sean-k-mooney | if we did the funciton woudl be returnign a 410 | |
| 18:50:06 | melwitt | this sounds familiar and maybe I forgot to reply (and don't remember at the moment) | |
| 18:50:30 | sean-k-mooney | melwitt: context is i started reviewing mikal spice console serise again yesterday | |
| 18:50:39 | sean-k-mooney | and noticed your comment did not seam to be adressed | |
| 18:51:18 | mikal | So I can revert the changes to that file. Honestly I'm not across the validation stuff much, but if you think that's correct I believe you. | |
| 18:51:25 | melwitt | ok, I'll take a look | |
| 18:52:22 | mikal | sean-k-mooney: I'm just removing the validation for the HTTP GET right, not the POST? | |
| 18:52:24 | sean-k-mooney | mikal: i think you can revert the changes to that file and also remove the other changes melwitt mention in ps 18 | |
| 18:52:47 | sean-k-mooney | i would also need ot load context | |
| 18:52:56 | sean-k-mooney | im looking for the patch now | |
| 18:53:21 | sean-k-mooney | ok so https://review.opendev.org/c/openstack/nova/+/924844/24/nova/api/openstack/compute/remote_consoles.py | |
| 18:53:51 | sean-k-mooney | so the changes to create are correct | |
| 18:54:22 | sean-k-mooney | schema.get_spice_console_v298 is not needed and the changes to get_spice_console can be reverted | |
| 18:54:25 | mikal | Ok, doing that now. | |
| 18:55:11 | sean-k-mooney | mel mention you can remvoe the scheme here https://review.opendev.org/c/openstack/nova/+/924844/comment/bcfe7166_8d9bb51c/ | |
| 18:56:16 | sean-k-mooney | mikal: i think all the other comments were adress looking over them quickly | |
| 18:56:36 | mikal | Yeah honestly I thought I'd addressed them all but I definitely missed that one. | |
| 18:57:01 | sean-k-mooney | beyond that i dont see anything quickly that i would -1 for | |
| 18:57:22 | sean-k-mooney | i need to finsih reading the release note but i suspect we could proceed ith it as is | |
| 18:57:32 | sean-k-mooney | or adress other issue in a followup | |
| 18:58:07 | mikal | As an aside, I learned the other day that libvirt's equivalent to oVirt VDSM hooks _does_ _not_ allow modifying the domain XML or qemu command line on instance start. There are some times you can change the XML, mostly around live migration, but not for a domain create. | |
| 18:58:14 | sean-k-mooney | oh ya one trivial issue in the release note | |
| 18:58:24 | sean-k-mooney | "spice-direct" shoudl be ``spice-direct`` | |
| 18:58:35 | sean-k-mooney | double backtics to make it bold | |
| 18:58:41 | mikal | I cna fix that now too. | |
| 18:58:41 | sean-k-mooney | btu honstly it fine with quotes | |
| 18:59:07 | sean-k-mooney | same for spice_direct_proxy_base_url | |
| 18:59:08 | mikal | Do you want it bold in the API reelase notes too? | |
| 18:59:34 | sean-k-mooney | you mena the api ref | |
| 18:59:47 | mikal | nova/api/openstack/compute/rest_api_version_history.rst | |
| 19:00:02 | sean-k-mooney | ah the microversion history doc | |
| 19:00:09 | sean-k-mooney | it does not hurt to call it out | |
| 19:00:13 | sean-k-mooney | but up to you | |
| 19:00:24 | sean-k-mooney | i was more commenting on not useing "" for empahsie | |
| 19:00:40 | sean-k-mooney | *emphasis | |
| 19:00:41 | mikal | Ok | |
| 19:02:02 | sean-k-mooney | once that is resovled i think im +2 on the 3 main patches | |
| 19:03:47 | sean-k-mooney | ill try and review the remaing too now while i have context | |
| 19:04:07 | mikal | Thank you. I am in the process of prepping to upload a new version now that address those comments. | |
| 19:08:53 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 19:08:54 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 19:08:55 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 20:17:07 | sean-k-mooney | mikal: im just finishing for today. im +2 on the first 3 pathces and -1 for the last two, comments in line | |
| 20:32:08 | mikal | Ok cool, I'll take a look at the comments today. | |
| 23:24:51 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 23:25:48 | mikal | sean-k-mooney: ^--- a first swing at the os-traits change | |
| 23:45:53 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| #openstack-nova - 2025-01-30 | |||
| 00:31:36 | opendevreview | Merged openstack/nova master: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/883411 | |
| 01:06:05 | opendevreview | Michael Still proposed openstack/os-traits master: Add traits for sound and USB devices on instances. https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 06:07:17 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | |
| 08:17:03 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 08:48:35 | ierdem | Hi, how can I live migrate VMs between two different containers? I have environment deployed by using kolla-ansible and some of my compute nodes have rocky containers, some of them have ubuntu. I want to live migrate VMs from Rocky (has higher qemu version and different machine type *_rhel-*) to Ubuntu. Is there any hackish and easy method to do this? (on production) | |
| 08:59:29 | mnasiadka | ierdem: I know people just run rocky version of libvirt container on Ubuntu - but that’s not the solution you are asking for :) | |
| 09:04:31 | ierdem | mnasiadka, yes :) actually we run all containers on Ubuntu too but the problem is difference between nova containers OS releases | |
| 09:15:23 | mikal | sean-k-mooney: I'm still working on the sound traits changes, I haven't even attempted the equivalent changes for the USB controller yet. So I think that os-traits patch is simple and could do with some feedback if possible. When I give up for the day today I'll upload the sound patch so you can decide if I am even on the right track... | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 10:10:23 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 10:10:24 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:10:25 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 12:07:57 | opendevreview | Stephen Finucane proposed openstack/nova-specs master: Add flavor-search-by-name spec https://review.opendev.org/c/openstack/nova-specs/+/940440 | |