| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-28 | |||
| 18:18:38 | sean-k-mooney | oh i dont mind the backport impact its trivial, its just annoying to read when it expand the enum in particalar | |
| 18:19:14 | sean-k-mooney | we are not actully using ruff, at least right now but it might be nice ot add that to our pyproject.toml anyway | |
| 19:19:03 | sean-k-mooney | stephenfin: i belive we have a bug in the openapi schma serise. you are asusmign that project id and user id have to be uuids but as afar as i cna tell looking at keystone and our own code they are not required to eb uuids | |
| 19:22:05 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 19:22:05 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 19:22:06 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 19:22:06 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 19:22:07 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 19:22:22 | mikal | sean-k-mooney: ^--- is a rebase and the tweaked USB controller patch. | |
| 20:11:40 | opendevreview | Merged openstack/nova master: Fix typo in release note https://review.opendev.org/c/openstack/nova/+/935681 | |
| 20:11:50 | opendevreview | Merged openstack/nova stable/2023.2: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/940272 | |
| 22:32:51 | opendevreview | Merged openstack/nova master: zuul: Add missing context comments for nova-next https://review.opendev.org/c/openstack/nova/+/935682 | |
| #openstack-nova - 2025-01-29 | |||
| 02:14:07 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 08:09:37 | opendevreview | Balazs Gibizer proposed openstack/nova-specs master: Extend image-properties-in-server-show spec with rebuild https://review.opendev.org/c/openstack/nova-specs/+/940360 | |
| 08:12:11 | gibi | dansmith, melwitt, sean-k-mooney: thanks for the quick response. Here are the spec update ^^ | |
| 08:17:30 | masahito | gibi: hi, could you review the small bug fixes for the v2.96 or later API bug if you have time? It has been +2ed already so it needs one more W+1. https://review.opendev.org/c/openstack/nova/+/939673 and https://review.opendev.org/c/openstack/nova/+/939658 | |
| 08:21:46 | gibi | masahito: looking... | |
| 08:48:42 | gibi | masahito: I've approved the reproducer and left some API concerns in the fix. We probably need other cores to express opinion about the API impact. | |
| 08:49:03 | gibi | sean-k-mooney: ^^ | |
| 09:33:22 | masahito | gibi: thanks for the quick review :) | |
| 09:34:00 | mikal | sean-k-mooney: that SPICE patch series has now been updated and passes CI. | |
| 09:57:37 | opendevreview | Mark Goddard proposed openstack/nova master: ironic: Let Ironic handle deployment cleanup actions during destroy https://review.opendev.org/c/openstack/nova/+/883411 | |
| 10:02:55 | stephenfin | sean-k-mooney: feck :( | |
| 10:04:12 | stephenfin | sean-k-mooney: Yeah, that checks out. Let me think on it. If you're doing further reviews, maybe just ignore/call out the places I've made those assumption and move on. I'll rejig | |
| 10:05:17 | sean-k-mooney[m] | sure we have merged one already the flavor acess schema | |
| 10:05:23 | sean-k-mooney[m] | we should fix that | |
| 10:05:44 | sean-k-mooney[m] | but there are very few apis that take either a project id or user id | |
| 10:15:10 | stephenfin | sean-k-mooney[m]: Potential proposal. I'm going to drop https://review.opendev.org/c/openstack/nova/+/937013 from the stack and see how clean the rebase is | |
| 10:15:40 | stephenfin | If it's horrific, I might keep it and rejig the commit message to indicate that no, these things aren't UUIDs but they often look like UUIDs so this is a little more realistic?? | |
| 10:16:17 | stephenfin | Hopefully not an issue but I'd _love_ to avoid a multi-hour rebase if possible 😇 | |
| 10:16:17 | sean-k-mooney[m] | sure, i would jsut assert that its a stiring between 1 and 64 printable characters | |
| 10:16:43 | stephenfin | printable or ascii? | |
| 10:16:51 | stephenfin | *alphanumeric | |
| 10:17:08 | stephenfin | (if you know off the top of your head) | |
| 10:17:25 | sean-k-mooney[m] | you can look at the keystone def its effectivly base64 | |
| 10:17:31 | sean-k-mooney[m] | i think | |
| 10:17:55 | sean-k-mooney[m] | alphanumeric and _ perhaps - | |
| 10:18:14 | sean-k-mooney[m] | i dont recall exactly but a subset of ascii | |
| 10:19:39 | sean-k-mooney[m] | stephenfin: https://github.com/openstack/keystone/blob/master/keystone/api/validation/parameter_types.py#L67-L73 | |
| 10:21:40 | stephenfin | ideal, copy-paste job so | |
| 10:39:39 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server topology API https://review.opendev.org/c/openstack/nova/+/940300 | |
| 10:53:57 | frickler | well this is more explicit, so likely for domains the full answer is "UUID4 without dashes or 'default'"? https://opendev.org/openstack/keystone/src/branch/master/keystone/resource/schema.py#L249 | |
| 10:54:46 | sean-k-mooney | frickler: domain are not used in any nova api | |
| 10:54:55 | sean-k-mooney | project and user ids are and have different rules | |
| 10:55:43 | frickler | ah, ok | |
| 10:56:00 | sean-k-mooney | frickler: user ids for federated keystone are the first 64 bytes of the sha256 of the user objects fields by default btu thte hash is both plugable and configurable | |
| 10:56:50 | sean-k-mooney | frickler: this basically all stems out of the fact that when using ldap/active directory they dont produce uuids for the identifer | |
| 10:57:07 | sean-k-mooney | so orginally keystone pass that through directly | |
| 10:57:31 | sean-k-mooney | the sql backend that most use does produced the hex dump of a uuid4 | |
| 10:59:50 | sean-k-mooney | its one of those things where it will almost alwasy be a uuid in practice but in reality we cant depend on that | |
| 11:00:12 | sean-k-mooney | frickler: my real concer is that the sdk or some other code has made the same assumation | |
| 11:04:13 | sean-k-mooney | quick glance says no, they are constucitng fake ides usign uuid4 but prepeending user-id https://github.com/openstack/openstacksdk/blob/c6459ae0b0983530d8db75178bbfe213c8022396/openstack/tests/unit/identity/v3/test_proxy.py#L38 | |
| 11:11:57 | opendevreview | John Garbutt proposed openstack/nova master: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/883411 | |
| 11:17:30 | johnthetubaguy | this in the past): https://review.opendev.org/c/openstack/nova/+/883411 | |
| 11:17:30 | johnthetubaguy | sean-k-mooney: I have reworded the commit message on this old patch, because it is now really urgent. We have a big regression on the Ironic driver after merging those convert to SDK patches, basically we lost the ability to retry on HTTP Conflict for the silly unplug_vif code. This old patch looks to fix the problem. It would be ace if you have chance to review this one please (you added some comments saying you wanted to look at | |
| 11:29:23 | opendevreview | Merged openstack/nova master: Add ServersViewBuilderTestV296 unit test class https://review.opendev.org/c/openstack/nova/+/939673 | |
| 11:32:51 | sean-k-mooney | johnthetubaguy: so retrying on http conflict is not really a thing we shoudl do in general | |
| 11:33:38 | sean-k-mooney | a 409 means the request is invaild for the current state and we shoudl not expect resending it to work | |
| 11:34:54 | sean-k-mooney | johnthetubaguy: with that said i dont crrently have the context of this patch loaded so i will take a look | |
| 11:39:01 | sean-k-mooney | johnthetubaguy: i had previoulys agreed to allow fixign the current sate even thought he ironci workfow violates our driver api | |
| 11:39:30 | johnthetubaguy | [@_oftc_sean-k-mooney:matrix.org](https://matrix.to/#/@_oftc_sean-k-mooney:matrix.org)I agree with you, we should add more retry on conflict back in. But in this specific case, after we retry for around 15-30 mins, what we get is Bad request, and only then we consider the operation complete. Basically when unprovision has succeded, all the other work has already been done for us. | |
| 11:39:34 | sean-k-mooney | so johnthetubaguy with that in mind i assume you have tested this? | |
| 11:40:56 | sean-k-mooney | we do have a greeen ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa but that boot and deelete like 1 instance | |
| 11:41:09 | johnthetubaguy | [@_oftc_sean-k-mooney:matrix.org](https://matrix.to/#/@_oftc_sean-k-mooney:matrix.org)I haven't tested this on master, but it has been running in some old clouds for a while. I haven't heard back if this works on Caracal yet either I am afraid. Just had this reported to me yesterday evening internally. | |
| 11:41:22 | sean-k-mooney | so this obviouly does nto entrily break everythign but it does not validate that the node can be used again | |
| 11:41:49 | sean-k-mooney | johnthetubaguy: ack | |
| 11:42:09 | johnthetubaguy | Sure, but we call unprovison, and that goes into either error or available, let me find that graph a sec in the ironic docs to check. | |
| 11:42:43 | sean-k-mooney | johnthetubaguy: that not really the issue | |
| 11:43:02 | johnthetubaguy | OK, what bit are you worried about? I could easily be missing something? | |
| 11:43:58 | sean-k-mooney | so there are two conferns one is practically does this work which is what you were answering. and i trust you when you say that unprovision will do all the actions that cleanup_deploy does | |
| 11:44:57 | sean-k-mooney | the issue with that is ironic is not allow to modify neturon ports or cinder volume attachments assocated with a nova instnace. so it doing the cleanup as part of unprovision by makign api calls ironic si not allowed to do | |
| 11:45:25 | sean-k-mooney | so long term that is a probelem that shoudl be fixed | |
| 11:46:41 | johnthetubaguy | Ah, I was missing your concern before. Now I see what you mean. It is a “different dance” with Ironic, for sure. And we do hit issues because of the oddities going on there, e.g.: https://bugs.launchpad.net/nova/+bug/2085432 | |
| 11:46:46 | sean-k-mooney | i agreed that we can move forward with the current state. that does not mean the current state is correct. i condier this to just be a workaround | |
| 11:48:45 | sean-k-mooney | johnthetubaguy: well its not jsut that its also this https://security.openstack.org/ossa/OSSA-2023-003.html | |
| 11:49:11 | johnthetubaguy | I mean, this is Nova better respecting Ironic’s API semantics, in my book, but I don’t think we have connects on what we want it to look like. I know Ironic are keen to re-work the networking stack for their standalone cases, and making NGS suck much less would be ace… I should take a look at that soon ish. | |
| 11:50:01 | johnthetubaguy | Ah, so, volumes and Ironic, I mostly hard ignore myself. So that probably is an aspect we need someone to test better. Or at least get some lovely Ironic people to take a look at our reasoning here. | |
| 11:50:31 | sean-k-mooney | form my perspecitve ironci is not allwoed ot make any calls to neutorn or cinder for ports or volumes port are assocated with a nove instance | |
| 11:51:27 | sean-k-mooney | johnthetubaguy: nova does not allow you to add/remove voluvmes or port to/form an instnace via the cidner/neutrion api inluciding createing/modifying volume attachments or port bindings | |
| 11:51:36 | sean-k-mooney | johnthetubaguy: ironic is doign both | |
| 11:51:45 | johnthetubaguy | Yeah, true. | |
| 11:52:53 | sean-k-mooney | so unprovision in ironic should not be cleanign up the neutorn prots ro removing the volume attahcments | |
| 11:53:12 | sean-k-mooney | that shoudl be done by our generic code in the compute manager as part of the instance delete flow | |
| 11:53:51 | sean-k-mooney | johnthetubaguy: anyway what importnt right now is this is impacting actual users | |
| 11:54:05 | sean-k-mooney | so we need to do the best we can in the current state | |
| 11:54:37 | sean-k-mooney | but if we have simialr CVEs in the future ironic integation may break | |
| 11:58:36 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hosts APIs https://review.opendev.org/c/openstack/nova/+/937047 | |
| 11:58:37 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (1/3) https://review.opendev.org/c/openstack/nova/+/937245 | |
| 11:58:37 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for instance actions https://review.opendev.org/c/openstack/nova/+/937048 | |
| 11:58:38 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (3/3) https://review.opendev.org/c/openstack/nova/+/937247 | |
| 11:58:38 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (2/3) https://review.opendev.org/c/openstack/nova/+/937246 | |
| 11:58:39 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for remote consoles https://review.opendev.org/c/openstack/nova/+/940114 | |
| 11:58:39 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server IPs APIs https://review.opendev.org/c/openstack/nova/+/937608 | |
| 11:58:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for image metadata APIs https://review.opendev.org/c/openstack/nova/+/940299 | |
| 11:58:40 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | |
| 11:58:42 | opendevreview | Stephen Finucane proposed openstack/nova master: api: project/tenant and user IDs are not UUIDs https://review.opendev.org/c/openstack/nova/+/940369 | |
| 11:58:42 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server topology API https://review.opendev.org/c/openstack/nova/+/940300 | |
| 11:59:54 | sean-k-mooney | johnthetubaguy: anyway +2 | |
| 12:00:48 | sean-k-mooney | johnthetubaguy: there is another ironci change that you might want to take a look at if you feel like doing a review | |
| 12:01:16 | sean-k-mooney | it fixes a regression added in dalmation so you may not have hit it yet | |