| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-27 | |||
| 14:54:57 | sean-k-mooney | by calling https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1441-L1446 | |
| 14:57:05 | sean-k-mooney | although i migh tbe looking at the wrong place | |
| 14:57:20 | sean-k-mooney | i was looking at teh host manager. its fine for it to have just the id | |
| 14:57:42 | sean-k-mooney | its https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L144 that we really care about | |
| 14:58:44 | sean-k-mooney | i suspect its also jsut a dict with the minimal object | |
| 15:00:47 | sean-k-mooney | they are consutcted here https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L790-L827 | |
| 15:01:30 | sean-k-mooney | so the instnace info is populated by https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L880 | |
| 15:02:15 | sean-k-mooney | so unfortunetly it will have a minor db impact to lookup taht data instead of just the uuid | |
| 15:04:35 | artom | Uggla, since you mentioned doing the os-traits release, the TPM traits patch is pending: https://review.opendev.org/c/openstack/os-traits/+/940191 | |
| 15:08:01 | bauzas | sean-k-mooney: you know what ? we could just say that it could have some db performance if we use the weigher, but fwiw, my change for moment doesn't default to use this weigher | |
| 15:08:12 | bauzas | so let's discuss this on the review then | |
| 15:12:54 | sean-k-mooney | sure, we have 2 options as far as i see, 1 lazy load if you enable the weigher, 2 perload the filed either based on the weigher multipler or a new config | |
| 15:13:09 | sean-k-mooney | *feild | |
| 15:13:36 | sean-k-mooney | in either case you are opting in to the schdulelr memory/db overhead | |
| 15:13:57 | sean-k-mooney | so there is no impact for existign deployment which wont use it by default | |
| 15:14:49 | sean-k-mooney | im happy to disscuss that more in the review, as long as we document the impact im not stongly pushed one way or another althgouh i would tend to prefer not lazyloading | |
| 15:15:18 | sean-k-mooney | bauzas: what you could do is have a folloup patch POCing the preloading in the host_manager | |
| 15:15:52 | sean-k-mooney | at the end fo the day that is an indepented patch form my perspective as it does nto actully change the implemtion of the weigher | |
| 15:15:54 | bauzas | sean-k-mooney: we also call the scheduler RPC API when creating an instance | |
| 15:16:11 | bauzas | sean-k-mooney: yes indeed a follow-up patch for that | |
| 15:16:40 | bauzas | or a dependend one, whether other people have some performance concerns | |
| 15:16:49 | bauzas | anyway, thanks | |
| 18:08:30 | bauzas | sean-k-mooney: fwiw, I'm wrapping my head around on how to compare ImageMetaProps fields against system_metadata dict | |
| 18:09:45 | bauzas | this is like comparing apples vs. oranges since the keys are fucking different | |
| 18:11:29 | sean-k-mooney | ya the image meta is sotred in system_metadata with a img_ prefix | |
| 18:11:34 | sean-k-mooney | btu we look at the request spec | |
| 18:11:39 | sean-k-mooney | for the image properties | |
| 18:11:43 | sean-k-mooney | not the host state | |
| 18:11:54 | bauzas | https://paste.opendev.org/show/bX5inHhgIOOmOgSwVxyH/ | |
| 18:12:27 | bauzas | so I need to find a way to compare both | |
| 18:12:41 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L122 | |
| 18:13:15 | sean-k-mooney | bauzas: we have a helper function to get the image props form the system_metadta table i belive | |
| 18:13:20 | sean-k-mooney | let me see if i can find it | |
| 18:13:33 | sean-k-mooney | i think its defiend on the instnace object | |
| 18:13:34 | bauzas | we have a from_dict() helper | |
| 18:13:44 | bauzas | on the ImageMetaProps object | |
| 18:13:54 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L256-L258 | |
| 18:14:06 | bauzas | but some of the keys are not having an 'image_' prefix | |
| 18:14:13 | sean-k-mooney | so instnace.image_meta | |
| 18:15:20 | bauzas | that would work but that's still a lazy-load IIRC | |
| 18:15:26 | bauzas | anyway, thnaks | |
| 18:16:46 | priteau | Could Nova cores please approve this backport? https://review.opendev.org/c/openstack/nova/+/939695 | |
| 18:17:20 | sean-k-mooney | ah the 2024.2 version is merged | |
| 18:17:21 | bauzas | priteau: done | |
| 18:17:22 | sean-k-mooney | sure | |
| 18:18:08 | sean-k-mooney | priteau: +2w | |
| 18:18:30 | priteau | Thank you both! | |
| 18:18:36 | sean-k-mooney | priteau: once thats merged feel free to ping us for the 2023.2 version | |
| 18:20:44 | priteau | I deployed a downstream backport on 2023.1 today, for a customer that has been suffering from this issue (mostly on a couple of hypervisors that were hosting around 50 VMs each), it appears to be helping so far. | |
| 18:34:14 | mikal | sean-k-mooney: if you're still around, are you ok with the plan to just drop everything except the two xhci USB controllers from that final SPICE patch? We can always add the others back if someone genuinely does need an ancient controller, although it would be a bit like someone asking for IDE support. | |
| 18:38:32 | sean-k-mooney | im ok with that yes. it just means limiting the allowed values of the image property | |
| 18:38:57 | sean-k-mooney | so we can alwyas extend the enuma if there is a reason to do so | |
| 18:40:39 | sean-k-mooney | mikal: as your aware nova is nto a virtualisation plathform its ment to be a cloud computing serivice so we dont have to, and generally shoudl not expose every possibel value supproted by any given hypervior, we shoudl make an informed choice | |
| 18:42:22 | sean-k-mooney | mikal: the usb over ip spec https://review.opendev.org/c/openstack/nova-specs/+/920687/7/specs/2024.2/approved/usb-over-ip.rst#132 from shadow play also wanted to sue qemu-xhci | |
| 18:42:36 | mikal | w we got here. | |
| 18:42:36 | mikal | sean-k-mooney: yeah that's pretty much my take too -- adding enum entries is cheap, and the other controllers are inefficient and don't support USB3. I think we _should_ keep qemu-xhci and nec-xhci, just in case we encounter someone who can't install the qemu drivers (bootstrapping them on windows is sometimes fiddly). I'll make that change, limit the port count, and leave a comment in the enum explaining ho | |
| 18:48:41 | mikal | sean-k-mooney: hmmm, that spec doesn't cover the maximum port count thing though. I guess it was only thought of later. | |
| 18:49:12 | mikal | sean-k-mooney: also, the relevant qemu maintainer agrees with us: https://www.kraxel.org/blog/2018/08/qemu-usb-tips/ | |
| 21:13:00 | opendevreview | Merged openstack/nova stable/2024.1: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939695 | |
| 21:17:43 | opendevreview | Pierre Riteau proposed openstack/nova stable/2023.2: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/940272 | |
| #openstack-nova - 2025-01-28 | |||
| 03:00:04 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 07:25:28 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 12:24:08 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server topology API https://review.opendev.org/c/openstack/nova/+/940300 | |
| 12:24:08 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for image metadata APIs https://review.opendev.org/c/openstack/nova/+/940299 | |
| 13:48:24 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | |
| 13:48:24 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/939643 | |
| 14:35:23 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 15:27:33 | stephenfin | gmann: sean-k-mooney: Would I be able to ask for another burst through those OpenAPI patches in the next few days? I suspect this is going to drag into a third release, but I'd really like there not to be fourth and I still have quite a few patches to push beyond what's there | |
| 15:45:02 | sean-k-mooney | i can try | |
| 16:00:27 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:27 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:27 | opendevmeet | Meeting started Tue Jan 28 16:00:27 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:27 | bauzas | #startmeeting nova | |
| 16:01:16 | fwiesel | o/ | |
| 16:01:22 | masahito | o/ | |
| 16:01:23 | r-taketn | o/ | |
| 16:01:25 | sean-k-mooney | o/ | |
| 16:01:45 | gibi | o/ | |
| 16:03:07 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:03:46 | bauzas | I guess we can softly start | |
| 16:04:20 | bauzas | #topic Bugs (stuck/critical) | |
| 16:04:33 | bauzas | #info No Critical bug | |
| 16:05:25 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:05:47 | masahito | hi, question for the bug roster activity. | |
| 16:05:53 | bauzas | any othre sure | |
| 16:06:10 | masahito | Is it bug triage activity newly reported? | |
| 16:07:08 | bauzas | we stopped looking at the non triaged bugs, as unfortunately there were no longer any volunteers :( | |
| 16:07:39 | bauzas | and it takes a large hit to triage those new bugs, given 2 of 3 are more configuration problems than real bugs :( | |
| 16:08:18 | Uggla | o/ | |
| 16:08:30 | sean-k-mooney | ocationally we will still look and triage some | |
| 16:08:50 | sean-k-mooney | but its now mostly async or based on pings form folks on irc or teh mailign list | |
| 16:09:05 | bauzas | this indeed | |
| 16:09:09 | masahito | I got the situation. | |
| 16:09:21 | sean-k-mooney | we still use the bug tracker but we are not doing tirage weekly in thei meeting | |
| 16:09:30 | sean-k-mooney | if you have issue you can however bring them up here | |
| 16:10:30 | masahito | we hit some bugs in the v2.96 API and started to report and to fix it. Let me bring it up here or the bug triage roaster. | |
| 16:11:11 | masahito | I try to check other bugs as well for the triage if possible. | |
| 16:12:04 | masahito | ping on irc is sometime difficult for us because of time difference. The bug roster activity sounds nice :) | |
| 16:12:07 | masahito | thank you. | |
| 16:12:57 | bauzas | masahito: what you can do is to add your patches in the tracking etherpad, we'll look over them | |