| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-24 | |||
| 14:35:41 | sean-k-mooney | ya so if you not adding db calls, but decisde to use a dict or caluate the value with omething other then a set that is ok | |
| 14:35:41 | bauzas | okay, I see, you provided some high level algorithm for calculating the weigh by intersecting sets | |
| 14:36:15 | bauzas | sets are interesting because they come with batteries for calculating the intersects or the joined elemenbts | |
| 14:36:27 | sean-k-mooney | the set approch should be fast yes and that^ | |
| 14:36:28 | bauzas | so your idea sounds good to me | |
| 14:36:44 | bauzas | ok, now I better understand, thanks | |
| 14:36:54 | bauzas | and thanks for the idea | |
| 14:37:38 | sean-k-mooney | no worries. i likely wont get to it today but if you have a poc that you want me to look at ping me when its pushed | |
| 14:38:06 | opendevreview | Masahito Muroi proposed openstack/nova master: Add managed='no' flag to a guest xml definition https://review.opendev.org/c/openstack/nova/+/940135 | |
| 14:38:29 | sean-k-mooney | am ... | |
| 14:39:56 | sean-k-mooney | oh that is seprate form the pci thing | |
| 14:50:13 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | |
| #openstack-nova - 2025-01-25 | |||
| 02:11:06 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 05:48:52 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 12:41:06 | opendevreview | Artom Lifshitz proposed openstack/os-traits master: Add vTPM secret policy traits https://review.opendev.org/c/openstack/os-traits/+/940191 | |
| 17:32:05 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194 | |
| 17:32:05 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771 | |
| 17:32:06 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 17:32:06 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 17:32:07 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| #openstack-nova - 2025-01-26 | |||
| 01:47:52 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 01:47:52 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194 | |
| 01:47:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 01:47:53 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 01:47:54 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771 | |
| 15:24:12 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 15:24:13 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 15:24:13 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 15:24:14 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771 | |
| #openstack-nova - 2025-01-27 | |||
| 03:08:43 | opendevreview | Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/940225 | |
| 03:10:46 | opendevreview | Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/937587 | |
| 03:26:06 | opendevreview | Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/937587 | |
| 10:57:41 | priteau | Hello Nova team. Could another core approve this backport? https://review.opendev.org/c/openstack/nova/+/939665 | |
| 11:01:26 | gibi | priteau: done, thanks for backporting | |
| 12:20:45 | opendevreview | Biser Milanov proposed openstack/nova master: StorPool: Pass the instance UUID and device_name to os-brick https://review.opendev.org/c/openstack/nova/+/930297 | |
| 13:14:58 | opendevreview | Merged openstack/nova stable/2024.2: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939665 | |
| 13:19:08 | opendevreview | Pierre Riteau proposed openstack/nova stable/2024.1: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939695 | |
| 13:21:21 | priteau | Thank you gibi. The Caracal backport is also ready to review ^ | |
| 13:29:34 | opendevreview | Biser Milanov proposed openstack/nova master: StorPool: Pass the instance UUID and device_name to os-brick https://review.opendev.org/c/openstack/nova/+/930297 | |
| 14:44:29 | bauzas | sean-k-mooney: hrmmm, looks like system_metadata needs to be lazy-loaded https://paste.opendev.org/show/boOPqY0RzgGM3SYO8k5M/ | |
| 14:45:16 | bauzas | sean-k-mooney: context being https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-07-16.01.log.html#l-86 | |
| 14:45:18 | sean-k-mooney | bauzas: it depend where. its in the default filed so it should be loaded by default unless you change that | |
| 14:45:44 | bauzas | sean-k-mooney: I tested on the HostState.instances value | |
| 14:46:31 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L69-L71 | |
| 14:47:18 | sean-k-mooney | maybe we are not using that for what i tought we were | |
| 14:50:07 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L875-L896 | |
| 14:50:52 | sean-k-mooney | so it looks like we are building fake instance object wiht only the uuid set | |
| 14:52:28 | sean-k-mooney | bauzas: do you have track_instance_changes enabled | |
| 14:53:23 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 14:54:05 | bauzas | sean-k-mooney: yes indeed, but I'll doublecheck | |
| 14:54:42 | sean-k-mooney | bauzas: what we likely need to do is repalce the call to just get the uuid and expiclty get the uuid and system metadata as teh only requested fieds | |
| 14:54:57 | sean-k-mooney | by calling https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1441-L1446 | |
| 14:57:05 | sean-k-mooney | although i migh tbe looking at the wrong place | |
| 14:57:20 | sean-k-mooney | i was looking at teh host manager. its fine for it to have just the id | |
| 14:57:42 | sean-k-mooney | its https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L144 that we really care about | |
| 14:58:44 | sean-k-mooney | i suspect its also jsut a dict with the minimal object | |
| 15:00:47 | sean-k-mooney | they are consutcted here https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L790-L827 | |
| 15:01:30 | sean-k-mooney | so the instnace info is populated by https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L880 | |
| 15:02:15 | sean-k-mooney | so unfortunetly it will have a minor db impact to lookup taht data instead of just the uuid | |
| 15:04:35 | artom | Uggla, since you mentioned doing the os-traits release, the TPM traits patch is pending: https://review.opendev.org/c/openstack/os-traits/+/940191 | |
| 15:08:01 | bauzas | sean-k-mooney: you know what ? we could just say that it could have some db performance if we use the weigher, but fwiw, my change for moment doesn't default to use this weigher | |
| 15:08:12 | bauzas | so let's discuss this on the review then | |
| 15:12:54 | sean-k-mooney | sure, we have 2 options as far as i see, 1 lazy load if you enable the weigher, 2 perload the filed either based on the weigher multipler or a new config | |
| 15:13:09 | sean-k-mooney | *feild | |
| 15:13:36 | sean-k-mooney | in either case you are opting in to the schdulelr memory/db overhead | |
| 15:13:57 | sean-k-mooney | so there is no impact for existign deployment which wont use it by default | |
| 15:14:49 | sean-k-mooney | im happy to disscuss that more in the review, as long as we document the impact im not stongly pushed one way or another althgouh i would tend to prefer not lazyloading | |
| 15:15:18 | sean-k-mooney | bauzas: what you could do is have a folloup patch POCing the preloading in the host_manager | |
| 15:15:52 | sean-k-mooney | at the end fo the day that is an indepented patch form my perspective as it does nto actully change the implemtion of the weigher | |
| 15:15:54 | bauzas | sean-k-mooney: we also call the scheduler RPC API when creating an instance | |
| 15:16:11 | bauzas | sean-k-mooney: yes indeed a follow-up patch for that | |
| 15:16:40 | bauzas | or a dependend one, whether other people have some performance concerns | |
| 15:16:49 | bauzas | anyway, thanks | |
| 18:08:30 | bauzas | sean-k-mooney: fwiw, I'm wrapping my head around on how to compare ImageMetaProps fields against system_metadata dict | |
| 18:09:45 | bauzas | this is like comparing apples vs. oranges since the keys are fucking different | |
| 18:11:29 | sean-k-mooney | ya the image meta is sotred in system_metadata with a img_ prefix | |
| 18:11:34 | sean-k-mooney | btu we look at the request spec | |
| 18:11:39 | sean-k-mooney | for the image properties | |
| 18:11:43 | sean-k-mooney | not the host state | |
| 18:11:54 | bauzas | https://paste.opendev.org/show/bX5inHhgIOOmOgSwVxyH/ | |
| 18:12:27 | bauzas | so I need to find a way to compare both | |
| 18:12:41 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L122 | |
| 18:13:15 | sean-k-mooney | bauzas: we have a helper function to get the image props form the system_metadta table i belive | |
| 18:13:20 | sean-k-mooney | let me see if i can find it | |
| 18:13:33 | sean-k-mooney | i think its defiend on the instnace object | |
| 18:13:34 | bauzas | we have a from_dict() helper | |
| 18:13:44 | bauzas | on the ImageMetaProps object | |
| 18:13:54 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L256-L258 | |
| 18:14:06 | bauzas | but some of the keys are not having an 'image_' prefix | |
| 18:14:13 | sean-k-mooney | so instnace.image_meta | |
| 18:15:20 | bauzas | that would work but that's still a lazy-load IIRC | |
| 18:15:26 | bauzas | anyway, thnaks | |
| 18:16:46 | priteau | Could Nova cores please approve this backport? https://review.opendev.org/c/openstack/nova/+/939695 | |
| 18:17:20 | sean-k-mooney | ah the 2024.2 version is merged | |
| 18:17:21 | bauzas | priteau: done | |
| 18:17:22 | sean-k-mooney | sure | |
| 18:18:08 | sean-k-mooney | priteau: +2w | |
| 18:18:30 | priteau | Thank you both! | |
| 18:18:36 | sean-k-mooney | priteau: once thats merged feel free to ping us for the 2023.2 version | |
| 18:20:44 | priteau | I deployed a downstream backport on 2023.1 today, for a customer that has been suffering from this issue (mostly on a couple of hypervisors that were hosting around 50 VMs each), it appears to be helping so far. | |