Earlier  
Posted Nick Remark
#openstack-nova - 2025-01-22
19:56:29 sean-k-mooney mikal: i run my windows gaming pc in a vm
19:56:34 sean-k-mooney mikal: and it has
19:56:36 sean-k-mooney <controller type="usb" index="0" model="qemu-xhci" ports="15">
19:56:38 sean-k-mooney <address type="pci" domain="0x0000" bus="0x02" slot="0x00" function="0x0"/>
19:56:40 sean-k-mooney </controller>
19:57:12 mikal Yeah, there is some ovirt code I'm reading which seems to change the controller type based on guest OS, but if qemu-xhci works for Linux and modern Windows I think we're good to go.
19:57:35 sean-k-mooney i may have installed virtio drivers for it but that was the default model that virt-manager selected
19:59:06 sean-k-mooney it worked fine when i was passhtihg though a phsical mouse and keyboard to the vm
19:59:22 sean-k-mooney again i dont recall if installed a dirver but i dont think i had to
20:00:11 mikal I think https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java#L79 is effectively saying that RHEL 6 and 7 need nec-xhci but maybe nothing else? I still need to find the code which does that thing, instead of the test which tests it.
20:00:20 mikal But Java is not a thing I've read in quite a while now...
20:00:49 mikal I need to wander off for now, but I will keep poking at this and let you know if I find anything interesting.
#openstack-nova - 2025-01-23
04:22:31 opendevreview ChungWon Lee proposed openstack/nova master: Reduce node build fail value by time https://review.opendev.org/c/openstack/nova/+/939929
05:11:31 opendevreview ChungWon Lee proposed openstack/nova master: Reduce node build fail value by time https://review.opendev.org/c/openstack/nova/+/939929
07:25:51 opendevreview benlei proposed openstack/nova master: Abort live migration task when stop nova compute service https://review.opendev.org/c/openstack/nova/+/938223
07:26:13 opendevreview Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933
08:37:30 opendevreview James Page proposed openstack/nova master: Restore nova.virt.__init__ https://review.opendev.org/c/openstack/nova/+/939827
09:09:10 gibi bauzas: when you are up this seems to be important ^^ and needs a second core
09:18:55 bauzas gibi: noted
09:20:53 gibi thanks
09:22:46 ratailor gibi, sean-k-mooney artom_ bauzas could you please review https://review.opendev.org/c/openstack/nova/+/939649 and provide your initial feedback on approach.
09:40:39 gibi ratailor: did a quick review on the patch, see my comments inline
09:41:01 ratailor gibi, ack. Thanks!
10:48:57 opendevreview Pavlo Shchelokovskyy proposed openstack/nova master: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/909611
13:23:44 opendevreview Merged openstack/nova master: Restore nova.virt.__init__ https://review.opendev.org/c/openstack/nova/+/939827
16:23:18 opendevreview Kaloyan Kotlarski proposed openstack/nova master: libvirt: Fetch the available vCPUs from the respective cgroup https://review.opendev.org/c/openstack/nova/+/927474
18:20:35 opendevreview melanie witt proposed openstack/nova master: tests: Functional reproducer for bug 2088831 https://review.opendev.org/c/openstack/nova/+/935565
19:59:00 opendevreview Tobias Urdin proposed openstack/nova master: Remove libvirt tunnelled migration https://review.opendev.org/c/openstack/nova/+/879021
19:59:13 opendevreview Tobias Urdin proposed openstack/nova master: Remove libvirt tunnelled migration https://review.opendev.org/c/openstack/nova/+/879021
#openstack-nova - 2025-01-24
06:48:28 masanori Hello. I have created this bug fix: https://review.opendev.org/c/openstack/nova/+/936910 Could you please review it when you have time. > gibi, stephenfin or anyone :) This fixes the process to get the image's metadata from instance.image_meta instead of request_spec.image during resize.
10:11:09 stephenfin sean-k-mooney: Would you be able to take a look at https://review.opendev.org/c/openstack/nova/+/937377/ today?
10:18:15 opendevreview Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to response https://review.opendev.org/c/openstack/nova/+/936364
10:18:15 opendevreview Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to expected_errors https://review.opendev.org/c/openstack/nova/+/936363
10:18:16 opendevreview Stephen Finucane proposed openstack/nova master: api: Adjust validation helpers for a single-method future https://review.opendev.org/c/openstack/nova/+/936365
10:18:16 opendevreview Stephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377
10:18:17 opendevreview Stephen Finucane proposed openstack/nova master: api: Add new, simpler api_version decorator https://review.opendev.org/c/openstack/nova/+/936367
10:18:17 opendevreview Stephen Finucane proposed openstack/nova master: api: Stop using wsgi.Controller.api_version to switch between API versions https://review.opendev.org/c/openstack/nova/+/936366
10:18:18 opendevreview Stephen Finucane proposed openstack/nova master: api: Only run format checks on strings https://review.opendev.org/c/openstack/nova/+/936368
10:18:19 opendevreview Stephen Finucane proposed openstack/nova master: tests: Ensure all APIs have a response body schema https://review.opendev.org/c/openstack/nova/+/924598
10:18:19 opendevreview Stephen Finucane proposed openstack/nova master: api: Simplify parameter types https://review.opendev.org/c/openstack/nova/+/936369
10:18:21 opendevreview Stephen Finucane proposed openstack/nova master: tests: Use UUIDs in TestOpenStackClient https://review.opendev.org/c/openstack/nova/+/937013
10:18:21 opendevreview Stephen Finucane proposed openstack/nova master: doc: Add missing API samples https://review.opendev.org/c/openstack/nova/+/937012
10:18:23 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for instance actions https://review.opendev.org/c/openstack/nova/+/937048
10:18:23 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hosts APIs https://review.opendev.org/c/openstack/nova/+/937047
10:18:25 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (2/3) https://review.opendev.org/c/openstack/nova/+/937246
10:18:25 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (1/3) https://review.opendev.org/c/openstack/nova/+/937245
10:18:27 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server IPs APIs https://review.opendev.org/c/openstack/nova/+/937608
10:18:27 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (3/3) https://review.opendev.org/c/openstack/nova/+/937247
10:18:29 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115
10:18:29 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for remote consoles https://review.opendev.org/c/openstack/nova/+/940114
14:24:42 bauzas sean-k-mooney: reading your whiteboard comment on https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher
14:24:55 bauzas sean-k-mooney: are we clear that I *need* to create those sets ,
14:24:57 bauzas ?
14:29:15 sean-k-mooney can you repahse that
14:29:31 sean-k-mooney they dont already exist but they are trivial to construct from the data you have
14:29:55 sean-k-mooney i was trying to descibe the algorithum i would use and its the one i would have documented in a spec if we were to have had a spec
14:31:42 sean-k-mooney are you askign are free to come up with an entirly diffent design? from my perspecitve i was agreeing to treat this treat it as a specless blueprint on the understadign that you would implemnt the design in the whiteboard but if you ahve a diffent approch i can review it
14:33:14 sean-k-mooney bauzas: if ^ is not what you were asking can you restate the question
14:33:19 bauzas nevermind, your answers are fine
14:33:40 bauzas sean-k-mooney: your whiteboard description looked confusing to me
14:33:53 bauzas but OK, fair enough, your response helped me
14:34:17 sean-k-mooney well the clip notes version is score = common_props / total_props
14:34:55 sean-k-mooney the rest was just defining how to count the common and total sets
14:34:59 bauzas so, yeah, I'll lookup the instances flavor field for generating the sets and as as we discussed https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-07-16.01.log.html#l-86 we avoid a DB lookup call
14:35:41 sean-k-mooney ya so if you not adding db calls, but decisde to use a dict or caluate the value with omething other then a set that is ok
14:35:41 bauzas okay, I see, you provided some high level algorithm for calculating the weigh by intersecting sets
14:36:15 bauzas sets are interesting because they come with batteries for calculating the intersects or the joined elemenbts
14:36:27 sean-k-mooney the set approch should be fast yes and that^
14:36:28 bauzas so your idea sounds good to me
14:36:44 bauzas ok, now I better understand, thanks
14:36:54 bauzas and thanks for the idea
14:37:38 sean-k-mooney no worries. i likely wont get to it today but if you have a poc that you want me to look at ping me when its pushed
14:38:06 opendevreview Masahito Muroi proposed openstack/nova master: Add managed='no' flag to a guest xml definition https://review.opendev.org/c/openstack/nova/+/940135
14:38:29 sean-k-mooney am ...
14:39:56 sean-k-mooney oh that is seprate form the pci thing
14:50:13 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115
#openstack-nova - 2025-01-25
02:11:06 opendevreview melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926
05:48:52 opendevreview melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926
12:41:06 opendevreview Artom Lifshitz proposed openstack/os-traits master: Add vTPM secret policy traits https://review.opendev.org/c/openstack/os-traits/+/940191
17:32:05 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194
17:32:05 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771
17:32:06 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196
17:32:06 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195
17:32:07 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197
#openstack-nova - 2025-01-26
01:47:52 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195
01:47:52 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194
01:47:53 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197
01:47:53 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196
01:47:54 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771
15:24:12 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195
15:24:13 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197
15:24:13 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196
15:24:14 opendevreview Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771
#openstack-nova - 2025-01-27
03:08:43 opendevreview Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/940225
03:10:46 opendevreview Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/937587
03:26:06 opendevreview Masanori Kuroha proposed openstack/nova-specs master: Allow only one custom trait with the same prefix in provider.yaml https://review.opendev.org/c/openstack/nova-specs/+/937587
10:57:41 priteau Hello Nova team. Could another core approve this backport? https://review.opendev.org/c/openstack/nova/+/939665
11:01:26 gibi priteau: done, thanks for backporting
12:20:45 opendevreview Biser Milanov proposed openstack/nova master: StorPool: Pass the instance UUID and device_name to os-brick https://review.opendev.org/c/openstack/nova/+/930297
13:14:58 opendevreview Merged openstack/nova stable/2024.2: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939665

Earlier   Later