| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-15 | |||
| 16:32:00 | sean-k-mooney | i have not hit that but you coudl work around it by doing a local rebase agaisnt master before doing "git revew" | |
| 16:32:13 | sean-k-mooney | for what its worth we do nto allow merge commits to be part of a review | |
| 16:33:13 | sean-k-mooney | i have git version 2.46.0 | |
| 16:33:20 | sean-k-mooney | so your version is not that old | |
| 16:33:24 | JayF | I've absolutely used git review w/git 2.39.2 at some point, I think it's unlikely to be that | |
| 16:33:33 | JayF | sean-k-mooney may have id'd the issue -- if there are any merge commits in your push | |
| 16:34:15 | sean-k-mooney | you probaly dont want pull.rebase=merges in your git cofnig either | |
| 16:35:33 | sean-k-mooney | i woudl set that to pull.rebase=true | |
| 16:35:42 | sean-k-mooney | or just unset it to get the default behvior | |
| 16:38:53 | MengyangZhang[m] | ``` | |
| 16:38:53 | MengyangZhang[m] | Thanks for the help! So i did a local rebase agains master and tried git review again but still same error | |
| 16:39:10 | MengyangZhang[m] | Current branch mzhang-branch is up to date. | |
| 16:39:10 | MengyangZhang[m] | git rebase master | |
| 16:39:10 | MengyangZhang[m] | * Thanks for the help! So i did a local rebase agains master and tried git review again but still same error | |
| 16:42:05 | JayF | Look at the git config changes that Sean suggested, perhaps? | |
| 16:43:41 | sean-k-mooney | so you shoudl do it like this | |
| 16:43:47 | sean-k-mooney | git fetch --all | |
| 16:43:56 | sean-k-mooney | git rebase -i gerrit/master | |
| 16:44:00 | sean-k-mooney | git review | |
| 16:44:29 | sean-k-mooney | if your local master is behind origin or gerrit master there may be a remote merge conflict that you are not seeing | |
| 16:47:02 | sean-k-mooney | JayF: ill see if i can find time to push a ptch to add teh if check later but i need to step away for a bit, this is the bug https://github.com/eventlet/eventlet/issues/1014 | |
| 16:54:38 | JayF | sean-k-mooney: sounds like Itamar agrees with our suggested fix, will work on it soon :) | |
| 16:55:35 | sean-k-mooney | oh awsome | |
| 16:56:29 | sean-k-mooney | im going to try hackign it in locally to confirm that it does nto fail later but that woudl be good if they had time | |
| 16:59:38 | JayF | it's a good fix regardless of if it resolves the watcher issue | |
| 16:59:46 | JayF | but hopefully it cleans up both | |
| 18:16:12 | opendevreview | ribaudr proposed openstack/nova-specs master: Fix a line that was not removed before merging the specification https://review.opendev.org/c/openstack/nova-specs/+/939380 | |
| 21:19:03 | opendevreview | Dmitriy Chubinidze proposed openstack/nova master: Correct description for AggregateMultiTenancyIsolation. https://review.opendev.org/c/openstack/nova/+/939398 | |
| 21:36:22 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939310 | |
| 23:37:29 | opendevreview | melanie witt proposed openstack/nova master: libvirt pwr mgmt: reproduce bug 2085122 https://review.opendev.org/c/openstack/nova/+/932922 | |
| 23:37:30 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| #openstack-nova - 2025-01-16 | |||
| 00:42:53 | opendevreview | Merged openstack/nova master: Improve heal_instance_info_cache periodic https://review.opendev.org/c/openstack/nova/+/935858 | |
| 02:18:16 | opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 03:16:11 | opendevreview | suiong ng proposed openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | |
| 03:32:02 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939310 | |
| 04:01:10 | opendevreview | suiong ng proposed openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | |
| 09:48:51 | opendevreview | Merged openstack/nova master: Revert "libvirt: Wrap un-proxied listDevices() and listAllDevices()" https://review.opendev.org/c/openstack/nova/+/939262 | |
| 14:12:25 | gibi | bauzas: when you are aroun I'm +2 on https://review.opendev.org/c/openstack/os-traits/+/939264 . If you can approve it then Uggla can quickly propose a new os-traits release and we can start bumping the min version in nova | |
| 14:13:31 | bauzas | gibi: cool, I'll look | |
| 14:19:49 | opendevreview | Bogdan Dobrelya proposed openstack/nova master: Run nova-next without periodic cache healing https://review.opendev.org/c/openstack/nova/+/939453 | |
| 14:23:08 | opendevreview | Merged openstack/nova-specs master: Fix a line that was not removed before merging the specification https://review.opendev.org/c/openstack/nova-specs/+/939380 | |
| 14:24:53 | opendevreview | Merged openstack/os-traits master: Add 'HW_PCI_LIVE_MIGRATABLE' https://review.opendev.org/c/openstack/os-traits/+/939264 | |
| 15:04:08 | gibi | Uggla: ^^ you can propose a os-traits release now :) | |
| 17:08:33 | Uggla | gibi, yep I will do that. | |
| 17:46:14 | melwitt | sean-k-mooney, stephenfin: fyi the revert of the libvirt tpool proxy patch merged and I have reproposed the patch with unit tests added here https://review.opendev.org/c/openstack/nova/+/939317 if you might have a chance to re-review at your convenience | |
| 17:46:28 | stephenfin | already done | |
| 17:46:44 | melwitt | thanks stephenfin | |
| 17:47:04 | sean-k-mooney | cool ill take a look shortly | |
| 17:47:23 | sean-k-mooney | im runnging the funtional test locally and my laptop is a littel laggy right now | |
| 17:48:17 | melwitt | thanks stephenfin | |
| 17:48:21 | melwitt | argh | |
| 17:48:23 | melwitt | thanks sean-k-mooney | |
| 17:49:04 | sean-k-mooney | load average of 20 oin 8cores.16 thread... its fine.... | |
| 17:49:46 | sean-k-mooney | 22, the fact its going up is definally not an issue, nope nope nope :) | |
| 18:06:36 | melwitt | 😳 | |
| 18:08:25 | opendevreview | sean mooney proposed openstack/nova master: disable the heal instance info cache periodic https://review.opendev.org/c/openstack/nova/+/939476 | |
| 18:10:48 | sean-k-mooney | melwitt: two questions, since we are redoing https://review.opendev.org/c/openstack/nova/+/939317 do we want a release note too? second question is i have readded +2 but do we want to wait for dan to review before +w | |
| 18:11:40 | sean-k-mooney | melwitt: there isnt anything required of the operator so we dont technially need a release not i was just wondering if you think its important enough to call out as a fixes note or not | |
| 18:15:42 | sean-k-mooney | the upstream bug does not have an improants set althoguh the downstream ones you linked seam to be high/medium | |
| 18:15:55 | sean-k-mooney | so it might be worth callign out its up to you however | |
| 18:16:36 | melwitt | sean-k-mooney: hm, I hadn't considered that. I'm not sure how commonly people hit the issue but if they do hit it, I would consider it a pretty significant issue and worth a reno. and yeah probably a good idea to have dansmith look at it before +Wing | |
| 18:17:19 | dansmith | yeah it's probably worth one because if people don't know why their stuff is locking up, they're not going to be looking for something specific | |
| 18:17:46 | dansmith | since these tend to hang us in the middle of something that doesn't go into the logs as "about to do something that might hang, if so, check like 123 in the file" | |
| 18:18:43 | melwitt | makes sense. I'll write one up and push an update | |
| 18:49:26 | artom | dansmith, remind me, what was your patch that enabled direct LUN passthrough? | |
| 18:49:44 | artom | (What I really want to know is in what release it went out, but I can figure that out on my own if I know the patch | |
| 18:49:46 | artom | ) | |
| 18:49:58 | artom | Is it https://review.opendev.org/c/openstack/nova/+/918089? | |
| 18:50:06 | sean-k-mooney | there are two patches | |
| 18:50:29 | sean-k-mooney | but that is one of them | |
| 18:50:35 | dansmith | yeah that's the second one I think | |
| 18:50:59 | sean-k-mooney | you can see them in the serice https://review.opendev.org/c/openstack/nova/+/918470/2 is the other | |
| 18:51:30 | sean-k-mooney | this depend on another serise however | |
| 18:51:42 | sean-k-mooney | which was the device alisa feature | |
| 18:52:08 | sean-k-mooney | https://review.opendev.org/q/topic:%22bp/libvirt-dev-alias%22 | |
| 18:53:07 | sean-k-mooney | @artom: tldr the lun type cant have a serial embeded os we need to be able to detach/attach volumes based on the alias instead | |
| 18:53:24 | artom | I remember the alias -> direct LUN passthrough dependency chain | |
| 18:53:49 | artom | This is just to answer an email internally - tl;dr, it's not in our released product yet | |
| 18:54:02 | sean-k-mooney | correct | |
| 19:03:17 | sean-k-mooney | the detach via alias change set was considred an upstream freature to use the new libvirt api, that merged in 2024.1(caracal) the lun type suport is considered a bugfix and was merged in 2024.2 dalmatin | |
| 19:03:29 | sean-k-mooney | so tha tcould be backported ot caracal upstream if really wanted | |
| 19:13:52 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939317 | |
| 19:18:19 | gmann | bauzas: hi, can you check this, let me know exactly where (ML or meeting) I need to propose exception if needed https://review.opendev.org/c/openstack/nova-specs/+/937650 | |
| 19:24:21 | opendevreview | sean mooney proposed openstack/nova master: disable the heal instance info cache periodic https://review.opendev.org/c/openstack/nova/+/939476 | |
| 19:49:22 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939490 | |
| 20:13:28 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939310 | |
| 20:15:27 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939490 | |
| 20:26:30 | opendevreview | Mengyang Zhang proposed openstack/nova-specs master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova-specs/+/932653 | |
| 20:43:19 | opendevreview | Mengyang Zhang proposed openstack/nova-specs master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova-specs/+/932653 | |
| #openstack-nova - 2025-01-17 | |||
| 11:08:12 | opendevreview | Stephen Finucane proposed openstack/nova master: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/939317 | |
| 13:54:48 | gibi | folks, what is a good way to change a multinode zuul job (nova-next) to have a different placement config than default? I cannot just set vars:devstack_local_conf as that fails as it tries to be applied on all nodes and computes has no placement service. Setting it is a group-vars that controller only does not work either as then I lose what is already set via vars. | |
| 13:54:56 | gibi | context https://review.opendev.org/c/openstack/nova/+/937275 | |
| 13:55:48 | gibi | do I need to duplicate the settings from vars to group-vars? | |
| 13:56:18 | dougszu | Has anyone seen ephemeral volumes corrupted after a VM is migrated? I see Nova create the filesystem on the backing disk file during instance create, but then regenerate the backing disk on the destination HV. It leads to the UUID changing in the backing disk file, and the VM sees the filesystem as corrupted (for a subset of filesystems which are good spotting the anomaly). | |
| 13:56:50 | dougszu | *good at spotting | |
| 13:57:02 | dougszu | happy to create a bug and work on it, if there isn't something already | |
| 14:04:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275 | |
| 14:20:29 | sean-k-mooney | gibi: so i can think of a few hacks but i tought we fixed this in the past | |
| 14:21:05 | sean-k-mooney | gibi: there was a patch propsoed before to make sure hta tbefore the post-config code ran it would do a make -p on the partent path | |
| 14:21:50 | sean-k-mooney | the hack is in the devstack_local_conf section you could jsut add that | |