| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-07 | |||
| 16:15:09 | elodilles | that's all about stable branches from me | |
| 16:15:29 | bauzas | cool | |
| 16:15:47 | bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | |
| 16:16:04 | bauzas | fwiesel: heya, happy new year too | |
| 16:16:05 | fwiesel | Hi, happy new year. No updates from my side. | |
| 16:16:08 | bauzas | ++ | |
| 16:16:18 | bauzas | #topic Open discussion | |
| 16:16:38 | bauzas | one item in the agenda, quite on time given thursday's deadline | |
| 16:16:46 | bauzas | (bauzas) Specless approval for https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher ? | |
| 16:17:06 | bauzas | tl;dr: I'm hereby asking for an exception to write a spec | |
| 16:17:22 | bauzas | this is just a weigher, we have everything we already need | |
| 16:17:41 | bauzas | in the past, some filters and weighers required a spec, some others not | |
| 16:18:02 | bauzas | so I'm leaning towards asking you to grant this blueprint as it is | |
| 16:18:17 | gibi | bauzas: fine by me to have it specless | |
| 16:22:09 | bauzas | tbc, we have Instance objects in the HostState | |
| 16:23:27 | sean-k-mooney | we do | |
| 16:23:39 | sean-k-mooney | for affinity/anti affintiy filters | |
| 16:23:48 | sean-k-mooney | and a sa result the weigher have them too for the same reason | |
| 16:24:19 | bauzas | the weigher design will be 'lookup at each of the instances from the host, see their imagemeta from the instance and compare with the request' | |
| 16:24:20 | sean-k-mooney | and the instance objects have teh image metadata avaialable | |
| 16:24:33 | sean-k-mooney | the only concern is is that lazy loaded today or not | |
| 16:24:42 | bauzas | the instances list ? | |
| 16:24:48 | sean-k-mooney | not the instnace list | |
| 16:25:10 | sean-k-mooney | the image metadta which is construction form the cached copy in teh instance_system_metadata table | |
| 16:25:22 | sean-k-mooney | i dont know if we load that in the host manager | |
| 16:25:32 | sean-k-mooney | we proably do just wanted ot call that out | |
| 16:25:39 | bauzas | ah good point | |
| 16:26:12 | bauzas | we can't load that later | |
| 16:26:20 | bauzas | as we're on the scheduler | |
| 16:26:33 | bauzas | or we need to target the cell db | |
| 16:26:34 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L70-L71 | |
| 16:26:46 | sean-k-mooney | we are good the instnace system metadta is in teh defalt fields | |
| 16:26:58 | sean-k-mooney | so we have that already | |
| 16:27:29 | bauzas | excellenbt | |
| 16:27:34 | bauzas | thanks for checking | |
| 16:27:46 | bauzas | are we then ok with the design ? | |
| 16:28:05 | sean-k-mooney | i think so. i capture dmost of my feedback inthe blueprint already | |
| 16:28:29 | sean-k-mooney | so im more or less ok with proceedign to the implemenation reivew based on that design | |
| 16:29:35 | bauzas | ++ | |
| 16:29:58 | bauzas | okay, then let's approve it as specless | |
| 16:30:14 | bauzas | #approved https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher approved as specless | |
| 16:30:20 | bauzas | doh | |
| 16:30:35 | bauzas | #agreed https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher approved as specless | |
| 16:30:39 | bauzas | that was it for me | |
| 16:30:44 | bauzas | anything else to mention ? | |
| 16:30:51 | sean-k-mooney | if there is time/enerty i have one topic | |
| 16:31:09 | bauzas | I don't have energy but we have time | |
| 16:31:36 | sean-k-mooney | https://blueprints.launchpad.net/nova/+spec/host-discovery-distributed-lock | |
| 16:31:57 | sean-k-mooney | we talked about this at the ptg | |
| 16:32:06 | sean-k-mooney | and htere is a related spec https://review.opendev.org/c/openstack/nova-specs/+/936389 | |
| 16:32:27 | sean-k-mooney | tldr they woud like to be able to enabel the discover host periodic on multiple schduler at a time | |
| 16:32:38 | sean-k-mooney | so i dont actully like the proposal as written | |
| 16:32:49 | sean-k-mooney | but i did a short poc of one of the alternitives | |
| 16:32:58 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/938523 | |
| 16:33:15 | sean-k-mooney | i don think this could be a reasonable minor imporvment | |
| 16:33:39 | sean-k-mooney | the change is basically just this https://review.opendev.org/c/openstack/nova/+/938523/2/nova/scheduler/manager.py#113 | |
| 16:34:16 | sean-k-mooney | what i wanted to know is if we took this supper simpler approch of doing leader election in the perodic and returnign if not the leader | |
| 16:34:26 | sean-k-mooney | woudl this be a spec/bluepirnt or bugfix? | |
| 16:35:01 | bauzas | hmmmm | |
| 16:35:06 | sean-k-mooney | im askign becasue of the time constratint for the first two options | |
| 16:35:12 | gibi | it has no API impact so I lean towards specless bp | |
| 16:35:36 | s3rj1k | specless from me if that counts :) | |
| 16:36:08 | sean-k-mooney | s3rj1k: input is always welcome :) | |
| 16:36:25 | gibi | sean-k-mooney: but you can formulate it as a bug as nova allows enabling the periodic in multiple schedulers today | |
| 16:36:27 | s3rj1k | (plus it somewhat covered in alternatives section of mentioned above spec) | |
| 16:36:55 | gibi | sean-k-mooney: without a safety net | |
| 16:37:15 | sean-k-mooney | ya so my perspecitve was. if we are takign the heviry weight approch of adding a distibuted lock manager that needed a spec because its complex and a large change | |
| 16:37:29 | bauzas | can't we just add a config option ? | |
| 16:37:39 | sean-k-mooney | if we do a very very small change to just od best effored leader election it might be a bug | |
| 16:37:45 | bauzas | I understand the reasoning, magically nova will elect a new leader | |
| 16:38:07 | sean-k-mooney | bauzas: we could also and a config opiton yes | |
| 16:38:08 | bauzas | but I'm afraid this periodic could silently run somewhere else without the op noticing it | |
| 16:38:14 | dansmith | omg, DLM? | |
| 16:38:31 | sean-k-mooney | bauzas: so you have to opt into the perodic | |
| 16:38:33 | bauzas | and you know, brainsplits and all the likes happen | |
| 16:38:40 | sean-k-mooney | by settign a config option to specify the interval today | |
| 16:38:51 | bauzas | that's my point | |
| 16:39:02 | sean-k-mooney | so this woudl just be a change to the behaiovr when you opt in | |
| 16:39:04 | bauzas | -1 disables the periodic IIRC | |
| 16:39:15 | sean-k-mooney | yep and i dont want to change that | |
| 16:39:24 | bauzas | but I wouldn't trust python for electing my leader | |
| 16:39:38 | bauzas | particularly the sorted command | |
| 16:39:42 | sean-k-mooney | so today the db enfoces that bad thing dont happen | |
| 16:39:53 | sean-k-mooney | you just get excptions in the log | |
| 16:40:14 | sean-k-mooney | if multiple race that is | |
| 16:40:22 | sean-k-mooney | which is annoying for operators | |
| 16:40:44 | dansmith | if you want to automate host discovery active-active, you can do that yourself with nova-manage and your own DLM right? | |
| 16:40:54 | sean-k-mooney | yes | |
| 16:41:04 | bauzas | yes, that's why I don't like that approach | |
| 16:41:12 | sean-k-mooney | that a pain in k8s however which s3rj1k cares about | |
| 16:41:18 | bauzas | you're considering that DLM is just not needed because sorted exists | |
| 16:41:25 | gibi | definitely having a full DLM in nova just for this is way overkill | |
| 16:41:39 | sean-k-mooney | yep which is why i did no liek the dlm/tooz approch | |
| 16:41:56 | bauzas | the SG API isn't also good at doing live healthchecks | |
| 16:42:19 | bauzas | there could be a reasonable amount in time where nova wouldn't see a node done | |
| 16:42:26 | bauzas | gone* | |
| 16:42:33 | sean-k-mooney | which is fine | |
| 16:42:37 | gibi | today if you run the periodic in multiple schedulers you burn power unnecessarily but you don't break nova DB just get exceptions. | |
| 16:42:48 | sean-k-mooney | we can miss runnign the perodic for a protracted period of time with out bad impacts | |
| 16:43:56 | bauzas | we could just let CONF.scheduler.discover_hosts_in_cells_interval be mutable and leave DLMs to manage nova-scheduler A/Ps instead of us | |