| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-11-20 | |||
| 19:57:29 | melwitt | heh | |
| 19:58:00 | sean-k-mooney | taking a step back | |
| 19:58:09 | sean-k-mooney | we are just talking about validating the config right | |
| 19:58:18 | melwitt | right | |
| 19:58:25 | sean-k-mooney | does oslo allow ues to register a callback for that on the config opt | |
| 19:58:39 | melwitt | hm, dunno but I'll look | |
| 20:01:06 | melwitt | not seeing something like that in https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py | |
| 20:01:32 | sean-k-mooney | so i know we can define our own otp types | |
| 20:01:47 | sean-k-mooney | and for string we have the ablity to provide enum vlaues | |
| 20:02:50 | melwitt | we need dynamic enum (from os-resource-classes standard classes) and a regex for CUSTOM_stuff I think | |
| 20:03:52 | sean-k-mooney | well i was thinking of inheriting form listOpt | |
| 20:04:03 | sean-k-mooney | and just adding the validation | |
| 20:04:18 | sean-k-mooney | basically providing a limitListOPT class | |
| 20:05:23 | melwitt | ah ok | |
| 20:05:47 | melwitt | that sounds interesting. I'll check it out | |
| 20:06:40 | sean-k-mooney | looking at how its implemted fro string | |
| 20:06:43 | sean-k-mooney | https://github.com/openstack/oslo.config/blob/68cefad313bd03522e99b3de95f1786ebea45d4b/oslo_config/types.py#L68 | |
| 20:07:05 | sean-k-mooney | when you create and isntance of the opt you can provide choices (for a enum) or a regex | |
| 20:07:18 | sean-k-mooney | and then the __call__ method actully does the validation | |
| 20:07:37 | melwitt | that's cool | |
| 20:07:39 | sean-k-mooney | and raise a valueError if it invalid | |
| 20:07:47 | sean-k-mooney | https://github.com/openstack/oslo.config/blob/68cefad313bd03522e99b3de95f1786ebea45d4b/oslo_config/types.py#L141-L170 | |
| 20:09:02 | sean-k-mooney | so if you inherited form List your call could call super which would provide a list and you could just loop over all the values and check if they were valid | |
| 20:09:14 | sean-k-mooney | if yes just return the result form the call to super else rais | |
| 20:09:37 | sean-k-mooney | melwitt: im not sure if that is overkill but its doable | |
| 20:10:49 | sean-k-mooney | and it keeps the valdiation in teh config code so thats nice cause it will work for the api the same as everything else | |
| 20:11:00 | sean-k-mooney | anyway o/ | |
| 20:11:05 | melwitt | we could show off pro level oslo.config usage | |
| 20:11:39 | melwitt | thanks for the ideas. seeya tomorrow o/ | |
| 20:56:16 | frickler | sean-k-mooney: sorry if I missed that in scrollback, but https://review.opendev.org/c/openstack/os-vif/+/935653 failed in gate with the error it is supposed to fix, iiuc you wanted to skip that check completely, then? | |
| 20:57:40 | sean-k-mooney[m] | ya i didnt get around to pushing a patch but i was going to make that test skip if the native driver was used | |
| 20:58:14 | sean-k-mooney[m] | i just finished dinner but i can update the patch to do that in a little bit | |
| 20:59:09 | sean-k-mooney[m] | we have 2 drivers ovs-vsctl and the nantive python on. its only the native one that sometimes times out | |
| 21:22:00 | opendevreview | sean mooney proposed openstack/os-vif master: address test stablity under load https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 21:22:12 | sean-k-mooney | frickler: ^ updated to skip | |
| 21:22:48 | sean-k-mooney | the rest of the change is technially not needed but it does not hurt so i kept it | |
| 21:23:42 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 21:24:37 | sean-k-mooney | i rebsased and reappoved ^ on top so hopefuly that will pass and we can merge both soon | |
| 21:27:15 | frickler | thx, will check for results tomorrow | |
| 21:44:18 | opendevreview | Cyril Roelandt proposed openstack/python-novaclient master: Replace glanceclient with openstacksdk https://review.opendev.org/c/openstack/python-novaclient/+/931276 | |
| 21:54:18 | opendevreview | melanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits https://review.opendev.org/c/openstack/nova/+/924110 | |
| 21:56:18 | dansmith | melwitt: why the most recent change? | |
| 21:56:23 | dansmith | did checking the rc not work? | |
| 21:56:33 | dansmith | because if not, that needs fixing I think | |
| 21:56:52 | dansmith | oh I see, you kept the output check without the ... output | |
| 22:11:07 | melwitt | dansmith: yeah :( dumb | |
| 23:54:11 | sean-k-mooney | dansmith: melwitt: https://review.opendev.org/c/openstack/os-vif/+/935653 passed with the test skip woudl one of ye mind reappoving that to unblock the follow up patch which is holding up the oslo requirement bump | |
| #openstack-nova - 2024-11-21 | |||
| 00:08:30 | dansmith | sean-k-mooney: I'm not sure why you added the skip though.. your comment says "I'm not an SME but approved" and then followed up with a skip :) | |
| 01:27:06 | sean-k-mooney | i added the skip because extending the time out to 10 seconds worked in check and failed in gate after 12 seconds... | |
| 01:27:38 | sean-k-mooney | so basically we said fi the longer time out did not work we would skip until we can find a better long term solution. | |
| 01:30:13 | sean-k-mooney | we can leave it till tomorrow, no worries | |
| 01:44:22 | gmann | it seems nova live migration job failing with "openstack server create: error: argument --image: expected one argument" | |
| 01:44:27 | gmann | https://zuul.opendev.org/t/openstack/build/ae91e51ade8147bd8063218f0b88cc12/log/job-output.txt#20779 | |
| 01:44:33 | gmann | anything changed in osc side? | |
| 01:47:08 | gmann | oh, actual error is due to not able to talk to glance. "Failed to contact the endpoint at https://10.210.65.110/image for discovery. Fallback to using that endpoint as the base url." | |
| 01:47:21 | gmann | and image_id is None and so osc error | |
| 02:02:40 | opendevreview | melanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits https://review.opendev.org/c/openstack/nova/+/924110 | |
| 05:19:21 | opendevreview | melanie witt proposed openstack/nova master: Add [quota]unified_limits_resource_(strategy|list) https://review.opendev.org/c/openstack/nova/+/924025 | |
| 06:37:13 | frickler | bauzas: gibi: please have another look at https://review.opendev.org/c/openstack/os-vif/+/935653 , I'd really like to get the whole stack that is blocked by this done this week. and I do think we will also need a fresh os-vif release for that once the two fixes are merged | |
| 06:40:14 | frickler | gmann: if you look further up in the log, devstack already failed while deploying glance. not sure about the root cause for that, though | |
| 08:55:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Improve heal_instance_info_cache periodic https://review.opendev.org/c/openstack/nova/+/935858 | |
| 09:28:36 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 09:28:36 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 09:28:37 | opendevreview | ribaudr proposed openstack/nova master: Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 09:28:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 09:28:38 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 09:28:38 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 09:28:39 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 09:28:40 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 09:28:40 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 09:28:42 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 09:28:42 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 09:28:44 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 09:28:44 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 09:28:46 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 09:28:46 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares https://review.opendev.org/c/openstack/nova/+/860287 | |
| 09:28:48 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 09:28:48 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 09:28:50 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 09:28:50 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 09:28:52 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 09:28:52 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 09:28:54 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 09:28:54 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 09:28:56 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 09:28:56 | opendevreview | ribaudr proposed openstack/nova master: Reports instance events to the DB regarding attaching and detaching a share https://review.opendev.org/c/openstack/nova/+/927088 | |
| 09:28:58 | opendevreview | ribaudr proposed openstack/nova master: Manila shares admin guide documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 09:28:58 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 09:29:00 | opendevreview | ribaudr proposed openstack/nova master: Refactor test_server_shares: Mock in Base Class and trait verification https://review.opendev.org/c/openstack/nova/+/935861 | |
| 11:08:20 | opendevreview | Merged openstack/os-vif master: address test stablity under load https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 11:08:21 | opendevreview | Merged openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 11:55:24 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove empty description field https://review.opendev.org/c/openstack/nova/+/935882 | |
| 12:35:35 | yosef | Hi, what is the best way to renew flavor properties of a created VM? I mean it is copied to a separate table and without down time it is not possible to refresh its contents | |
| 12:35:49 | yosef | if flavor properties is changed | |
| 12:46:10 | sean-k-mooney | yosef: so the short answer is you cant do that by desgin the long answer is the flavor is embeded in 2 diffent dbs. there is a copy in the request_spec in the api db and a copy in the instance_extra table in the cell db | |
| 12:46:44 | sean-k-mooney | the only wasy to update the embeded flaovr in an instance today vai supproted methods is resize | |
| 12:46:59 | sean-k-mooney | once a flavor is used you are not really ment to change any of the extra specs | |
| 12:56:45 | jkulik | We built a nova-manage command for that in our cloud: https://github.com/sapcc/nova/blob/stable/xena-m3/nova/cmd/manage.py#L3207 - reason was that we would have to change properties on flavors and wanted them used on live- and offline migrations to prohibit them from going to hypervisors with a new trait | |
| 12:58:14 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 12:58:14 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |