| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-22 | |||
| 09:11:06 | bauzas | hence the agenda proposal | |
| 09:22:11 | bauzas | gibi: I think we have a serious problem that we need to solve about Wed | |
| 09:41:54 | sean-k-mooney | bauzas: gibi: i dont know if we want to discuss this at the ptg https://bugs.launchpad.net/nova/+bug/2076089 but it would be good if other could confirm or refute my assertion that we shoudl not be abel to force boot a new instance on a disabled compute | |
| 09:42:17 | bauzas | sean-k-mooney: the agenda is now fully packed tbh | |
| 09:42:22 | sean-k-mooney | as far as i am aware we made an intentional decsion to prevent this | |
| 09:42:32 | sean-k-mooney | bauzas: that fine its a bug so we can discuss it async | |
| 09:42:34 | bauzas | the eventlet-removal session just ate all the left time | |
| 09:42:40 | sean-k-mooney | i just want to spread awareness of it | |
| 09:44:02 | sean-k-mooney | im basically asking for a sanity check to ensure im not off base when i say this is not a bug. we can put it on the next team meeting adgenda too if we like | |
| 09:44:09 | bauzas | well | |
| 09:44:22 | bauzas | the forced AZ hack was the usual way for ops to test new computes | |
| 09:44:36 | sean-k-mooney | right but not disabled hosts | |
| 09:44:45 | bauzas | no, even disabled ones | |
| 09:44:56 | sean-k-mooney | that was definetly a bug then | |
| 09:45:09 | sean-k-mooney | i.e that that ever worked | |
| 09:45:21 | bauzas | yeah, for me it looks to me a regression | |
| 09:45:39 | sean-k-mooney | im saying we should not allow that to happen and that i dont condier this a regression | |
| 09:46:01 | sean-k-mooney | if the az hack worked in the past tha that was a bug IMO | |
| 09:46:09 | bauzas | because when you want to verify that your new compute works fine, then you just use the AZ hack for it | |
| 09:46:36 | bauzas | you just make sure that when you create the new compute, it's disabled first | |
| 09:46:54 | sean-k-mooney | your you regerster it as disabeld and add it to a host aggreate restricted to your tenent and then enable it | |
| 09:48:23 | bauzas | hum, no, in general you just disable the host, and then you create new instances using the AZ hack | |
| 09:48:39 | sean-k-mooney | bauzas: the az hack is not ment to force a host bypasssing all schdulign | |
| 09:48:41 | bauzas | once you're sure it works, then you delete the instances and the enable the host, that's it | |
| 09:49:06 | bauzas | sean-k-mooney: trust me, this is why I say this is a hack :) | |
| 09:49:33 | sean-k-mooney | bauzas: right so i object to reintroducing that broken behavior if its what we had in the past | |
| 09:49:39 | sean-k-mooney | as i said i condier it a bug | |
| 09:50:00 | sean-k-mooney | so if we want to fix it i want to be conviced why that is accapable to bypass placment | |
| 09:50:54 | bauzas | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L593 | |
| 09:51:11 | sean-k-mooney | the reporter confirmed the existing behavior (where its rejected) exists as far back as zed | |
| 09:51:18 | sean-k-mooney | meaning that all stable release have the current behavior | |
| 09:52:00 | sean-k-mooney | bauzas: right i have used that in the past but that was nto inteded to ignore if its disabeld. | |
| 09:53:30 | bauzas | that's because the forced host values are not checking the filters | |
| 09:53:46 | bauzas | but... the pre-filters actually check them | |
| 09:53:55 | bauzas | hence the change | |
| 09:53:55 | sean-k-mooney | the prefilters run before the filters | |
| 09:54:00 | bauzas | correct, hence the bug | |
| 09:54:05 | sean-k-mooney | yep a change that was made in train | |
| 09:54:18 | sean-k-mooney | as a result of a spec that was intened to prevent schduling to disable compute | |
| 09:54:31 | sean-k-mooney | to me this was somethign we agree to block as part of the spec | |
| 09:54:40 | sean-k-mooney | so not a bug as a result | |
| 09:56:07 | sean-k-mooney | we also added the ablity to request a host without the az hack in train for what its worth | |
| 09:56:48 | sean-k-mooney | this is the spec https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/pre-filter-disabled-computes.html | |
| 10:01:16 | bauzas | I just think we forgot about this UX... | |
| 10:01:37 | bauzas | and honestly I agree with the solution on https://bugs.launchpad.net/nova/+bug/2076089/comments/1 | |
| 10:02:05 | sean-k-mooney | its possible but i dont think this shoudl be allowed wihtout a new microversion becuase honstely i think that is breaking the meaning of disbaled | |
| 10:02:13 | bauzas | or indeed the workaround is to force live-migrate to the compute | |
| 10:02:20 | sean-k-mooney | we have had this behavior since train | |
| 10:02:33 | sean-k-mooney | so all cloud in produciton should expect this behavior | |
| 10:02:35 | bauzas | I don't see why we need to add a microversion | |
| 10:02:53 | bauzas | because this is only for an admin-only AZ hack value | |
| 10:03:31 | sean-k-mooney | i do because as far as i am concerned disbaled mean you cannot schdule to this under any cuirmsutances | |
| 10:03:52 | sean-k-mooney | so if you are changing the maning of disable by allowitn this we need to have a way to request that explcitly | |
| 10:04:06 | sean-k-mooney | the az hack which is deprecated is not that IMO | |
| 10:04:32 | bauzas | let's then agree to disagree :) | |
| 10:04:38 | sean-k-mooney | if we actully want to supprot this we shoudl have --force or similar which we intentionally removed form other apis | |
| 10:05:19 | sean-k-mooney | well we can but how do we move forward with this bug close it or reintoduce the broken pre train behavior | |
| 10:05:34 | sean-k-mooney | this is why i wanted to add it to the ptg but we can disuss it in next weeks meeitng too | |
| 10:06:00 | bauzas | yeah, let's discuss this then on next tuesday's meeting | |
| 10:07:27 | sean-k-mooney | we have other mandaory prefiletrs too by the way, and we also include required/forbiden triats in other ways uncondtionally | |
| 10:07:47 | sean-k-mooney | so fundementally you cant ignore the placement filtering the way you coudl before placemnt | |
| 11:22:52 | opendevreview | sean mooney proposed openstack/nova master: Fix detaching devices by alias with mdevs https://review.opendev.org/c/openstack/nova/+/932931 | |
| 11:23:11 | sean-k-mooney | gibi: ^ sorry got distracted, should be good now i hope | |
| 11:27:44 | sean-k-mooney | gibi: on a related note it would be good to merge https://review.opendev.org/c/openstack/nova/+/923738/2 to update to fix issues caught by the latest version of codespell and https://review.opendev.org/c/openstack/nova/+/923739/2 to bump to using that version | |
| 12:34:03 | gibi | sean-k-mooney: looks good to me | |
| 13:02:39 | bauzas | nova PTG sessions starting now : https://meetpad.opendev.org/nova-2025.1-ptg | |
| 13:07:44 | bauzas | sean-k-mooney: want to join us ? | |
| 13:07:59 | sean-k-mooney | bauzas: just finising a 1:1 ill join shortly | |
| 13:08:02 | sean-k-mooney | start without me | |
| 13:19:24 | bauzas | artom: will you be able to join us today ? we have your topic for around 2.30pm UTC | |
| 14:46:03 | tkajinam | hmm ok so we undefine the secret here https://github.com/openstack/nova/blob/ed2bf3699ddc360fb646b895560fa9dbcfd6beba/nova/virt/libvirt/driver.py#L8074-L8075 | |
| 15:20:21 | opendevreview | Julien LE JEUNE proposed openstack/nova master: Reset the mapped field of nodes at service deletion https://review.opendev.org/c/openstack/nova/+/933022 | |
| 15:23:40 | jlejeune | gibi: hello, I propose that small patch to fix https://bugs.launchpad.net/nova/+bug/2085135 | |
| 15:23:55 | gibi | jlejeune: awesome, thanks you. I will take a look | |
| 15:50:47 | bauzas | as a reminder, today's nova meeting is CANCELLED | |
| 15:51:03 | bauzas | please rather join the nova PTG sessions if you want to join us :) https://ptg.opendev.org/ptg.html | |
| 16:52:44 | bauzas | as a reminder, nova sessions will start back tomorrow at *1400 UTC | |
| 16:52:50 | bauzas | (and not 1300UTC) | |
| 17:30:33 | opendevreview | Artom Lifshitz proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| 17:53:41 | opendevreview | Artom Lifshitz proposed openstack/nova master: Add whitebox-devstack-multinode job to periodic https://review.opendev.org/c/openstack/nova/+/833453 | |
| #openstack-nova - 2024-10-23 | |||
| 02:48:04 | mikal | sean-k-mooney: sorry, I missed your message. I think some of the later patches might need some small tweaks, but I have them all passing on my private CI, that's just a case of merging them back to gerrit. | |
| 02:48:26 | mikal | sean-k-mooney: that is, I can do that pretty quickkly once the spec is approved. I figured there wasn't much point before then. | |
| 06:32:29 | opendevreview | Amit Uniyal proposed openstack/nova master: Update Nova bdm with updated swap info https://review.opendev.org/c/openstack/nova/+/929858 | |
| 10:30:39 | sean-k-mooney | mikal: feel free to update them if you have time no need to wait for the spec to be reappoved in this case but if you want to wait that is also ok | |
| 13:33:55 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix case sensitive comparison https://review.opendev.org/c/openstack/nova/+/933107 | |
| 13:35:30 | bauzas | reminder: our nova sessions will softly start at 1400UTC | |
| 14:03:41 | bauzas | nova sessions start now | |
| 14:05:06 | bauzas | gibi: sean-k-mooney: dansmith: want to join the nova session or prefer to stay on the eventlet room ? | |
| 14:05:20 | dansmith | I have a glance topic right now | |
| 14:05:27 | dansmith | I thought nova was vfio first? | |
| 14:05:39 | sean-k-mooney | ill joing in a while | |
| 14:05:42 | sean-k-mooney | we can start | |
| 14:06:04 | bauzas | dansmith: yup, it will be vfio | |
| 14:06:16 | bauzas | sean-k-mooney: for the moment, I'm like the only core :) | |
| 14:06:18 | sean-k-mooney | im plannign to wait for 10 mins to see fi there are any other topics in the eventlet room | |
| 14:20:02 | gibi | eventlet room is finishing so I will jump soon to nova | |
| 14:21:43 | MengyangZhang[m] | hello, I recently submitted a spec and blueprint to add burst length support to Cinder QoS: https://review.opendev.org/c/openstack/nova-specs/+/932653. I wanted to check if it has been successfully submitted and if it's on the community's radar. Since I've just joined the channel, I'm unable to view previous messages. Could you let me know if there's anything else I should be doing, or should I just wait for peer review? | |
| 14:23:56 | opendevreview | Will Szumski proposed openstack/nova stable/2023.1: Process unlimited exceptions raised by unplug_vifs https://review.opendev.org/c/openstack/nova/+/933115 | |
| 14:27:55 | tkajinam | MengyangZhang[m], the spec is now visible in gerrit so was proposed successfully | |
| 14:28:13 | tkajinam | MengyangZhang[m], you may add "blueprint: add-burst-length-support" to the commit message to associate the spec to the bp | |