| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-15 | |||
| 16:58:07 | tkajinam | so it maybe time to drop it, as we usually use eventlet patch differently for windows removing the logic may help removing eventlet. | |
| 16:58:27 | gmann | tkajinam: what exactly left to remove window support? | |
| 16:58:41 | tkajinam | gmann, tons of os.name == 'nt' checks | |
| 16:58:42 | bauzas | gmann: see above, there is a cleanup patch | |
| 16:58:59 | tkajinam | maybe not 'tons' but 'numbers' | |
| 16:59:05 | gmann | ohk, just cleanup things. got it | |
| 16:59:28 | gmann | but we have already declared the winbdow support removal during hyper-V removal | |
| 16:59:49 | tkajinam | yes | |
| 17:00:17 | tkajinam | that's all from me today | |
| 17:00:57 | bauzas | cool and we're at time | |
| 17:00:59 | bauzas | thanks all | |
| 17:01:02 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.log.html | |
| 17:01:02 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.txt | |
| 17:01:02 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.html | |
| 17:01:02 | opendevmeet | Meeting ended Tue Oct 15 17:01:02 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:01:02 | bauzas | #endmeeting | |
| 17:02:44 | elodilles | thanks o/ | |
| 17:03:09 | tkajinam | thank you ! | |
| 17:09:21 | opendevreview | Takashi Kajinami proposed openstack/nova master: Clean up the remaining logic for Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | |
| 17:23:29 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 17:36:53 | gmann | tkajinam: I changed my -1 to +2 on the py3.8 drop changes for python_requires flag. let me know if I missed any and that is blocking them to merge. | |
| 17:37:39 | opendevreview | Merged openstack/nova stable/2023.1: add functional repoducer for bug 2065927 https://review.opendev.org/c/openstack/nova/+/922987 | |
| 17:40:16 | sean-k-mooney | gibi: i really dont know why this does not work https://paste.opendev.org/show/bv7MnOwOylKgvUiBOube/ | |
| 17:40:26 | sean-k-mooney | it never print LOG.info(f"Finished after {end_time - start_time} seconds") | |
| 17:41:43 | opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.8 support https://review.opendev.org/c/openstack/placement/+/925648 | |
| 17:46:40 | sean-k-mooney | maybe im not emulating this well and iw was working ill try soemthign other then sleep as teh worker function | |
| 18:12:37 | sean-k-mooney | oh there first example in https://www.geeksforgeeks.org/python-different-ways-to-kill-a-thread/ does not actlly work | |
| 18:19:46 | sean-k-mooney | ok i have it workign now but im not sure i like it | |
| 18:25:28 | sean-k-mooney | https://paste.opendev.org/show/bl8yqiKsPC6fv8iMA1tG/ | |
| 18:26:45 | sean-k-mooney | that works with eventlet too https://paste.opendev.org/show/bsbrV4lpmgzIBj5WOB2M/ | |
| 18:30:08 | sean-k-mooney | any the behavior is differnt if i eventlet monkeypathc or not | |
| 18:31:13 | sean-k-mooney | ok so this will work for native threads which is what we want it for but not nessiarly for eventlet greenthreads | |
| 18:31:42 | opendevreview | Merged openstack/nova stable/2023.1: retry write_sys call on device busy https://review.opendev.org/c/openstack/nova/+/922988 | |
| 18:31:48 | opendevreview | Merged openstack/nova stable/2023.1: testing: Fix and robustify archive_deleted_rows test https://review.opendev.org/c/openstack/nova/+/887978 | |
| 19:33:10 | opendevreview | Merged openstack/python-novaclient master: Remove Python 3.8 support https://review.opendev.org/c/openstack/python-novaclient/+/931477 | |
| 21:58:53 | opendevreview | Merged openstack/nova stable/2023.1: database: Archive parent and child rows "trees" one at a time https://review.opendev.org/c/openstack/nova/+/887979 | |
| 22:18:50 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| 22:18:51 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add base image format tracking with file extensions https://review.opendev.org/c/openstack/nova/+/930962 | |
| 22:18:51 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Move cache filename generation to imagebackend https://review.opendev.org/c/openstack/nova/+/930961 | |
| 22:18:52 | opendevreview | melanie witt proposed openstack/nova master: objects: Add image_type to BlockDeviceMapping object https://review.opendev.org/c/openstack/nova/+/930965 | |
| 22:18:52 | opendevreview | melanie witt proposed openstack/nova master: db: Add image_type to block_device_mapping table https://review.opendev.org/c/openstack/nova/+/930964 | |
| 22:18:53 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 22:18:53 | opendevreview | melanie witt proposed openstack/nova master: virt: Add image_type to relevant DriverBlockDevice https://review.opendev.org/c/openstack/nova/+/930966 | |
| 22:18:54 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 22:18:54 | opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | |
| 22:34:14 | opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | |
| #openstack-nova - 2024-10-16 | |||
| 00:56:59 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 02:03:38 | opendevreview | Takashi Kajinami proposed openstack/placement master: Switch python version for placement-nova-tox-functional https://review.opendev.org/c/openstack/placement/+/932472 | |
| 02:17:45 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Drop kuryr-kubernetes job https://review.opendev.org/c/openstack/os-vif/+/932474 | |
| 04:17:27 | opendevreview | Takashi Kajinami proposed openstack/placement master: Switch python version used for periodic jobs https://review.opendev.org/c/openstack/placement/+/932472 | |
| 04:23:56 | opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | |
| 06:58:14 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 09:07:49 | auniyal | https://review.opendev.org/c/openstack/nova/+/926521 - melwittis +2 on this already | |
| 09:07:49 | auniyal | https://review.opendev.org/c/openstack/nova/+/929858 | |
| 09:07:49 | auniyal | sean-k-mooney can you please have another look on these | |
| 10:45:05 | tkajinam | so for some reason placement-nova-tox-functional-py39 uses python 3.8 actually. I wonder if we can migrate that job to noble which uses 3.12 by default. https://review.opendev.org/c/openstack/placement/+/932472 | |
| 10:45:26 | sean-k-mooney | ah is that why that failed | |
| 10:45:30 | tkajinam | though we may want to fix that inconsistency in stable branches (especially 2024.2 ) | |
| 10:45:31 | tkajinam | yeah | |
| 10:46:18 | sean-k-mooney | +2 | |
| 10:46:23 | tkajinam | that's truly wired | |
| 10:46:27 | sean-k-mooney | i have approved the nova and os-vif bumps | |
| 10:46:37 | tkajinam | thanks ! | |
| 10:47:55 | sean-k-mooney | i wonder if its related to the min tox version we are using | |
| 10:48:12 | sean-k-mooney | minversion = 3.18.0 vs minversion = 4.6.0 in nova | |
| 10:49:16 | tkajinam | minversion only determines min and would not decide the version actually used. | |
| 10:49:20 | tkajinam | tox-4.21.2-py3-none-any.whl is what is pulled in the job | |
| 10:49:23 | sean-k-mooney | https://github.com/openstack/placement/commit/1c8afcd3f10a2ace8fdbada4f758b27bb2774cec | |
| 10:49:56 | sean-k-mooney | so when we bumped to 4.0 we were able to drop ignore_basepython_conflict = True | |
| 10:50:01 | sean-k-mooney | on ok | |
| 10:50:12 | sean-k-mooney | ya that makes sense you cant use tox to install tox | |
| 11:28:57 | gibi | sean-k-mooney: could you please check my test results in https://bugs.launchpad.net/nova/+bug/2077070/comments/7 regarding the pci_devices cleanup at compute_node delete. | |
| 11:29:31 | gibi | sean-k-mooney: other than the discover_hosts complication I will dig later, I don't see any real bugs. | |
| 11:29:52 | sean-k-mooney | are you testign a fix or trying to repoduce | |
| 11:30:40 | gibi | I only trying to reproduce | |
| 11:30:50 | sean-k-mooney | so "nova-manage db archive_deleted_rows" shoudl not be requried to be able to crate a new compute node | |
| 11:30:58 | gibi | it is not required | |
| 11:31:18 | sean-k-mooney | ok so the compute node is marked as deleted? | |
| 11:31:28 | sean-k-mooney | when the compute service is deleted? | |
| 11:31:51 | sean-k-mooney | ill read your comment poeprly | |
| 11:32:17 | gibi | yes, the compute_node is marked deleted | |
| 11:32:38 | gibi | the pci_devices rows are not marked deleted but they are pointing to a compute that is marked deleted so they does not interfere | |
| 11:33:22 | gibi | and archive deletes both the compute_node and the pci_devices rows | |
| 11:34:04 | gibi | this might clarify it further https://bugs.launchpad.net/nova/+bug/2077070/comments/9 | |
| 11:34:07 | sean-k-mooney | reading your comemnt ohter then it not workint without --by-service | |
| 11:34:15 | sean-k-mooney | it seams reasonable | |
| 11:34:48 | sean-k-mooney | i susppect the --by-service thing is what was really the issue then | |
| 11:34:59 | sean-k-mooney | tripleo or the end user were problly not using that | |
| 11:35:30 | gibi | yeah, I will dig into that side of the issue as we might fix the discover_hosts to work with undeleted computes | |
| 11:37:34 | sean-k-mooney | im sure you had but just double chekcing you had pci devices in the pci_device table when checking this right | |
| 11:39:19 | opendevreview | Merged openstack/nova master: Libvirt: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926521 | |
| 11:39:20 | sean-k-mooney | im wonderign if an instance was using one and you evacuated it will the archive still work | |
| 11:39:25 | sean-k-mooney | or the undelete | |
| 11:40:51 | gibi | yes, I had pci device even allocated :) | |
| 11:41:31 | gibi | I can try the evac case, as I local deleted the instance after the simulated compute failure | |
| 11:42:22 | sean-k-mooney | so in the evacuate case wehre your keepign the identity | |
| 11:42:39 | sean-k-mooney | there is extra logic in the compute agent to properly clean up after the evacuated instnaces | |
| 11:42:50 | sean-k-mooney | so im wondering if that could be relevent here | |
| 11:43:25 | sean-k-mooney | it proably does not hurt to test wtih the removal of the compute uuid file too but im more concerned about the ohter case | |
| 11:47:24 | gibi | OK. I will check the two case with evac today... | |