| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-11 | |||
| 15:44:50 | sean-k-mooney | oh https://github.com/openstack/nova/blob/master/nova/db/main/migrations/versions/8f2f1571d55b_initial_version.py#L274-L275 | |
| 15:44:58 | sean-k-mooney | that a bug | |
| 15:45:11 | jlejeune | hé hé | |
| 15:45:53 | sean-k-mooney | that should be utf8mb4 | |
| 15:45:57 | jlejeune | :) | |
| 15:46:04 | amorin | there are some latin1 as well | |
| 15:46:05 | sean-k-mooney | i guess depending on your release there may be an alias for that | |
| 15:46:52 | sean-k-mooney | yes so we had a discussion about if nova can move to perscifbeing a charset to use a long time ago and i tought we agrreed no | |
| 15:47:07 | sean-k-mooney | this was incontext to maigin to a case sensitive coalation type | |
| 15:47:39 | sean-k-mooney | which is a slictly diffent topic | |
| 15:47:56 | sean-k-mooney | looking at https://dev.mysql.com/doc/refman/5.7/en/charset-charsets.html and 9.0 | |
| 15:48:15 | sean-k-mooney | utf8mb4 shoudl be viable for a wide range of release | |
| 15:48:41 | sean-k-mooney | utf8 exists in 5.7 but not in 8.0+ | |
| 15:48:45 | sean-k-mooney | im not sure when it was removed | |
| 15:49:16 | sean-k-mooney | jlejeune: can you file a but for this. | |
| 15:49:59 | jlejeune | I can for sure, but it will wait for monday :) | |
| 15:50:03 | jlejeune | I have to go | |
| 15:50:07 | sean-k-mooney | no worries | |
| 15:50:19 | jlejeune | see you | |
| 15:50:41 | sean-k-mooney | o/ | |
| 15:51:03 | sean-k-mooney | looks like we have 3 migration that are affected. 2 in the main/cell db an 1 in the api db | |
| 15:52:03 | sean-k-mooney | https://dev.mysql.com/doc/refman/8.4/en/charset-unicode-utf8.html | |
| 15:52:11 | sean-k-mooney | that is the deprecation notice | |
| 15:52:39 | sean-k-mooney | so its an alias for utf8mb3 and it was remvoed in 8.0 | |
| 15:52:49 | sean-k-mooney | utf8mb3 is also deprecated | |
| 15:53:09 | sean-k-mooney | so if we should move to utf8mb4 for all tables if we are goign to specify one | |
| 15:54:22 | sean-k-mooney | idealaly using utf8mb4_unicode_ci or utf8mb4_bin coralation type | |
| 15:54:58 | sean-k-mooney | i would prefer utf8mb4_bin but there are some upgrade concerns with that | |
| 15:56:02 | sean-k-mooney | bauzas: i know your done for the weekend but ^ might need to be a ptg topic again | |
| 16:55:35 | sean-k-mooney | gibi: pci in placement still allow sriov networkign today right | |
| 16:56:05 | sean-k-mooney | the neutron sriov vf are just not tracked in placment | |
| 16:56:52 | sean-k-mooney | i tore down my home cloud a few weeks ago to do some hardware mantance and im debating if im going to redpeloy it at the weekend | |
| 16:57:24 | sean-k-mooney | if i do im condiering going sriov only or mainly sriov for my netorking to keep ti simple. and fast | |
| #openstack-nova - 2024-10-12 | |||
| 05:21:45 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Deprecate volume driver for unsupported volume backends https://review.opendev.org/c/openstack/nova/+/932247 | |
| 05:23:01 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop usage of pkg_resources https://review.opendev.org/c/openstack/nova/+/931312 | |
| 05:51:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Drop usage of pkg_resources https://review.opendev.org/c/openstack/nova/+/931312 | |
| 06:10:14 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Deprecate volume driver for unsupported volume backends https://review.opendev.org/c/openstack/nova/+/932247 | |
| 07:26:00 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Deprecate volume driver for unsupported volume backends https://review.opendev.org/c/openstack/nova/+/932247 | |
| 10:18:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Deprecate volume driver for unsupported volume backends https://review.opendev.org/c/openstack/nova/+/932247 | |
| 12:35:08 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2025.1 Epoxy https://review.opendev.org/c/openstack/nova/+/929918 | |
| 16:31:14 | opendevreview | Takashi Kajinami proposed openstack/python-novaclient master: tox: Drop envdir https://review.opendev.org/c/openstack/python-novaclient/+/932263 | |
| #openstack-nova - 2024-10-14 | |||
| 10:16:46 | opendevreview | Merged openstack/nova master: Update contributor guide for 2025.1 Epoxy https://review.opendev.org/c/openstack/nova/+/929918 | |
| 11:12:08 | opendevreview | Amit Uniyal proposed openstack/nova master: Update Nova bdm with updated swap info https://review.opendev.org/c/openstack/nova/+/929858 | |
| 11:18:22 | opendevreview | Amit Uniyal proposed openstack/nova master: Update Nova bdm with updated swap info https://review.opendev.org/c/openstack/nova/+/929858 | |
| 11:26:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove libvirt tunnelled migration https://review.opendev.org/c/openstack/nova/+/879021 | |
| 11:44:14 | opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/929719 | |
| 11:46:07 | opendevreview | Merged openstack/python-novaclient master: tox: Drop envdir https://review.opendev.org/c/openstack/python-novaclient/+/932263 | |
| 11:59:05 | opendevreview | Takashi Kajinami proposed openstack/placement master: Drop db migration tool https://review.opendev.org/c/openstack/placement/+/932324 | |
| 12:02:05 | tkajinam | ^^^ I wonder if we can drop the migration script directly or we need deprecation step (I feel like no one may use it from master so direct removal doesn't annoy real users) | |
| 12:22:49 | sean-k-mooney | tkajinam: i assuem we have a placement-manage db_sync command so it shoudl not be in use but im not sure. i have never checked that | |
| 12:23:06 | sean-k-mooney | oh | |
| 12:23:20 | sean-k-mooney | this is the tool to migrate form in nova placment to split out placemnet | |
| 12:23:57 | sean-k-mooney | that a good question we have not requried this for so long that enven the unmaintaiend brances shoudl not need it | |
| 12:24:09 | sean-k-mooney | so i feel like a direct removal would be ok | |
| 12:24:53 | sean-k-mooney | we are talking about somethign that shoudl have been done when upgrading to stien so i dont think deprecation of a shel script really shoudl be required at this point | |
| 12:42:54 | opendevreview | Balazs Gibizer proposed openstack/nova master: Revert "Test live migration between hosts with differnet cpu_shared_sets" https://review.opendev.org/c/openstack/nova/+/932327 | |
| 12:43:13 | gibi | sean-k-mooney: ^^ revert to stabilize CI | |
| 12:43:30 | sean-k-mooney | gibi: ah yep thanks i ment to do that for two weeks now and have been putting it off | |
| 12:43:53 | sean-k-mooney | it fiail infrequetly but it will increase as more raxflex host come online | |
| 12:43:57 | gibi | I got hit by it twice in a row so got enough motivation to at least push the revert | |
| 12:44:29 | sean-k-mooney | do we need another to +w i added +2 | |
| 12:44:43 | gibi | bauzas: could you put a +w to ^^ | |
| 12:44:54 | gibi | it is a revert for CI stablization | |
| 12:44:59 | bauzas | okay | |
| 12:45:16 | sean-k-mooney | ill be changign which jobs to what anyway when i get time to work on this again | |
| 12:45:45 | gibi | thanks | |
| 12:55:31 | tkajinam | sean-k-mooney, yeah that's the tool to pull placement tables from old nova db. | |
| 17:19:01 | opendevreview | Merged openstack/nova master: Revert "Test live migration between hosts with differnet cpu_shared_sets" https://review.opendev.org/c/openstack/nova/+/932327 | |
| 18:50:07 | melwitt | sean-k-mooney: you had mentioned that scatter_gather_cells is not currently waiting for timeout in the main thread but I thought it is? this is using the eventlet.timeout.Timeout context manager in the main thread right? https://github.com/openstack/nova/blob/741e1b38705efecc083f091c51164b3cafb9697c/nova/context.py#L437 | |
| 19:07:47 | dansmith | melwitt: I think in uwsgi mode it can't since we're not running the eventlet hub right? | |
| 19:08:14 | dansmith | IIRC that's what sean-k-mooney was referring to.. it "waits" but the timeout will never fire in fully uwsgi mode | |
| 19:08:18 | melwitt | dansmith: oh, ok I didn't realize that was why | |
| 19:08:45 | melwitt | I see. thanks | |
| 22:11:48 | sean-k-mooney[m] | it was related to a comment gibi made | |
| 22:14:09 | sean-k-mooney | ... peopel changed my topic | |
| 22:15:00 | sean-k-mooney | melwitt: i was refering to this comment thread https://review.opendev.org/c/openstack/nova/+/905284/comment/ea51fb75_6013c0cd/ | |
| 22:15:53 | sean-k-mooney | im pretty sure that the entire query_wrapper can go away and the timeout logic can move as we only use it for one thing | |
| 22:17:24 | sean-k-mooney | its been a month since i looke at it but i think i was leaning towards puting the timeout here https://github.com/openstack/nova/blob/01b207e50d307a7e7650b5839535fbd3ad40bc1b/nova/context.py#L421 or https://github.com/openstack/nova/blob/01b207e50d307a7e7650b5839535fbd3ad40bc1b/nova/compute/multi_cell_list.py#L262 | |
| 22:17:52 | melwitt | sean-k-mooney: I remember that thread but I didn't realize that today the timeout doesn't work because of no eventlet hub in full uwsgi mode | |
| 22:18:35 | sean-k-mooney | im not sure if that is true or not | |
| 22:19:08 | sean-k-mooney | when run under uwsig today we are monkey patching so i think we have a hub but honestly i have not looked at that in a long time | |
| 22:19:31 | sean-k-mooney | we were not starting the hub at one point | |
| 22:19:47 | sean-k-mooney | but i think matt booth changed that as a bugfix? | |
| 22:20:47 | sean-k-mooney | https://github.com/openstack/nova/commit/3c5e2b0e9fac985294a949852bb8c83d4ed77e04 | |
| 22:21:48 | melwitt | ok well ... if the timeout context manager works then it seems to me the timeout is in the right place in today's code (in the main thread and kills the child threads if the timeout fires). and I'm not making an opinion about where the timeout should go as part of eventlet removal | |
| 22:22:32 | sean-k-mooney | so i htink the issue is the timeout fires on the main thread but does not kill the child threads | |
| 22:23:02 | sean-k-mooney | again i dont currently have the context loaded form gibi's testing but i blieve we need the timeout to fire on the child thread? | |
| 22:23:51 | melwitt | I thought gibi was testing with native threads not eventlet? | |
| 22:24:19 | sean-k-mooney | yes but with this patch we are using native treads too | |
| 22:24:20 | melwitt | yeah, gibi's comment is about the code proposed in your patch | |
| 22:24:34 | sean-k-mooney | right that is what i was brignin up today | |
| 22:24:55 | melwitt | ok, maybe I misunderstood what you said. I thought you said the timeout doesn't work at all today | |
| 22:25:08 | sean-k-mooney | when we remove eventelte we need to ensure the timeout still works for the treads in the tread pool | |
| 22:26:13 | sean-k-mooney | baisicly what we want to have happen is if the timout expires we want the thread to be killed and clean up by the timeout expction when resumed by the kernel | |
| 22:26:29 | melwitt | right. I had thought you were commenting on what's in tree right now. I misunderstood that you were talking about future stuff, my bad | |
| 22:26:50 | sean-k-mooney | by startign the timer in the child thread if we dont get io before it expires then the kernel shoud resume it whtn the timer interupt fires | |
| 22:27:16 | sean-k-mooney | no worries, ya i was talking about the unresolved comments in the current series | |
| 22:27:49 | melwitt | I agree the timer needs to be in the child thread with native threads | |
| 22:27:51 | melwitt | we don't have the ability anyway to kill them from the parent | |
| 22:27:55 | melwitt | *them = native threads | |