Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2024-10-08
16:33:06 auniyal to return output in more formats such as json
16:33:26 dansmith doesn't this need a spec given some of the complexities around making sure there is consistency among all the commands?
16:33:29 sean-k-mooney so that eaiser said then done
16:33:44 sean-k-mooney unlike osc we are using raw prints
16:33:51 sean-k-mooney in nova manage
16:34:42 gibi at least on of the use case is coming from here https://github.com/openstack-k8s-operators/nova-operator/blob/7e7ba33aab515809fb23ce20cb6a55e50da3f457/templates/nova-manage/bin/ensure_cell_mapping.sh#L20-L25 and for that having a --cell_name param would be enough
16:35:00 sean-k-mooney we cnat rely on click/cliff to help use with that generically
16:35:14 sean-k-mooney we could do it on a per comand basis yes
16:35:21 bauzas AFAIK, originally nova-manage wasn't intended to be scripted
16:35:27 bauzas hence the poor interface
16:35:45 auniyal sure, I can write a spec, the output is formatted by prettytable mostly
16:35:54 gibi bauzas: deployment tooling needs to add cells, there is no other interface for that
16:36:05 auniyal which supports other format as well
16:36:19 bauzas gibi: I wasn't disagreeing your usecase, I was just explaining why we basically have that
16:36:51 sean-k-mooney auniyal: so for succsful output yes alot goes via prettytbale
16:36:52 gibi and my use case does not need json output per se, it needs a way to easily manipulate cells by name and not by uuid
16:36:58 sean-k-mooney error tend to just use print directly
16:37:02 bauzas but I agree with dansmith, there could be some concerns about ensuring that we keep the same formatted output
16:37:23 sean-k-mooney so lets move forward with a spec and review the proposal
16:37:28 bauzas agreed
16:37:29 dansmith gibi: ack, the cell_name thing is easy to just do without a spec, no doubt.. the json thing not so much, IMHO
16:37:52 dansmith I think we can just tuck the cell_name thing under the covers without a lot of paperwork, IMHO, if it's as easy as I expect
16:37:59 dansmith so perhaps just do that as a one-off and spec for the json stuff?
16:38:16 auniyal ack
16:38:19 gibi we can do both but I prefer to have --cell_name as that feels easier
16:38:27 bauzas yeah that should be two blueprints
16:38:46 bauzas one for adding a new param to the command, the other one about formatting outputs
16:39:05 dansmith idk that we need a blueprint for a single simpleish patch for cell_name, personally, but whatever the PTL says :)
16:39:13 bauzas and as dansmith, I'm cool with stamping over the cell param addition bp as a specless, if that helps
16:39:36 bauzas then the PTL says : dude, write the patch and consider it as just a techdeby
16:39:45 dansmith ++
16:39:49 sean-k-mooney if we want a tracker i guess we can use a wishlist bug
16:39:52 bauzas tech debt reduction
16:40:02 dansmith sean-k-mooney: sure
16:40:03 sean-k-mooney yep
16:40:13 bauzas let's not paper it, we now have a status etherpad for tracking such patches
16:40:25 bauzas but I'm cool with a wishlist bug
16:41:17 dansmith moving on?
16:41:23 bauzas yah
16:41:31 gibi cool
16:41:34 bauzas that was it in the agenda
16:41:45 dansmith if I can, I'd like to beg for review of this: https://review.opendev.org/c/openstack/nova/+/930754
16:41:48 bauzas anything else or can I just take a breath before my 4th meeting ?
16:42:00 dansmith definitely could use some in-depth sanity checking of my findings
16:42:10 dansmith but it needs to go in before glance can start enforcing image formats
16:42:19 bauzas I'll
16:42:52 bauzas I already have the context
16:43:00 dansmith thanks
16:43:34 haleyb can i ask for a review of https://review.opendev.org/c/openstack/nova/+/811521 ? just need one more +2 to finally complete this BP
16:44:15 sean-k-mooney oh that ya i ment to loop back to it. im also +2 on haleyb change
16:44:33 bauzas dansmith: I just have one open question, this will change the uploaded image type, right?
16:44:35 haleyb sean-k-mooney: thanks for the +2, i figured i'd wait until we were in epoxy
16:44:51 bauzas if so, shall we document that in a relnote ?
16:45:28 dansmith bauzas: it doesn't upload an image
16:45:40 dansmith bauzas: it just creates one and then does a zero-byte upload to make it active
16:46:02 dansmith bauzas: since it claims it will be qcow2, zero bytes is not a valid qcow2 file, so glance rejects it
16:46:09 bauzas ah I see
16:46:14 dansmith we really shouldn't be doing this at all, IMHO, but alas
16:46:19 dansmith (I thought you already had context? :D)
16:46:29 bauzas we just ping glance just for the sake of flipping something on our side, naice
16:46:43 dansmith we just LIE to glance, but yeah :D
16:46:58 bauzas dansmith: I had the context, but I missed that detail
16:47:06 sean-k-mooney its not really that, we are tryign to make bfv snapshot look like boot form image snapshots
16:47:09 sean-k-mooney but they are not
16:47:12 sean-k-mooney the same
16:47:19 bauzas and trust me, I refrain myself as hard as a I can from stepping into that image mud
16:47:25 dansmith that's the reason for the lie yeah
16:48:01 bauzas okay, now I have everything I need for reviewing that patch
16:49:25 dansmith thanks
16:49:54 sean-k-mooney bauzas: gibi woudl either of ye have bandwith to review haleyb patch
16:50:10 sean-k-mooney bauzas: you have seen that before too a few months ago
16:50:23 bauzas yeah
16:50:26 bauzas I'll
16:50:27 sean-k-mooney cool
16:50:48 bauzas that's it for me
16:50:55 bauzas anything else last minute ?
16:51:08 auniyal sean-k-mooney, can you please loop back at this too https://review.opendev.org/c/openstack/nova/+/929858
16:51:31 sean-k-mooney yes i can try
16:51:42 auniyal thanks
16:51:53 sean-k-mooney i asked you to ping me if i didnt do it last week so thansk for the reminder
16:51:55 gibi sean-k-mooney: I can try too
16:52:12 bauzas okay, that's it for the meeting then
16:52:14 bauzas thanks all
16:52:19 opendevmeet Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-08-16.00.log.html
16:52:19 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-08-16.00.txt
16:52:19 opendevmeet Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-08-16.00.html
16:52:19 opendevmeet Meeting ended Tue Oct 8 16:52:19 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
16:52:19 bauzas #endmeeting
16:52:37 fwiesel Thank you too
16:52:44 gibi thanks folks
16:52:46 elodilles thanks o/
18:07:12 opendevreview Dan Smith proposed openstack/nova master: Handle iso+gpt detections https://review.opendev.org/c/openstack/nova/+/931833
19:01:06 opendevreview Ghanshyam proposed openstack/nova master: WIP Revert "add pyproject.toml to support pip 23.1" https://review.opendev.org/c/openstack/nova/+/931840
19:01:26 opendevreview Ghanshyam proposed openstack/nova stable/2024.2: WIP Revert "add pyproject.toml to support pip 23.1" https://review.opendev.org/c/openstack/nova/+/931841
19:07:40 opendevreview Merged openstack/nova stable/2023.2: [doc]Fix the device_spec config doc about placement https://review.opendev.org/c/openstack/nova/+/931637
19:07:46 opendevreview Merged openstack/nova master: Fix image format error on vol-backed snapshot https://review.opendev.org/c/openstack/nova/+/930754
21:30:43 opendevreview Merged openstack/nova stable/2023.1: [doc]Fix the device_spec config doc about placement https://review.opendev.org/c/openstack/nova/+/931638
#openstack-nova - 2024-10-09
02:31:55 opendevreview Takashi Kajinami proposed openstack/nova master: Drop usage of pkg_resources https://review.opendev.org/c/openstack/nova/+/931312
02:49:08 opendevreview Amit Uniyal proposed openstack/nova master: VMware: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926522
02:49:08 opendevreview Amit Uniyal proposed openstack/nova master: Libvirt: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926521

Earlier   Later