| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-01 | |||
| 16:44:43 | tkajinam | so py3.8 is already EOL when Epoxy is released | |
| 16:45:00 | bauzas | https://governance.openstack.org/tc/reference/runtimes/2025.1.html | |
| 16:45:15 | bauzas | that's not in our runtimes, so I'm cool | |
| 16:45:55 | bauzas | tkajinam: if that's review support you need for your patches, bug me | |
| 16:46:20 | tkajinam | One thing I want to get agreement about is the min version enforced by python_requires in setup.cfg | |
| 16:46:32 | bauzas | we can also add your patches in the status etherpad | |
| 16:46:37 | tkajinam | which actually defines the min python version during installation | |
| 16:47:06 | bauzas | do we have a choice here given the Epoxy runtimes ? | |
| 16:47:10 | tkajinam | My own opinion is that we should bump min to 3.9, because we no longer test 3.8 and we don't aim to fix compatibility with it | |
| 16:47:35 | gibi | yeah, if we don't test it then it is broken | |
| 16:47:41 | gibi | so bump to 3.9 | |
| 16:48:16 | elodilles | we had issues in the past when we too early dropped a version and some thing went to error, | |
| 16:48:34 | elodilles | but i guess with py38 we are probably beyond that line :) | |
| 16:48:37 | bauzas | don't ask me to send you the pypi query that shows the number of "py2.7 supported" projects | |
| 16:48:53 | bauzas | elodilles: this was due to some oslo libs | |
| 16:48:53 | elodilles | maybe not merge it before tomorrow final 2024.2 Dalmatian release? :D | |
| 16:49:06 | tkajinam | py38 removal has been discussed for very long time and it was even removed from testing in 2024.2 . | |
| 16:49:17 | bauzas | and this was also happening very late in the development cycle | |
| 16:49:34 | elodilles | yepp | |
| 16:49:41 | bauzas | how many projects import nova.* ? | |
| 16:50:07 | tkajinam | I believe we gave all projects enough time to migrate job and now it's time to force any lagging projects to do their migration. | |
| 16:50:17 | elodilles | +1 | |
| 16:50:25 | tkajinam | bauzas, I'm aware of none, but I've not checked external projects really. | |
| 16:50:42 | bauzas | well, Blazar did that a decade ago :D | |
| 16:50:49 | bauzas | anyway | |
| 16:50:51 | tkajinam | As I said we may have new releases from oslo in M1 which drops py38 support. that would allow us to catch problems early | |
| 16:51:11 | elodilles | +1 | |
| 16:51:17 | bauzas | I'd say that oslo librairies should may be the latest to change their min versions | |
| 16:51:42 | elodilles | or drop it early in the cycle | |
| 16:51:45 | bauzas | but we're way in advance, so we can cut the cord now and see which projects fail the gap | |
| 16:52:07 | bauzas | elodilles: sure, and then it will become a TC discussion :D | |
| 16:52:21 | bauzas | like, project X CI fails, why ? | |
| 16:52:27 | bauzas | anyway | |
| 16:52:39 | elodilles | :) | |
| 16:53:09 | bauzas | tkajinam: from my sole angle of view which is the Nova project, I'd say you can safely bump our min_version in the descriptor, including os-vif and the clients | |
| 16:53:19 | tkajinam | ok | |
| 16:53:42 | bauzas | anyything else then ? | |
| 16:53:42 | tkajinam | I'll submit the bump and see how it goes. | |
| 16:53:50 | tkajinam | no :-) thanks for your time. | |
| 16:53:55 | bauzas | tkajinam: and don't hesitate to bug me then | |
| 16:54:14 | gibi | tkajinam: thanks for doing the cleanup | |
| 16:54:51 | bauzas | yup, thanks indeed | |
| 16:55:04 | bauzas | anything else to discuss ? | |
| 16:55:05 | dansmith | I just want to point out this patch of mine, which fixes a long-running transgression with us lying to glance about volume snapshots: https://review.opendev.org/c/openstack/nova/+/930754 | |
| 16:55:35 | dansmith | as far as I could tell while looking, the snap we create for volumes is not useful for actually booting from and was added for a completely unrelated reason ages ago | |
| 16:55:46 | dansmith | so i think we might want to consider not doing that anymore if there is no reason | |
| 16:56:14 | dansmith | if there is, then we're going to need to consider what we want to do there when we stop allowing nova to boot from unformatted (i.e. raw) images in the future | |
| 16:56:27 | dansmith | but I have a lot of history summarized there with links if anyone wants to have a look | |
| 16:56:51 | dansmith | that's blocking glance work because we fail in tempest tests to snapshot BFV instances since glance rejects nova's lies that we're uploading a qcow2 when we're clearly not | |
| 16:56:56 | bauzas | dansmith: fwiw, I trust you on that yet another image backend story | |
| 16:57:06 | dansmith | please trust but verify :) | |
| 16:57:17 | dansmith | anyway, no time to discuss in depth now, I need to run to something else but wanted to point it out | |
| 16:57:35 | gibi | dansmith: thanks for the heads up, I have to read your excellent commit message... | |
| 16:58:35 | bauzas | dansmith: I'll carefully verify your commit msg then | |
| 16:58:38 | dansmith | thanks | |
| 16:59:45 | gibi | bauzas: I feel we are done | |
| 16:59:54 | bauzas | yup, and we're on time | |
| 17:00:02 | gibi | perfect :) | |
| 17:00:11 | bauzas | I was doing some paperwork to add dansmith's patch into the etherpad | |
| 17:00:14 | bauzas | that's his fault | |
| 17:00:19 | bauzas | thanks all | |
| 17:00:22 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.log.html | |
| 17:00:22 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.txt | |
| 17:00:22 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-01-16.01.html | |
| 17:00:22 | opendevmeet | Meeting ended Tue Oct 1 17:00:22 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:00:22 | bauzas | #endmeeting | |
| 17:00:29 | gibi | bauzas: thanks | |
| 17:00:31 | elodilles | thanks o/ | |
| 17:00:32 | gibi | o/ | |
| 17:00:50 | tkajinam | thank you | |
| 17:17:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add new option to enforce multipath volume connections https://review.opendev.org/c/openstack/nova/+/845660 | |
| 17:27:13 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:27:52 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:28:51 | gmann | tkajinam: I think we should remove the python_requires itself | |
| 17:29:37 | sean-k-mooney | currently tkajinam is not modifying it | |
| 17:30:01 | sean-k-mooney | or the verions in setup.cfg at all | |
| 17:30:49 | sean-k-mooney | there patch is just reverting to using hashlib instead of oslo for md5 | |
| 17:31:14 | sean-k-mooney | tkajinam: we shoudl proably update https://github.com/openstack/nova/blob/master/setup.cfg#L13-L23 in the same patch | |
| 17:31:38 | sean-k-mooney | wether we remvoe python_requires = >=3.8 or change it to python_requires = >=3.9 i have less opipion on | |
| 17:31:47 | sean-k-mooney | but we shoudl drop Programming Language :: Python :: 3.8 | |
| 17:31:58 | gmann | yeah and add py3.12 also | |
| 17:32:07 | sean-k-mooney | yep | |
| 17:32:44 | tkajinam | I though I modified setup.cfg but I somehow reverted that change... | |
| 17:33:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove Python 3.8 support https://review.opendev.org/c/openstack/nova/+/931047 | |
| 17:33:23 | sean-k-mooney | that explains why v1 and v2 are the same exctp the commit message :) | |
| 17:33:52 | sean-k-mooney | gmann: you prefer not to bump python_requires in general yes | |
| 17:34:03 | sean-k-mooney | to allow it to install even if its not nessiarly compatible | |
| 17:34:14 | gmann | sean-k-mooney: yeah, it create problem more than benefit | |
| 17:34:24 | sean-k-mooney | without a downstream patch python once we revert to hashlibg directly it will fail on vanilla py38 | |
| 17:34:55 | sean-k-mooney | usedforsecurity does not exist in the upstream python 3.8 hashlib | |
| 17:35:04 | gmann | python versions listed in classifier should tell what all python versions are tested and supported and rest all no guarantee | |
| 17:35:08 | tkajinam | I'd say classifier is just useless because it does not enforce anything and have been unmantained for very long | |
| 17:35:11 | gmann | if it work as long as it is good | |
| 17:35:34 | gmann | this is just a info and doc we do not need to enforce things | |
| 17:36:08 | sean-k-mooney | gmann: right my point is nova wont work on py38 with this change (unless the distro backported the hashlib change to 3.8) | |
| 17:36:41 | tkajinam | what you are saying is equivalent to drop all min version from requirements, IMHO | |
| 17:37:05 | tkajinam | I don't know why we should maintain these although we won't maintain compat version for core python. | |
| 17:37:15 | sean-k-mooney | so tkajinam we may not be able to do this change this cycle | |
| 17:37:27 | sean-k-mooney | we still need ubuntu 22.04 for grenade | |
| 17:37:34 | sean-k-mooney | and i belive it uses 3.8 | |