| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-09-12 | |||
| 12:04:49 | sean-k-mooney | yusufgungor_: so it shoudl be noted that nova does not supprot multi segment networks with differnt mtu | |
| 12:05:46 | sean-k-mooney | yusufgungor_: vxlan has 48? byte of encapsulation overhead so we round that up to 50 and reduce its mtu vs vlan/flat in neutorn automatically | |
| 12:07:45 | sean-k-mooney | yusufgungor_: you should file a bug with as much detail as is relevent | |
| 12:08:05 | yusufgungor_ | @sean thanks for reply. so a nova instance with both vxlan tenant network (mtu: 1450) and provider network (mtu: 1500) is not supported? Actually it works except live migration on spesific case. For example after hard reboot the instance we can live migrate too. | |
| 12:08:32 | yusufgungor_ | @sean-k-mooney thanks, then i will file a bug report to nova | |
| 12:09:42 | sean-k-mooney | no you can have instance with a mix of both | |
| 12:09:45 | sean-k-mooney | that should be fine | |
| 12:10:04 | sean-k-mooney | just not a neutron network that has a vlan segment and a vxlan segment with differnt mtus | |
| 12:10:57 | sean-k-mooney | that actully might work form a nova side as we take the mtu form the port | |
| 12:11:21 | sean-k-mooney | but it would break l2 connectivty between the segments as mtus should only chagne on l3(subnet) bondaries | |
| 12:12:19 | yusufgungor_ | @sean-k-mooney thanks. actually we have tried to set the provider network mtu as 1450 too and tested but hitting the same live migrate error | |
| 12:12:40 | yusufgungor_ | @sean-k-mooney i will test it again, and file a bug | |
| 12:12:56 | sean-k-mooney | oh this might be an old bug then | |
| 12:13:20 | sean-k-mooney | so we do not suprot changing the mtu of neutron netowrks | |
| 12:13:29 | sean-k-mooney | and by we i mean nova | |
| 12:14:12 | sean-k-mooney | the only way to do that properly is if you detach and reattach all the ports or otherwise regenerate the guest xml | |
| 12:15:21 | yusufgungor_ | @sean-k-mooney thanks 🙏 | |
| 12:55:41 | ratailor_ | sean-k-mooney, could you please provide your suggestion on this approach https://review.opendev.org/c/openstack/nova/+/928933 for https://bugs.launchpad.net/nova/+bug/2058928 | |
| 12:56:44 | ratailor_ | sean-k-mooney, the finish_time field is not shown in instance action show output, that's why we need to do this before calling instance action finish method for respective APIs where we need to finish the started action. | |
| 12:57:20 | ratailor_ | sean-k-mooney, I will fix failing tests and add new tests wherever required, once this approach looks good. | |
| 13:00:17 | ratailor_ | artom, gibi please provide your suggestions as well ^^ | |
| 13:01:59 | opendevreview | sean mooney proposed openstack/nova master: repoduce post liberty pre vicoria instance numa db issue https://review.opendev.org/c/openstack/nova/+/929025 | |
| 13:02:13 | sean-k-mooney | dansmith: gibi bauzas ^ | |
| 13:04:19 | sean-k-mooney | ill file a bug for that and update it when i push the fix patch | |
| 13:31:08 | yusufgungor_ | @sean-k-mooney i have filed a bug: https://bugs.launchpad.net/nova/+bug/2080531 | |
| 14:02:31 | opendevreview | Dan Smith proposed openstack/nova stable/2023.1: [stable-only]: Port qcow2v2 support from oslo https://review.opendev.org/c/openstack/nova/+/928937 | |
| 14:08:33 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933 | |
| 16:29:59 | dansmith | sean-k-mooney: are you respinning the safety patch to invert the safe/unsafe logic or no? | |
| 16:30:07 | dansmith | your comment made it sound like yes, but... | |
| 16:31:05 | sean-k-mooney | no | |
| 16:31:10 | sean-k-mooney | i inverted the logic already | |
| 16:31:19 | sean-k-mooney | so it should be good as is | |
| 16:31:27 | dansmith | okay | |
| 16:31:35 | sean-k-mooney | unsafe would have been less work but i was alrey 30 mins into fixing the tests | |
| 16:31:46 | sean-k-mooney | so i decied to just finish it | |
| 16:32:04 | dansmith | yeah I just wasn't sure from your comment if you were going to respin is all | |
| 16:32:11 | bauzas | hum, looks like we don't have any existing functional tests checking shared storage | |
| 16:32:18 | sean-k-mooney | ya i proably should have dropped the comment | |
| 16:32:56 | sean-k-mooney | bauzas: we may under the libvirt section | |
| 16:33:18 | sean-k-mooney | but in generally its light if it exists | |
| 16:33:36 | bauzas | my grep on shared_storage or just storage shows me nothing | |
| 16:34:17 | bauzas | I assume I may have to mock this | |
| 16:34:46 | bauzas | iirc, we just detect shared storage if we can see the same instance files on both computes, right? | |
| 16:36:02 | sean-k-mooney | yep you can mock that function | |
| 16:36:16 | sean-k-mooney | i would just create a regression test in a spereate file | |
| 16:36:23 | sean-k-mooney | and use https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L264 to make live migration work | |
| 16:36:39 | sean-k-mooney | then stub the function for the shared storage check to return true | |
| 16:36:57 | sean-k-mooney | https://github.com/openstack/nova/blob/16d815990b53b9afa35fc4da38609f87820fa690/nova/tests/functional/regressions/test_bug_1939545.py | |
| 16:36:59 | bauzas | we have a couple of functional tests for live-migration, that's not a problem | |
| 16:37:05 | sean-k-mooney | i think has all the ground work | |
| 16:37:16 | bauzas | oh cool, thanks for the digging but I was about to do it :) | |
| 17:20:08 | bauzas | okay, I'm out of steam and I don't have ideas on how to correctly assert we delete the local disks, except checking we call the delete | |
| 17:20:17 | bauzas | see you tomorrow | |
| 20:09:17 | opendevreview | sean mooney proposed openstack/nova master: repoduce post liberty pre vicoria instance numa db issue https://review.opendev.org/c/openstack/nova/+/929025 | |
| 20:09:18 | opendevreview | sean mooney proposed openstack/nova master: allow upgrade of pre-victoria InstanceNUMACells https://review.opendev.org/c/openstack/nova/+/929187 | |
| 20:14:55 | opendevreview | sean mooney proposed openstack/nova master: repoduce post liberty pre vicoria instance numa db issue https://review.opendev.org/c/openstack/nova/+/929025 | |
| 20:14:56 | opendevreview | sean mooney proposed openstack/nova master: allow upgrade of pre-victoria InstanceNUMACells https://review.opendev.org/c/openstack/nova/+/929187 | |
| 22:11:45 | sean-k-mooney | looks like openstack clinet is broken | |
| 22:11:48 | sean-k-mooney | 024-09-12 21:04:32.171696 | controller | + /opt/stack/nova/roles/run-evacuate-hook/files/test_negative_evacuate.sh:evacuate_and_wait_for_error:19 : openstack --os-compute-api-version 2.67 server evacuate --host np0038485592 evacuate-test | |
| 22:11:51 | sean-k-mooney | 2024-09-12 21:04:33.305045 | controller | compute version 2.67 is not in supported versions: 2, 2.1 | |
| 22:11:53 | sean-k-mooney | 2024-09-12 21:04:34.474915 | controller | Proxy.evacuate_server() got an unexpected keyword argument 'password' | |
| 22:12:49 | sean-k-mooney | stephenfin: ^ fyi for the morning | |
| #openstack-nova - 2024-09-13 | |||
| 03:59:41 | opendevreview | Sam Morrison proposed openstack/nova master: Filter out deleted instances when looking for build timouts https://review.opendev.org/c/openstack/nova/+/880125 | |
| 05:59:13 | frickler | stephenfin: sean-k-mooney: note that we release osc 7.1.0 yesterday, so likely related to that. 7.0.0 was also broken and never made it into u-c. I can also reproduce the above issue locally fwiw | |
| 06:01:22 | frickler | maybe let's move this to sdks channel | |
| 07:56:08 | gibi | sean-k-mooney: I have small things in https://review.opendev.org/q/topic:%22bug/2080556%22 but I'm overall positive. | |
| 08:02:26 | gibi | bauzas: I have a nit in the prelude https://review.opendev.org/c/openstack/nova/+/928995 | |
| 08:03:17 | gibi | bauzas: also I think we can go with the RC1 for placement even if we need to wait with the nova RC1 | |
| 08:04:54 | gibi | bauzas: also we have negative answer for our proposal of fixing the live migration issue https://bugs.launchpad.net/nova/+bug/2080436 | |
| 08:05:16 | bauzas | cool, I'm just busy with another task | |
| 08:05:27 | bauzas | you're next in my waiting queue :) | |
| 08:05:40 | gibi | I'm not waiting :) | |
| 08:14:10 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add Dalmatian prelude section https://review.opendev.org/c/openstack/nova/+/928995 | |
| 08:26:38 | bauzas | gibi: I have full attention to the regression bug now | |
| 08:26:54 | bauzas | so, that sounds the conditional clause isn't enough | |
| 08:27:18 | bauzas | something in the cleanup really deletes the instance path | |
| 08:29:58 | gibi | I just published a set of observations in https://review.opendev.org/c/openstack/nova/+/928970 | |
| 08:32:12 | gibi | If I have to guess the complication is around: > NUMA pinned VMs and an NFS mount for the VMs, but we also use cinder boot volumes | |
| 08:33:07 | gibi | I guess we won't be able to avoid setting up a multinode devstack.. | |
| 08:36:28 | bauzas | I tried yesterday to write a functional test but that was hard | |
| 08:37:00 | bauzas | I would have to create a specific tempfs for the instance paths in order to correctly reproduce it | |
| 08:37:19 | bauzas | but I failed finding where we mock the paths | |
| 08:37:31 | bauzas | ++ | |
| 08:37:43 | bauzas | (oops, wrong window) | |
| 08:40:15 | gibi | I will try to set up multinode devstack with NFS but I cannot promise it will work today | |
| 08:41:18 | bauzas | I have two nodes, I can also try to modify them | |
| 08:41:42 | bauzas | either way, we'll probably need to come to a decision today or monday | |
| 08:41:58 | bauzas | we can't delay RC1 more | |
| 08:42:24 | bauzas | but I'd like some core quorum | |
| 08:43:18 | gibi | an alternative is to revert the power mgmt live migration fix. Declare that that power mgmt does not work with live migration and fix the whole thing later | |
| 08:44:07 | bauzas | that's what I had in mind | |
| 08:44:26 | bauzas | or a third alternative is ship power management but let the call be optional | |
| 08:44:46 | bauzas | if you don't setup power management, you shouldn't be impacted | |
| 08:44:49 | gibi | we could hack a fix together where shared storage live migration works if power mgmt is not used, and power mgmt live migration works if no shared storage is used (basically the original proposal from the reported) but that is uggly | |
| 08:45:14 | bauzas | that's the concern I have with the current master, which inconditionnally says you're power manageable | |
| 08:45:14 | gibi | and power mgmt with shared storage will still not work | |
| 08:45:44 | bauzas | I wish we had a flag on the migrate_data object that would signal that info | |
| 08:45:53 | bauzas | like we did for mdevs or vpmems | |
| 08:46:27 | gibi | that would not remove the problem that shared storage live migration does not work if you have power mgmt, mdevs, or vpmems. | |
| 08:46:37 | gibi | as those would trigger calling clenaup | |