Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2024-09-04
15:42:04 dansmith yeah, push something up and I'll +W it
15:42:32 mnaser ok thank you
15:43:41 mnaser dansmith: https://review.opendev.org/c/openstack/os-test-images/+/928001
15:44:16 dansmith done
16:00:31 melwitt sean-k-mooney: hey, I saw your comment on https://review.opendev.org/c/openstack/nova/+/924319 about being in a freeze period. I thought we are frozen for features but not frozen for bug fixes?
16:11:33 dansmith melwitt: no bug reference was the point I think
16:11:43 dansmith looks like a feature without it as it doesn't even say "fix.." or anything
16:13:31 melwitt dansmith: ah, ok. that makes more sense, thanks
16:19:12 sean-k-mooney ya i wanted a bug link for backporting mainly
16:19:40 sean-k-mooney until RC1 we can merge bug afeter RC1 they shoudl only be regression bugs but we will have mater at that point
16:19:54 sean-k-mooney *master at that point reopend for dev
16:20:08 dansmith yeah so between m3 and rc1 being stricter about requiring a bug ref makes sense ot me
16:20:31 melwitt sean-k-mooney: gotcha. thanks
16:20:41 sean-k-mooney that and i asked for a minor release note becasue if operator have doen this already
16:21:00 sean-k-mooney they need to be aware that the changes they made did not propagate to the requst spec
16:21:17 melwitt I saw that but misinterpreted the "freeze" part of your sentence
16:21:36 sean-k-mooney well i wanted to also check with other how we felt about merging it
16:21:46 sean-k-mooney but i saw this as a very low risk
16:22:29 melwitt sure
16:25:56 mnaser https://github.com/openstack/os-test-images -- thanks, i got what i need
16:26:33 dansmith mnaser: cool
16:36:35 opendevreview Lajos Katona proposed openstack/nova master: WIP Use SDK for Neutron https://review.opendev.org/c/openstack/nova/+/928022
16:37:26 sean-k-mooney lajoskatona: best of luck. you are the third person to start that
16:38:32 sean-k-mooney lajoskatona: with that said we would happliy move to the sdk if you can make it work properly
16:39:23 sean-k-mooney lajoskatona: there are some subtleies in that we need to use both admin and non admin clinets and we need to includ a service token when making request ot nutron too
16:41:16 sean-k-mooney lajoskatona: gibi and Uggla have had expirnce with using service token and the sdk recently with the manila serise so we likely ahve some refernc matiral for that
16:41:52 sean-k-mooney our previous usage of sdk was for ironic and placment both of which were admin only clients
16:42:20 sean-k-mooney so neutron and manila will be the first that need to have a mix of admin and non admin token usage
17:02:37 lajoskatona sean-k-mooney: :-)
17:04:14 lajoskatona sean-k-mooney: thanks, I will check with gibi, this patch now works for basic boot, but to tell the truth I am not sure I have the strength to understand the dirty internals of Nova (not to speak about Neutron API :-))
17:09:39 sean-k-mooney lajoskatona: i see you are not replacing how we are doing auth which i foudn a little odd
17:10:25 sean-k-mooney have you confirmed that user tokens and not admin tokens are used for thinks liek creating a neuton port when we add a network to the vms
17:11:18 sean-k-mooney not intoducing privadge escaltion but using the admin token is one of the more imporant things we need to watch out for
17:19:41 lajoskatona sean-k-mooney: yes, I made some notes for myself, and that is one of the swampy things as I see (the other is filtering i.e.: networks like shared non-shared admin / non-admin etc) but I am sure there should be more
17:20:25 sean-k-mooney lajoskatona: well the problem with neutrons rbac featues is no one updated nova to supprot any of them
17:21:01 sean-k-mooney lajoskatona: i.e. after many release there are now patches to supprot shared secruity groups for example
17:21:12 lajoskatona sean-k-mooney: any feedback is really useful, I will see if I can work on this (and if I have to patience for this ;))
17:21:20 sean-k-mooney but as neutron was building out it rbac feature there were no sister propossla filed to nova to use them
17:21:48 sean-k-mooney lajoskatona: nueton has several feature that nova does not officaly supprot
17:21:55 sean-k-mooney like multi provider netwroks
17:23:51 sean-k-mooney the unfortunet pattern is often the neuton extentoin lands and then no one does the nova part to enabel ti properly end ot end
17:23:52 lajoskatona sean-k-mooney: well, we can have a list of these things officially written somewhere where possible brave fresh minded geniuses can select future projects :-) I believe these things should be written somewhere otherwise they are just forgotten
17:25:35 sean-k-mooney funny i was having a paralle conversation about how to document unsupptotred feature a few minutes ago
17:59:11 opendevreview melanie witt proposed openstack/nova master: nova-manage: Add --max_rows option to 'db purge' command https://review.opendev.org/c/openstack/nova/+/927339
18:11:43 opendevreview Merged openstack/nova stable/2023.2: Skip snapshot test when missing qemu-img https://review.opendev.org/c/openstack/nova/+/927897
18:36:44 opendevreview melanie witt proposed openstack/nova master: Call volume detach rollback API if detach fails https://review.opendev.org/c/openstack/nova/+/880399
21:36:26 melwitt dansmith: I was looking through New bugs in launchpad and saw this one that may interest you. online data migration for populate_instance_compute_id failing because of the "fake" instance created by the fill_virtual_interface_list online data migration https://bugs.launchpad.net/nova/+bug/2076614
21:59:50 opendevreview Merged openstack/nova stable/2023.2: libvirt: call get_capabilities() with all CPUs online https://review.opendev.org/c/openstack/nova/+/927557
22:00:00 opendevreview Merged openstack/nova stable/2023.1: Skip snapshot test when missing qemu-img https://review.opendev.org/c/openstack/nova/+/927898
22:19:03 dansmith melwitt: "interest" is a strong word :D
22:19:18 dansmith melwitt: surely the virtual interface migration is crazy old right?
22:20:07 sean-k-mooney its pre trian
22:20:15 dansmith trian?
22:20:18 dansmith oh train
22:20:38 sean-k-mooney porbaly older but its pre pandemic
22:20:56 dansmith yeah I'm just wondering if we want to maybe also delete that.. we really don't need those to stay around forever since we don't support upgrading from any release to any other,
22:20:56 sean-k-mooney so the before times
22:21:09 dansmith although I'm not sure if we (bauzas) added a blocker migration for this or not
22:21:43 sean-k-mooney i kind of forgot it exited so we probably could
22:22:01 sean-k-mooney i had assuemd some of this cleanup was done when stephen did the move to alembic
22:23:08 dansmith "This script should be executed while upgrading to Stein release."
22:23:16 dansmith I thought this was bauzas for sure, but I guess not
22:24:59 sean-k-mooney no this was realted to healing the network info cache
22:25:00 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/614167
22:25:13 melwitt dansmith: I saw you on the commit for the compute_id migration :)
22:25:48 sean-k-mooney i have unloaded the contex but if i rememebr correctly this was technially optional
22:26:20 sean-k-mooney as in if you didnt run it i just would not populate the table and give you a stabel order
22:27:17 sean-k-mooney so for me this is old enough that we dont even have unmaintianed barnaches that need it
22:27:30 sean-k-mooney so i dont see why we could not drop anything for stine and older
22:28:24 sean-k-mooney honestly https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L196-L217 everyting in that block could likely be dropped
22:29:12 dansmith yeah
#openstack-nova - 2024-09-05
08:51:22 opendevreview zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319
08:52:23 opendevreview zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319
08:56:53 opendevreview zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319
08:59:17 opendevreview zhou zhong proposed openstack/nova master: nova-manage: modify image properties in request_spec https://review.opendev.org/c/openstack/nova/+/924319
09:54:54 stan sean-k-mooney is there any work being done on using Shared security group during an instance launch?
09:55:33 stan We have a common security rule that allows access to our backup server, so I would really be handy if we can attach this during instance creation.
09:57:33 sean-k-mooney stan: yes, there is a patch for it but its been worked on inconsitently
09:57:59 sean-k-mooney im expecting we will merge in in the next 3-4 weeks shortly after rc1 is released
09:58:51 stan sean-k-mooney Thanks, that is great news. :)
09:58:54 sean-k-mooney stan: the issue is that when that feature was orgianlly added to neutron it was not even discussed with us let alone propsoed as an enhanemnet
09:59:22 sean-k-mooney the gap is not being closed but its a feature not a bug
09:59:29 sean-k-mooney so we wont be backporting it
10:00:00 sean-k-mooney with that said its pretty trivial so you could do that downstream if you really wanted
10:00:35 sean-k-mooney stan: https://review.opendev.org/c/openstack/nova/+/811521
10:01:19 stan yeah, I think I will merge it at our downstream. I'm trying to move off of VMware in our company, so I will also try to help as much I can, to contribute back.
10:01:37 stan Thanks again for the prompt response :)
12:07:03 opendevreview Merged openstack/nova stable/2023.1: libvirt: call get_capabilities() with all CPUs online https://review.opendev.org/c/openstack/nova/+/927558
14:46:30 opendevreview Brian Haley proposed openstack/nova master: Support creating servers with RBAC SGs https://review.opendev.org/c/openstack/nova/+/811521
15:01:00 chris218 Hi guys is there a reason this patch never got merged or it just wasn't ever proposed? https://opendev.org/openstack/openstack-virtual-baremetal/src/branch/stable/2.0/patches/nova/nova-pxe-boot-pike.patch
15:10:09 JayF I don't know the history of that patch specifically, but the repository it's in has been archived for a couple years. Also the pike release of openstack was something in the neighborhood of 8 years ago? So I suspect that patch is old, too
15:10:28 JayF You might have better results asking a question related to what you're trying to do
15:58:47 chris218 Well i'm interested in letting nova boot directly from pxe which is what that patch provided
16:02:23 melwitt I used this gerrit search "project:openstack/nova message:pxe" to find https://review.opendev.org/c/openstack/nova/+/434549
16:04:23 opendevreview Merged openstack/nova master: doc: Fix markup syntax and typo https://review.opendev.org/c/openstack/nova/+/906379
16:05:40 chris218 melwitt: awesome thanks, my gerrit-fu is unfortunately very bad and I didn't find it myself.
16:06:21 chris218 So in theory if somebody implemented it as a flavor extra spec it could get accepted?
16:06:33 melwitt from what I can tell, if someone proposed this with a proper flavor extra spec or image property then it could be considered mergeable.. but obvs would need to run it by other people too in case there is some other concern about the idea
16:18:06 sean-k-mooney we discussee this in the past
16:18:11 sean-k-mooney you can actully do it already today

Earlier   Later