Earlier  
Posted Nick Remark
#openstack-nova - 2024-08-27
15:19:06 sean-k-mooney which is diffent then auto config which will create it if there is none
15:19:27 stephenfin right, but do we care? that's not the aim of this test
15:19:49 sean-k-mooney it is the aim to ensure that the old command line argument work as openstack evolves
15:20:02 sean-k-mooney at least fo the legacy version that is testin 2.1
15:20:46 sean-k-mooney stephenfin: if we have a sperate test case for this then im fine with changing this one
15:20:50 stephenfin Again, right, but the test is testing the '--image-with' option, not the '--nic' option (or lack thereof). My change proves the '--image-with' option works on both 2.1 and 2.latest
15:20:59 stephenfin okay, lemme see
15:21:33 sean-k-mooney i think this is the only test without a nic specifed
15:21:36 stephenfin that was easy. It's a short file. None there. Do we add one (with the skip)?
15:22:23 stephenfin relying on there only being one test seems fairly fragile and would prevent us running said tests against a local devstack (at least without doing what CI does and e.g. deleting the 'shared' network)
15:22:30 stephenfin *one network
15:24:21 sean-k-mooney so i think this regression was intoduced by https://github.com/openstack/devstack/commit/24b65adc9cedff9c7a8ab412fb39613ef5d4a627
15:24:50 stephenfin Hardly. That's there since yoga
15:24:57 stephenfin per the GitHub UI anyway
15:25:27 sean-k-mooney maybe not but was srbac enabeld in neutron by default for that long
15:26:06 sean-k-mooney ok im torn personally i want to remvoe the cli testing and the shell module
15:26:20 sean-k-mooney on the other hand while its there we shoudl nto reduce test coverage
15:26:36 sean-k-mooney so if you want to add a test taht will skip if multiple networks i guess that fine
15:26:43 sean-k-mooney but it also kind of useless without fixing the ci
15:26:49 stephenfin agreed
15:26:59 stephenfin maybe we just merge that and move on with our lives? 🤷
15:27:16 stephenfin undoubtedly better than making the whole thing non-voting
15:27:21 sean-k-mooney if we do then i think we need to delete the cli next cycle
15:27:26 stephenfin perfect is the enemy of the good
15:27:28 stephenfin etc. etc.
15:27:59 sean-k-mooney well no voting was just a precuisor to deleting it
15:28:16 sean-k-mooney we can see what people think in the nova meeting in 30 mins
15:28:52 stephenfin ack
15:29:03 sean-k-mooney if they are fine with our patch then we can merge it but i dicussed this with melwitt last week and we wanted to wait for the team meeting
15:29:31 sean-k-mooney as in i discussed skiping or modifying the test to work with multiple networks
16:01:36 opendevmeet The meeting name has been set to 'nova'
16:01:36 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:36 opendevmeet Meeting started Tue Aug 27 16:01:36 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:36 bauzas #startmeeting nova
16:01:40 bauzas hey folks
16:01:59 bauzas sorry, that's been so long, maybe you forgot about it
16:02:13 gibi never!
16:02:25 fwiesel o/
16:02:46 elodilles o/
16:03:03 sean-k-mooney o/
16:03:12 auniyal o/
16:03:34 bauzas cool folks
16:03:42 bauzas let's start then :)
16:03:56 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:04:05 bauzas #topic Bugs (stuck/critical)
16:04:12 bauzas #info No Critical bug
16:04:18 bauzas (glad to hear it)
16:04:26 bauzas #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:04:45 bauzas any important bug people would want to discuss ?
16:04:59 bauzas I was off for 3 weeks so I don't really know
16:06:01 bauzas looks no
16:06:08 bauzas moving on
16:06:33 sean-k-mooney novaclint is blokced but we will talk about that later
16:06:37 bauzas okay
16:06:43 bauzas #topic Gate status
16:06:49 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:06:54 bauzas #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:07:01 bauzas #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status
16:07:06 bauzas all greens
16:07:24 bauzas (well, we have a stable/zed job done, but meh)
16:07:33 bauzas #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:07:38 bauzas #info Please try to provide meaningful comment when you recheck
16:08:25 bauzas moving on ?
16:08:52 bauzas #topic Release Planning
16:08:57 bauzas #link https://releases.openstack.org/dalmatian/schedule.html
16:09:04 bauzas #info Dalmatian-3 in 1 week
16:09:10 bauzas #info non-client library freeze happened last week
16:09:15 bauzas #info client library freeze this week
16:09:23 bauzas sean-k-mooney: want to discss the novaclient issue ?
16:10:13 dansmith I kinda have something for release planning
16:10:20 sean-k-mooney we have 2 issues
16:10:30 sean-k-mooney the first one is just a ci job issue
16:10:45 sean-k-mooney the functioanl job is exepcting there to only be one network
16:10:45 bauzas okay, tell me both
16:10:54 sean-k-mooney there are now 2
16:10:58 sean-k-mooney so 2 tests fail
16:11:10 sean-k-mooney we can update them to skip or modify them to use the first network
16:11:18 sean-k-mooney stephenfin: has a patch for the latter
16:11:48 sean-k-mooney the second issue is the cli does not work on python 3.11
16:11:59 sean-k-mooney it was deprecated when the newest veriohn we supproted was 3.9
16:11:59 bauzas this is a priority before we release novaclient IMHO
16:12:41 sean-k-mooney so i think we need to look at removing the nova client cli in 2025.1 and the python bidnign by 2026.1
16:12:58 sean-k-mooney that is a ptg discussion that im hopign melwitt and stephenfin can partake in
16:13:26 sean-k-mooney to actully do that we need to dicsuss with neutron and heat to get them to swap to the sdk
16:13:31 bauzas https://github.com/openstack/python-novaclient/blob/master/setup.cfg#L22-L24
16:13:43 bauzas are you saying that we don't have any job testing 3.11 ?
16:13:49 sean-k-mooney we do and it fails
16:13:59 sean-k-mooney but we deprecated the cli before that
16:14:16 bauzas oh, you're saying the deprecation of the CLI
16:14:16 sean-k-mooney so the cli has not been updated to supprot py311
16:14:22 bauzas I see
16:14:40 sean-k-mooney the 3.11 issue is a change in argparse behavior
16:14:44 sean-k-mooney so only affect the cli
16:14:55 bauzas this is deprecated, but we could provide some exception telling "sorry, we only support up to 3.9 for the CLI"
16:14:57 sean-k-mooney anyway there are two patches to fix the 3.11 issue
16:15:31 sean-k-mooney so the main question is do we quickly fix this for 2024.2
16:15:32 bauzas we could backport such patches then
16:15:51 sean-k-mooney and then look at removing the shell in 2025.1/2
16:16:04 bauzas I think we should rather just fix the 3.11 issues
16:16:12 sean-k-mooney actully we can dicussss post 2024.1 at the ptg

Earlier   Later