| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-19 | |||
| 14:08:06 | tkajinam | X-( | |
| 14:08:20 | tkajinam | the 2nd one should have been https://review.opendev.org/q/topic:%22bp/amd-sev-es-libvirt-support%22 | |
| 14:08:50 | tkajinam | frickler, thanks for pointing that wrong paste :-D | |
| 14:09:08 | frickler | np, /me was just curious :) | |
| 14:19:19 | sean-k-mooney | tkajinam: 2 minor -1s but over all the stateless firmware changes look good to me | |
| 14:20:08 | sean-k-mooney | tkajinam: geneal question are you plannign to work on a tempest test to validate this | |
| 14:20:32 | sean-k-mooney | it woudl be nice to add one that creates a flavor with stateless firmware which is enabeld via a compute_feature flag | |
| 14:20:56 | dansmith | sean-k-mooney: it'd also be nice to have the object change separate from the libvirt one, IMHO | |
| 14:21:00 | sean-k-mooney | i dont think that will actully work until we move the ci to ubuntu 24.04 | |
| 14:21:19 | sean-k-mooney | dansmith: ya i have no objection to that | |
| 14:21:43 | sean-k-mooney | we have seen that that makes some bugfix backports simler recently | |
| 14:22:02 | sean-k-mooney | *simpeler | |
| 14:22:52 | sean-k-mooney | :) i see you even said that in your comment | |
| 14:25:29 | dansmith | right | |
| 14:26:07 | dansmith | I hate to ask tkajinam to do that after the fact, but hopefully it won't be too hard if he's willing | |
| 15:01:59 | opendevreview | James Page proposed openstack/python-novaclient master: shell: Python >= 3.11 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/926532 | |
| 15:02:42 | tkajinam | dansmith sean-k-mooney, thanks. I'll try updating the changes tomorrow. | |
| 15:04:19 | tkajinam | sean-k-mooney, I don't have any specific plan for tempest tests but I can look into it. However I have to add the bare tpm suppor test as well so I'm unsure if I can actually implement these before feature freeze in nova (which approximately means in 1 week) | |
| 15:04:58 | sean-k-mooney | im kind of fine with just doing this post ff | |
| 15:05:02 | tkajinam | ok | |
| 15:06:27 | sean-k-mooney | the unit/functional tests should be enough to merge but this would be good to test later. we will eventually add support for testing this in whitebox too | |
| 15:07:26 | tkajinam | yeah. that makes sense | |
| 15:07:43 | dansmith | yeah, same pattern as other version-dependent changes, and just a line in the xml, so not necessary to prove with integration tests, IMHO | |
| 15:08:37 | tkajinam | s/tpm/uefi/ minor but important correction... | |
| 15:08:39 | tkajinam | yeah | |
| 15:08:54 | tkajinam | let me check how the existing features are validated and I'll try following the existing patterns | |
| 15:09:18 | tkajinam | dansmith, sean-k-mooney thanks for these comments :-D | |
| 15:10:58 | mnasiadka | Hello, in Kolla we have been historically installing xen-utils rpm/deb package for Nova (maybe that was for Xen support - have no real knowledge about this) - is that still needed nowadays? | |
| 15:12:08 | dansmith | mnasiadka: we removed xen support a couple cycles ago | |
| 15:12:49 | mnasiadka | Was just curious if that's needed for anything else, but I assume it's not. | |
| 15:15:01 | sean-k-mooney | not that im aware of | |
| 15:15:14 | sean-k-mooney | when we remvoed the xen supprot that should not be required after that | |
| 15:15:28 | mnasiadka | ok then, let me drop that | |
| 15:15:30 | mnasiadka | thanks | |
| 15:43:31 | stephenfin | sean-k-mooney: My rational for approving https://review.opendev.org/c/openstack/nova/+/907976/ is that it's a definite improvement and minimally controversial. It doesn't look like your patch is ready for prime time. Surely we can merge the smaller patch now until you find time to rework yours? | |
| 15:57:17 | sean-k-mooney | ot me its tech debt and i didnte really like doign this as a one off | |
| 15:58:48 | stephenfin | it's still better than what we have though | |
| 15:59:22 | stephenfin | perfect is the enemy of good and all that | |
| 15:59:42 | sean-k-mooney | so my patch is also better then what we have | |
| 16:28:52 | dansmith | melwitt: yawna +W this or prefer to wait for bauzas? https://review.opendev.org/c/openstack/nova/+/926144 | |
| 16:51:11 | opendevreview | sean mooney proposed openstack/nova master: imporve nova object logging https://review.opendev.org/c/openstack/nova/+/898057 | |
| 16:52:14 | sean-k-mooney | stephenfin: melwitt ^ i updated the name and added a unit test as bauzas asked | |
| 17:01:58 | sean-k-mooney | dansmith: any idea if https://review.opendev.org/c/openstack/python-glanceclient/+/890634 will merge in time to allow https://review.opendev.org/c/openstack/nova/+/891036 to proceed this cycle | |
| 17:02:46 | sean-k-mooney | it looks like the sdk patch is also not ready https://review.opendev.org/c/openstack/openstacksdk/+/883271 | |
| 17:02:55 | dansmith | abhishekk: ^ | |
| 17:03:07 | dansmith | sean-k-mooney: I have been too busy to follow the progress lately, so I'm not sure | |
| 17:03:30 | sean-k-mooney | dansmith: no worreis i was just doing jira paperwork... hence checking | |
| 17:03:32 | abhishekk | ack | |
| 17:03:57 | abhishekk | I think glance client is good to go | |
| 17:04:19 | abhishekk | not sure about openstacksdk though | |
| 17:05:10 | sean-k-mooney | well we dont actully need the sdk change | |
| 17:05:17 | sean-k-mooney | dans currenct change uses cinder client | |
| 17:05:28 | sean-k-mooney | but we would need a cinder client release before feature freeze | |
| 17:05:49 | sean-k-mooney | what are the changes for merging the clinet change and doing a release this week | |
| 17:06:04 | sean-k-mooney | so that we can follow up with dans patch next week in advance of FF | |
| 17:06:05 | abhishekk | client just need one more +2 | |
| 17:06:26 | sean-k-mooney | well that and an actual release | |
| 17:06:35 | abhishekk | I think rosmaita can do that | |
| 17:06:54 | sean-k-mooney | ack well if this lines up it woudl be nice to get incldued in this release | |
| 17:06:57 | abhishekk | yes, once patch is merged I can post a release patch | |
| 17:07:03 | sean-k-mooney | if now i guess we will do the nova part next cycle | |
| 17:07:13 | sean-k-mooney | abhishekk++ | |
| 17:07:15 | abhishekk | right | |
| 17:07:45 | abhishekk | let me ping rosmaita on glance channel | |
| 17:10:35 | melwitt | dansmith: have we discussed with bauzas before? I was thinking if not then it might be best for him to review it | |
| 17:11:16 | sean-k-mooney | the deprecation is somethign we can merge post FF but i think they are back from PTO next week in either case | |
| 17:11:57 | dansmith | melwitt: yeah we did sort of informally, but ack, as long as we get it done in this release, that's fine | |
| 17:12:16 | melwitt | yeah he is back next monday iirc | |
| 17:15:06 | opendevreview | Merged openstack/nova master: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926407 | |
| 17:15:31 | sean-k-mooney | @artom ^ | |
| 17:15:58 | artom | sean-k-mooney, ack, backport time | |
| 17:16:06 | sean-k-mooney | yes please :) | |
| 17:17:49 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/926554 | |
| 17:17:50 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926555 | |
| 17:18:04 | artom | Wait, I skipped 2024.1, didn't I? | |
| 17:18:25 | artom | Actual names were better, fight me | |
| 17:18:44 | sean-k-mooney | yes you did | |
| 17:19:07 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2024.1: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/926556 | |
| 17:19:08 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2024.1: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926557 | |
| 17:20:33 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/926554 | |
| 17:20:34 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.2: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926555 | |
| 17:21:33 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Functional test test_boot_reschedule_with_proper_pci_device_count https://review.opendev.org/c/openstack/nova/+/926558 | |
| 17:21:34 | opendevreview | Artom Lifshitz proposed openstack/nova stable/2023.1: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926559 | |
| #openstack-nova - 2024-08-20 | |||
| 00:37:39 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 00:37:39 | opendevreview | Takashi Kajinami proposed openstack/nova master: Report availability of stateless firmware support https://review.opendev.org/c/openstack/nova/+/908888 | |
| 00:37:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_firmware_stateless image property https://review.opendev.org/c/openstack/nova/+/926590 | |
| 03:37:36 | opendevreview | Merged openstack/nova master: [libvirt]log XML if nova fails to parse it https://review.opendev.org/c/openstack/nova/+/906364 | |
| 05:23:43 | opendevreview | Zhang Hua proposed openstack/nova master: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/920374 | |
| 08:39:34 | ralonsoh | sean-k-mooney, hello! I have an investigation in progress (well, very little progress so far) | |
| 08:39:57 | ralonsoh | I'm fixing an issue with eventlet, wsgi and tls with ML2/OVN | |
| 08:40:21 | ralonsoh | in a nutshell: I'm pushing https://review.opendev.org/c/openstack/neutron/+/925376/ | |
| 08:40:37 | ralonsoh | this patch works fine with ML2/OVN but not so great with ML2/OVS | |
| 08:41:21 | ralonsoh | the same test is randomly (but very frequently) failing in the OVS jobs: test_established_tcp_session_after_re_attachinging_sg | |
| 08:41:49 | ralonsoh | the issue, so far, is because n-compute is deleting the VM used to test the ping | |
| 08:42:00 | ralonsoh | for example: https://32db135de77b6f5b2e24-00cf68680e4576901ac5e284377f47f2.ssl.cf2.rackcdn.com/924317/7/experimental/neutron-tempest-plugin-openvswitch-distributed-dhcp/43f8b60/controller/logs/index.html | |
| 09:10:11 | ralonsoh | sean-k-mooney, if you have time to review these logs, can you explain why nova is trying to delete the VM? | |
| 09:10:20 | ralonsoh | Aug 19 12:41:14.998800 np0038215967 devstack@n-api.service[58447]: DEBUG nova.compute.api [None req-54123910-92d9-491b-b845-f8e7d37490dd tempest-StatefulNetworkSecGroupTest-1423213631 tempest-StatefulNetworkSecGroupTest-1423213631-project-member] [instance: 4623b509-a848-41a4-9fc2-1cf8227bd4ca] Going to try to terminate instance {{(pid=58447) delete /opt/stack/nova/nova/compute/api.py:2725}} | |
| 09:10:21 | ralonsoh | sorry, I don't find the reason | |
| 09:19:21 | mikal | sean-k-mooney: I'd do a change for the usb redirect devices as extra specs, but I'm starting to be a bit worried about any of these changes landing in time. What would you prefer? | |
| 09:19:45 | mikal | sean-k-mooney: naively I'd just cargo cult the sound device extra spec one for usb redirect devices, so I was kind of waiting for someone to tell me I did that one wrong first. | |