| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-16 | |||
| 10:12:35 | gibi | yeah that would probably make sense otherwise the scheduler blows up later anyway | |
| 10:13:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926407 | |
| 12:54:39 | opendevreview | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for 2025.1 Epoxy https://review.opendev.org/c/openstack/nova-specs/+/924227 | |
| 13:31:19 | opendevreview | sean mooney proposed openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425 | |
| 13:31:20 | opendevreview | sean mooney proposed openstack/nova master: Remove nova debugger funcitonality https://review.opendev.org/c/openstack/nova/+/922496 | |
| 13:31:20 | opendevreview | sean mooney proposed openstack/nova master: refactor cmd dir for non eventlet console_scripts https://review.opendev.org/c/openstack/nova/+/904424 | |
| 13:31:21 | opendevreview | sean mooney proposed openstack/nova master: remove eventlet.tpool https://review.opendev.org/c/openstack/nova/+/905287 | |
| 13:31:21 | opendevreview | sean mooney proposed openstack/nova master: Add IO Thread Pool Executor https://review.opendev.org/c/openstack/nova/+/922497 | |
| 13:31:22 | opendevreview | sean mooney proposed openstack/nova master: use futerist for RBD calls https://review.opendev.org/c/openstack/nova/+/917962 | |
| 13:31:22 | opendevreview | sean mooney proposed openstack/nova master: use futureist for scatter_gather https://review.opendev.org/c/openstack/nova/+/905284 | |
| 13:31:57 | sean-k-mooney | stephenfin: gibi: ^ rebased and adress the current out standing issues if you have time to review | |
| 13:32:09 | stephenfin | aclk | |
| 13:55:26 | opendevreview | sean mooney proposed openstack/nova master: add initial healthcheck support https://review.opendev.org/c/openstack/nova/+/825015 | |
| 13:55:27 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck tracker to nova context https://review.opendev.org/c/openstack/nova/+/829468 | |
| 13:55:27 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck manager to manager base https://review.opendev.org/c/openstack/nova/+/827844 | |
| 13:55:28 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add iniital health check to compute agent https://review.opendev.org/c/openstack/nova/+/906911 | |
| 13:55:28 | opendevreview | sean mooney proposed openstack/nova master: add healthcheck endpoint to proxy commands https://review.opendev.org/c/openstack/nova/+/830703 | |
| 13:55:29 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add libvirt connection healtcheck https://review.opendev.org/c/openstack/nova/+/907424 | |
| 13:55:47 | sean-k-mooney | thats ^ just a rebase i need to go though them and see what review feedback is present | |
| 14:10:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix PCI passthrough cleanup on reschedule https://review.opendev.org/c/openstack/nova/+/926407 | |
| 14:34:11 | opendevreview | Zhang Hua proposed openstack/nova master: BlockDeviceMapping object has no attribute copy https://review.opendev.org/c/openstack/nova/+/920374 | |
| 15:07:06 | opendevreview | Arnaud Morin proposed openstack/nova master: libvirt: Log exception if failure checking block job https://review.opendev.org/c/openstack/nova/+/907720 | |
| 16:27:00 | gibi | artom: sean-k-mooney: the running CI looking green on https://review.opendev.org/c/openstack/nova/+/926407 and I fixed up all the comments. | |
| 16:27:24 | gibi | that is my last contribution for this week and next week I'm off. | |
| 16:27:43 | gibi | see you on the 26th | |
| 17:19:25 | sean-k-mooney | gibi: thanks gibi im pretty happy with that patch | |
| 17:19:36 | sean-k-mooney | ill see if i can chase other to review while your on pto, enjoy | |
| 22:03:32 | opendevreview | Merged openstack/nova master: api: Add response body validation helper https://review.opendev.org/c/openstack/nova/+/915741 | |
| 22:35:47 | opendevreview | Merged openstack/nova master: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/926223 | |
| #openstack-nova - 2024-08-17 | |||
| 13:20:33 | opendevreview | Artom Lifshitz proposed openstack/nova master: libvirt: call get_capabilities() with all CPUs online https://review.opendev.org/c/openstack/nova/+/926218 | |
| 20:25:08 | opendevreview | Alexey Stupnikov proposed openstack/nova master: [libvirt]log XML if nova fails to parse it https://review.opendev.org/c/openstack/nova/+/906364 | |
| #openstack-nova - 2024-08-18 | |||
| 09:24:16 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | |
| 09:24:17 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 09:24:17 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| #openstack-nova - 2024-08-19 | |||
| 00:27:07 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771 | |
| 10:12:45 | opendevreview | Amit Uniyal proposed openstack/nova master: Reproducer test for image property hw_architecture https://review.opendev.org/c/openstack/nova/+/926128 | |
| 10:12:46 | opendevreview | Amit Uniyal proposed openstack/nova master: VMware: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926522 | |
| 10:12:46 | opendevreview | Amit Uniyal proposed openstack/nova master: Libvirt: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926521 | |
| 10:12:47 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP Ironic: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926524 | |
| 10:12:47 | opendevreview | Amit Uniyal proposed openstack/nova master: zvm: updates resource provider trait list https://review.opendev.org/c/openstack/nova/+/926523 | |
| 10:38:37 | stephenfin | gmann: Would you be able to look through a few more of the OpenAPI patches this week? https://review.opendev.org/c/openstack/nova/+/915742 | |
| 11:48:47 | sean-k-mooney | fyi: im pretty sure https://review.opendev.org/c/openstack/nova/+/926083/comments/ad6713dc_e6542156 that is a current gate bug | |
| 11:49:04 | sean-k-mooney | current latent gate bug | |
| 11:49:40 | sean-k-mooney | test_shelve_unshelve_server has been flaky for a while and i think it only fails if we unshelve to a diffent host | |
| 12:01:19 | stephenfin | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/756867 | |
| 12:05:13 | sean-k-mooney | cool thats what i was looking for. i might see if we can get someone to pick that back up | |
| 12:05:50 | opendevreview | Stephen Finucane proposed openstack/nova master: docs: Add image metadata property reference guide https://review.opendev.org/c/openstack/nova/+/756867 | |
| 12:06:00 | sean-k-mooney | i just rebased that via the ui | |
| 12:06:56 | sean-k-mooney | if it still applies and renders properly we might just want ot merge that and build on it later | |
| 12:45:13 | opendevreview | James Page proposed openstack/python-novaclient master: shell: Python >= 3.11 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/926532 | |
| 13:44:21 | tkajinam | sean-k-mooney, o/ It'd be nice if you can check the updated version and the remaining comment in https://review.opendev.org/c/openstack/nova/+/909183 when you have time. | |
| 13:47:37 | sean-k-mooney | tkajinam: sure | |
| 13:55:58 | sean-k-mooney | ill take a look shortly but sure | |
| 13:56:31 | sean-k-mooney | brb | |
| 14:02:09 | tkajinam | thx ! | |
| 14:03:41 | tkajinam | (for all cores) I'd appreciate any feedback for the other two series https://review.opendev.org/q/topic:%22bp/libvirt-stateless-firmware%22 and https://review.opendev.org/q/topic:%22bp/libvirt-stateless-firmware%22 | |
| 14:07:47 | frickler | tkajinam: that's twice the same link? | |
| 14:08:06 | tkajinam | X-( | |
| 14:08:20 | tkajinam | the 2nd one should have been https://review.opendev.org/q/topic:%22bp/amd-sev-es-libvirt-support%22 | |
| 14:08:50 | tkajinam | frickler, thanks for pointing that wrong paste :-D | |
| 14:09:08 | frickler | np, /me was just curious :) | |
| 14:19:19 | sean-k-mooney | tkajinam: 2 minor -1s but over all the stateless firmware changes look good to me | |
| 14:20:08 | sean-k-mooney | tkajinam: geneal question are you plannign to work on a tempest test to validate this | |
| 14:20:32 | sean-k-mooney | it woudl be nice to add one that creates a flavor with stateless firmware which is enabeld via a compute_feature flag | |
| 14:20:56 | dansmith | sean-k-mooney: it'd also be nice to have the object change separate from the libvirt one, IMHO | |
| 14:21:00 | sean-k-mooney | i dont think that will actully work until we move the ci to ubuntu 24.04 | |
| 14:21:19 | sean-k-mooney | dansmith: ya i have no objection to that | |
| 14:21:43 | sean-k-mooney | we have seen that that makes some bugfix backports simler recently | |
| 14:22:02 | sean-k-mooney | *simpeler | |
| 14:22:52 | sean-k-mooney | :) i see you even said that in your comment | |
| 14:25:29 | dansmith | right | |
| 14:26:07 | dansmith | I hate to ask tkajinam to do that after the fact, but hopefully it won't be too hard if he's willing | |
| 15:01:59 | opendevreview | James Page proposed openstack/python-novaclient master: shell: Python >= 3.11 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/926532 | |
| 15:02:42 | tkajinam | dansmith sean-k-mooney, thanks. I'll try updating the changes tomorrow. | |
| 15:04:19 | tkajinam | sean-k-mooney, I don't have any specific plan for tempest tests but I can look into it. However I have to add the bare tpm suppor test as well so I'm unsure if I can actually implement these before feature freeze in nova (which approximately means in 1 week) | |
| 15:04:58 | sean-k-mooney | im kind of fine with just doing this post ff | |
| 15:05:02 | tkajinam | ok | |
| 15:06:27 | sean-k-mooney | the unit/functional tests should be enough to merge but this would be good to test later. we will eventually add support for testing this in whitebox too | |
| 15:07:26 | tkajinam | yeah. that makes sense | |
| 15:07:43 | dansmith | yeah, same pattern as other version-dependent changes, and just a line in the xml, so not necessary to prove with integration tests, IMHO | |
| 15:08:37 | tkajinam | s/tpm/uefi/ minor but important correction... | |
| 15:08:39 | tkajinam | yeah | |
| 15:08:54 | tkajinam | let me check how the existing features are validated and I'll try following the existing patterns | |
| 15:09:18 | tkajinam | dansmith, sean-k-mooney thanks for these comments :-D | |
| 15:10:58 | mnasiadka | Hello, in Kolla we have been historically installing xen-utils rpm/deb package for Nova (maybe that was for Xen support - have no real knowledge about this) - is that still needed nowadays? | |
| 15:12:08 | dansmith | mnasiadka: we removed xen support a couple cycles ago | |
| 15:12:49 | mnasiadka | Was just curious if that's needed for anything else, but I assume it's not. | |
| 15:15:01 | sean-k-mooney | not that im aware of | |
| 15:15:14 | sean-k-mooney | when we remvoed the xen supprot that should not be required after that | |
| 15:15:28 | mnasiadka | ok then, let me drop that | |
| 15:15:30 | mnasiadka | thanks | |
| 15:43:31 | stephenfin | sean-k-mooney: My rational for approving https://review.opendev.org/c/openstack/nova/+/907976/ is that it's a definite improvement and minimally controversial. It doesn't look like your patch is ready for prime time. Surely we can merge the smaller patch now until you find time to rework yours? | |
| 15:57:17 | sean-k-mooney | ot me its tech debt and i didnte really like doign this as a one off | |
| 15:58:48 | stephenfin | it's still better than what we have though | |
| 15:59:22 | stephenfin | perfect is the enemy of good and all that | |
| 15:59:42 | sean-k-mooney | so my patch is also better then what we have | |
| 16:28:52 | dansmith | melwitt: yawna +W this or prefer to wait for bauzas? https://review.opendev.org/c/openstack/nova/+/926144 | |
| 16:51:11 | opendevreview | sean mooney proposed openstack/nova master: imporve nova object logging https://review.opendev.org/c/openstack/nova/+/898057 | |
| 16:52:14 | sean-k-mooney | stephenfin: melwitt ^ i updated the name and added a unit test as bauzas asked | |
| 17:01:58 | sean-k-mooney | dansmith: any idea if https://review.opendev.org/c/openstack/python-glanceclient/+/890634 will merge in time to allow https://review.opendev.org/c/openstack/nova/+/891036 to proceed this cycle | |